Re: [Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

2015-06-26 Thread Boris Ostrovsky
On 06/26/2015 11:56 AM, Jan Beulich wrote: On 26.06.15 at 17:50, wrote: On 06/26/2015 11:42 AM, Jan Beulich wrote: On 26.06.15 at 16:58, wrote: On 06/26/2015 05:02 AM, Jan Beulich wrote: -uint64_t nsvm_vcpu_guestcr3(struct vcpu *v) -{ -return vcpu_nestedsvm(v).ns_vmcb_guestcr3; -}

Re: [Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

2015-06-26 Thread Jan Beulich
>>> On 26.06.15 at 17:50, wrote: > On 06/26/2015 11:42 AM, Jan Beulich wrote: > On 26.06.15 at 16:58, wrote: >>> On 06/26/2015 05:02 AM, Jan Beulich wrote: -uint64_t nsvm_vcpu_guestcr3(struct vcpu *v) -{ -return vcpu_nestedsvm(v).ns_vmcb_guestcr3; -} - >>

Re: [Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

2015-06-26 Thread Boris Ostrovsky
On 06/26/2015 11:42 AM, Jan Beulich wrote: On 26.06.15 at 16:58, wrote: On 06/26/2015 05:02 AM, Jan Beulich wrote: -uint64_t nsvm_vcpu_guestcr3(struct vcpu *v) -{ -return vcpu_nestedsvm(v).ns_vmcb_guestcr3; -} - If this is removed then I don't see why we still need ns_vmcb_guestcr3, I

Re: [Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

2015-06-26 Thread Jan Beulich
>>> On 26.06.15 at 16:58, wrote: > On 06/26/2015 05:02 AM, Jan Beulich wrote: >> >> -uint64_t nsvm_vcpu_guestcr3(struct vcpu *v) >> -{ >> -return vcpu_nestedsvm(v).ns_vmcb_guestcr3; >> -} >> - > > If this is removed then I don't see why we still need ns_vmcb_guestcr3, > I don't see it bei

Re: [Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

2015-06-26 Thread Boris Ostrovsky
On 06/26/2015 05:02 AM, Jan Beulich wrote: -uint64_t nsvm_vcpu_guestcr3(struct vcpu *v) -{ -return vcpu_nestedsvm(v).ns_vmcb_guestcr3; -} - If this is removed then I don't see why we still need ns_vmcb_guestcr3, I don't see it being used anywhere except for being assigned a value. -bo

Re: [Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

2015-06-26 Thread Andrew Cooper
On 26/06/15 10:02, Jan Beulich wrote: > Some of the generic hooks were unused altogether - drop them. > > Some of the hooks were used only to handle calls from the specific > vendor's code (SVM) - drop them too. > > Several more hooks were pointlessly implementaed as out-of-line > functions, when m

[Xen-devel] [PATCH] x86/nHVM: generic hook adjustments

2015-06-26 Thread Jan Beulich
Some of the generic hooks were unused altogether - drop them. Some of the hooks were used only to handle calls from the specific vendor's code (SVM) - drop them too. Several more hooks were pointlessly implementaed as out-of-line functions, when most (all?) other HVM hooks use inline ones - make