Re: [Xen-devel] [PATCH] x86/hvm: Fix the unknown nested vmexit reason 80000021 bug

2015-04-13 Thread Li, Liang Z
> >> This would be easier to read as > >> > >> if ( cpu_has_vmx_vnmi && > >> (idtv_info & INTR_INFO_INTR_TYPE_MASK) == > >> (X86_EVENTTYPE_NMI<<8)) ) > > > > I was going to say something similar, but I think in the past Jan has > > said that Liang's original is more in line with the coding sty

Re: [Xen-devel] [PATCH] x86/hvm: Fix the unknown nested vmexit reason 80000021 bug

2015-04-13 Thread Jan Beulich
>>> On 08.04.15 at 11:20, wrote: > On Tue, Apr 7, 2015 at 5:11 PM, Andrew Cooper > wrote: >> On 07/04/15 14:27, Liang Li wrote: >>> This bug will be trigged when NMI happen in the L2 guest. The current >>> code handles the NMI incorrectly. According to Intel SDM 31.7.1.2 >>> (Resuming Guest Soft

Re: [Xen-devel] [PATCH] x86/hvm: Fix the unknown nested vmexit reason 80000021 bug

2015-04-08 Thread George Dunlap
On Tue, Apr 7, 2015 at 5:11 PM, Andrew Cooper wrote: > On 07/04/15 14:27, Liang Li wrote: >> This bug will be trigged when NMI happen in the L2 guest. The current >> code handles the NMI incorrectly. According to Intel SDM 31.7.1.2 >> (Resuming Guest Software after Handling an Exception), If bit 3

Re: [Xen-devel] [PATCH] x86/hvm: Fix the unknown nested vmexit reason 80000021 bug

2015-04-08 Thread Tian, Kevin
> From: Li, Liang Z > Sent: Tuesday, April 07, 2015 9:27 PM > > This bug will be trigged when NMI happen in the L2 guest. The current > code handles the NMI incorrectly. According to Intel SDM 31.7.1.2 > (Resuming Guest Software after Handling an Exception), If bit 31 of the > IDT-vectoring inform

Re: [Xen-devel] [PATCH] x86/hvm: Fix the unknown nested vmexit reason 80000021 bug

2015-04-07 Thread Andrew Cooper
On 07/04/15 14:27, Liang Li wrote: > This bug will be trigged when NMI happen in the L2 guest. The current > code handles the NMI incorrectly. According to Intel SDM 31.7.1.2 > (Resuming Guest Software after Handling an Exception), If bit 31 of the > IDT-vectoring information fields is set, and the

[Xen-devel] [PATCH] x86/hvm: Fix the unknown nested vmexit reason 80000021 bug

2015-04-07 Thread Liang Li
This bug will be trigged when NMI happen in the L2 guest. The current code handles the NMI incorrectly. According to Intel SDM 31.7.1.2 (Resuming Guest Software after Handling an Exception), If bit 31 of the IDT-vectoring information fields is set, and the virtual NMIs VM-execution control is 1, wh