> >> This would be easier to read as > >> > >> if ( cpu_has_vmx_vnmi && > >> (idtv_info & INTR_INFO_INTR_TYPE_MASK) == > >> (X86_EVENTTYPE_NMI<<8)) ) > > > > I was going to say something similar, but I think in the past Jan has > > said that Liang's original is more in line with the coding style. > > No, my complaint here wouldn't be about coding style, but about the hard- > coded 8 - it's not been that long ago that I replaced may of them, and I'd > really like to see it replaced here too. Liang - can you please submit an > incremental change (as the original one got committed already)? There > should be several examples in VMX code on how the 8 can be avoided. > > Jan
Of course, with pleasure. Liang _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
