Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Andrew Cooper
On 02/03/17 15:33, Jan Beulich wrote: On 02.03.17 at 16:06, wrote: >> On 02/03/17 13:08, Jan Beulich wrote: >>> start_svm() already runs after cpu_data[] was set up, so it shouldn't >>> modify it anymore (at least not directly). Constify the involved >>> pointers. >>> >>> Furthermore LMSLE fe

Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Jan Beulich
>>> On 02.03.17 at 16:06, wrote: > On 02/03/17 13:08, Jan Beulich wrote: >> start_svm() already runs after cpu_data[] was set up, so it shouldn't >> modify it anymore (at least not directly). Constify the involved >> pointers. >> >> Furthermore LMSLE feature detection was broken by 566ddbe833 ("x8

Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Jan Beulich
>>> On 02.03.17 at 16:19, wrote: > On 03/02/2017 10:02 AM, Jan Beulich wrote: > On 02.03.17 at 15:58, wrote: >>> On 03/02/2017 08:08 AM, Jan Beulich wrote: start_svm() already runs after cpu_data[] was set up, so it shouldn't modify it anymore (at least not directly). Constify the i

Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Andrew Cooper
On 02/03/17 13:08, Jan Beulich wrote: > start_svm() already runs after cpu_data[] was set up, so it shouldn't > modify it anymore (at least not directly). Constify the involved > pointers. > > Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86: > Fail CPU bringup cleanly if it canno

Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Boris Ostrovsky
On 03/02/2017 10:02 AM, Jan Beulich wrote: On 02.03.17 at 15:58, wrote: >> On 03/02/2017 08:08 AM, Jan Beulich wrote: >>> start_svm() already runs after cpu_data[] was set up, so it shouldn't >>> modify it anymore (at least not directly). Constify the involved >>> pointers. >>> >>> Furthermor

Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Jan Beulich
>>> On 02.03.17 at 15:58, wrote: > On 03/02/2017 08:08 AM, Jan Beulich wrote: >> start_svm() already runs after cpu_data[] was set up, so it shouldn't >> modify it anymore (at least not directly). Constify the involved >> pointers. >> >> Furthermore LMSLE feature detection was broken by 566ddbe833

Re: [Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Boris Ostrovsky
On 03/02/2017 08:08 AM, Jan Beulich wrote: > start_svm() already runs after cpu_data[] was set up, so it shouldn't > modify it anymore (at least not directly). Constify the involved > pointers. > > Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86: > Fail CPU bringup cleanly if it

[Xen-devel] [PATCH] x86/SVM: correct boot time cpu_data[] handling

2017-03-02 Thread Jan Beulich
start_svm() already runs after cpu_data[] was set up, so it shouldn't modify it anymore (at least not directly). Constify the involved pointers. Furthermore LMSLE feature detection was broken by 566ddbe833 ("x86: Fail CPU bringup cleanly if it cannot initialise HVM"), as Andrew Cooper has pointed