Re: [Xen-devel] [PATCH] x86/HAP: avoid using bogus/misleading locking

2017-05-31 Thread Jan Beulich
>>> On 31.05.17 at 11:03, wrote: > On 05/29/2017 02:55 PM, Andrew Cooper wrote: >> On 29/05/2017 13:37, Jan Beulich wrote: >>> hap_teardown() unconditionally releases the paging lock and is always >>> being called without the lock held: Lock acquire should then be >>> unconditional too. >>> >>> Si

Re: [Xen-devel] [PATCH] x86/HAP: avoid using bogus/misleading locking

2017-05-31 Thread Julien Grall
Hi, On 05/29/2017 02:55 PM, Andrew Cooper wrote: On 29/05/2017 13:37, Jan Beulich wrote: hap_teardown() unconditionally releases the paging lock and is always being called without the lock held: Lock acquire should then be unconditional too. Signed-off-by: Jan Beulich Reviewed-by: Andrew Co

Re: [Xen-devel] [PATCH] x86/HAP: avoid using bogus/misleading locking

2017-05-29 Thread Andrew Cooper
On 29/05/2017 13:37, Jan Beulich wrote: > hap_teardown() unconditionally releases the paging lock and is always > being called without the lock held: Lock acquire should then be > unconditional too. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper __

[Xen-devel] [PATCH] x86/HAP: avoid using bogus/misleading locking

2017-05-29 Thread Jan Beulich
hap_teardown() unconditionally releases the paging lock and is always being called without the lock held: Lock acquire should then be unconditional too. Signed-off-by: Jan Beulich --- While this is only a cosmetic change afaict I would still like to explore whether to include this in 4.9. --- a/