Re: [Xen-devel] [PATCH] memory: fix XSA-158 fix

2015-12-09 Thread Jan Beulich
>>> On 09.12.15 at 12:02, wrote: > On Wed, 2015-12-09 at 03:53 -0700, Jan Beulich wrote: >> For one the uses of domu_max_order and ptdom_max_order were swapped. > >> And then gcc warns about an unused result of a __must_check function >> in the control part of a conditional expression when both o

Re: [Xen-devel] [PATCH] memory: fix XSA-158 fix

2015-12-09 Thread Ian Campbell
On Wed, 2015-12-09 at 03:53 -0700, Jan Beulich wrote: > For one the uses of domu_max_order and ptdom_max_order were swapped. > And then gcc warns about an unused result of a __must_check function > in the control part of a conditional expression when both other > expressions can be determined by t

[Xen-devel] [PATCH] memory: fix XSA-158 fix

2015-12-09 Thread Jan Beulich
For one the uses of domu_max_order and ptdom_max_order were swapped. And then gcc warns about an unused result of a __must_check function in the control part of a conditional expression when both other expressions can be determined by the compiler to produce the same value (see https://gcc.gnu.org