Re: [Xen-devel] [PATCH] libxc: Fix CID 1351225 resource leak

2016-02-10 Thread Ian Jackson
Dario Faggioli writes ("Re: [PATCH] libxc: Fix CID 1351225 resource leak"): > That being said, this case is very simple, so I'll leave it to the > tools maintainers to tell whether they want something like what I > described above in place or not. I agree that what you suggest would be better. Th

Re: [Xen-devel] [PATCH] libxc: Fix CID 1351225 resource leak

2016-02-10 Thread Ian Campbell
On Wed, 2016-02-10 at 10:28 +0100, Dario Faggioli wrote: > Hi Harmandeep, > > Thanks for this patch. > > On Wed, 2016-02-10 at 14:37 +0530, Harmandeep Kaur wrote: > > > In general, I think it would be best if the subject is a bit more > "explicative", and if you add a few words of changelog, her

Re: [Xen-devel] [PATCH] libxc: Fix CID 1351225 resource leak

2016-02-10 Thread Dario Faggioli
Hi Harmandeep, Thanks for this patch. On Wed, 2016-02-10 at 14:37 +0530, Harmandeep Kaur wrote: > In general, I think it would be best if the subject is a bit more "explicative", and if you add a few words of changelog, here, above the S-o-b. In this case, this could be something like this. Sub

[Xen-devel] [PATCH] libxc: Fix CID 1351225 resource leak

2016-02-10 Thread Harmandeep Kaur
Signed-off-by: Harmandeep Kaur --- tools/libxc/xc_offline_page.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_offline_page.c b/tools/libxc/xc_offline_page.c index bc91d51..3248a34 100644 --- a/tools/libxc/xc_offline_page.c +++ b/tools/libxc/xc_offline_page.c