Hi Harmandeep, Thanks for this patch.
On Wed, 2016-02-10 at 14:37 +0530, Harmandeep Kaur wrote: > In general, I think it would be best if the subject is a bit more "explicative", and if you add a few words of changelog, here, above the S-o-b. In this case, this could be something like this. Subject: "libxc: fix leak in xc_offline_page error path" Changelog: " Avoid leaking the mapping of the m2p in one of the possible failure cases. Coverity CID 1351225 " > Signed-off-by: Harmandeep Kaur <[email protected]> > That being said, this case is very simple, so I'll leave it to the tools maintainers to tell whether they want something like what I described above in place or not. The code looks ok to me, so, with or without the subject/changelog improvements: Reviewed-by: Dario Faggioli <[email protected]> Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list [email protected] http://lists.xen.org/xen-devel
