Re: [Xen-devel] How to prepare the COLO test environment

2017-10-11 Thread Zhang Chen
detail you can get from here. https://wiki.qemu.org/Features/COLO Thanks Zhang Chen On Mon, Oct 9, 2017 at 9:23 AM, Zhang Chen wrote: > > > On Thu, Oct 5, 2017 at 5:57 AM, 山本真吾 wrote: > >> 2017/09/19 午後10:11 "Zhang Chen" : >> >> > >> > On 09/1

Re: [Xen-devel] How to prepare the COLO test environment

2017-10-08 Thread Zhang Chen
On Thu, Oct 5, 2017 at 5:57 AM, 山本真吾 wrote: > 2017/09/19 午後10:11 "Zhang Chen" : > > > > > On 09/19/2017 04:32 PM, Dario Faggioli wrote: > > > On Mon, 2017-09-18 at 18:52 +, Zhang Chen wrote: > > >> 山本真吾 于2017年9月18日周一 下午6:27写道: > > >&g

Re: [Xen-devel] How to prepare the COLO test environment

2017-09-19 Thread Zhang Chen
On 09/19/2017 04:32 PM, Dario Faggioli wrote: > On Mon, 2017-09-18 at 18:52 +0000, Zhang Chen wrote: >> 山本真吾 于2017年9月18日周一 下午6:27写道: >>> I have read the following documents: >>> >>> COLO - Coarse Grain Lock Stepping >>> https://wiki.xen.org/wiki/COLO

Re: [Xen-devel] How to prepare the COLO test environment

2017-09-18 Thread Zhang Chen
qemu code to upstream, just in progress. So, you can try our internal latest version: Xen: https://github.com/zhangckid/xen/tree/xen-colo-v2 Qemu: https://github.com/zhangckid/qemu/tree/qemu-colo-for-xen The start scripts is same with wiki (you just need remove the modprobe commands). Thank you f

Re: [Xen-devel] [PATCH RFC 01/20] tools: rename COLO 'postcopy' to 'aftercopy'

2017-04-10 Thread Zhang Chen
e name in the COLO context. No functional change. Signed-off-by: Joshua Otto Acked-by: Zhang Chen --- tools/libxc/include/xenguest.h | 4 ++-- tools/libxc/xc_sr_restore.c| 4 ++-- tools/libxc/xc_sr_save.c | 4 ++-- tools/libxl/libxl_colo_restore.c | 2 +- tool

[Xen-devel] [PATCH] COLO-proxy: Fix argument check error

2017-03-23 Thread Zhang Chen
Here, we should check the 'outdev' before use. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 4344c53..f8ba859 100644 --- a/tools/libxl/libxl_dm.c +++ b/t

Re: [Xen-devel] [PATCH 0/2] Update COLO related API

2017-03-19 Thread Zhang Chen
On 03/17/2017 06:54 PM, Wei Liu wrote: On Fri, Mar 17, 2017 at 04:42:30PM +0800, Zhang Chen wrote: After related patch merged by Xen, qemu side patch got some comments to change the API in qemu community. So we update Xen side codes. Qemu patchs: https://lists.nongnu.org/archive/html/qemu

[Xen-devel] [PATCH 2/2] libxl/libxl_qmp.c: Update COLO query replication status API

2017-03-17 Thread Zhang Chen
Because of qemu side patch changed the API that comment by community, So we fix it in Xen side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_restore.c | 2 +- tools/libxl/libxl_colo_save.c| 3 ++- tools/libxl/libxl_internal.h | 2 +- tools/libxl/libxl_qmp.c | 4 ++-- 4

[Xen-devel] [PATCH 1/2] libxl/libxl_qmp.c: Update COLO do checkpoint API

2017-03-17 Thread Zhang Chen
Because of qemu side patch changed the API that comment by community, So we fix it in Xen side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_restore.c | 2 +- tools/libxl/libxl_colo_save.c| 2 +- tools/libxl/libxl_internal.h | 2 +- tools/libxl/libxl_qmp.c | 5 +++-- 4

[Xen-devel] [PATCH 0/2] Update COLO related API

2017-03-17 Thread Zhang Chen
After related patch merged by Xen, qemu side patch got some comments to change the API in qemu community. So we update Xen side codes. Qemu patchs: https://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg07654.html Zhang Chen (2): libxl/libxl_qmp.c: Update COLO do checkpoint API libxl

Re: [Xen-devel] [PATCH V4 7/8] COLO-Proxy: Use socket to get checkpoint event.

2017-03-15 Thread Zhang Chen
On 03/15/2017 06:56 PM, Wei Liu wrote: On Wed, Mar 15, 2017 at 10:02:46AM +0800, Zhang Chen wrote: On 03/14/2017 07:24 PM, Wei Liu wrote: On Mon, Mar 06, 2017 at 10:59:25AM +0800, Zhang Chen wrote: We use kernel colo proxy's way to get the checkpoint event from qemu colo-compare. Qemu

[Xen-devel] [PATCH] tools/xl/xl_parse.c: Remove blank line.

2017-03-14 Thread Zhang Chen
Address Liu wei's comments. Signed-off-by: Zhang Chen --- tools/xl/xl_parse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 0787337..faa9c61 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -524,7 +524,6 @@ int parse_nic_c

Re: [Xen-devel] [PATCH V4 7/8] COLO-Proxy: Use socket to get checkpoint event.

2017-03-14 Thread Zhang Chen
On 03/14/2017 07:24 PM, Wei Liu wrote: On Mon, Mar 06, 2017 at 10:59:25AM +0800, Zhang Chen wrote: We use kernel colo proxy's way to get the checkpoint event from qemu colo-compare. Qemu colo-compare need add a API to support this(I will add this in qemu). Qemu side patch:

Re: [Xen-devel] [PATCH V4 5/8] COLO-Proxy: Add secondary userspace colo-proxy start args

2017-03-14 Thread Zhang Chen
On 03/14/2017 07:39 PM, Wei Liu wrote: On Tue, Mar 14, 2017 at 11:24:12AM +, Wei Liu wrote: On Mon, Mar 06, 2017 at 10:59:23AM +0800, Zhang Chen wrote: Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen Acked-by: Wei Liu diff --git a/tools/xl/xl_parse.c b

Re: [Xen-devel] [PATCH V4 0/8] COLO-Proxy: Make Xen COLO use userspace colo-proxy

2017-03-06 Thread Zhang Chen
On 03/06/2017 10:31 PM, Konrad Rzeszutek Wilk wrote: On Mon, Mar 06, 2017 at 10:59:18AM +0800, Zhang Chen wrote: Because of some reason, We no longer support COLO kernel proxy. However the #7 talks about kernel colo proxy? Is this description out-dated? In patch 7/8, the comments: We use

[Xen-devel] [PATCH V4 6/8] COLO-Proxy: Add colo-compare notify args

2017-03-05 Thread Zhang Chen
Xen colo-frame can use the notify way communicate with qemu colo-compare. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 12 +--- tools/libxl/libxl_nic.c | 8 tools/libxl/libxl_types.idl | 4 tools/xl/xl_parse.c | 8 4 files changed, 29

[Xen-devel] [PATCH V4 7/8] COLO-Proxy: Use socket to get checkpoint event.

2017-03-05 Thread Zhang Chen
We use kernel colo proxy's way to get the checkpoint event from qemu colo-compare. Qemu colo-compare need add a API to support this(I will add this in qemu). Qemu side patch: https://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg07265.html Signed-off-by: Zhang Chen --- tools/

[Xen-devel] [PATCH V4 2/8] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-03-05 Thread Zhang Chen
In this patch we close kernel COLO-Proxy on primary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_proxy.c | 31 +++ tools/libxl/libxl_colo_save.c | 9 +++-- 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/tools/libxl

[Xen-devel] [PATCH V4 0/8] COLO-Proxy: Make Xen COLO use userspace colo-proxy

2017-03-05 Thread Zhang Chen
remove the 'RFC' tag. - fix some bug in patch 7/7. - fix codestyle. V2: - Address wei's comments, use macro to reuse codes. - Do some work on the last patch. - Fix some typo. - Add LIBXL_HAVE_COLO_USERSPACE_PROXY macro in libxl.h. - Some bug fix. V1: - Ini

[Xen-devel] [PATCH V4 4/8] COLO-Proxy: Add primary userspace colo proxy start args

2017-03-05 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 98 + tools/libxl/libxl_nic.c | 78 tools/libxl/libxl_types.idl | 31 +- tools/xl

[Xen-devel] [PATCH V4 3/8] COLO-Proxy: Setup userspace colo-proxy on secondary side

2017-03-05 Thread Zhang Chen
In this patch we add a function to close COLO kernel Proxy on secondary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_restore.c | 8 ++-- tools/libxl/libxl_create.c | 8 ++-- tools/libxl/libxl_types.idl | 1 + tools/xl/xl.h| 1 + tools/xl

[Xen-devel] [PATCH V4 5/8] COLO-Proxy: Add secondary userspace colo-proxy start args

2017-03-05 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 34 ++ tools/libxl/libxl_nic.c | 27 +++ tools/libxl/libxl_types.idl | 15 ++- tools/xl/xl_parse.c | 27

[Xen-devel] [PATCH V4 1/8] COLO-Proxy: Add remus command to open userspace proxy

2017-03-05 Thread Zhang Chen
Add remus '-p' to enable userspace colo proxy(in qemu). Signed-off-by: Zhang Chen --- docs/man/xl.pod.1.in | 5 + tools/libxl/libxl_colo.h | 5 + tools/libxl/libxl_colo_save.c | 2 ++ tools/libxl/libxl_types.idl | 17 + tools/xl/xl_

[Xen-devel] [PATCH V4 8/8] COLO-proxy: Add colo_userspace_proxy macro

2017-03-05 Thread Zhang Chen
Signed-off-by: Zhang Chen --- tools/libxl/libxl.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index 92f1751..4c60e8f 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -870,6 +870,12 @@ typedef struct libxl__ctx libxl_ctx

Re: [Xen-devel] [PATCH V3 2/7] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-02-21 Thread Zhang Chen
On 02/21/2017 07:18 PM, Wei Liu wrote: On Tue, Feb 21, 2017 at 07:03:29PM +0800, Zhang Chen wrote: On 02/21/2017 05:53 PM, Wei Liu wrote: On Tue, Feb 21, 2017 at 10:57:46AM +0800, Zhang Chen wrote: On 02/20/2017 11:55 PM, Wei Liu wrote: On Fri, Feb 17, 2017 at 10:18:24AM +0800, Zhang Chen

Re: [Xen-devel] [PATCH V3 2/7] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-02-21 Thread Zhang Chen
On 02/21/2017 05:53 PM, Wei Liu wrote: On Tue, Feb 21, 2017 at 10:57:46AM +0800, Zhang Chen wrote: On 02/20/2017 11:55 PM, Wei Liu wrote: On Fri, Feb 17, 2017 at 10:18:24AM +0800, Zhang Chen wrote: In this patch we close kernel COLO-Proxy on primary side. Signed-off-by: Zhang Chen

Re: [Xen-devel] [PATCH V3 7/7] COLO-Proxy: Use socket to get checkpoint event.

2017-02-20 Thread Zhang Chen
On 02/21/2017 12:07 AM, Wei Liu wrote: On Fri, Feb 17, 2017 at 10:18:29AM +0800, Zhang Chen wrote: We use kernel colo proxy's way to get the checkpoint event from qemu colo-compare. Qemu colo-compare need add a API to support this(I will add this in qemu). Signed-off-by: Zhang

Re: [Xen-devel] [PATCH V3 5/7] COLO-Proxy: Add primary userspace colo proxy start args

2017-02-20 Thread Zhang Chen
On 02/20/2017 11:59 PM, Wei Liu wrote: On Fri, Feb 17, 2017 at 10:18:27AM +0800, Zhang Chen wrote: Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen [...] + +#undef APPEND_COLO_SOCK_SERVER +#undef APPEND_COLO_SOCK_CLIENT I would move these a bit further up

Re: [Xen-devel] [PATCH V3 2/7] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-02-20 Thread Zhang Chen
On 02/20/2017 11:55 PM, Wei Liu wrote: On Fri, Feb 17, 2017 at 10:18:24AM +0800, Zhang Chen wrote: In this patch we close kernel COLO-Proxy on primary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_proxy.c | 27 +++ tools/libxl/libxl_colo_save.c | 9

Re: [Xen-devel] [PATCH V3 1/7] COLO-Proxy: Add remus command to open userspace proxy

2017-02-20 Thread Zhang Chen
On 02/20/2017 11:50 PM, Wei Liu wrote: On Fri, Feb 17, 2017 at 10:18:23AM +0800, Zhang Chen wrote: Add remus '-p' to enable userspace colo proxy(in qemu). Signed-off-by: Zhang Chen --- docs/man/xl.pod.1.in | 5 + tools/libxl/libxl.h | 6 ++ t

Re: [Xen-devel] [PATCH V3 3/7] tools/libxl: refactor do_domain_create()

2017-02-20 Thread Zhang Chen
On 02/20/2017 11:50 PM, Wei Liu wrote: On Fri, Feb 17, 2017 at 10:18:25AM +0800, Zhang Chen wrote: We use params->colo_proxy_script to make do_domain_create() doesn't take "colo_proxy_script" anymore. Signed-off-by: Zhang Chen --- This patch is self-contained so: Ack

[Xen-devel] [PATCH V3 0/7] COLO-Proxy: Make Xen COLO use userspace colo-proxy

2017-02-16 Thread Zhang Chen
ork on the last patch. - Fix some typo. - Add LIBXL_HAVE_COLO_USERSPACE_PROXY macro in libxl.h. - Some bug fix. V1: - Initial patch Zhang Chen (7): COLO-Proxy: Add remus command to open userspace proxy COLO-Proxy: Setup userspace colo-proxy on primary side tools/libxl: refa

[Xen-devel] [PATCH V3 1/7] COLO-Proxy: Add remus command to open userspace proxy

2017-02-16 Thread Zhang Chen
Add remus '-p' to enable userspace colo proxy(in qemu). Signed-off-by: Zhang Chen --- docs/man/xl.pod.1.in | 5 + tools/libxl/libxl.h | 6 ++ tools/libxl/libxl_colo.h | 5 + tools/libxl/libxl_colo_save.c | 2 ++ tools/libxl/libxl_types.

[Xen-devel] [PATCH V3 3/7] tools/libxl: refactor do_domain_create()

2017-02-16 Thread Zhang Chen
We use params->colo_proxy_script to make do_domain_create() doesn't take "colo_proxy_script" anymore. Signed-off-by: Zhang Chen --- tools/libxl/libxl_create.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tools/libxl/libxl_crea

[Xen-devel] [PATCH V3 4/7] COLO-Proxy: Setup userspace colo-proxy on secondary side

2017-02-16 Thread Zhang Chen
In this patch we add a function to close COLO kernel Proxy on secondary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_restore.c | 8 ++-- tools/libxl/libxl_create.c | 8 ++-- tools/libxl/libxl_types.idl | 1 + tools/libxl/xl_cmdimpl.c | 18

[Xen-devel] [PATCH V3 7/7] COLO-Proxy: Use socket to get checkpoint event.

2017-02-16 Thread Zhang Chen
We use kernel colo proxy's way to get the checkpoint event from qemu colo-compare. Qemu colo-compare need add a API to support this(I will add this in qemu). Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo.h | 2 + tools/libxl/libxl_colo_proxy.c

[Xen-devel] [PATCH V3 5/7] COLO-Proxy: Add primary userspace colo proxy start args

2017-02-16 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 98 + tools/libxl/libxl_nic.c | 78 tools/libxl/libxl_types.idl | 31 +- tools/libxl

[Xen-devel] [PATCH V3 6/7] COLO-Proxy: Add secondary userspace colo-proxy start args

2017-02-16 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 34 ++ tools/libxl/libxl_nic.c | 27 +++ tools/libxl/libxl_types.idl | 15 ++- tools/libxl/xl_cmdimpl.c| 27

[Xen-devel] [PATCH V3 2/7] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-02-16 Thread Zhang Chen
In this patch we close kernel COLO-Proxy on primary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_proxy.c | 27 +++ tools/libxl/libxl_colo_save.c | 9 +++-- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_colo_proxy.c

Re: [Xen-devel] [PATCH RFC V2 7/7] COLO-Proxy: Use socket to get checkpoint event.

2017-02-15 Thread Zhang Chen
On 02/16/2017 12:24 AM, Konrad Rzeszutek Wilk wrote: On Wed, Feb 15, 2017 at 05:54:33PM +0800, Zhang Chen wrote: We use kernel colo proxy's way to get the checkpoint event from qemu colo-compare. Qemu colo-compare need add a API to support this(I will add this in qemu). Signed-off-by:

Re: [Xen-devel] [PATCH RFC V2 0/7] COLO-Proxy: Make Xen COLO use userspace colo-proxy

2017-02-15 Thread Zhang Chen
On 02/16/2017 12:18 AM, Konrad Rzeszutek Wilk wrote: On Wed, Feb 15, 2017 at 05:54:26PM +0800, Zhang Chen wrote: Because of some reason, We no longer support COLO kernel proxy. So we send this patch set to make Xen use userspace colo-proxy in qemu. How come it is RFC? It looks quite baked

[Xen-devel] [PATCH RFC V2 0/7] COLO-Proxy: Make Xen COLO use userspace colo-proxy

2017-02-15 Thread Zhang Chen
libxl.h. - Some bug fix. V1: - Initial patch Zhang Chen (7): COLO-Proxy: Add remus command to open userspace proxy COLO-Proxy: Setup userspace colo-proxy on primary side tools/libxl: refactor do_domain_create() COLO-Proxy: Setup userspace colo-proxy on secondary side COLO-Proxy:

[Xen-devel] [PATCH RFC V2 2/7] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-02-15 Thread Zhang Chen
In this patch we close kernel COLO-Proxy on primary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_proxy.c | 27 +++ tools/libxl/libxl_colo_save.c | 9 +++-- 2 files changed, 34 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_colo_proxy.c

[Xen-devel] [PATCH RFC V2 6/7] COLO-Proxy: Add secondary userspace colo-proxy start args

2017-02-15 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 34 ++ tools/libxl/libxl_nic.c | 27 +++ tools/libxl/libxl_types.idl | 15 ++- tools/libxl/xl_cmdimpl.c| 27

[Xen-devel] [PATCH RFC V2 5/7] COLO-Proxy: Add primary userspace colo proxy start args

2017-02-15 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 98 + tools/libxl/libxl_nic.c | 78 tools/libxl/libxl_types.idl | 31 +- tools/libxl

[Xen-devel] [PATCH RFC V2 4/7] COLO-Proxy: Setup userspace colo-proxy on secondary side

2017-02-15 Thread Zhang Chen
In this patch we add a function to close COLO kernel Proxy on secondary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_restore.c | 8 ++-- tools/libxl/libxl_create.c | 8 ++-- tools/libxl/libxl_types.idl | 1 + tools/libxl/xl_cmdimpl.c | 18

[Xen-devel] [PATCH RFC V2 7/7] COLO-Proxy: Use socket to get checkpoint event.

2017-02-15 Thread Zhang Chen
We use kernel colo proxy's way to get the checkpoint event from qemu colo-compare. Qemu colo-compare need add a API to support this(I will add this in qemu). Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo.h | 2 + tools/libxl/libxl_colo_proxy.c

[Xen-devel] [PATCH RFC V2 1/7] COLO-Proxy: Add remus command to open userspace proxy

2017-02-15 Thread Zhang Chen
Add remus '-p' to enable userspace colo proxy(in qemu). Signed-off-by: Zhang Chen --- docs/man/xl.pod.1.in | 5 + tools/libxl/libxl.h | 6 ++ tools/libxl/libxl_colo.h | 5 + tools/libxl/libxl_colo_save.c | 2 ++ tools/libxl/libxl_types.

[Xen-devel] [PATCH RFC V2 3/7] tools/libxl: refactor do_domain_create()

2017-02-15 Thread Zhang Chen
We use params->colo_proxy_script to make do_domain_create() doesn't take "colo_proxy_script" anymore. Signed-off-by: Zhang Chen --- tools/libxl/libxl_create.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/tools/libxl/libxl_crea

Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c

2017-02-08 Thread Zhang Chen
On 02/09/2017 12:54 AM, Wei Liu wrote: And CC Zhangchen Thanks, I will apply this patch set before test my patch. Zhang Chen On Wed, Feb 08, 2017 at 02:35:27PM +, Wei Liu wrote: Cc Yi Sun as well. Haozhong and Yi: This is just a heads-up -- Juergen from SuSE took the time to split

Re: [Xen-devel] [PATCH RFC 4/6] COLO-Proxy: Add primary userspace colo proxy start args

2017-02-08 Thread Zhang Chen
On 01/28/2017 01:05 AM, Wei Liu wrote: On Thu, Jan 26, 2017 at 02:36:07PM +0800, Zhang Chen wrote: Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen Since we have: # Note that the COLO configuration settings should be considered unstable. # They may

Re: [Xen-devel] [PATCH RFC 5/6] COLO-Proxy: Add secondary userspace colo-proxy start args

2017-02-08 Thread Zhang Chen
On 01/28/2017 01:05 AM, Wei Liu wrote: On Thu, Jan 26, 2017 at 02:36:08PM +0800, Zhang Chen wrote: Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen See previous patch. Same comments apply here. OK~ I will fix it in next version. Thanks Zhang Chen Wei

Re: [Xen-devel] [PATCH RFC 0/6] COLO-Proxy: Make Xen COLO use userspace colo-proxy

2017-02-08 Thread Zhang Chen
On 01/28/2017 01:08 AM, Wei Liu wrote: On Thu, Jan 26, 2017 at 02:36:03PM +0800, Zhang Chen wrote: Hi~ All~ Happy Chinese New Year~~ Happy Chinese New Year to you, too! I skimmed through this series and made some comments based on my preliminary assessment. If you have any questions, feel

Re: [Xen-devel] [PATCH RFC 6/6] COLO-Proxy: Use socket to get checkpoint event.

2017-02-08 Thread Zhang Chen
On 01/28/2017 01:05 AM, Wei Liu wrote: On Thu, Jan 26, 2017 at 02:36:09PM +0800, Zhang Chen wrote: We use old kernel colo proxy way to get the checkpoint event from qemu. This patch have some TODO job. Qemu compare need add a API to support this(I will add this in qemu). Signed-off-by: Zhang

Re: [Xen-devel] [PATCH RFC 3/6] COLO-Proxy: Setup userspace colo-proxy on secondary side

2017-02-06 Thread Zhang Chen
On 02/06/2017 07:25 PM, Wei Liu wrote: On Mon, Feb 06, 2017 at 05:27:43PM +0800, Zhang Chen wrote: [...] set_disk_colo_restore(d_config); } else { unset_disk_colo_restore(d_config); } return do_domain_create(ctx, d_config, domid, restore_fd

Re: [Xen-devel] [PATCH RFC 3/6] COLO-Proxy: Setup userspace colo-proxy on secondary side

2017-02-06 Thread Zhang Chen
On 01/28/2017 01:05 AM, Wei Liu wrote: On Thu, Jan 26, 2017 at 02:36:06PM +0800, Zhang Chen wrote: In this patch we add a function to close kernel COLO-Proxy on secondary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_restore.c | 9 +++-- tools/libxl/libxl_create.c

Re: [Xen-devel] [PATCH RFC 2/6] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-02-05 Thread Zhang Chen
On 01/28/2017 01:05 AM, Wei Liu wrote: On Thu, Jan 26, 2017 at 02:36:05PM +0800, Zhang Chen wrote: In this patch we close kernel COLO-Proxy on primary side. Signed-off-by: Zhang Chen Acked-by: Wei Liu I don't claim I know much about COLO though, nor have I ever run it, so it wou

Re: [Xen-devel] [PATCH RFC 1/6] COLO-Proxy: Add remus command to open userspace proxy

2017-02-05 Thread Zhang Chen
On 01/28/2017 01:05 AM, Wei Liu wrote: On Thu, Jan 26, 2017 at 02:36:04PM +0800, Zhang Chen wrote: Add remus '-p' to enable userspace colo proxy(in qemu). Signed-off-by: Zhang Chen --- docs/man/xl.pod.1.in | 4 tools/libxl/libxl_colo.h | 5 + t

[Xen-devel] [PATCH RFC 4/6] COLO-Proxy: Add primary userspace colo proxy start args

2017-01-25 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 104 tools/libxl/libxl_nic.c | 232 tools/libxl/libxl_types.idl | 31 +- tools/libxl/xl_cmdimpl.c| 58

[Xen-devel] [PATCH RFC 0/6] COLO-Proxy: Make Xen COLO use userspace colo-proxy

2017-01-25 Thread Zhang Chen
ts sent by the netdev +--+ You can know the detail from here: http://wiki.qemu.org/Features/COLO https://github.com/qemu/qemu/blob/master/docs/colo-proxy.txt Zhang Chen (6): COLO-Proxy: Add remus command to open userspace proxy COLO-Proxy: Setup userspace colo-proxy on primary side COLO-P

[Xen-devel] [PATCH RFC 1/6] COLO-Proxy: Add remus command to open userspace proxy

2017-01-25 Thread Zhang Chen
Add remus '-p' to enable userspace colo proxy(in qemu). Signed-off-by: Zhang Chen --- docs/man/xl.pod.1.in | 4 tools/libxl/libxl_colo.h | 5 + tools/libxl/libxl_colo_save.c | 2 ++ tools/libxl/libxl_types.idl | 17 + tools/libxl/xl

[Xen-devel] [PATCH RFC 2/6] COLO-Proxy: Setup userspace colo-proxy on primary side

2017-01-25 Thread Zhang Chen
In this patch we close kernel COLO-Proxy on primary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_proxy.c | 30 ++ tools/libxl/libxl_colo_save.c | 9 +++-- 2 files changed, 37 insertions(+), 2 deletions(-) diff --git a/tools/libxl

[Xen-devel] [PATCH RFC 3/6] COLO-Proxy: Setup userspace colo-proxy on secondary side

2017-01-25 Thread Zhang Chen
In this patch we add a function to close kernel COLO-Proxy on secondary side. Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_restore.c | 9 +++-- tools/libxl/libxl_create.c | 9 +++-- tools/libxl/libxl_types.idl | 1 + tools/libxl/xl_cmdimpl.c | 18

[Xen-devel] [PATCH RFC 6/6] COLO-Proxy: Use socket to get checkpoint event.

2017-01-25 Thread Zhang Chen
We use old kernel colo proxy way to get the checkpoint event from qemu. This patch have some TODO job. Qemu compare need add a API to support this(I will add this in qemu). Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo.h | 2 ++ tools/libxl/libxl_colo_proxy.c | 12

[Xen-devel] [PATCH RFC 5/6] COLO-Proxy: Add secondary userspace colo-proxy start args

2017-01-25 Thread Zhang Chen
Qemu need this args to start userspace colo-proxy. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 45 +++ tools/libxl/libxl_nic.c | 66 + tools/libxl/libxl_types.idl | 15 ++- tools/libxl

[Xen-devel] [PATCH V2] libxl/libxl_qmp.c: Fix code style in qmp_next()

2016-12-25 Thread Zhang Chen
Fix text-indent. Signed-off-by: Zhang Chen --- tools/libxl/libxl_qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index ad22ad4..a91643a 100644 --- a/tools/libxl/libxl_qmp.c +++ b/tools/libxl/libxl_qmp.c @@ -499,7 +499,7

Re: [Xen-devel] [PATCH] libxl/libxl_qmp.c: Fix code style in qmp_next()

2016-12-25 Thread Zhang Chen
On 12/23/2016 07:44 PM, Wei Liu wrote: On Fri, Dec 23, 2016 at 11:16:58AM +0800, Zhang Chen wrote: [...] + Here, as I understand it, read can return incomplete message. For example, when the buffer is not big enough. And the inner loop in original code handles that by checking if there is

Re: [Xen-devel] [PATCH] libxl/libxl_qmp.c: Fix code style in qmp_next()

2016-12-22 Thread Zhang Chen
On 12/22/2016 06:47 PM, Wei Liu wrote: Also CC Anthony, who wrote the original code. On Thu, Dec 22, 2016 at 05:53:07PM +0800, Zhang Chen wrote: Make select loop more readable. The behaviour of this function is changed. The changes are not necessarily wrong, but we need to have clear commit

[Xen-devel] [PATCH] libxl/libxl_qmp.c: Fix code style in qmp_next()

2016-12-22 Thread Zhang Chen
Make select loop more readable. Signed-off-by: Zhang Chen --- tools/libxl/libxl_qmp.c | 123 1 file changed, 61 insertions(+), 62 deletions(-) diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c index ad22ad4..123a6bf 100644 --- a

Re: [Xen-devel] [PATCH 2/3] Add Xen colo support for qemu-upstream colo codes

2016-12-12 Thread Zhang Chen
On 12/12/2016 06:37 PM, Wei Liu wrote: On Thu, Dec 01, 2016 at 01:20:18PM +, Wei Liu wrote: On Wed, Nov 30, 2016 at 05:47:51PM +0800, Zhang Chen wrote: Because of qemu codes update, we update Xen colo block codes Signed-off-by: Zhang Chen COLO being an experimental feature means that

Re: [Xen-devel] [PATCH] x86/hvm: don't create a default ioreq server...

2016-12-11 Thread Zhang Chen
with this patch? Tested-by: Zhang Chen I have tested this patch, it works well on COLO! Thanks Zhang Chen --- Cc: Jan Beulich Cc: Andrew Cooper --- xen/arch/x86/hvm/hvm.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/

Re: [Xen-devel] [PATCH 1/3] Don't create default ioreq server

2016-12-08 Thread Zhang Chen
On 12/01/2016 09:19 PM, Wei Liu wrote: On Wed, Nov 30, 2016 at 05:47:50PM +0800, Zhang Chen wrote: The ioreq server make colo run failed. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- xen/arch/x86/hvm/hvm.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/xen

Re: [Xen-devel] [Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO

2016-12-06 Thread Zhang Chen
ID: ed37ef1f91c20f0ab162ce60f8c38400b917fa64 COLO: introduce new API to prepare/start/do/get_error/stop replication a0ddc0b359375b2418213966dfbdbfab593ecc6f tools/libxl: introduction of libxl__qmp_restore to load qemu state Thanks Zhang Chen Thanks! - Stefano On Thu, 1 Dec 2016, Zhang Chen

[Xen-devel] [PATCH 2/3] Add Xen colo support for qemu-upstream colo codes

2016-11-30 Thread Zhang Chen
Because of qemu codes update, we update Xen colo block codes Signed-off-by: Zhang Chen --- tools/libxl/libxl_colo_qdisk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_colo_qdisk.c b/tools/libxl/libxl_colo_qdisk.c index d271d1f..300bff2 100644 --- a

[Xen-devel] [PATCH 3/3] Add COLO replication top-id support

2016-11-30 Thread Zhang Chen
Because of qemu colo add the top-id, so we update it. Signed-off-by: Zhang Chen --- tools/libxl/libxl_dm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index ad366a8..815938e 100644 --- a/tools/libxl/libxl_dm.c +++ b

[Xen-devel] [PATCH 0/3] Support the latest version of qemu COLO

2016-11-30 Thread Zhang Chen
Because of new version COLO has been merged by QEMU, Some codes has changed by community comments. So, we must update Xen COLO codes to support latest qemu. Zhang Chen (3): Don't create default ioreq server Add Xen colo support for qemu-upstream colo codes Add COLO replication t

[Xen-devel] [PATCH 1/3] Don't create default ioreq server

2016-11-30 Thread Zhang Chen
The ioreq server make colo run failed. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- xen/arch/x86/hvm/hvm.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 25dc759..8522852 100644 --- a/xen/arch/x86/hvm/hvm.c

Re: [Xen-devel] Error migrating VM to secondary host using COLO replication

2016-11-02 Thread Zhang Chen
On 10/29/2016 12:56 AM, Konrad Rzeszutek Wilk wrote: On Thu, Oct 27, 2016 at 08:56:34PM -0200, Sadi wrote: Hello, Hey! CC-ing relevant people. CC Xie Changlong, Wen Congyang and Yang Hongyang on the COLO-Xen wiki for help. Thanks Zhang Chen I've been trying to set COLO replicati