On 01/28/2017 01:05 AM, Wei Liu wrote:
On Thu, Jan 26, 2017 at 02:36:05PM +0800, Zhang Chen wrote:
In this patch we close kernel COLO-Proxy on primary side.
Signed-off-by: Zhang Chen <zhangchen.f...@cn.fujitsu.com>
Acked-by: Wei Liu <wei.l...@citrix.com>
I don't claim I know much about COLO though, nor have I ever run it, so
it would be better to have a second eye on this patch.
There are some style nits below.
---
tools/libxl/libxl_colo_proxy.c | 30 ++++++++++++++++++++++++++++++
tools/libxl/libxl_colo_save.c | 9 +++++++--
2 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_colo_proxy.c b/tools/libxl/libxl_colo_proxy.c
index 0983f42..348484d 100644
--- a/tools/libxl/libxl_colo_proxy.c
+++ b/tools/libxl/libxl_colo_proxy.c
@@ -152,6 +152,11 @@ int colo_proxy_setup(libxl__colo_proxy_state *cps)
STATE_AO_GC(cps->ao);
+ if (cps->is_userspace_proxy) {
+ /* If enable userspace proxy mode, we don't need setup kernel proxy */
+ return 0;
+ }
+
There is only one statement so no need to have {}.
You can move the comment before "if" and remove {}.
Same rule applies to all the patches.
OK, I will fix this in next version.
Thanks
Zhang Chen
Wei.
.
--
Thanks
Zhang Chen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
