Re: [Xen-devel] [PATCH v7 2/3] * util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-05-10 Thread Vladimir 'phcoder' Serbinenko
On Tue, May 9, 2017, 11:02 Fu Wei wrote: > Hi Vladimir > > On 9 May 2017 at 14:59, Vladimir 'phcoder' Serbinenko > wrote: > > > > > > Le Tue, May 2, 2017 à 9:06 AM, a écrit : > >> > >> From: Fu Wei > >> > >> This pat

Re: [Xen-devel] [PATCH v7 2/3] * util/grub.d/20_linux_xen.in: Add xen_boot command support for aarch64

2017-05-09 Thread Vladimir 'phcoder' Serbinenko
Le Tue, May 2, 2017 à 9:06 AM, a écrit : > From: Fu Wei > > This patch adds the support of xen_boot command for aarch64: > xen_hypervisor > xen_module > These two commands are only for aarch64, since it has its own protocol and > commands to boot xen hypervisor and Dom0, but not multiboo

Re: [Xen-devel] [PATCH v7 1/3] arm64: add "--nounzip" option support in xen_module command

2017-05-08 Thread Vladimir 'phcoder' Serbinenko
Le Tue, May 2, 2017 à 9:06 AM, a écrit : > From: Fu Wei > > This patch adds "--nounzip" option support in order to > be compatible with the module command of multiboot on other architecture, > by this way we can simplify grub-mkconfig support code. > > This patch also allow us to use zip compres

Re: [Xen-devel] [GRUB2 PATCH v4 4/4] multiboot2: Add support for relocatable images

2016-03-16 Thread Vladimir 'phcoder' Serbinenko
On Tuesday, March 15, 2016, Daniel Kiper wrote: > On Tue, Mar 15, 2016 at 05:30:20PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Tuesday, March 15, 2016, Vladimir 'phcoder' Serbinenko < > phco...@gmail.com > > > wrote: &g

Re: [Xen-devel] [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-16 Thread Vladimir &#x27;phcoder' Serbinenko
ces from grub, there is no > sense to provide EFI memory map at all, because to exit boot services [from > OS], you *have to* fetch current memory map to get the map key to exit boot > services. > But this doesn't apply for e820-like and simple maps which are unaffected by bootloader allocations > > basically it means, if BS is not disabled and grub is still providing EFI > memory map, the OS has to assume this map is not valid - which is bad and > better not to provide (potentially) invalid data in first place. > > rgds, > toomas -- Regards Vladimir 'phcoder' Serbinenko ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-15 Thread Vladimir &#x27;phcoder' Serbinenko
Le mar. 15 mars 2016 19:06, Andrei Borzenkov a écrit : > 15.03.2016 19:07, Vladimir 'phcoder' Serbinenko пишет: > > Looks good. Let's give a day for others to comment. Is the second email > the > > version for commit? > > > > On Tuesday, March 15,

Re: [Xen-devel] [GRUB2 PATCH v4 4/4] multiboot2: Add support for relocatable images

2016-03-15 Thread Vladimir &#x27;phcoder' Serbinenko
On Tuesday, March 15, 2016, Vladimir 'phcoder' Serbinenko wrote: > >> + if (mld->relocatable) >> + err = grub_relocator_alloc_chunk_align >> (grub_multiboot_relocator, &ch, >> +

Re: [Xen-devel] [GRUB2 PATCH v4 4/4] multiboot2: Add support for relocatable images

2016-03-15 Thread Vladimir &#x27;phcoder' Serbinenko
ble) > +{ > + if (mld.load_base_addr >= mld.link_base_addr) > + grub_multiboot_payload_eip += mld.load_base_addr - > mld.link_base_addr; > + else > + grub_multiboot_payload_eip -= mld.link_base_addr - > mld.load_base_addr;

Re: [Xen-devel] [GRUB2 PATCH v4 3/4 - FOR REVIEW ONLY] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-15 Thread Vladimir &#x27;phcoder' Serbinenko
er then > it should get them itself just before ExitBootServices() call. > > Signed-off-by: Daniel Kiper > > Reviewed-by: Konrad Rzeszutek Wilk > > --- > v3 - suggestions/fixes: >- improve commit message > (suggested by Konrad Rzeszutek Wilk and Vladim

Re: [Xen-devel] [GRUB2 PATCH v4 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-15 Thread Vladimir &#x27;phcoder' Serbinenko
--- > v4 - suggestions/fixes: >- reduce number of #ifdefs in grub_multiboot_get_mbi_size() > (suggested by Vladimir 'phcoder' Serbinenko). > > v3 - suggestions/fixes: >- mbi EFI related stuff size calculation > should depend on target architecture &

Re: [Xen-devel] [GRUB2 PATCH v4 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-15 Thread Vladimir &#x27;phcoder' Serbinenko
Probably without _start. Comment probably applies even more here than above. Are you ok with me moving ends to the same place when comitting? This would make the code less error-prone. -- Regards Vladimir 'phcoder' Serbinenko ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Fri, Mar 11, 2016 at 04:44:00PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > [...] > > > multiboot2 spec is a rolling update. > > OK. So, I think that we should do this in that way: > - apply th

Re: [Xen-devel] [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
fused link address and minimal loading address? How is entry usually specified in ELF? How do you suggest it should be done in mb headers? > > > from base addr. What do ET_DYN files use? > > I will take a look. > > Daniel > -- Regards Vladimir 'phcoder' Serbinenko ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Thu, Mar 10, 2016 at 09:23:23PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 2, 2016, Daniel Kiper > wrote: > > > > > Add grub_relocator64_efi relocator. It will be used on EFI

Re: [Xen-devel] [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Fri, Mar 11, 2016 at 01:27:32PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 9, 2016, Daniel Kiper > wrote: > > > > > On Wed, Mar 02, 2016 at 05:51:36PM +0100, Daniel Kiper wrote

Re: [Xen-devel] [GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Thu, Mar 10, 2016 at 09:23:23PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 2, 2016, Daniel Kiper > wrote: > > > > > Add grub_relocator64_efi relocator. It will be used on EFI

Re: [Xen-devel] [GRUB2 PATCH v3 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
On Friday, March 11, 2016, Daniel Kiper wrote: > On Thu, Mar 10, 2016 at 09:26:06PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > On Wednesday, March 2, 2016, Daniel Kiper > wrote: > > > > > Add tags used to pass ImageHandle to loaded image if

Re: [Xen-devel] [GRUB2 PATCH v3 0/4] multiboot2: Add two extensions

2016-03-11 Thread Vladimir &#x27;phcoder' Serbinenko
y're features but code is well isolated and the alternative is painful. I answered the individual mails with review. Is there a followup with updating multiboot2 docs? > > Daniel > -- Regards Vladimir 'phcoder' Serbinenko ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-10 Thread Vladimir &#x27;phcoder' Serbinenko
ocation data. Can you add a check that image doesn't have any relocation entries? So that we fail nicely rather than loading half-working binary? > However, I was asked by Konrad Rzeszutek Wilk and Vladimir > 'phcoder' Serbinenko to investigate that thing. It looks that rele

Re: [Xen-devel] [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-10 Thread Vladimir &#x27;phcoder' Serbinenko
whole static > > and dynamic knowledge provided by boot loader. > > > > This patch does not provide functionality which could do relocations > using > > ELF relocation data. However, I was asked by Konrad Rzeszutek Wilk and > Vladimir > > 'phcoder'

Re: [Xen-devel] [GRUB2 PATCH v3 4/4] multiboot2: Add support for relocatable images

2016-03-10 Thread Vladimir &#x27;phcoder' Serbinenko
ine MULTIBOOT_TAG_TYPE_EFI_BS18 > #define MULTIBOOT_TAG_TYPE_EFI32_IH 19 > #define MULTIBOOT_TAG_TYPE_EFI64_IH 20 > +#define MULTIBOOT_TAG_TYPE_BASE_ADDR 21 > > #define MULTIBOOT_HEADER_TAG_END 0 > #define MULTIBOOT_HEADER_TAG_INFORMATION_REQUEST 1 > @@ -72,11 +73,16 @@ > #define MULTIBOOT_HEADER_TAG_MODULE_ALIGN 6 > #define MULTIBOOT_HEADER_TAG_EFI_BS 7 > #define MULTIBOOT_HEADER_TAG_ENTRY_ADDRESS_EFI64 9 > +#define MULTIBOOT_HEADER_TAG_RELOCATABLE 10 > > #define MULTIBOOT_ARCHITECTURE_I386 0 > #define MULTIBOOT_ARCHITECTURE_MIPS32 4 > #define MULTIBOOT_HEADER_TAG_OPTIONAL 1 > > +#define MULTIBOOT_LOAD_PREFERENCE_NONE 0 > +#define MULTIBOOT_LOAD_PREFERENCE_LOW 1 > +#define MULTIBOOT_LOAD_PREFERENCE_HIGH 2 > + > #define MULTIBOOT_CONSOLE_FLAGS_CONSOLE_REQUIRED 1 > #define MULTIBOOT_CONSOLE_FLAGS_EGA_TEXT_SUPPORTED 2 > > @@ -161,6 +167,17 @@ struct multiboot_header_tag_module_align >multiboot_uint32_t size; > }; > > +struct multiboot_header_tag_relocatable > +{ > + multiboot_uint16_t type; > + multiboot_uint16_t flags; > + multiboot_uint32_t size; > + multiboot_uint32_t min_addr; > + multiboot_uint32_t max_addr; > + multiboot_uint32_t align; > + multiboot_uint32_t preference; > +}; > + > struct multiboot_color > { >multiboot_uint8_t red; > @@ -387,6 +404,13 @@ struct multiboot_tag_efi64_ih >multiboot_uint64_t pointer; > }; > > +struct multiboot_tag_base_addr > +{ > + multiboot_uint32_t type; > + multiboot_uint32_t size; > + multiboot_uint32_t base_addr; > +}; > + > #endif /* ! ASM_FILE */ > > #endif /* ! MULTIBOOT_HEADER */ > -- > 1.7.10.4 > > -- Regards Vladimir 'phcoder' Serbinenko ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [GRUB2 PATCH v3 3/4] multiboot2: Do not pass memory maps to image if EFI boot services are enabled

2016-03-10 Thread Vladimir &#x27;phcoder' Serbinenko
tered. Can you provide 2 variants: normal (for commit) and with ignoring whitespaces (for review) > > Signed-off-by: Daniel Kiper > > Reviewed-by: Konrad Rzeszutek Wilk > > --- > v3 - suggestions/fixes: >- improve commit message > (suggested by Konrad

Re: [Xen-devel] [GRUB2 PATCH v3 2/4] multiboot2: Add tags used to pass ImageHandle to loaded image

2016-03-10 Thread Vladimir &#x27;phcoder' Serbinenko
fi_mmap >multiboot_uint8_t efi_mmap[0]; > }; > > +struct multiboot_tag_efi32_ih > +{ > + multiboot_uint32_t type; > + multiboot_uint32_t size; > + multiboot_uint32_t pointer; > +}; > + > +struct multiboot_tag_efi64_ih > +{ > + multiboot_uint32_t type; > + multiboot_uint32_t size; > + multiboot_uint64_t pointer; > +}; > + > #endif /* ! ASM_FILE */ > > #endif /* ! MULTIBOOT_HEADER */ > -- > 1.7.10.4 > > -- Regards Vladimir 'phcoder' Serbinenko ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [GRUB2 PATCH v3 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-10 Thread Vladimir &#x27;phcoder' Serbinenko
EFI boot services without any issues. > > If idea is accepted I will prepare grub_relocator32_efi relocator too. > > Signed-off-by: Daniel Kiper > > --- > v3 - suggestions/fixes: >- reuse grub-core/lib/i386/relocator64.S code > instead of creating separate assembl

Re: [Xen-devel] [PATCH v2 2/6] relocator: Do not use memory region if its starta is smaller than size

2016-02-12 Thread Vladimir &#x27;phcoder' Serbinenko
Le ven. 12 févr. 2016 20:01, Daniel Kiper a écrit : > On Fri, Feb 12, 2016 at 03:57:59PM +0100, Vladimir 'φ-coder/phcoder' > Serbinenko wrote: > > Applied, thanks > > Thanks but here > http://lists.gnu.org/archive/html/grub-devel/2015-07/msg00100.html > Andrei and later here > http://lists.gnu.or

Re: [Xen-devel] [PATCH 0/6] grub-xen: support booting huge pv-domains

2015-11-15 Thread Vladimir &#x27;phcoder' Serbinenko
Sorry for delay. Just this patch series is more difficult to review for me but I'm definitely not ignoring it. I'll try to get to it this week Le 16 nov. 2015 6:47 AM, "Juergen Gross" a écrit : > On 02/11/15 06:51, Juergen Gross wrote: > > The Xen hypervisor supports starting a dom0 with large me

Re: [Xen-devel] [PATCH v2 1/6] gitignore: Ignore *.orig, *.rej and *.swp files

2015-11-04 Thread Vladimir &#x27;phcoder' Serbinenko
Le 12 août 2015 11:04 AM, "Ian Campbell" a écrit : > > > (Having written the below I see too late that this is a grub patch not a > Xen one, a tag in the subject for such cross posted patches would be useful > please. Anyway, my opinion counts for very little in this context but I > leave it below

Re: [Xen-devel] Is: grub2-mkconfig detecting ELF files the multiboot2 header and using proper module. Was:Re: [PATCH 0/5] multiboot2: Enable EFI boot services usage in loaded images

2015-05-11 Thread Vladimir &#x27;phcoder' Serbinenko
On May 11, 2015 6:26 PM, "Konrad Rzeszutek Wilk" wrote: > > On Mon, Feb 09, 2015 at 06:55:05PM +0100, Daniel Kiper wrote: > > Hi all, > > > > On Fri, Jan 30, 2015 at 06:59:23PM +0100, Daniel Kiper wrote: > > > Hi, > > > > > > This patch series enable EFI boot services usage > > > in loaded images

Re: [Xen-devel] [PATCH 00/18] x86: multiboot2 protocol support

2015-02-05 Thread Vladimir &#x27;phcoder' Serbinenko
Le 2015-02-04 10:51, "Jan Beulich" a écrit : > > >>> On 04.02.15 at 10:04, wrote: > > On 03/02/2015 17:14, Daniel Kiper wrote: > >> On Mon, Feb 02, 2015 at 09:28:49AM +, Jan Beulich wrote: > >> On 30.01.15 at 18:54, wrote: > - xen.efi build will not so strongly depend > o