[Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask

2016-07-06 Thread Wei Jiangang
verify_local_APIC() had been removed by commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), so apic_id_mask isn't used by it. Signed-off-by: Wei Jiangang --- arch/x86/xen/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.

[Xen-devel] [qemu-mainline test] 96732: tolerable FAIL - PUSHED

2016-07-06 Thread osstest service owner
flight 96732 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/96732/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-stop fail like 96703 test-amd64-i386-xl-qemuu-win

Re: [Xen-devel] [PATCH v4] x86/cpuid: AVX-512 Feature Detection

2016-07-06 Thread Kang, Luwei
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, July 5, 2016 3:03 PM > To: Kang, Luwei > Cc: andrew.coop...@citrix.com; chao.p.p...@linux.intel.com; xen- > de...@lists.xen.org > Subject: RE: [PATCH v4] x86/cpuid: AVX-512 Feature Detection > > >>> On

Re: [Xen-devel] [PATCH v2] xen/arm: register clocks used by the hypervisor

2016-07-06 Thread Michael Turquette
Quoting Mark Rutland (2016-07-05 04:07:37) > Hi, > > On Tue, Jul 05, 2016 at 12:45:34PM +0200, Dirk Behme wrote: > > On 05.07.2016 12:39, Mark Rutland wrote: > > >On Tue, Jul 05, 2016 at 08:50:23AM +0200, Dirk Behme wrote: > > >>+- clocks: one or more clocks to be registered. > > >>+ Xen hypervis

[Xen-devel] [ovmf test] 96719: regressions - FAIL

2016-07-06 Thread osstest service owner
flight 96719 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/96719/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 17 guest-start/debianhvm.repeat fail REGR. vs. 94748 test-amd64-i386-

Re: [Xen-devel] [PATCH v8 4/6] arm/vm_event: get/set registers

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 3:12 PM, Julien Grall wrote: > > > On 06/07/2016 20:23, Tamas K Lengyel wrote: >> >> On Wed, Jul 6, 2016 at 1:43 AM, Jan Beulich wrote: >> >> On 05.07.16 at 20:37, wrote: +struct vm_event_regs_arm64 { +uint64_t x0; +uint64_t x1; +

[Xen-devel] [xen-unstable test] 96712: tolerable FAIL - PUSHED

2016-07-06 Thread osstest service owner
flight 96712 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/96712/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-i386-rumpuserxen6 xen-buildfail like 96611 build-amd64-rumpuserxen

Re: [Xen-devel] [PATCH v8 4/6] arm/vm_event: get/set registers

2016-07-06 Thread Julien Grall
On 06/07/2016 20:23, Tamas K Lengyel wrote: On Wed, Jul 6, 2016 at 1:43 AM, Jan Beulich wrote: On 05.07.16 at 20:37, wrote: +struct vm_event_regs_arm64 { +uint64_t x0; +uint64_t x1; +uint64_t x2; +uint64_t x3; +uint64_t x4; +uint64_t x5; +uint64_t x6; +uint64

Re: [Xen-devel] [PATCH v2] xen/arm: register clocks used by the hypervisor

2016-07-06 Thread Michael Turquette
Hi Julien, Quoting Julien Grall (2016-07-06 06:10:52) > On 06/07/16 02:34, Michael Turquette wrote: > > Hi! > > Hello Michael, > > > Quoting Dirk Behme (2016-06-30 03:32:32) > >> Some clocks might be used by the Xen hypervisor and not by the Linux > >> kernel. If these are not registered by the

[Xen-devel] [xen-unstable-smoke test] 96731: tolerable all pass - PUSHED

2016-07-06 Thread osstest service owner
flight 96731 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/96731/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH v8 4/6] arm/vm_event: get/set registers

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 1:43 AM, Jan Beulich wrote: On 05.07.16 at 20:37, wrote: >> +struct vm_event_regs_arm64 { >> +uint64_t x0; >> +uint64_t x1; >> +uint64_t x2; >> +uint64_t x3; >> +uint64_t x4; >> +uint64_t x5; >> +uint64_t x6; >> +uint64_t x7; >> +uin

Re: [Xen-devel] [PATCH v8 4/6] arm/vm_event: get/set registers

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 12:04 PM, Julien Grall wrote: > > > On 05/07/16 19:37, Tamas K Lengyel wrote: >> >> +void vm_event_fill_regs(vm_event_request_t *req) >> +{ >> +const struct cpu_user_regs *regs = guest_cpu_user_regs(); >> + >> +req->data.regs.arm.cpsr = regs->cpsr; >> +req->data.

Re: [Xen-devel] [PATCH v8 2/6] arm: filter SMC exceptions with failed condition checks

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 11:31 AM, Julien Grall wrote: > On 05/07/16 19:37, Tamas K Lengyel wrote: >> >> In AArch32 state, the ARMv8-A architecture permits, but does not require, >> this trap to apply to conditional SMC instructions that fail their >> condition >> code check, in the same way as with

Re: [Xen-devel] [PATCH 02/18] arm/altp2m: Add first altp2m HVMOP stubs.

2016-07-06 Thread Julien Grall
On 06/07/16 17:35, Tamas K Lengyel wrote: On Wed, Jul 6, 2016 at 10:29 AM, Julien Grall wrote: On 06/07/16 17:05, Tamas K Lengyel wrote: On Wed, Jul 6, 2016 at 9:54 AM, Julien Grall wrote: Taken aside the VMFUNC, it looks like insecure to expose a HVMOP to the guest which could modify

[Xen-devel] [PATCH v1] hvmloader, pci: Don't try to relocate memory if 64-bit BAR is bigger than 4GB

2016-07-06 Thread Konrad Rzeszutek Wilk
There is no point. We can try to balloon out the memory between hvm_info->low_mem_pgend to pci_mem_end and we will never be able have a hole big enough for 4GB MMIO. Instead just let it go above 4GB in the 64-bit zone. Note that prior to this patch the hvmloader would relocate as much memory as i

Re: [Xen-devel] [PATCH v4 0/4] arm64, xen: add xen_boot support into grup-mkconfig

2016-07-06 Thread Julien Grall
Hi Fu Wei, On 06/07/16 18:58, Fu Wei wrote: On 5 July 2016 at 18:48, Julien Grall wrote: Hi Fu Wei, What is the status of this series? IIRC the comments on this version were minor. Sorry, I missed the suggestion of docs, I have rebased them to latest upstream grub and posted v5 just now.

Re: [Xen-devel] [PATCH v8 4/6] arm/vm_event: get/set registers

2016-07-06 Thread Julien Grall
On 05/07/16 19:37, Tamas K Lengyel wrote: +void vm_event_fill_regs(vm_event_request_t *req) +{ +const struct cpu_user_regs *regs = guest_cpu_user_regs(); + +req->data.regs.arm.cpsr = regs->cpsr; +req->data.regs.arm.ttbr0 = READ_SYSREG64(TTBR0_EL1); +req->data.regs.arm.ttbr1 = RE

[Xen-devel] [qemu-mainline test] 96703: tolerable FAIL - PUSHED

2016-07-06 Thread osstest service owner
flight 96703 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/96703/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 6 xen-boot fail REGR. vs. 94856 test-amd64-amd64-xl-qemuu-wi

[Xen-devel] [PATCH v5 0/4] arm64, xen: add xen_boot support into grup-mkconfig

2016-07-06 Thread fu . wei
From: Fu Wei This patchset add xen_boot support into grup-mkconfig for generating xen boot entrances automatically Also update the docs/grub.texi for new xen_boot commands. This patchset has been tested on Foudation model with a bug fix: http://lists.gnu.org/archive/html/grub-devel/2016-02/msg0

Re: [Xen-devel] [PATCH v4 0/4] arm64, xen: add xen_boot support into grup-mkconfig

2016-07-06 Thread Fu Wei
Hi Julien, On 5 July 2016 at 18:48, Julien Grall wrote: > Hi Fu Wei, > > What is the status of this series? IIRC the comments on this version were > minor. Sorry, I missed the suggestion of docs, I have rebased them to latest upstream grub and posted v5 just now. Thanks for reminding me > > Re

[Xen-devel] [PATCH v5 1/4] i386, xen: Add xen_hypervisor and xen_module aliases for i386

2016-07-06 Thread fu . wei
From: Fu Wei Signed-off-by: Fu Wei --- grub-core/loader/i386/xen.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c index c4d9689..15b0727 100644 --- a/grub-core/loader/i386/xen.c +++ b/grub-core/loader/i386/xen.c @@ -689,6 +68

[Xen-devel] [PATCH v5 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-07-06 Thread fu . wei
From: Fu Wei delete: xen_linux, xen_initrd, xen_xsm add: xen_module This update bases on commit 0edd750e50698854068358ea53528100a9192902 Author: Vladimir Serbinenko Date: Fri Jan 22 10:18:47 2016 +0100 xen_boot: Remove obsolete module type distinctions. Also bases on the

[Xen-devel] [PATCH v5 3/4] * util/grub.d/20_linux_xen.in: Add xen_boot command support

2016-07-06 Thread fu . wei
From: Fu Wei This patch adds the support of xen_boot command: xen_hypervisor xen_module Also add a new "feature_xen_boot" to indicate this grub support xen_boot command. Signed-off-by: Fu Wei --- grub-core/normal/main.c | 2 +- util/grub.d/20_linux_xen.in | 13 ++--- 2 fi

[Xen-devel] [PATCH v5 2/4] arm64: add "--nounzip" option support in xen_module command

2016-07-06 Thread fu . wei
From: Fu Wei This patch adds "--nounzip" option support in order to be compatible with the module command of i386, then we can simplify grub-mkconfig support code. Signed-off-by: Fu Wei --- grub-core/loader/arm64/xen_boot.c | 17 + 1 file changed, 17 insertions(+) diff --git a

Re: [Xen-devel] [PATCH v8 4/6] arm/vm_event: get/set registers

2016-07-06 Thread Julien Grall
On 06/07/16 08:43, Jan Beulich wrote: On 05.07.16 at 20:37, wrote: +struct vm_event_regs_arm64 { +uint64_t x0; +uint64_t x1; +uint64_t x2; +uint64_t x3; +uint64_t x4; +uint64_t x5; +uint64_t x6; +uint64_t x7; +uint64_t x8; +uint64_t x9; +uint64_t x1

[Xen-devel] [PATCH] credi2-ratelimit: Implement rate limit for credit2 scheduler

2016-07-06 Thread Anshul Makkar anshul.makkar
From: Anshul Makkar Rate limit assures that a vcpu will execute for a minimum amount of time before being put at the back of a queue or being preempted by higher priority thread. It introduces a minimum amount of latency to enable a VM to batch its work and it also ensures that system is not spe

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 01:03 PM, Julien Grall wrote: > > > On 06/07/16 17:30, Boris Ostrovsky wrote: >> On 07/06/2016 12:04 PM, Julien Grall wrote: >>> Hi Boris, >>> >>> On 06/07/16 16:50, Boris Ostrovsky wrote: On 07/06/2016 07:05 AM, Julien Grall wrote: >> +static int populate_acpi_pages(struct x

Re: [Xen-devel] [PATCH 10/19] xen: credit2: rework load tracking logic

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:12 AM, Dario Faggioli wrote: > The existing load tracking code was hard to understad and > maintain, and not entirely consistent. This is due to a > number of reasons: > - code and comments were not in perfect sync, making it >difficult to figure out what the intent

Re: [Xen-devel] [PATCH v8 2/6] arm: filter SMC exceptions with failed condition checks

2016-07-06 Thread Julien Grall
On 05/07/16 19:37, Tamas K Lengyel wrote: In AArch32 state, the ARMv8-A architecture permits, but does not require, this trap to apply to conditional SMC instructions that fail their condition code check, in the same way as with traps on other conditional instructions. Please add a quote to the

Re: [Xen-devel] [PATCH] libxl/netbsd: check num_exec in hotplug function

2016-07-06 Thread Wei Liu
On Mon, Jul 04, 2016 at 01:13:42PM +0100, Wei Liu wrote: > This basically replicates the same logic in libxl_linux.c but with one > change -- only test num_exec == 0 in nic hotplug case because NetBSD let > QEMU call a script itself. Without this patch libxl will loop > indefinitely trying to execu

Re: [Xen-devel] [PATCH 4/6] libxl: debug output for args and env when invoking hotplug script

2016-07-06 Thread Wei Liu
On Mon, Jul 04, 2016 at 06:06:27PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 4/6] libxl: debug output for args and env when > invoking hotplug script"): > > > From 49714976c5fde3d08baa6f34295b3f7db6a81444 Mon Sep 17 00:00:00 2001 > > > From: Wei Liu > > > Date: Fri, 15 Apr 2016 12:5

Re: [Xen-devel] [PATCH 14/18] arm/altp2m: Add HVMOP_altp2m_set_mem_access.

2016-07-06 Thread Julien Grall
Hi, On 04/07/16 12:45, Sergej Proskurin wrote: --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -2085,6 +2085,159 @@ bool_t p2m_mem_access_check(paddr_t gpa, vaddr_t gla, const struct npfec npfec) [...] +static inline +int p2m_set_altp2m_mem_access(struct domain *d, struct p2m_domain *h

Re: [Xen-devel] [PATCH 14/18] arm/altp2m: Add HVMOP_altp2m_set_mem_access.

2016-07-06 Thread Sergej Proskurin
On 07/06/2016 06:12 PM, Tamas K Lengyel wrote: > On Wed, Jul 6, 2016 at 8:32 AM, Julien Grall wrote: >> >> On 05/07/16 22:55, Sergej Proskurin wrote: >>> Hello Julien, >>> >>> On 07/05/2016 02:49 PM, Julien Grall wrote: Hello Sergej, On 04/07/16 12:45, Sergej Proskurin wrote:

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Julien Grall
On 06/07/16 17:30, Boris Ostrovsky wrote: On 07/06/2016 12:04 PM, Julien Grall wrote: Hi Boris, On 06/07/16 16:50, Boris Ostrovsky wrote: On 07/06/2016 07:05 AM, Julien Grall wrote: +static int populate_acpi_pages(struct xc_dom_image *dom, + xen_pfn_t *extents,

Re: [Xen-devel] [PATCH 14/18] arm/altp2m: Add HVMOP_altp2m_set_mem_access.

2016-07-06 Thread Julien Grall
On 06/07/16 17:12, Tamas K Lengyel wrote: On Wed, Jul 6, 2016 at 8:32 AM, Julien Grall wrote: On 05/07/16 22:55, Sergej Proskurin wrote: Hello Julien, On 07/05/2016 02:49 PM, Julien Grall wrote: Hello Sergej, On 04/07/16 12:45, Sergej Proskurin wrote: +static inline +int p2m_set_alt

Re: [Xen-devel] [PATCH 09/19] xen: credit2: avoid calling __update_svc_load() multiple times on the same vcpu

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:12 AM, Dario Faggioli wrote: > by not resetting the variable that should guard against > that at the beginning of each step of the outer loop. > > Signed-off-by: Dario Faggioli Oops. :-/ Reviewed-by: George Dunlap And queued. ___

Re: [Xen-devel] [PATCH 08/19] xen: credit2: when tickling, check idle cpus first

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:12 AM, Dario Faggioli wrote: > If there are idle pCPUs, it's always better to try to > "ship" the new vCPU there, instead than letting it > preempting on a currently busy one. > > This commit also adds a cpumask_test_or_cycle() helper > function, to make it easier to cod

Re: [Xen-devel] [PATCH 02/18] arm/altp2m: Add first altp2m HVMOP stubs.

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 10:29 AM, Julien Grall wrote: > > > On 06/07/16 17:05, Tamas K Lengyel wrote: >> >> On Wed, Jul 6, 2016 at 9:54 AM, Julien Grall wrote: >>> >>> Taken aside the VMFUNC, it looks like insecure to expose a HVMOP to the >>> guest which could modify the memaccess attribute of a

Re: [Xen-devel] [PATCH v1 00/20] Make ACPI builder available to components other than hvmloader

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 12:04 PM, Roger Pau Monné wrote: > Hello, > > Thanks for the refresh! Do you have this series in some git tree I can pull > from? Sorry, forgot to include this in the message: git://oss.oracle.com/git/bostrovs/xen.git:acpi_v1 > > On Tue, Jul 05, 2016 at 03:04:59PM -0400, Boris O

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 12:04 PM, Julien Grall wrote: > Hi Boris, > > On 06/07/16 16:50, Boris Ostrovsky wrote: >> On 07/06/2016 07:05 AM, Julien Grall wrote: +static int populate_acpi_pages(struct xc_dom_image *dom, + xen_pfn_t *extents, +

Re: [Xen-devel] [PATCH 02/18] arm/altp2m: Add first altp2m HVMOP stubs.

2016-07-06 Thread Julien Grall
On 06/07/16 17:05, Tamas K Lengyel wrote: On Wed, Jul 6, 2016 at 9:54 AM, Julien Grall wrote: Taken aside the VMFUNC, it looks like insecure to expose a HVMOP to the guest which could modify the memaccess attribute of a region. I thought the whole purpose of VM introspection is to avoid trus

Re: [Xen-devel] [PATCH 07/19] xen: credit2: prevent load balancing to go mad if time goes backwards

2016-07-06 Thread George Dunlap
On Mon, Jun 20, 2016 at 9:02 AM, Jan Beulich wrote: On 18.06.16 at 01:12, wrote: >> This really should not happen, but: >> 1. it does happen! Investigation is ongoing here: >> http://lists.xen.org/archives/html/xen-devel/2016-06/msg00922.html >> 2. even when 1 will be fixed it makes se

Re: [Xen-devel] [PATCH v3 4/8] x86/vm_event/monitor/cr: check for vm-event subscriber on domctl

2016-07-06 Thread Corneliu ZUZU
On 7/6/2016 7:15 PM, Corneliu ZUZU wrote: On 7/6/2016 7:01 PM, Jan Beulich wrote: On 06.07.16 at 17:52, wrote: Also adjust returned error code for similar check from -EINVAL to more descriptive -ENOSYS (XEN_DOMCTL_MONITOR_OP_EMULATE_EACH_REP). I'm not sure that's more descriptive, and we real

Re: [Xen-devel] default XSM policy for PCI passthrough for unlabeled resources.

2016-07-06 Thread anshul makkar
On 06/07/16 16:59, Daniel De Graaf wrote: On 07/06/2016 11:34 AM, anshul makkar wrote: Hi, It allows the resource to be added and removed by the source domain to target domain, but its use by target domain is blocked. This rule only mandates the use of resource_type for resource types. If y

Re: [Xen-devel] [PATCH v3 4/8] x86/vm_event/monitor/cr: check for vm-event subscriber on domctl

2016-07-06 Thread Corneliu ZUZU
On 7/6/2016 7:01 PM, Jan Beulich wrote: On 06.07.16 at 17:52, wrote: Also adjust returned error code for similar check from -EINVAL to more descriptive -ENOSYS (XEN_DOMCTL_MONITOR_OP_EMULATE_EACH_REP). I'm not sure that's more descriptive, and we really try to not use ENOSYS for other than uni

Re: [Xen-devel] [PATCH 06/19] xen: credit2: read NOW() with the proper runq lock held

2016-07-06 Thread George Dunlap
On Mon, Jun 20, 2016 at 8:56 AM, Jan Beulich wrote: On 18.06.16 at 01:12, wrote: >> Yet another situation very similar to 779511f4bf5ae >> ("sched: avoid races on time values read from NOW()"). >> >> In fact, when more than one runqueue is involved, we need >> to make sure that the following

Re: [Xen-devel] [PATCH 14/18] arm/altp2m: Add HVMOP_altp2m_set_mem_access.

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 8:32 AM, Julien Grall wrote: > > > On 05/07/16 22:55, Sergej Proskurin wrote: >> >> Hello Julien, >> >> On 07/05/2016 02:49 PM, Julien Grall wrote: >>> >>> Hello Sergej, >>> >>> On 04/07/16 12:45, Sergej Proskurin wrote: +static inline +int p2m_set_altp2m_mem_

Re: [Xen-devel] [PATCH 0/3] libxl: add framework for device types

2016-07-06 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH 0/3] libxl: add framework for device types"): > On 06/07/16 14:47, Ian Jackson wrote: > > Juergen Gross writes ("Re: [PATCH 0/3] libxl: add framework for device > > types"): > >> On 06/07/16 13:04, Ian Jackson wrote: > +for (i = 0; i < d_config->num_pcide

Re: [Xen-devel] [PATCH 05/19] xen: credit2: do not warn if calling burn_credits more than once

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli wrote: > on the same vcpu, without NOW() having changed. > > This is, in fact, a legitimate use case. If it happens, > we should just do nothing, without producing any warning > or debug message. > > While there, fix style and add a couple of branch

Re: [Xen-devel] [PATCH 02/18] arm/altp2m: Add first altp2m HVMOP stubs.

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 9:54 AM, Julien Grall wrote: > (Add x86 maintainers) > > > On 06/07/16 16:23, Tamas K Lengyel wrote: >> >> On Wed, Jul 6, 2016 at 7:43 AM, Julien Grall wrote: >>> >>> Hello Sergej, >>> >>> >>> On 06/07/16 10:14, Sergej Proskurin wrote: On 07/05/2016 12:19 PM,

Re: [Xen-devel] [PATCH 04/19] xen: credit2: kill useless helper function choose_cpu

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli wrote: > In fact, it has the same signature of csched2_cpu_pick, > which also is its uniqe caller. > > Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap And queued, fixing up the spelling of "unique".

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Julien Grall
Hi Boris, On 06/07/16 16:50, Boris Ostrovsky wrote: On 07/06/2016 07:05 AM, Julien Grall wrote: +static int populate_acpi_pages(struct xc_dom_image *dom, + xen_pfn_t *extents, + unsigned int num_pages, + s

Re: [Xen-devel] [PATCH v1 00/20] Make ACPI builder available to components other than hvmloader

2016-07-06 Thread Roger Pau Monné
Hello, Thanks for the refresh! Do you have this series in some git tree I can pull from? On Tue, Jul 05, 2016 at 03:04:59PM -0400, Boris Ostrovsky wrote: > This is V1 of the series posted earlier as an RFC > > The goal here is to build ACPI tables for PVHv2/HVMlite guests while reusing > exist

Re: [Xen-devel] [PATCH v3 4/8] x86/vm_event/monitor/cr: check for vm-event subscriber on domctl

2016-07-06 Thread Jan Beulich
>>> On 06.07.16 at 17:52, wrote: > Also adjust returned error code for similar check from -EINVAL to more > descriptive -ENOSYS (XEN_DOMCTL_MONITOR_OP_EMULATE_EACH_REP). I'm not sure that's more descriptive, and we really try to not use ENOSYS for other than unimplemented hypercalls. EOPNOTSUPP p

Re: [Xen-devel] [PATCH 03/19] xen: credit2: insert and tickle don't need a cpu parameter

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli wrote: > In fact, they always operate on the svc->processor of > the csched2_vcpu passed to them. > > No functional change intended. > > Signed-off-by: Dario Faggioli Acked-by: George Dunlap And queued this one and patch 2. Good to see those fi

Re: [Xen-devel] default XSM policy for PCI passthrough for unlabeled resources.

2016-07-06 Thread Daniel De Graaf
On 07/06/2016 11:34 AM, anshul makkar wrote: Hi, Default XSM policy doesn't allow the use of unlabeled PCI resources that have been passed through to target domain. xen.te # Resources must be declared using . resource_type neverallow * ~resource_type:resource use; It allows the resource to be

[Xen-devel] [PATCH v3 8/8] minor #include change

2016-07-06 Thread Corneliu ZUZU
Move xen/paging.h #include from hvm/monitor.h to hvm/monitor.c (include strictly where needed) and also change to asm/paging.h (include strictly what's needed). Signed-off-by: Corneliu ZUZU Acked-by: Tamas K Lengyel Acked-by: Razvan Cojocaru --- Changed since v2: --- xen/arch/x86/hvm/monitor.

[Xen-devel] [PATCH v3 7/8] minor fixes (formatting, comments, unused includes etc.)

2016-07-06 Thread Corneliu ZUZU
Minor fixes: - remove some empty lines - remove some unused includes - multi-line comment fixes - 80-columns formatting fixes Signed-off-by: Corneliu ZUZU Acked-by: Razvan Cojocaru Acked-by: Julien Grall --- Changed since v2: --- xen/arch/arm/domain.c | 1 - xen/arch/arm/trap

[Xen-devel] [PATCH v3 6/8] x86/vm-event: minor ASSERT fix, add 'unlikely'

2016-07-06 Thread Corneliu ZUZU
Minor fixes: * vm_event_register_write_resume: ASSERT on non-NULL v->arch.vm_event instead of &v->arch.vm_event->write_data. * add 'unlikely' in if Signed-off-by: Corneliu ZUZU --- Changed since v2: --- xen/arch/x86/hvm/hvm.c | 2 +- xen/arch/x86/vm_event.c | 6 -- 2 files changed, 5 in

Re: [Xen-devel] [PATCH 02/18] arm/altp2m: Add first altp2m HVMOP stubs.

2016-07-06 Thread Julien Grall
(Add x86 maintainers) On 06/07/16 16:23, Tamas K Lengyel wrote: On Wed, Jul 6, 2016 at 7:43 AM, Julien Grall wrote: Hello Sergej, On 06/07/16 10:14, Sergej Proskurin wrote: On 07/05/2016 12:19 PM, Julien Grall wrote: Hello Sergej, On 04/07/16 12:45, Sergej Proskurin wrote: +static int

[Xen-devel] [PATCH v3 5/8] x86/vm_event_resume: surround VM_EVENT_REASON_MOV_TO_MSR w/ CONFIG_X86

2016-07-06 Thread Corneliu ZUZU
VM_EVENT_REASON_MOV_TO_MSR is X86-specific, surround w/ #ifdef accordingly. Signed-off-by: Corneliu ZUZU Acked-by: Razvan Cojocaru --- Changed since v2: --- xen/common/vm_event.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c index 47ae96c..

[Xen-devel] [PATCH v3 4/8] x86/vm_event/monitor/cr: check for vm-event subscriber on domctl

2016-07-06 Thread Corneliu ZUZU
Enforce presence of a monitor vm-event subscriber when the toolstack user calls xc_monitor_write_ctrlreg (XEN_DOMCTL_MONITOR_EVENT_WRITE_CTRLREG domctl). Without this change, ASSERT(v->arch.vm_event) @ hvm_set_cr0 and such would fail if the toolstack user calls xc_monitor_write_ctrlreg(...) w/ enab

[Xen-devel] [PATCH v3 3/8] x86/vm-event/monitor: don't compromise monitor_write_data on domain cleanup

2016-07-06 Thread Corneliu ZUZU
The arch_vm_event structure is dynamically allocated and freed @ vm_event_cleanup_domain. This cleanup is triggered e.g. when the toolstack user disables domain monitoring (xc_monitor_disable), which in turn effectively discards any information that was in arch_vm_event.write_data. But this can yi

Re: [Xen-devel] [PATCH 02/19] xen: sched: make the 'tickled' perf counter clearer

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli wrote: > In fact, what we have right now, i.e., tickle_idlers_none > and tickle_idlers_some, is not good enough for describing > what really happens in the various tickling functions of > the various scheduler. > > Switch to a more descriptive set o

[Xen-devel] [PATCH v3 2/8] x86/vm-event/monitor: relocate code-motion more appropriately

2016-07-06 Thread Corneliu ZUZU
For readability: * Add function arch_monitor_write_data (in x86/monitor.c) and separate handling of monitor_write_data there (previously done directly in hvm_do_resume). * Separate enabling/disabling of CPU_BASED_CR3_LOAD_EXITING for CR3 monitor vm-events from CR0 node @ vmx_update_guest_cr(v, 0)

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 07:05 AM, Julien Grall wrote: > (CC Stefano) > > Hi Boris, > > On 05/07/16 20:05, Boris Ostrovsky wrote: >> diff --git a/tools/libxl/libxl_arch.h b/tools/libxl/libxl_arch.h >> index 34a853c..7c6536b 100644 >> --- a/tools/libxl/libxl_arch.h >> +++ b/tools/libxl/libxl_arch.h >> @@ -62,4

[Xen-devel] [PATCH v3 1/8] x86/vmx_update_guest_cr: minor optimization

2016-07-06 Thread Corneliu ZUZU
Minor optimization @ vmx_update_guest_cr: checks if v->arch.hvm_vmx.exec_control was modified before actually calling vmx_update_cpu_exec_control(v). Signed-off-by: Corneliu ZUZU --- Changed since v2: --- xen/arch/x86/hvm/vmx/vmx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [Xen-devel] [PATCH v3 1/2] Interface for grant copy operation in libs.

2016-07-06 Thread Roger Pau Monné
On Wed, Jun 22, 2016 at 05:49:59PM +0100, Wei Liu wrote: > On Wed, Jun 22, 2016 at 03:52:43PM +0100, Wei Liu wrote: > > On Wed, Jun 22, 2016 at 02:52:47PM +0100, David Vrabel wrote: > > > On 22/06/16 14:29, Wei Liu wrote: > > > > On Wed, Jun 22, 2016 at 01:37:50PM +0100, David Vrabel wrote: > > > >

[Xen-devel] [PATCH v3 0/8] x86/vm-event: Adjustments & fixes

2016-07-06 Thread Corneliu ZUZU
This patch-series makes some adjustments and fixes to the X86 vm-events code. Summary: Corneliu ZUZU (8): 1. x86/vmx_update_guest_cr: minor optimization 2. x86/vm-event/monitor: relocate code-motion more appropriately 3. x86/vm-event/monitor: don't compromise monitor_write_data on domain

Re: [Xen-devel] [PATCH v1 18/20] libxl/acpi: Add ACPI e820 entry

2016-07-06 Thread Boris Ostrovsky
On 07/06/2016 06:00 AM, Julien Grall wrote: > (CC Stefano) > > Hi Boris, > > On 05/07/16 20:05, Boris Ostrovsky wrote: >> Add entry for ACPI tables created for PVHv2 guests to e820 map. >> >> Signed-off-by: Boris Ostrovsky >> --- >> >> New patch >> >> tools/libxc/include/xc_dom.h |4 >>

Re: [Xen-devel] [PATCH 01/19] xen: sched: leave CPUs doing tasklet work alone.

2016-07-06 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli wrote: > In both Credit1 and Credit2, stop considering a pCPU idle, > if the reason why the idle vCPU is being selected, is to > do tasklet work. > > Not doing so means that the tickling and load balancing > logic, seeing the pCPU as idle, considers

Re: [Xen-devel] [PATCH v5 10/17] xen/arm: map_regions_rw_cache: Map the region with p2m->default_access

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 5:10 AM, Julien Grall wrote: > (CC Tamas) > > On 06/07/16 11:43, Stefano Stabellini wrote: >> >> On Tue, 28 Jun 2016, Julien Grall wrote: >>> >>> The parameter 'access' is used by memaccess to restrict temporarily the >>> permission. This parameter should not be used for oth

[Xen-devel] default XSM policy for PCI passthrough for unlabeled resources.

2016-07-06 Thread anshul makkar
Hi, Default XSM policy doesn't allow the use of unlabeled PCI resources that have been passed through to target domain. xen.te # Resources must be declared using . resource_type neverallow * ~resource_type:resource use; It allows the resource to be added and removed by the source domain to

[Xen-devel] [OSSTEST PATCH 1/8] Tcl: Use tclsh8.5

2016-07-06 Thread Ian Jackson
I have checked that tclsh8.5 and TclX work on osstest.test-lab (and also osstest.xs.citrite.net). TclX seems to be provided by tcl8.4 but work with tcl8.5 (at least on wheezy and jessie). Signed-off-by: Ian Jackson CC: Wei Liu --- README| 2 +- ms-ownerdaemon| 2 +- ms-queuedae

[Xen-devel] [OSSTEST PATCH 5/8] ts-hosts-allocate-Executive: Replace some odd commas with semicolons

2016-07-06 Thread Ian Jackson
There does not seem to be any reason for this. I think it must be a leftover from a previous use of { A => X, B => Y, ... } syntax. Signed-off-by: Ian Jackson CC: Wei Liu --- ts-hosts-allocate-Executive | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ts-hosts-allocate-E

[Xen-devel] [OSSTEST PATCH 2/8] ms-flights-summary: Remove spurious \ in keys \%{ something }

2016-07-06 Thread Ian Jackson
With some versions of Perl this generates a warning which causes ms-flights-summary to fail. Signed-off-by: Ian Jackson CC: Wei Liu --- ms-flights-summary | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ms-flights-summary b/ms-flights-summary index ea72088..c703d81 100755 --

[Xen-devel] [OSSTEST PATCH 3/8] mg-schema-test-database: Direct logs to local directory

2016-07-06 Thread Ian Jackson
Do not pollute a shared log area with logs of flights whose numbers are valid only in the context of our test database. Signed-off-by: Ian Jackson CC: Wei Liu --- mg-schema-test-database | 8 1 file changed, 8 insertions(+) diff --git a/mg-schema-test-database b/mg-schema-test-databas

[Xen-devel] [OSSTEST PATCH 4/8] ms-planner: Support ClientNotes

2016-07-06 Thread Ian Jackson
No users yet. Signed-off-by: Ian Jackson CC: Wei Liu --- README.planner | 22 ++ ms-planner | 23 +++ 2 files changed, 45 insertions(+) diff --git a/README.planner b/README.planner index daccef5..80c2506 100644 --- a/README.planner +++ b/README.plann

[Xen-devel] [OSSTEST PATCH 8/8] DO NOT APPLY make-flight-diverse-test: test case for diverse-CLASS hostflag

2016-07-06 Thread Ian Jackson
This generates a flight with two jobs, test-1 and test-2. They can be run, and are supposed to allocate different hosts, and will bomb out after host allocation. Signed-off-by: Ian Jackson CC: Wei Liu --- make-flight-diverse-test | 11 +++ 1 file changed, 11 insertions(+) create mode

[Xen-devel] [OSSTEST PATCH 0/8] Support diverse-CLASS hostflag

2016-07-06 Thread Ian Jackson
Here is a quick series for osstest which provides support for a new kind of hostflag diverse-CLASS. The host allocator will not consider any host for such an allocation, which has been allocated for any other such allocation (with the same CLASS) in the same flight. This is going to be useful bec

[Xen-devel] [OSSTEST PATCH 7/8] ts-hosts-allocate-Executive: Support diverse-CLASS hostflag

2016-07-06 Thread Ian Jackson
Specifically: * Parse it out of the hostflags when constructing the hid * Look for the `hostalloc-diverse-FLIGHT-CLASS' ClientNote in the resource plan, to avoid inappropriately planning to reuse hosts. * Look for the `diversehosts_CLASS' runvar in other jobs in this flight, to find out wh

[Xen-devel] [OSSTEST PATCH 6/8] ts-hosts-allocate-Executive: pass $plan to hid_find_possibilities

2016-07-06 Thread Ian Jackson
We are going to want this to implement the new diverse-CLASS hostflag. Signed-off-by: Ian Jackson CC: Wei Liu --- ts-hosts-allocate-Executive | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive index 69f1cf6..d4a96d

Re: [Xen-devel] [PATCH 02/18] arm/altp2m: Add first altp2m HVMOP stubs.

2016-07-06 Thread Tamas K Lengyel
On Wed, Jul 6, 2016 at 7:43 AM, Julien Grall wrote: > Hello Sergej, > > > On 06/07/16 10:14, Sergej Proskurin wrote: >> >> On 07/05/2016 12:19 PM, Julien Grall wrote: >>> >>> Hello Sergej, >>> >>> On 04/07/16 12:45, Sergej Proskurin wrote: +static int do_altp2m_op(XEN_GUEST_HANDLE_PARAM(

[Xen-devel] [linux-3.18 baseline-only test] 66492: trouble: blocked/broken/fail/pass

2016-07-06 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 66492 linux-3.18 real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66492/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen

[Xen-devel] [PATCH v2 0/4] libxl: add framework for device types

2016-07-06 Thread Juergen Gross
Instead of duplicate coding for each device type (vtpms, usbctrls, ...) especially on domain creation introduce a framework for that purpose. I especially found it annoying that e.g. the vtpm callback issued the error message for a failed attach of nic devices. Changes in V2: - added new patch 4

[Xen-devel] [PATCH v2 4/4] libxl: move DEFINE_DEVICE* macros to libxl_internal.h

2016-07-06 Thread Juergen Gross
In order to be able to have all functions related to a device type in a single source file move the macros used to generate device type specific functions to libxl_internal.h. Rename the macros as they are no longer local to a source file. While at it hide device remove and device destroy in one ma

[Xen-devel] [PATCH v2 2/4] libxl: refactor domcreate_attach_pci() to use device type framework

2016-07-06 Thread Juergen Gross
Signed-off-by: Juergen Gross --- tools/libxl/libxl_create.c | 54 ++-- tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_pci.c | 32 ++ 3 files changed, 40 insertions(+), 47 deletions(-) diff --git a/tools/libxl/libxl_cr

[Xen-devel] [PATCH v2 1/4] libxl: add framework for device types

2016-07-06 Thread Juergen Gross
Instead of duplicate coding for each device type (vtpms, usbctrls, ...) especially on domain creation introduce a framework for that purpose. Signed-off-by: Juergen Gross --- V2: - add macro to fill struct libxl__device_type as suggested by Ian Jackson - make struct libxl__device_type v

[Xen-devel] [PATCH v2 3/4] libxl: refactor domcreate_attach_dtdev() to use device type framework

2016-07-06 Thread Juergen Gross
Signed-off-by: Juergen Gross --- tools/libxl/libxl_create.c | 68 +- 1 file changed, 31 insertions(+), 37 deletions(-) diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 354c73f..828f254 100644 --- a/tools/libxl/libxl_create.c +

Re: [Xen-devel] [PATCH v1 01/20] hvmloader: Provide hvmloader_acpi_build_tables()

2016-07-06 Thread Konrad Rzeszutek Wilk
On Tue, Jul 05, 2016 at 03:05:00PM -0400, Boris Ostrovsky wrote: > In preparation for moving out ACPI builder make all > BIOSes call hvmloader_acpi_build_tables() instead of > calling ACPI code directly. > > No functional changes. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek

Re: [Xen-devel] [PATCH 11/18] arm/altp2m: Make flush_tlb_domain ready for altp2m.

2016-07-06 Thread Sergej Proskurin
Hi Julien, On 07/06/2016 04:28 PM, Julien Grall wrote: > > > On 05/07/16 21:21, Sergej Proskurin wrote: >> I agree on this point as well. However, we should maybe think of another >> name for flush_tlb_domain. Especially, if we do not flush the entire >> domain (including all currently active alt

Re: [Xen-devel] [PATCH 14/18] arm/altp2m: Add HVMOP_altp2m_set_mem_access.

2016-07-06 Thread Julien Grall
On 05/07/16 22:55, Sergej Proskurin wrote: Hello Julien, On 07/05/2016 02:49 PM, Julien Grall wrote: Hello Sergej, On 04/07/16 12:45, Sergej Proskurin wrote: +static inline +int p2m_set_altp2m_mem_access(struct domain *d, struct p2m_domain *hp2m, + struct p2m_do

Re: [Xen-devel] [PATCH 11/18] arm/altp2m: Make flush_tlb_domain ready for altp2m.

2016-07-06 Thread Julien Grall
On 05/07/16 21:21, Sergej Proskurin wrote: I agree on this point as well. However, we should maybe think of another name for flush_tlb_domain. Especially, if we do not flush the entire domain (including all currently active altp2m views). What do you think? This function is only used within p

Re: [Xen-devel] [PATCH 15/18] arm/altp2m: Add altp2m paging mechanism.

2016-07-06 Thread Julien Grall
On 06/07/16 09:33, Sergej Proskurin wrote: On 07/04/2016 10:53 PM, Julien Grall wrote: Can we introduce a function which return the xma, mfn, order, attribute at once? It will avoid to browse the p2m 3 times which is really expensive on ARMv7 because the p2m is not mapped in the virtual addres

Re: [Xen-devel] Kernel panic on Xen virtualisation in Debian

2016-07-06 Thread George Dunlap
On Mon, Jul 4, 2016 at 7:06 PM, Jan Prunk wrote: > Hello ! > > I am posting Xen virtualisation bug links to this e-mail address, > because I wasn't able to find the Xen specific bugtracker list. > This bug has been discovered in 2015 and so far it hasn't been > resolved through the Debian/Kernel b

Re: [Xen-devel] xenbits "official" repo for XTF (was Re: [PATCH 0/2] xtf: add launcher (+1 bugfix)

2016-07-06 Thread Konrad Rzeszutek Wilk
> Looking at the above, it occurs to me that, this whole area seems to be a > little inconsistent anyway and could do with a little house-keeping. We > have > - osstest.git > - there also is osstest/*.git which seems to be odd and seems to have been > inactive for a while (not very clear to me what

Re: [Xen-devel] [PATCH v2] xen: arm64: Add support for Renesas RCar Gen3 H3 Salvator-X platform

2016-07-06 Thread Julien Grall
On 06/07/16 15:03, Dirk Behme wrote: On 06.07.2016 15:17, Julien Grall wrote: Hi Dirk, On 06/07/16 07:33, Dirk Behme wrote: Could you share the U-Boot commands how you load and esp. start Xen? For loading you use TFTP? How do you start Xen with U-Boot, then? I think we have to pass the devic

Re: [Xen-devel] [PATCH v2] xen: arm64: Add support for Renesas RCar Gen3 H3 Salvator-X platform

2016-07-06 Thread Dirk Behme
On 06.07.2016 15:17, Julien Grall wrote: Hi Dirk, On 06/07/16 07:33, Dirk Behme wrote: Could you share the U-Boot commands how you load and esp. start Xen? For loading you use TFTP? How do you start Xen with U-Boot, then? I think we have to pass the device tree address in x0 and the Linux kerne

Re: [Xen-devel] xenstored memory leak

2016-07-06 Thread Andrew Cooper
On 06/07/16 14:55, Juergen Gross wrote: > On 06/07/16 15:48, Andrew Cooper wrote: >> On 06/07/16 08:31, Juergen Gross wrote: >>> While testing some patches for support of ballooning in Mini-OS by using >>> the xenstore domain I realized that each xl create/destroy pair would >>> increase memory con

Re: [Xen-devel] xenstored memory leak

2016-07-06 Thread Juergen Gross
On 06/07/16 15:48, Andrew Cooper wrote: > On 06/07/16 08:31, Juergen Gross wrote: >> While testing some patches for support of ballooning in Mini-OS by using >> the xenstore domain I realized that each xl create/destroy pair would >> increase memory consumption in Mini-OS by about 5kB. Wondering wh

  1   2   >