Re: [Xen-devel] [PATCH 7/7] arch.monitor: move bits to common (arch_domain to domain)

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 8:29 PM, Tamas K Lengyel wrote: On Mon, Feb 8, 2016 at 9:58 AM, Corneliu ZUZU > wrote: This patch moves bitfield members for single-step, software-breakpoint and guest-request monitor vm-events from the arch-side (struct arch_domain) t

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Luis R. Rodriguez
On Mon, Feb 08, 2016 at 10:31:36AM -0500, Boris Ostrovsky wrote: > > > On 02/06/2016 03:05 PM, Andy Lutomirski wrote: > > > >Anyway, this is all ridiculous. I propose that rather than trying to > >clean up paravirt_enabled, you just delete it. Here are its users: > > > >static inline bool is_hy

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Luis R. Rodriguez
On Mon, Feb 08, 2016 at 04:46:08PM +0100, Borislav Petkov wrote: > On Mon, Feb 08, 2016 at 10:31:36AM -0500, Boris Ostrovsky wrote: > > This range is reserved for hypervisors but the only hypervisor that uses it > > is Xen PV (lguest doesn't run in 64-bit mode). > > Yeah, this is mentioned in arch

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Luis R. Rodriguez
On Sat, Feb 06, 2016 at 12:05:32PM -0800, Andy Lutomirski wrote: > On Sat, Feb 6, 2016 at 12:59 AM, Luis R. Rodriguez wrote: > > On Fri, Feb 05, 2016 at 11:11:34PM -0800, Andy Lutomirski wrote: > >> On Feb 5, 2016 8:30 PM, "Luis R. Rodriguez" wrote: > >> > > >> > paravirt_enabled conveys the idea

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Luis R. Rodriguez
On Mon, Feb 08, 2016 at 04:53:00PM +, Andrew Cooper wrote: > On 08/02/16 16:45, Borislav Petkov wrote: > > On Mon, Feb 08, 2016 at 04:38:40PM +, Andrew Cooper wrote: > >> Does the early loader have extable support? If so, this is fairly easy > >> to fix. If not, we have a problem. > > It

[Xen-devel] [PATCH v2 1/1] XEN/ARM: Add Odroid-XU3/XU4 support

2016-02-08 Thread Suriyan Ramasami
The Odroid-XU3/XU4 from hardkernel is an Exynos 5422 based board. Code from mcpm-exynos.c and mcpm-platsmp.c from the Linux kernel has been used to get all the 8 cores from the 2 clusters powered on. The Linux DTS for these odroid uses "samsung,exynos5800" as the machine compatible string. Hence, t

Re: [Xen-devel] [PATCH v4 16/17] FDT: Add a helper to get specified name subnode

2016-02-08 Thread Rob Herring
On Thu, Feb 4, 2016 at 9:05 PM, Shannon Zhao wrote: > From: Shannon Zhao > > Sometimes it needs to check if there is a node in FDT by full path. I'm confused. Are you searching by full path or... > Introduce this helper to get the specified name subnode if it exists. name of sub node? Either

Re: [Xen-devel] [BUG] pci-passthrough generates "xen:events: Failed to obtain physical IRQ" for some devices

2016-02-08 Thread Konrad Rzeszutek Wilk
On Mon, Feb 08, 2016 at 06:39:17PM +0100, Marek Marczykowski-Górecki wrote: > On Wed, Feb 03, 2016 at 10:26:58AM -0500, Konrad Rzeszutek Wilk wrote: > > On Wed, Feb 03, 2016 at 03:22:30PM +0100, Marek Marczykowski-Górecki wrote: > > > On Mon, Feb 01, 2016 at 09:50:53AM -0500, Konrad Rzeszutek Wilk

[Xen-devel] [PATCH v5][RFC]xen: sched: convert RTDS from time to event driven model

2016-02-08 Thread Tianyang Chen
Changes since v4: removed unnecessary replenishment queue checks in vcpu_wake() extended replq_remove() to all cases in vcpu_sleep() used _deadline_queue_insert() helper function for both queues _replq_insert() and _replq_remove() program timer internally Changes since v3: remo

[Xen-devel] [PATCH v2 1/2] xenoprof: fix up ability to disable it

2016-02-08 Thread Doug Goldstein
Allow Xenoprof to be fully disabled when toggling the option off. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Boris Ostrovsky CC: Suravee Suthikulpanit CC: Aravind Gopalakrishnan CC: Jun Nakajima CC: Kevin Tian Signed-off-by: Doug Goldstein --- change since v1: - switch to #defi

[Xen-devel] [PATCH v2 2/2] build: convert xenoprof to Kconfig

2016-02-08 Thread Doug Goldstein
Convert the xenoprof x86 build time option to Kconfig. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Reviewed-by: Andrew Cooper Signed-off-by: Doug Goldstein --- change since v1: - fix name of Kconfig entry as suggested by Andrew Cooper --- xen/arch/x86/Makefile | 2 +- xen/arch/x86/Rul

Re: [Xen-devel] [PATCH 1/2] xenoprof: fix up ability to disable it

2016-02-08 Thread Doug Goldstein
On 2/8/16 10:24 AM, Boris Ostrovsky wrote: > > > On 02/08/2016 11:04 AM, Doug Goldstein wrote: >> Allow Xenoprof to be fully disabled when toggling the option off. >> >> CC: Keir Fraser >> CC: Jan Beulich >> CC: Andrew Cooper >> CC: Boris Ostrovsky >> CC: Suravee Suthikulpanit >> CC: Aravind

Re: [Xen-devel] [PATCH 1/2] xenoprof: fix up ability to disable it

2016-02-08 Thread Doug Goldstein
On 2/8/16 10:24 AM, Boris Ostrovsky wrote: > > > On 02/08/2016 11:04 AM, Doug Goldstein wrote: >> Allow Xenoprof to be fully disabled when toggling the option off. >> >> CC: Keir Fraser >> CC: Jan Beulich >> CC: Andrew Cooper >> CC: Boris Ostrovsky >> CC: Suravee Suthikulpanit >> CC: Aravind

Re: [Xen-devel] [RFC] support more qdisk types

2016-02-08 Thread Jim Fehlig
On 02/03/2016 07:53 PM, Jim Fehlig wrote: > On 02/03/2016 02:56 AM, Ian Campbell wrote: >> On Tue, 2016-02-02 at 15:06 -0700, Jim Fehlig wrote: And extending the structure seems to be the right thing to do. >>> So what do you think of the approach in the RFC patch? It adds discrete >>> k

Re: [Xen-devel] [PATCH v5 for Xen 4.7 3/4] libxl: enable per-VCPU parameter settings for RTDS scheduler

2016-02-08 Thread Chong Li
On Mon, Feb 8, 2016 at 5:07 AM, Wei Liu wrote: > > > [...] > > >> +num_vcpus = max_vcpuid + 1; > > >> +GCNEW_ARRAY(vcpus, num_vcpus); > > >> +if (sched_rtds_validate_params(gc, scinfo->vcpus[0].period, > > >> + scinfo->vcpus[0].budget, > > >

Re: [Xen-devel] Adding Xen to the kbuild bot?

2016-02-08 Thread Andy Lutomirski
On Mon, Feb 8, 2016 at 7:24 AM, Doug Goldstein wrote: > On 2/5/16 2:10 PM, Andy Lutomirski wrote: >> On Feb 4, 2016 7:11 PM, "Fengguang Wu" wrote: >>> >>> Hi Andy, >>> >>> CC more people on Xen testing -- in case OSStest already (or plans to) >>> cover such test case. >>> >>> On Tue, Feb 02, 2016

Re: [Xen-devel] [PATCH v4 01/17] Xen: ACPI: Hide UART used by Xen

2016-02-08 Thread Rafael J. Wysocki
On Monday, February 08, 2016 10:57:01 AM Stefano Stabellini wrote: > On Sat, 6 Feb 2016, Rafael J. Wysocki wrote: > > On Fri, Feb 5, 2016 at 4:05 AM, Shannon Zhao > > wrote: > > > From: Shannon Zhao > > > > > > ACPI 6.0 introduces a new table STAO to list the devices which are used > > > by Xen

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/06/2016 03:59 AM, Luis R. Rodriguez wrote: The enumeration of legacy crap by ACPI boot flags seems to provide enough details to suit our needs if we really wanted to zero down on the specifics of what paravirt_legacy() means, there are these flags: /* Masks for FADT IA-PC Boot Architectu

Re: [Xen-devel] [BUG} libxl.c:5947:libxl_send_trigger: Send trigger 'reset' failed: Function not implemented

2016-02-08 Thread Alex Braunegg
Hi Ian, Any update in looking at this issue? Best regards, Alex -Original Message- From: Alex Braunegg [mailto:alex.braun...@gmail.com] Sent: Friday, 5 February 2016 10:09 AM To: 'Ian Campbell'; 'xen-devel@lists.xen.org' Subject: RE: [Xen-devel] [BUG} libxl.c:5947:libxl_send_trigger: S

Re: [Xen-devel] [BUG] libxl: error: libxl_device.c:301:libxl__device_disk_set_backend: no suitable backend for disk

2016-02-08 Thread Alex Braunegg
Hi Ian, Any update in looking at this issue? Best regards, Alex -Original Message- From: Alex Braunegg [mailto:alex.braun...@gmail.com] Sent: Friday, 5 February 2016 6:19 AM To: 'Ian Campbell'; 'xen-devel@lists.xen.org' Subject: RE: [Xen-devel] [BUG] libxl: error: libxl_device.c:301:l

Re: [Xen-devel] HVMlite ABI specification DRAFT B + implementation outline

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 02:03 PM, Roger Pau Monné wrote: * PCI BARs: it's not possible for Xen to know the position of the BARs of the PCI devices without hardware domain interaction. In order to have the BARs of PCI devices properly mapped the hardware domain needs to call the PHYSDEVOP_p

Re: [Xen-devel] [PATCH v4] xen: sched: convert RTDS from time to event driven model

2016-02-08 Thread Dario Faggioli
On Mon, 2016-02-08 at 14:04 -0500, Tianyang Chen wrote: > > On 2/8/2016 6:27 AM, Dario Faggioli wrote: > >  > > I don't really follow, but I have the feeling that you're making it > > sound more complicated like it is in reality... :-) > > > > So my reasoning is that, when sleep() is called in s

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Borislav Petkov
On Mon, Feb 08, 2016 at 03:45:21PM -0500, Boris Ostrovsky wrote: > So it looks like we can just simply revert a18a0f6850 because the very next > patch to microcode code (fbae4ba8c4a) makes the original problem (of using > __pa_nodebug, which we shouldn't use on PV) go away: we don't call > load_uco

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Andy Lutomirski
On Mon, Feb 8, 2016 at 7:31 AM, Boris Ostrovsky wrote: > > > On 02/06/2016 03:05 PM, Andy Lutomirski wrote: >> >> >> Anyway, this is all ridiculous. I propose that rather than trying to >> clean up paravirt_enabled, you just delete it. Here are its users: >> >> static inline bool is_hypervisor_r

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 11:52 AM, Boris Ostrovsky wrote: On 02/08/2016 11:45 AM, Borislav Petkov wrote: On Mon, Feb 08, 2016 at 04:38:40PM +, Andrew Cooper wrote: Does the early loader have extable support? If so, this is fairly easy to fix. If not, we have a problem. It doesn't and regardless,

Re: [Xen-devel] [PATCH v4] xen: sched: convert RTDS from time to event driven model

2016-02-08 Thread Tianyang Chen
On 2/8/2016 6:27 AM, Dario Faggioli wrote: On Fri, 2016-02-05 at 23:27 -0500, Tianyang Chen wrote: On 2/5/2016 9:39 AM, Dario Faggioli wrote: On Wed, 2016-02-03 at 21:23 -0500, Tianyang Chen wrote: I see. So I'm just curious what can cause spurious wakeup? Does it only happen to a running

[Xen-devel] HVMlite ABI specification DRAFT B + implementation outline

2016-02-08 Thread Roger Pau Monné
Hello, I've Cced a bunch of people who have expressed interest in the HVMlite design/implementation, both from a Xen or OS point of view. If you would like to be removed, please say so and I will remove you in further iterations. The same applies if you want to be added to the Cc. This is an i

Re: [Xen-devel] [PATCH 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 8:18 PM, Tamas K Lengyel wrote: On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU > wrote: (last commit before this one explains why this was necessary) Signed-off-by: Corneliu ZUZU mailto:cz...@bitdefender.com>> I assume this patch will be gon

Re: [Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-08 Thread Tamas K Lengyel
> > > So I don't particularly like this #if check here. IMHO this should be done > in arch-specific function that you call from here that is just empty for > ARM. It could be a static inline function as it's rather small. > > >> +#if CONFIG_X86 >> > +if ( VM_EVENT_X86_CR3 == mop->u.mov_to_c

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 8:17 PM, Tamas K Lengyel wrote: On Mon, Feb 8, 2016 at 10:49 AM, Corneliu ZUZU > wrote: On 2/8/2016 7:15 PM, Andrew Cooper wrote: On 08/02/16 16:57, Corneliu ZUZU wrote: diff --git a/xen/include/asm-x86/hvm/event.h

Re: [Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 8:15 PM, Tamas K Lengyel wrote: On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU > wrote: +#if CONFIG_X86 Wouldn't it be safe to include these headers on ARM as well? +#include /* for VM_EVENT_X86_CR3 */ +#include /* for h

[Xen-devel] [xen-unstable-smoke test] 81429: tolerable all pass - PUSHED

2016-02-08 Thread osstest service owner
flight 81429 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/81429/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH 7/7] arch.monitor: move bits to common (arch_domain to domain)

2016-02-08 Thread Tamas K Lengyel
On Mon, Feb 8, 2016 at 9:58 AM, Corneliu ZUZU wrote: > This patch moves bitfield members for single-step, software-breakpoint and > guest-request monitor vm-events from the arch-side (struct arch_domain) to > the common-side (struct domain). Ctrl-reg bits (i.e. write_ctrlreg_* > members) > are le

Re: [Xen-devel] [PATCH 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-08 Thread Tamas K Lengyel
On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU wrote: > (last commit before this one explains why this was necessary) > > Signed-off-by: Corneliu ZUZU > I assume this patch will be gone in the next iteration after using -M so skipping it now. Tamas __

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Tamas K Lengyel
On Mon, Feb 8, 2016 at 10:49 AM, Corneliu ZUZU wrote: > On 2/8/2016 7:15 PM, Andrew Cooper wrote: > >> On 08/02/16 16:57, Corneliu ZUZU wrote: >> >>> diff --git a/xen/include/asm-x86/hvm/event.h >>> b/xen/include/asm-x86/hvm/event.h >>> index 11eb1fe..7c2252b 100644 >>> --- a/xen/include/asm-x86/

Re: [Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-08 Thread Tamas K Lengyel
On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU wrote: > 1. Kconfig: > * Added Kconfigs for common monitor vm-events: > # see files: common/Kconfig, x86/Kconfig > HAS_VM_EVENT_WRITE_CTRLREG > HAS_VM_EVENT_SINGLESTEP > HAS_VM_EVENT_SOFTWARE_BREAKPOINT > HAS_VM_EVENT_GUEST_REQUEST

Re: [Xen-devel] [PATCH v7] x86/p2m: use large pages for MMIO mappings

2016-02-08 Thread George Dunlap
On 02/02/16 15:15, Jan Beulich wrote: > When mapping large BARs (e.g. the frame buffer of a graphics card) the > overhead of establishing such mappings using only 4k pages has, > particularly after the XSA-125 fix, become unacceptable. Alter the > XEN_DOMCTL_memory_mapping semantics once again, so

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 7:15 PM, Andrew Cooper wrote: On 08/02/16 16:57, Corneliu ZUZU wrote: diff --git a/xen/include/asm-x86/hvm/event.h b/xen/include/asm-x86/hvm/event.h index 11eb1fe..7c2252b 100644 --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@ -27,9 +27,8 @@ bool_t hvm_

Re: [Xen-devel] [BUG] pci-passthrough generates "xen:events: Failed to obtain physical IRQ" for some devices

2016-02-08 Thread Marek Marczykowski-Górecki
On Wed, Feb 03, 2016 at 10:26:58AM -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Feb 03, 2016 at 03:22:30PM +0100, Marek Marczykowski-Górecki wrote: > > On Mon, Feb 01, 2016 at 09:50:53AM -0500, Konrad Rzeszutek Wilk wrote: > > > > The second bullet looks at first pretty interesting from this PoV,

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Tamas K Lengyel
On Mon, Feb 8, 2016 at 10:15 AM, Andrew Cooper wrote: > On 08/02/16 16:57, Corneliu ZUZU wrote: > > diff --git a/xen/include/asm-x86/hvm/event.h > b/xen/include/asm-x86/hvm/event.h > > index 11eb1fe..7c2252b 100644 > > --- a/xen/include/asm-x86/hvm/event.h > > +++ b/xen/include/asm-x86/hvm/event.

[Xen-devel] [PATCH v2.5 31/30] Fix PV guest XSAVE handling with levelling

2016-02-08 Thread Andrew Cooper
Will be folded into appropriate patches in v3. --- xen/arch/x86/cpu/amd.c | 15 +-- xen/arch/x86/domctl.c | 15 +++ 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index deb98ea..3e345fe 100644 --- a/xen/arch/

Re: [Xen-devel] [PATCH] x86/hvm: simplify emulation triggered by vm_event response

2016-02-08 Thread Tamas K Lengyel
On Thu, Feb 4, 2016 at 5:27 AM, Razvan Cojocaru wrote: > Currently, after receiving a vm_event reply requesting emulation, > the actual emulation is triggered in p2m_mem_access_check(), > which means that we're waiting for the page fault to occur again > before emulating. Aside from the performan

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:57, Corneliu ZUZU wrote: > diff --git a/xen/include/asm-x86/hvm/event.h b/xen/include/asm-x86/hvm/event.h > index 11eb1fe..7c2252b 100644 > --- a/xen/include/asm-x86/hvm/event.h > +++ b/xen/include/asm-x86/hvm/event.h > @@ -27,9 +27,8 @@ bool_t hvm_event_cr(unsigned int index, unsign

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Andrew Cooper
On 08/02/16 17:12, Corneliu ZUZU wrote: > On 2/8/2016 7:04 PM, Andrew Cooper wrote: >> On 08/02/16 16:57, Corneliu ZUZU wrote: >>> X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, >>> also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. >>> >>> Signed-off-by: Corneliu ZUZU >> For

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Borislav Petkov
On Mon, Feb 08, 2016 at 04:53:00PM +, Andrew Cooper wrote: > As an alternative check which should be doable this early on, peeking in > the head of hypercall_page should work. If Linux was booted as a PV > guest, the hypercall_page will have been constructed by the domain > builder, and won't

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 7:04 PM, Andrew Cooper wrote: On 08/02/16 16:57, Corneliu ZUZU wrote: X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. Signed-off-by: Corneliu ZUZU For future reference, constructing your patches with -M (detec

[Xen-devel] [PATCH 3/3] xen/init: Annotate all command line parameter infrastructure as const

2016-02-08 Thread Andrew Cooper
There is no reason for any of it to be modified. Additionally, link .init.setup beside the other constant .init data. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Tim Deegan CC: Ian Campbell CC: Stefano Stabellini --- xen/arch/arm/xen.lds.S | 11 ++- x

[Xen-devel] [PATCH 1/3] xen/x86: Drop the uses of invbool_param()

2016-02-08 Thread Andrew Cooper
There are only four users, and invbool_param() is an unnecessary cognitive overhead to use. Convert the four users to boolean_param(), and consistency use opt_* for the variable name. No change to the behaviour of the command line arguments. Signed-off-by: Andrew Cooper --- CC: Jan Beulich ---

[Xen-devel] [PATCH 2/3] xen/init: Drop invbool_param()

2016-02-08 Thread Andrew Cooper
There are now no users. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Tim Deegan CC: Ian Campbell --- xen/common/kernel.c| 3 +-- xen/include/xen/init.h | 5 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/

Re: [Xen-devel] [PATCH 0/7] Vm-events: move monitor vm-events code to common code.

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 6:57 PM, Corneliu ZUZU wrote: This patch series is an attempt to move (most) of the monitor vm-events code to the common-side. Patches summary: 1. Move xen/arch/arm/hvm.c to xen/arch/arm/hvm/hvm.c 2. Merge almost identical functions hvm_event_int3 + hvm_event_single_step -> hvm_eve

Re: [Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:57, Corneliu ZUZU wrote: > X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, > also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. > > Signed-off-by: Corneliu ZUZU For future reference, constructing your patches with -M (detect renames) makes reviews of patches li

Re: [Xen-devel] [PATCH] x86/hvm: simplify emulation triggered by vm_event response

2016-02-08 Thread Tamas K Lengyel
> >> The logic makes sense, so Acked-by: Andrew Cooper > >> for the x86-related nature, but it would be > >> nice to have a review from Tamas for the vm_event side of things. > > > > Thanks! Of course. Hopefully Tamas will like this, based on a > > conversation we've had a few days ago here. > Ye

Re: [Xen-devel] [PATCH v2] xen/arm: correctly handle DMA mapping of compound pages

2016-02-08 Thread Stefano Stabellini
On Mon, 8 Feb 2016, Ian Campbell wrote: > Currently xen_dma_map_page concludes that DMA to anything other than > the head page of a compound page must be foreign, since the PFN of the > page is that of the head. > > Fix the check to instead consider the whole of a compound page to be > local if th

[Xen-devel] [PATCH 5/7] xen/vm-events: Move hvm_event_* functions to common-side.

2016-02-08 Thread Corneliu ZUZU
1. Moved hvm_event_traps, hvm_event_cr, hvm_event_guest_request, hvm_event_software_breakpoint from arch-side to common-side 1.1. Moved arch/x86/hvm/event.c to common/hvm/event.c # see files: arch/x86/hvm/Makefile, xen/common/hvm/Makefile, xen/com

[Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

2016-02-08 Thread Corneliu ZUZU
1. Kconfig: * Added Kconfigs for common monitor vm-events: # see files: common/Kconfig, x86/Kconfig HAS_VM_EVENT_WRITE_CTRLREG HAS_VM_EVENT_SINGLESTEP HAS_VM_EVENT_SOFTWARE_BREAKPOINT HAS_VM_EVENT_GUEST_REQUEST 2. Moved monitor_domctl from arch-side to common-side 2.1. Moved

[Xen-devel] [PATCH 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h

2016-02-08 Thread Corneliu ZUZU
(last commit before this one explains why this was necessary) Signed-off-by: Corneliu ZUZU --- xen/arch/x86/Makefile | 2 +- xen/arch/x86/monitor.c | 72 + xen/arch/x86/monitor_x86.c | 72 -

[Xen-devel] [PATCH 6/7] Rename event_x86.c to event.c and event_arch.h to event.h + minor fixes

2016-02-08 Thread Corneliu ZUZU
* rename arch/x86/hvm/event_x86.c to arch/x86/hvm/event.c and asm-{x86,arm}/hvm/event_arch.h to asm-{x86/arm}/hvm/event.h (last commit before this one explains why this was necessary) Minor fixes: * ARM fix: xen/common/hvm/event.c was not actually compiled (see file-changes

[Xen-devel] [PATCH 1/7] arm: move arch/arm/hvm.c to arch/arm/hvm/hvm.c

2016-02-08 Thread Corneliu ZUZU
X86-side hvm.c is @ arch/x86/hvm/hvm.c. To maintain arm<->x86 symmetry, also move arch/arm/hvm.c to arch/arm/hvm/hvm.c. Signed-off-by: Corneliu ZUZU --- xen/arch/arm/Makefile | 2 +- xen/arch/arm/hvm.c| 67 --- xen/arch/arm/hvm/Makefile |

[Xen-devel] [PATCH 7/7] arch.monitor: move bits to common (arch_domain to domain)

2016-02-08 Thread Corneliu ZUZU
This patch moves bitfield members for single-step, software-breakpoint and guest-request monitor vm-events from the arch-side (struct arch_domain) to the common-side (struct domain). Ctrl-reg bits (i.e. write_ctrlreg_* members) are left on the arch-side, because control-registers number can vary ac

[Xen-devel] [PATCH 0/7] Vm-events: move monitor vm-events code to common code.

2016-02-08 Thread Corneliu ZUZU
This patch series is an attempt to move (most) of the monitor vm-events code to the common-side. Patches summary: 1. Move xen/arch/arm/hvm.c to xen/arch/arm/hvm/hvm.c 2. Merge almost identical functions hvm_event_int3 + This patch series is an attempt to move (most) of the monitor vm-events co

[Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Corneliu ZUZU
This patch merges almost identical functions hvm_event_int3 and hvm_event_single_step into a single function called hvm_event_software_breakpoint. Signed-off-by: Corneliu ZUZU --- xen/arch/x86/hvm/event.c| 52 ++--- xen/arch/x86/hvm/vmx/vmx.c | 11

Re: [Xen-devel] [PATCH v1 1/1] XEN/ARM: Add Odroid-XU3/XU4 support

2016-02-08 Thread Suriyan Ramasami
On Mon, Feb 8, 2016 at 7:27 AM, Ian Campbell wrote: > On Sun, 2016-02-07 at 09:44 -0800, Suriyan Ramasami wrote: > > The Odroid-XU3/XU4 from hardkernel is an Exynos 5422 based board. > > Code from mcpm-exynos.c and mcpm-platsmp.c from the Linux kernel > > has been used to get all the 8 cores from

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 11:45 AM, Borislav Petkov wrote: On Mon, Feb 08, 2016 at 04:38:40PM +, Andrew Cooper wrote: Does the early loader have extable support? If so, this is fairly easy to fix. If not, we have a problem. It doesn't and regardless, you want to have this CPUID querying as simple a

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Borislav Petkov
On Mon, Feb 08, 2016 at 11:41:16AM -0500, Boris Ostrovsky wrote: > Keep in mind that Xen PV doesn't go through startup_32|64(). It starts at > xen_start_kernel (save for a small stub before that), which sets pvops. It > "joins" regular/baremetal code in > i386_start_kernel/x86_64_start_reservation

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:45, Borislav Petkov wrote: > On Mon, Feb 08, 2016 at 04:38:40PM +, Andrew Cooper wrote: >> Does the early loader have extable support? If so, this is fairly easy >> to fix. If not, we have a problem. > It doesn't and regardless, you want to have this CPUID querying as > simple

Re: [Xen-devel] [PATCH v2 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain

2016-02-08 Thread David Vrabel
On 08/02/16 16:50, Juergen Gross wrote: > On 08/02/16 17:46, David Vrabel wrote: >> On 08/02/16 14:30, Juergen Gross wrote: >>> When adding more than one LUN to a frontend a warning for a failed >>> assignment is issued in dom0 for each already existing LUN. Avoid this >>> warning by checking for a

Re: [Xen-devel] [PATCH v2 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain

2016-02-08 Thread Juergen Gross
On 08/02/16 17:46, David Vrabel wrote: > On 08/02/16 14:30, Juergen Gross wrote: >> When adding more than one LUN to a frontend a warning for a failed >> assignment is issued in dom0 for each already existing LUN. Avoid this >> warning by checking for a LUN already existing when existence is >> all

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 11:35 AM, Borislav Petkov wrote: On Mon, Feb 08, 2016 at 11:31:04AM -0500, Boris Ostrovsky wrote: I think we are OK for PV because this code will be executed after pvops are set and so we will be calling xen_cpuid(). Not for the early loader - it is too early for pvops then. So

Re: [Xen-devel] [PATCH v2 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain

2016-02-08 Thread David Vrabel
On 08/02/16 14:30, Juergen Gross wrote: > When adding more than one LUN to a frontend a warning for a failed > assignment is issued in dom0 for each already existing LUN. Avoid this > warning by checking for a LUN already existing when existence is > allowed (scsiback_do_add_lun() called with try =

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Borislav Petkov
On Mon, Feb 08, 2016 at 04:38:40PM +, Andrew Cooper wrote: > Does the early loader have extable support? If so, this is fairly easy > to fix. If not, we have a problem. It doesn't and regardless, you want to have this CPUID querying as simple as possible. No special handling, no special pref

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:35, Borislav Petkov wrote: > On Mon, Feb 08, 2016 at 11:31:04AM -0500, Boris Ostrovsky wrote: >> I think we are OK for PV because this code will be executed after pvops are >> set and so we will be calling xen_cpuid(). > Not for the early loader - it is too early for pvops then. So y

Re: [Xen-devel] [PATCH v2 24/30] tools/libxc: Modify bitmap operations to take void pointers

2016-02-08 Thread Ian Campbell
On Mon, 2016-02-08 at 16:23 +, Tim Deegan wrote: > At 13:42 + on 05 Feb (1454679737), Andrew Cooper wrote: > > The type of the pointer to a bitmap is not interesting; it does not > > affect the > > representation of the block of bits being pointed to. > > It does affect the alignment, thou

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Borislav Petkov
On Mon, Feb 08, 2016 at 11:31:04AM -0500, Boris Ostrovsky wrote: > I think we are OK for PV because this code will be executed after pvops are > set and so we will be calling xen_cpuid(). Not for the early loader - it is too early for pvops then. So you're saying something like that won't work? -

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:31, Boris Ostrovsky wrote: > > > On 02/08/2016 11:26 AM, Andrew Cooper wrote: >> On 08/02/16 16:12, Boris Ostrovsky wrote: >>> >>> On 02/08/2016 11:05 AM, Andrew Cooper wrote: For compatibility with other virtualisation specs, Xen's cpuid leaves shift depending on configura

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 11:26 AM, Andrew Cooper wrote: On 08/02/16 16:12, Boris Ostrovsky wrote: On 02/08/2016 11:05 AM, Andrew Cooper wrote: For compatibility with other virtualisation specs, Xen's cpuid leaves shift depending on configuration. Spec at http://xenbits.xen.org/gitweb/?p=xen.git;a=blob

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:12, Boris Ostrovsky wrote: > > > On 02/08/2016 11:05 AM, Andrew Cooper wrote: >> >> For compatibility with other virtualisation specs, Xen's cpuid leaves >> shift depending on configuration. >> >> Spec at >> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/arch-x8

Re: [Xen-devel] [PATCH 1/2] xenoprof: fix up ability to disable it

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:04, Doug Goldstein wrote: > diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c > index 990e6f3..c7b5bd5 100644 > --- a/xen/arch/x86/cpu/vpmu_amd.c > +++ b/xen/arch/x86/cpu/vpmu_amd.c > @@ -22,6 +22,7 @@ > */ > > #include > +#include > #include > #include

Re: [Xen-devel] [PATCH 1/2] xenoprof: fix up ability to disable it

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 11:04 AM, Doug Goldstein wrote: Allow Xenoprof to be fully disabled when toggling the option off. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Boris Ostrovsky CC: Suravee Suthikulpanit CC: Aravind Gopalakrishnan CC: Jun Nakajima CC: Kevin Tian Signed-off-by: Doug

Re: [Xen-devel] [PATCH v2 24/30] tools/libxc: Modify bitmap operations to take void pointers

2016-02-08 Thread Tim Deegan
At 13:42 + on 05 Feb (1454679737), Andrew Cooper wrote: > The type of the pointer to a bitmap is not interesting; it does not affect the > representation of the block of bits being pointed to. It does affect the alignment, though. Is this safe on ARM? Tim. __

Re: [Xen-devel] [PATCH OSSTEST v3 2/2] Add a weekly coverity flight

2016-02-08 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST v3 2/2] Add a weekly coverity flight"): > This primarily consists of ts-coverity-{build,upload} and > make-coverity-flight which constructs the sole job. Acked-by: Ian Jackson Thanks! Ian. ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH 2/2] build: convert xenoprof to Kconfig

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:04, Doug Goldstein wrote: > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index 6f404b4..fbb64a7 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -84,6 +84,19 @@ config LATE_HWDOM > > If unsure, say N. > > +# Adds support for Xenoprof > +config X

Re: [Xen-devel] [PATCH OSSTEST 5/5 v3] mg-show-flight-runvars: recurse on buildjobs upon request

2016-02-08 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST 5/5 v3] mg-show-flight-runvars: recurse on buildjobs upon request"): > By looping over @rows looking for buildjobs runvars and adding those > jobs to the output until nothing changes. > > The output is resorted by runvar name which is the desired default > beh

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 11:05 AM, Andrew Cooper wrote: For compatibility with other virtualisation specs, Xen's cpuid leaves shift depending on configuration. Spec at http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=xen/include/public/arch-x86/cpuid.h;h=d709340f18d089560b959835eabb7b6609542c7e;hb=HEAD

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Andrew Cooper
On 08/02/16 15:55, Borislav Petkov wrote: > On Mon, Feb 08, 2016 at 10:39:43AM -0500, Boris Ostrovsky wrote: >> It does. Very much IIRC, the problem was not caused by an access to MSR but >> rather some sort of address not being available somewhere. > See below. > >>> - microcode application on Xen

[Xen-devel] [PATCH 1/2] xenoprof: fix up ability to disable it

2016-02-08 Thread Doug Goldstein
Allow Xenoprof to be fully disabled when toggling the option off. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Boris Ostrovsky CC: Suravee Suthikulpanit CC: Aravind Gopalakrishnan CC: Jun Nakajima CC: Kevin Tian Signed-off-by: Doug Goldstein --- xen/arch/x86/Makefile

[Xen-devel] [PATCH 2/2] build: convert xenoprof to Kconfig

2016-02-08 Thread Doug Goldstein
Convert the xenoprof x86 build time option to Kconfig. CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper Signed-off-by: Doug Goldstein --- xen/arch/x86/Makefile | 2 +- xen/arch/x86/Rules.mk | 3 --- xen/common/Kconfig| 13 + xen/common/Makefile | 2 +- 4 files changed, 1

[Xen-devel] [PATCH v2] xen/arm: correctly handle DMA mapping of compound pages

2016-02-08 Thread Ian Campbell
Currently xen_dma_map_page concludes that DMA to anything other than the head page of a compound page must be foreign, since the PFN of the page is that of the head. Fix the check to instead consider the whole of a compound page to be local if the PFN of the head passes the 1:1 check. We can neve

Re: [Xen-devel] [PATCH] xen/arm: correctly handle DMA mapping of compound pages

2016-02-08 Thread Ian Campbell
On Mon, 2016-02-08 at 15:46 +, Stefano Stabellini wrote: > On Mon, 8 Feb 2016, Ian Campbell wrote: > > Currently xen_dma_map_page concludes that DMA to anything other than > > the head page of a compound page must be foreign, since the PFN of the > > page is that of the head. > > > > Fix the c

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Borislav Petkov
On Mon, Feb 08, 2016 at 10:39:43AM -0500, Boris Ostrovsky wrote: > It does. Very much IIRC, the problem was not caused by an access to MSR but > rather some sort of address not being available somewhere. See below. > >- microcode application on Xen: we've had this before. The hypervisor > >should

Re: [Xen-devel] [PATCH] xen/arm: correctly handle DMA mapping of compound pages

2016-02-08 Thread Stefano Stabellini
On Mon, 8 Feb 2016, Ian Campbell wrote: > Currently xen_dma_map_page concludes that DMA to anything other than > the head page of a compound page must be foreign, since the PFN of the > page is that of the head. > > Fix the check to instead consider the whole of a compound page to be > local if th

Re: [Xen-devel] [PATCH v3 1/3] xen-access: minor fixes

2016-02-08 Thread Ian Campbell
On Sat, 2016-02-06 at 13:13 +0200, Razvan Cojocaru wrote: > On 02/05/2016 11:22 PM, Tamas K Lengyel wrote: > > Only copy the VCPU_PAUSED flag to the response. Copy the entire > > mem_access > > struct which is useful and easily forgotten when also testing the > > emulate > > response flags. Turn of

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Borislav Petkov
On Mon, Feb 08, 2016 at 10:31:36AM -0500, Boris Ostrovsky wrote: > This range is reserved for hypervisors but the only hypervisor that uses it > is Xen PV (lguest doesn't run in 64-bit mode). Yeah, this is mentioned in arch/x86/include/asm/page_64_types.h: /* * Set __PAGE_OFFSET to the most nega

Re: [Xen-devel] [PATCH] libxc: correct memory range check in domain builder

2016-02-08 Thread Ian Campbell
On Mon, 2016-02-08 at 15:20 +, Anthony PERARD wrote: > On Mon, Feb 08, 2016 at 03:23:52PM +0100, Juergen Gross wrote: > > Commit 81a76e4b12961a9f54f5021809074196dfe6dbba ("libxc: rework of > > domain builder's page table handler") introduced a regression with > > checking the required memory si

Re: [Xen-devel] [PATCH] vm_event: Fix regression caused by b701ccc8

2016-02-08 Thread Ian Campbell
On Mon, 2016-02-08 at 09:39 +, Ian Campbell wrote: > On Fri, 2016-02-05 at 14:20 -0700, Tamas K Lengyel wrote: > > When xc_map_foreign_batch got deprecated reinitializing vm_event on a > > domain > > where an event listener was previously active broke as it relied on the > > flag > > XEN_DOMCTL

Re: [Xen-devel] [PATCH v2 2/2] xen/scsiback: avoid warnings when adding multiple LUNs to a domain

2016-02-08 Thread Boris Ostrovsky
On 02/08/2016 09:30 AM, Juergen Gross wrote: When adding more than one LUN to a frontend a warning for a failed assignment is issued in dom0 for each already existing LUN. Avoid this warning by checking for a LUN already existing when existence is allowed (scsiback_do_add_lun() called with try

Re: [Xen-devel] [PATCH] xl: use bool type for flags instead of int

2016-02-08 Thread Ian Campbell
On Mon, 2016-02-08 at 10:21 +, George Dunlap wrote: > On 06/02/16 02:00, Dario Faggioli wrote: > > in schedulers' command handlers. > > > > No functional change intended. > > > > Signed-off-by: Dario Faggioli > > Acked-by: George Dunlap acked + applied. __

Re: [Xen-devel] Adding Xen to the kbuild bot?

2016-02-08 Thread Doug Goldstein
On 2/5/16 2:10 PM, Andy Lutomirski wrote: > On Feb 4, 2016 7:11 PM, "Fengguang Wu" wrote: >> >> Hi Andy, >> >> CC more people on Xen testing -- in case OSStest already (or plans to) >> cover such test case. >> >> On Tue, Feb 02, 2016 at 07:31:30PM -0800, Andy Lutomirski wrote: >>> Hi all- >>> >>>

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/06/2016 05:04 PM, Borislav Petkov wrote: On Sat, Feb 06, 2016 at 12:05:32PM -0800, Andy Lutomirski wrote: int __init microcode_init(void) { [...] if (paravirt_enabled() || dis_ucode_ldr) return -EINVAL; This is also asking "are we the natively booted k

Re: [Xen-devel] [PATCH v3 3/3] altp2m: Implement p2m_get_mem_access for altp2m views

2016-02-08 Thread Ian Campbell
On Fri, 2016-02-05 at 14:22 -0700, Tamas K Lengyel wrote: > Extend the existing get_mem_access memop to allow querying permissions in > altp2m views as well. > > Signed-off-by: Tamas K Lengyel > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Liu > Cc: Razvan Cojocaru >

Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy

2016-02-08 Thread Boris Ostrovsky
On 02/06/2016 03:05 PM, Andy Lutomirski wrote: Anyway, this is all ridiculous. I propose that rather than trying to clean up paravirt_enabled, you just delete it. Here are its users: static inline bool is_hypervisor_range(int idx) { /* * 8000 - 87ff is res

  1   2   >