On 2/8/16 10:24 AM, Boris Ostrovsky wrote: > > > On 02/08/2016 11:04 AM, Doug Goldstein wrote: >> Allow Xenoprof to be fully disabled when toggling the option off. >> >> CC: Keir Fraser <k...@xen.org> >> CC: Jan Beulich <jbeul...@suse.com> >> CC: Andrew Cooper <andrew.coop...@citrix.com> >> CC: Boris Ostrovsky <boris.ostrov...@oracle.com> >> CC: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> >> CC: Aravind Gopalakrishnan <aravind.gopalakrish...@amd.com> >> CC: Jun Nakajima <jun.nakaj...@intel.com> >> CC: Kevin Tian <kevin.t...@intel.com> >> Signed-off-by: Doug Goldstein <car...@cardoe.com> > > >> @@ -2666,10 +2669,11 @@ static int vmx_msr_write_intercept(unsigned >> int msr, uint64_t msr_content) >> goto gp_fault; >> break; >> default: >> - if ( passive_domain_do_wrmsr(msr, msr_content) ) >> + if ( IS_ENABLED(CONFIG_XENOPROF) && >> + passive_domain_do_wrmsr(msr, msr_content) ) >> return X86EMUL_OKAY; >> - if ( wrmsr_viridian_regs(msr, msr_content) ) >> + if ( wrmsr_viridian_regs(msr, msr_content) ) >> break; > > Looks like a stray change. > > Other than that, > > Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > > While at it --- I think we should put VPMU code under CONFIG option too, > especially given its support status. I can do that (unless Doug wants to). > > -boris
Boris, Thanks for the review. I didn't add your Reviewed-by because I've reworked this patch to take into account Andrew Cooper's suggestion to provide dummy function calls instead of wrapping everything with IS_ENABLED(). -- Doug Goldstein
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
