Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

>>> On 17.04.15 at 08:51, wrote: > > On 04/17/2015 02:23 PM, Jan Beulich wrote: > On 17.04.15 at 05:10, wrote: >>> On 04/16/2015 11:42 PM, Jan Beulich wrote: >>> On 15.04.15 at 09:03, wrote: > +void vmx_vcpu_flush_pml_buffer(struct vcpu *v) > +{ > +uint64_t *pml_buf; >>

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

On 04/17/2015 02:28 PM, Jan Beulich wrote: On 17.04.15 at 04:46, wrote: On 04/16/2015 11:51 PM, Jan Beulich wrote: On 15.04.15 at 09:03, wrote: @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, bool_t log_global) d->arch.paging.mode |= PG_log_dirty; pagi

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

On 04/17/2015 02:23 PM, Jan Beulich wrote: On 17.04.15 at 05:10, wrote: On 04/16/2015 11:42 PM, Jan Beulich wrote: On 15.04.15 at 09:03, wrote: +void vmx_vcpu_flush_pml_buffer(struct vcpu *v) +{ +uint64_t *pml_buf; +unsigned long pml_idx; + +ASSERT(vmx_vcpu_pml_enabled(v)); + +

Re: [Xen-devel] [PATCH] VTd/dmar: Tweak how the DMAR table is clobbered

>>> On 16.04.15 at 18:44, wrote: >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: Tuesday, April 14, 2015 5:09 PM >> On 14/04/15 08:50, Jan Beulich wrote: >> > Unless Kevin or >> > Yang object, I'd therefore suggest reverting the change. Once >> > we determined why VT-d needs wh

Re: [Xen-devel] [PATCH 11/19] xen: arm: Annotate handlers for PCTR_EL2.Tx

Hi Ian, On 16/04/2015 17:53, Ian Campbell wrote: On Mon, 2015-04-06 at 13:18 +0200, Julien Grall wrote: Hi Ian, Subject: s/PCTR/CPTR/ On 31/03/2015 12:07, Ian Campbell wrote: Signed-off-by: Ian Campbell --- xen/arch/arm/traps.c | 14 ++ 1 file changed, 14 insertions(+) d

Re: [Xen-devel] [v2 11/11] p2m/ept: enable PML in p2m-ept for log-dirty

>>> On 17.04.15 at 04:40, wrote: > On 04/16/2015 11:54 PM, Jan Beulich wrote: > On 15.04.15 at 09:03, wrote: >>> This patch firstly enables EPT A/D bits if PML is used, as PML depends on > EPT >>> A/D bits to work. A bit is set for all present leaf p2m types, D bit is set > for >>> all writ

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

>>> On 17.04.15 at 04:46, wrote: > On 04/16/2015 11:51 PM, Jan Beulich wrote: > On 15.04.15 at 09:03, wrote: >>> @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, >>> bool_t log_global) >>> d->arch.paging.mode |= PG_log_dirty; >>> paging_unlock(d); >>> >>>

Re: [Xen-devel] [PATCH 07/19] xen: arm: Annotate trap handler for HCR_EL2.{TWI, TWE, TSC}

Hi Ian, On 16/04/2015 17:34, Ian Campbell wrote: On Fri, 2015-04-03 at 15:05 +0200, Julien Grall wrote: Hi Ian, On 31/03/2015 12:07, Ian Campbell wrote: Reference the bit which enables the trap and the section/page which describes what that bit enables. These ones are pretty trivial, include

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

>>> On 17.04.15 at 05:10, wrote: > On 04/16/2015 11:42 PM, Jan Beulich wrote: > On 15.04.15 at 09:03, wrote: >>> +void vmx_vcpu_flush_pml_buffer(struct vcpu *v) >>> +{ >>> +uint64_t *pml_buf; >>> +unsigned long pml_idx; >>> + >>> +ASSERT(vmx_vcpu_pml_enabled(v)); >>> + >>> +vm

Re: [Xen-devel] [PATCH 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

Hi Ian, On 16/04/2015 17:22, Ian Campbell wrote: On Fri, 2015-04-03 at 14:51 +0200, Julien Grall wrote: On 31/03/2015 12:07, Ian Campbell wrote: Signed-off-by: Ian Campbell --- xen/arch/arm/traps.c | 52 -- 1 file changed, 33 insertions(

Re: [Xen-devel] [PATCH 02/19] xen: arm: add missing break

Hi Ian, On 16/04/2015 17:08, Ian Campbell wrote: On Thu, 2015-04-02 at 16:09 +0100, Julien Grall wrote: Hi Ian, On 31/03/2015 11:07, Ian Campbell wrote: Signed-off-by: Ian Campbell xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 Having injected an undefined instruction we don't want

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

Hi Ian, On 16/04/2015 16:40, Ian Campbell wrote: On Thu, 2015-04-16 at 16:20 +0100, Julien Grall wrote: Concerning XSM, even if ARM is using one hypercall rather than 2, the resulting check is nearly the same. XSM PHYSDEVOP_map_pirq: 1) Check if the current domain can add resource to the

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

On 04/17/2015 08:10 AM, Tim Deegan wrote: At 22:57 + on 16 Apr (1429225024), Tian, Kevin wrote: From: Kai Huang [mailto:kai.hu...@linux.intel.com] +if ( !p2m_change_type_one(v->domain, gfn, p2m_ram_logdirty, +p2m_ram_rw) ) +paging_mark_gfn_dirty(v->

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

On 04/17/2015 06:57 AM, Tian, Kevin wrote: From: Kai Huang [mailto:kai.hu...@linux.intel.com] Sent: Wednesday, April 15, 2015 3:04 PM This patch adds help functions to enable/disable PML, and flush PML buffer for single vcpu and particular domain for further use. Signed-off-by: Kai Huang ---

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

On 04/16/2015 11:42 PM, Jan Beulich wrote: On 15.04.15 at 09:03, wrote: +int vmx_vcpu_enable_pml(struct vcpu *v) +{ +struct domain *d = v->domain; + +if ( vmx_vcpu_pml_enabled(v) ) +return 0; + +v->arch.hvm_vmx.pml_pg = d->arch.paging.alloc_page(d); So you latch v->domain

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

On 04/16/2015 11:51 PM, Jan Beulich wrote: On 15.04.15 at 09:03, wrote: @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, bool_t log_global) d->arch.paging.mode |= PG_log_dirty; paging_unlock(d); +/* enable hardware-assisted log-dirty if it is supporte

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

On 04/17/2015 07:07 AM, Tian, Kevin wrote: From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Thursday, April 16, 2015 11:52 PM On 15.04.15 at 09:03, wrote: @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, bool_t log_global) d->arch.paging.mode |= PG_log_dirty;

Re: [Xen-devel] [v2 11/11] p2m/ept: enable PML in p2m-ept for log-dirty

On 04/16/2015 11:54 PM, Jan Beulich wrote: On 15.04.15 at 09:03, wrote: This patch firstly enables EPT A/D bits if PML is used, as PML depends on EPT A/D bits to work. A bit is set for all present leaf p2m types, D bit is set for all writable types, except log-dirty type. I think the tying o

[Xen-devel] Is it ok to routing periperal irq to any Domain0's vCPU on Xen ARM 4.5.x?

I'm studying periperal irq routing to Domain0's vCPU I'm testing on Arndale Broad and Domain 0 has 2 vCPU. So Xen can select vcpu0 or vcpu1 to inject periperal irq. I tested periperal routing on Xen 4.4.1 and it works well. But I tested periperal routing on Xen 4.5.0 but irq dosen't works wel

Re: [Xen-devel] [v2 05/11] vmx: add new data structure member to support PML

On 04/17/2015 06:39 AM, Tian, Kevin wrote: From: Kai Huang [mailto:kai.hu...@linux.intel.com] Sent: Wednesday, April 15, 2015 3:04 PM A new 4K page pointer is added to arch_vmx_struct as PML buffer for vcpu. And a new 'status' field is added to vmx_domain to indicate whether PML is enabled for

Re: [Xen-devel] [v2 04/11] vmx: add PML definition and feature detection.

On 04/17/2015 06:35 AM, Tian, Kevin wrote: From: Kai Huang [mailto:kai.hu...@linux.intel.com] Sent: Wednesday, April 15, 2015 3:04 PM The patch adds PML definition and feature detection. Note PML won't be detected if PML is disabled from boot parameter. PML is also disabled in construct_vmcs,

Re: [Xen-devel] [v2 05/11] vmx: add new data structure member to support PML

On 04/16/2015 11:33 PM, Jan Beulich wrote: On 15.04.15 at 09:03, wrote: --- a/xen/include/asm-x86/hvm/vmx/vmcs.h +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h @@ -70,8 +70,12 @@ struct ept_data { cpumask_var_t synced_mask; }; +#define _VMX_DOMAIN_PML_ENABLED0 +#define VMX_DOMAIN_PM

Re: [Xen-devel] Question. Inject virq to Domain on Xen ARM.

Yes. I confirm irq move from lr_queue to lr in gic_inject(). Thanks but i have another question about vgic_vcpu_inject_irq function. I will Start new thread. -Original Message- From: "Stefano Stabellini" To: "Ian Campbell"; Cc

[Xen-devel] [xen-unstable test] 50425: regressions - FAIL

flight 50425 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/50425/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-freebsd10-amd64 13 guest-localmigrate fail REGR. vs. 50405 test-amd64-i386-xl-q

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

At 22:57 + on 16 Apr (1429225024), Tian, Kevin wrote: > > From: Kai Huang [mailto:kai.hu...@linux.intel.com] > > +if ( !p2m_change_type_one(v->domain, gfn, p2m_ram_logdirty, > > +p2m_ram_rw) ) > > +paging_mark_gfn_dirty(v->domain, gfn); > > Should we ha

Re: [Xen-devel] [PATCH] libxl: Disallow save or migrate when host devices are assigned to a guest.

On Tue, 2015-04-14 at 20:15 -0600, Jim Fehlig wrote: > Konrad Rzeszutek Wilk wrote: > > -static bool > > -libxlDomainMigrationIsAllowed(virDomainDefPtr def) > > -{ > > -/* Migration is not allowed if definition contains any hostdevs */ > > -if (def->nhostdevs > 0) { > > -virReportE

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

On Thu, 2015-04-16 at 18:15 +0100, Ian Jackson wrote: > Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more > messages]"): > > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > > > Yes, this looks like the driver is not syncing the DMA buffers. Unmap

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, April 16, 2015 11:52 PM > > >>> On 15.04.15 at 09:03, wrote: > > > @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, > bool_t log_global) > > d->arch.paging.mode |= PG_log_dirty; > > paging_unlock(d);

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

> From: Tian, Kevin > Sent: Friday, April 17, 2015 6:57 AM > > +int vmx_domain_enable_pml(struct domain *d) > > +{ > > +struct vcpu *v; > > +int rc; > > + > > +ASSERT(atomic_read(&d->pause_count)); > > + > > +if ( vmx_domain_pml_enabled(d) ) > > +return 0; > > + > > +for

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

> From: Kai Huang [mailto:kai.hu...@linux.intel.com] > Sent: Wednesday, April 15, 2015 3:04 PM > > This patch adds help functions to enable/disable PML, and flush PML buffer for > single vcpu and particular domain for further use. > > Signed-off-by: Kai Huang > --- > xen/arch/x86/hvm/vmx/vmcs.c

Re: [Xen-devel] [libvirt] [PATCH V3 0/3] libxl: domain destroy fixes

On 04/09/2015 09:03 AM, Michal Privoznik wrote: On 04.04.2015 00:49, Jim Fehlig wrote: V3 of a small series to fix issues wrt domain destroy V1: https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html V2: https://www.redhat.com/archives/libvir-list/2015-April/msg00072.html In thi

Re: [Xen-devel] [v2 05/11] vmx: add new data structure member to support PML

> From: Kai Huang [mailto:kai.hu...@linux.intel.com] > Sent: Wednesday, April 15, 2015 3:04 PM > > A new 4K page pointer is added to arch_vmx_struct as PML buffer for vcpu. > And a > new 'status' field is added to vmx_domain to indicate whether PML is enabled > for > the domain or not. The 'status

Re: [Xen-devel] [v2 04/11] vmx: add PML definition and feature detection.

> From: Kai Huang [mailto:kai.hu...@linux.intel.com] > Sent: Wednesday, April 15, 2015 3:04 PM > > The patch adds PML definition and feature detection. Note PML won't be > detected > if PML is disabled from boot parameter. PML is also disabled in > construct_vmcs, > as it will only be enabled when

[Xen-devel] [libvirt bisection] complete build-armhf-libvirt

branch xen-unstable xen branch xen-unstable job build-armhf-libvirt test libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git Tree: qemuu git://xenbits.xen.org/staging/qemu-upstream-unstable.git Tree: xen git://xenbits.xen.org/xen.git ***

Re: [Xen-devel] [PATCH v2 0/3] libxl: fd events: Recheck with poll

On 04/16/2015 12:23 PM, Ian Jackson wrote: Ian: Jim: I too saw this bug just before Konrad's report, but the patches don't seem to\ help. Running a script that continually saves and restores domains will eventually lock libvirtd with essentially the same traces reported by Konrad I'm a total

Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

On Thu, Apr 16, 2015 at 05:44:10PM +0100, Tim Deegan wrote: > update_intremap_entry_from_msi() doesn't write to its data pointer on > some error paths, so we copying that variable into the msg would count > as undefined behaviour. > > Signed-off-by: Tim Deegan > Cc: Suravee Suthikulpanit > Cc: A

Re: [Xen-devel] [PATCH 1/1] x86/hvm: prevent hvm_free_ioreq_gmfn() clobber of arbitrary memory

On 16/04/15 17:37, Tim Deegan wrote: > At 12:32 +0100 on 16 Apr (1429187564), Jan Beulich wrote: > On 16.04.15 at 12:53, wrote: >>> I would be inclined to use a bigger hammer here. IMO refactoring like >>> this makes it easier to reason about (compile tested only): >> This looks like a pretty

[Xen-devel] [RFC] Linux save_fl PVOP for Xen

Having recently got some Broadwell hardware, our automatic test system discovered that 32bit PV guests would reliably blow up while attempting to boot. It turns out that the save_fl PVOP is at fault. The comment is false, as setup_smap() uses it to check that the Alignment Check flag is clear. A

Re: [Xen-devel] Archiving Xen on ARM and PVOPS subprojects

On Thu, Apr 16, 2015 at 12:37:15PM +0100, Ian Campbell wrote: > On Wed, 2015-04-15 at 17:23 +0100, Lars Kurth wrote: > > > > According to http://xenproject.org/governance.html we would need to > > perform an archivation review. In this case, the situation is quite > > clear IMHO and I believe that

[Xen-devel] [PATCH v2 0/3] libxl: fd events: Recheck with poll

Ian Jackson writes ("<21807.61130.841852.546...@mariner.uk.xensource.com>"): Gah, mangled the subject line. Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] <21807.61130.841852.546...@mariner.uk.xensource.com>

Ian: > > Jim: > > I too saw this bug just before Konrad's report, but the patches > > don't seem to\ > > help. Running a script that continually saves and restores domains will > > eventually lock libvirtd with essentially the same traces reported by Konrad > > I'm a total idiot. I do the rechec

[Xen-devel] [PATCH 2/3] libxl: fd events: Break out fd_occurs

No functional change, only code motion. Currently, contrary to this function's name, there are two sites where efd->func() is called so one of them doesn't go through here just yet. That will be dealt with in the next commit. Signed-off-by: Ian Jackson CC: Jim Fehlig CC: Konrad Rzeszutek Wilk

[Xen-devel] [PATCH 3/3] libxl: fd events: Suppress spurious fd events

Always recheck with poll() right before making the callback. All sorts of things may have happened since poll() originally signaled the fd. We would like the main functional libxl code not to have to worry about spurious wakeups. In particular, this fixes a bug in the save/restore callout: the s

[Xen-devel] [PATCH 1/3] libxl: fd events: Break out libxl__fd_poll_recheck

Replaces two call sites where a rechecking poll() was open-coded. No functional change, other than to highly unusual error path diagnosis, and debug and error message output. Signed-off-by: Ian Jackson CC: Jim Fehlig CC: Konrad Rzeszutek Wilk --- tools/libxl/libxl_event.c| 63 ++

Re: [Xen-devel] [PATCH v2 2/4] x86/MSI-X: access MSI-X table only after having enabled MSI-X

On Thu, Apr 16, 2015 at 08:43:30AM +0100, Jan Beulich wrote: > >>> On 15.04.15 at 19:41, wrote: > > On Mon, Apr 13, 2015 at 10:05:14AM +0100, Jan Beulich wrote: > >> You mentioning XSA-120 and its addendum - are these requirements > >> for the problem to be seen? I admit I may have tested a PV gue

[Xen-devel] [PATCH 1/3] libxl: fd events: Break out libxl__fd_poll_recheck

Replaces two call sites where a rechecking poll() was open-coded. No functional change, other than to highly unusual error path diagnosis, and debug and error message output. Signed-off-by: Ian Jackson CC: Jim Fehlig CC: Konrad Rzeszutek Wilk --- tools/libxl/libxl_event.c| 63 ++

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

From: Michael Chan Date: Thu, 16 Apr 2015 09:39:13 -0700 > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: >> Yes, this looks like the driver is not syncing the DMA buffers. Unmap is >> supposed to synchronize as well. >> > > For small rx packets (< 256 bytes), we sync th

Re: [Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

On 16/04/15 17:44, Tim Deegan wrote: > update_intremap_entry_from_msi() doesn't write to its data pointer on > some error paths, so we copying that variable into the msg would count > as undefined behaviour. > > Signed-off-by: Tim Deegan > Cc: Suravee Suthikulpanit > Cc: Aravind Gopalakrishnan

Re: [Xen-devel] [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh save /tmp/blah' with guest corrupting memory (on purpose).

Jim Fehlig writes ("Re: [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh save /tmp/blah' with guest corrupting memory (on purpose)."): > On 04/14/2015 11:31 AM, Ian Jackson wrote: > > I have produced what I think are two patches that will fix this. I > > have compiled them bu

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

Michael Chan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]"): > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > > Yes, this looks like the driver is not syncing the DMA buffers. Unmap is > > supposed to synchronize as well. > > For small rx pac

Re: [Xen-devel] [PATCH v7] libxl: provide libxl_bitmap_{or,and}

On 4/16/2015 8:45 AM, Wei Liu wrote: On Thu, Apr 16, 2015 at 08:40:52AM -0600, Linda wrote: On 4/16/2015 8:34 AM, Ian Campbell wrote: On Wed, 2015-04-15 at 11:02 -0600, Linda Jacobson wrote: New functions to provide logical and and or of two bitmaps functions can be used in vNUMA configuration

[Xen-devel] [linux-linus test] 50422: regressions - FAIL

flight 50422 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/50422/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 13 guest-saverestore fail REGR. vs. 50329 test-amd64-amd64-xl-m

Re: [Xen-devel] [PATCH 11/19] xen: arm: Annotate handlers for PCTR_EL2.Tx

On Mon, 2015-04-06 at 13:18 +0200, Julien Grall wrote: > Hi Ian, > > Subject: s/PCTR/CPTR/ > > On 31/03/2015 12:07, Ian Campbell wrote: > > Signed-off-by: Ian Campbell > > --- > > xen/arch/arm/traps.c | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/xen/arch/ar

Re: [Xen-devel] [PATCH 10/19] xen: arm: Annotate registers trapped by CPTR_EL2.TTA

On Mon, 2015-04-06 at 13:10 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > Add explicit handler for 64-bit CP14 accesses, with more relevant > > debug message (as per other handlers) and to provide a place for the > > comment. > > It's a bit strange to name

[Xen-devel] [PATCH] passthrough/amd: avoid reading an uninitialized variable.

update_intremap_entry_from_msi() doesn't write to its data pointer on some error paths, so we copying that variable into the msg would count as undefined behaviour. Signed-off-by: Tim Deegan Cc: Suravee Suthikulpanit Cc: Aravind Gopalakrishnan --- I'm not sure whether we ought to be writing som

Re: [Xen-devel] [PATCH 04/19] xen: arm: provide and use a handle_raz_wi helper

On Fri, 2015-04-03 at 14:39 +0200, Julien Grall wrote: > > On 02/04/2015 18:19, Ian Campbell wrote: > > On Thu, 2015-04-02 at 17:01 +0100, Ian Campbell wrote: > >> On Thu, 2015-04-02 at 16:50 +0100, Ian Campbell wrote: > >> > >>> Writing to the bottom half (e.g. w0) of a register implicitly clears

Re: [Xen-devel] [PATCH 08/19] xen: arm: implement handling of ACTLR_EL1 trap

On Fri, 2015-04-03 at 15:42 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > While annotating ACTLR I noticed that we don't appear to handle the > > 64-bit version of this trap. Do so and annotate everything. > > While Linux doesn't use ACTLR_EL1 on aarch64, a

Re: [Xen-devel] [PATCH RFC v2 2/3] libxl: Port libxl_blktap2.c to blktap2.5 API.

George Dunlap writes ("[PATCH RFC v2 2/3] libxl: Port libxl_blktap2.c to blktap2.5 API."): > This is code is in preparation for building against an external blktap > tree. (NB I'm not really familiar with the tapdisk API. I guess we'll want an ack from some blktap2.5 person ?) > +static int ta

Re: [Xen-devel] [PATCH RFC v2 1/3] tools: Remove in-tree blktap2

George Dunlap writes ("[PATCH RFC v2 1/3] tools: Remove in-tree blktap2"): > Remove and temporarily disable the in-tree blktap2 while we pivot to > using an external blktap2 library. > > The reason for removing first is to be able to port libxl_blktap2.c to > the upstream blktap2.5 API (which is i

Re: [Xen-devel] [PATCH 07/19] xen: arm: Annotate trap handler for HCR_EL2.{TWI, TWE, TSC}

On Fri, 2015-04-03 at 15:05 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > Reference the bit which enables the trap and the section/page which > > describes what that bit enables. > > > > These ones are pretty trivial, included for completeness. > > > > Signe

Re: [Xen-devel] [PATCH 5/8] raisin: Fix CentOS build

On 04/16/2015 05:19 PM, George Dunlap wrote: > diff --git a/components/xen b/components/xen > index a0c0034..f2e1254 100644 > --- a/components/xen > +++ b/components/xen > @@ -11,10 +11,16 @@ function xen_check_package() { > > local DEP_Fedora_common="make gcc python-devel gettext libuuid-de

Re: [Xen-devel] [PATCH] VTd/dmar: Tweak how the DMAR table is clobbered

> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Tuesday, April 14, 2015 5:09 PM > > On 14/04/15 08:50, Jan Beulich wrote: > On 10.04.15 at 11:08, wrote: > >> On 10/04/15 02:23, Tian, Kevin wrote: > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thur

Re: [Xen-devel] [PATCH 05/19] xen: arm: Add and use r/o+raz and w/o+wi helpers

On Fri, 2015-04-03 at 14:51 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > Signed-off-by: Ian Campbell > > --- > > xen/arch/arm/traps.c | 52 > > -- > > 1 file changed, 33 insertions(+), 19 deletions(-) >

Re: [Xen-devel] [PATCH 0/2] Re: libvirtd live-locking on CTX_LOCK when doing 'virsh save /tmp/blah' with guest corrupting memory (on purpose).

On 04/14/2015 11:31 AM, Ian Jackson wrote: Konrad Rzeszutek Wilk writes ("libvirtd live-locking on CTX_LOCK when doing 'virsh save /tmp/blah' with guest corrupting memory (on purpose)."): It looks like thread #10 is blocking in libxl_read_exactly waiting for 'libxl-save-helper'. Said applicati

Re: [Xen-devel] [PATCH 06/19] xen: arm: add minimum exception level argument to trap handler helpers

On Fri, 2015-04-03 at 14:58 +0200, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 12:07, Ian Campbell wrote: > > Removes a load of boiler plate. > > > > Signed-off-by: Ian Campbell > > --- > > xen/arch/arm/traps.c | 65 > > +- > > 1 file chan

[Xen-devel] [PATCH 1/8] raisin: Fix non-verbose case

Because we use "set -e", we can't use the "a && b" construct, as it will fail and stop the script. Signed-off-by: George Dunlap --- lib/common-functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/common-functions.sh b/lib/common-functions.sh index 36e1766..06

[Xen-devel] [PATCH 5/8] raisin: Fix CentOS build

Add package dependencies for CentOS. Also use PKGTYPE rather than DISTRO to determine if we need rpm-build. I've tested this for xen but not for libvirt or grub. Signed-off-by: George Dunlap --- CC: Stefano Stabellini --- components/grub| 5 + components/libvirt | 7 +++ compone

[Xen-devel] [PATCH 8/8] raisin: RFC Add blktap2 as an external tree

Until we start hosting the blktap repo on xenbits, use the one from github. Also, we need to pass in the directories where to find the libblktapctl headers in the Xen build. Signed-off-by: George Dunlap --- Note: For now use the "upstream" XenServer repo. Also, to build with this you need the p

[Xen-devel] [PATCH 7/8] raisin: Rework component specification

Allow COMPONENTS to be specified in the config (or on the command-line) Now you can keep all components enabled in your config but build only one like so: COMPONENTS="xen" ./raise build Signed-off-by: George Dunlap --- CC: Stefano Stabellini --- defconfig | 5 + lib/common-

[Xen-devel] [PATCH 3/8] raisin: Use fakeroot for mkdeb so we can build the package as non-root

Signed-off-by: George Dunlap --- CC: Stefano Stabellini --- lib/common-functions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/common-functions.sh b/lib/common-functions.sh index 06c894a..373d6fb 100644 --- a/lib/common-functions.sh +++ b/lib/common-functions.sh @@ -

[Xen-devel] [PATCH 6/8] raisin: Break build into components and allow the sub-steps to be called individually

This makes it easier to debug just one aspect of the build. Signed-off-by: George Dunlap --- CC: Stefano Stabellini --- lib/commands.sh | 16 raise | 2 +- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/lib/commands.sh b/lib/commands.sh index 17e2129

[Xen-devel] [PATCH 4/8] raisin: Use PKGTYPE rather than DISTRO to determine how to build a package

Signed-off-by: George Dunlap --- CC: Stefano Stabellini --- lib/common-functions.sh | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/common-functions.sh b/lib/common-functions.sh index 373d6fb..e66c6f4 100644 --- a/lib/common-functions.sh +++ b/lib/commo

[Xen-devel] [PATCH 2/8] Include actual config in package, not defconfig

We want to include the actual config used to build the packages. Signed-off-by: George Dunlap --- CC: Stefano Stabellini --- raise | 1 - scripts/mkdeb | 2 +- scripts/mkrpm | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/raise b/raise index 94507d2..bce6908 10075

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: > Yes, this looks like the driver is not syncing the DMA buffers. Unmap is > supposed to synchronize as well. > For small rx packets (< 256 bytes), we sync the DMA buffer before we copy the data to another SKB. For larger pac

Re: [Xen-devel] [PATCH 1/1] x86/hvm: prevent hvm_free_ioreq_gmfn() clobber of arbitrary memory

At 12:32 +0100 on 16 Apr (1429187564), Jan Beulich wrote: > >>> On 16.04.15 at 12:53, wrote: > > I would be inclined to use a bigger hammer here. IMO refactoring like > > this makes it easier to reason about (compile tested only): > > This looks like a pretty nice cleanup; I particularly like th

Re: [Xen-devel] [PATCH 02/19] xen: arm: add missing break

On Thu, 2015-04-02 at 16:09 +0100, Julien Grall wrote: > Hi Ian, > > On 31/03/2015 11:07, Ian Campbell wrote: > > Signed-off-by: Ian Campbell > > > > xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 > > > > Having injected an undefined instruction we don't want to also advance > > pc. So re

Re: [Xen-devel] [PATCH 4/9] raisin: add a component to build qemu_traditional

On Wed, 15 Apr 2015, Andrew Cooper wrote: # > On 15/04/15 16:14, Stefano Stabellini wrote: > > Introduce a component to build qemu-traditional out of xen-unstable. > > Do not compile qemu-traditional from xen-unstable by passing the right > > command line option to configure. > > > > Signed-off-by

Re: [Xen-devel] Ongoing issue with libvirt-xen driver for Openstack Nova

> Date: Thu, 16 Apr 2015 16:12:49 +0100 > From: anthony.per...@citrix.com > To: bderzhav...@hotmail.com > CC: xen-devel@lists.xen.org > Subject: Re: [Xen-devel] Ongoing issue with libvirt-xen driver for Openstack > Nova > > On Thu, Apr 16, 2015 at 01:05:44PM +0100, Ian Campbell wrote: > > On Th

Re: [Xen-devel] [PATCH RFC v2 0/3] tools: Allow building XenServer's blktap 2.5 as an external tree.

On 04/16/2015 04:56 PM, George Dunlap wrote: > For some time, the blktap2 in-tree has bitrotted. Many years ago the > XenServer team at Citrix forked the code into a separate repository; > several attempts have been made to upstream those changes back into > Xen, to no avail. > > The blktap code

[Xen-devel] [PATCH RFC v2 3/3] tools/configure: Detect out-of-tree blktap2 and use by default if available

Set the {CFLAGS,LDLIBS,SHLIBS}_libblktapctl conditionally so that if someone is building blkttap out-of-tree but not installing it in the build environment, they can specify the path thus: CFLAGS="-I$INST_DIR/$PREFIX/include/blktap -I$INST_DIR/$PREFIX/include/vhd" \ LDFLAGS="-L$INST_DIR/$PREFIX/li

[Xen-devel] [PATCH RFC v2 0/3] tools: Allow building XenServer's blktap 2.5 as an external tree.

For some time, the blktap2 in-tree has bitrotted. Many years ago the XenServer team at Citrix forked the code into a separate repository; several attempts have been made to upstream those changes back into Xen, to no avail. The blktap code at the moment is the only source of performant vhd format

[Xen-devel] [PATCH RFC v2 2/3] libxl: Port libxl_blktap2.c to blktap2.5 API.

This is code is in preparation for building against an external blktap tree. tap_ctl_find() has gone away, so in some cases we use tap_ctl_find_minor(), and in other cases we use a locally-reimplemented version of tap_ctl_find(). tap_ctl_create() has an extra three parameters, including a flags p

[Xen-devel] [PATCH RFC v2 1/3] tools: Remove in-tree blktap2

Remove and temporarily disable the in-tree blktap2 while we pivot to using an external blktap2 library. The reason for removing first is to be able to port libxl_blktap2.c to the upstream blktap2.5 API (which is incompatible with the in-tree bltkap) in a separate patch to the code linking the exte

Re: [Xen-devel] [xen-4.2-testing test] 50412: regressions - FAIL

>>> On 16.04.15 at 17:21, wrote: > Jan Beulich writes ("Re: [Xen-devel] [xen-4.2-testing test] 50412: > regressions - > FAIL"): >> On 15.04.15 at 21:09, wrote: >> > test-amd64-i386-pair 21 guest-migrate/src_host/dst_host fail REGR. vs. >> > 36512 >> > test-i386-i386-pair21 guest-migrat

Re: [Xen-devel] [v2] VMX: replace some plain numbers

> From: Li, Liang Z > Sent: Friday, April 17, 2015 4:50 AM > > ... making the code better document itself. No functional change > intended. > > Signed-off-by: Liang Li Acked-by: Kevin Tian > --- > xen/arch/x86/hvm/vmx/vmx.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [Xen-devel] [v2 11/11] p2m/ept: enable PML in p2m-ept for log-dirty

>>> On 15.04.15 at 09:03, wrote: > This patch firstly enables EPT A/D bits if PML is used, as PML depends on EPT > A/D bits to work. A bit is set for all present leaf p2m types, D bit is set > for > all writable types, except log-dirty type. I think the tying of "leaf" to the A bit part of the d

Re: [Xen-devel] [v2 10/11] log-dirty: refine common code to support PML

>>> On 15.04.15 at 09:03, wrote: > @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d, bool_t > log_global) > d->arch.paging.mode |= PG_log_dirty; > paging_unlock(d); > > +/* enable hardware-assisted log-dirty if it is supported */ > +p2m_enable_hardware_lo

Re: [Xen-devel] [RFC][PATCH 06/13] xen:vtd: create RMRR mapping

> From: Tim Deegan [mailto:t...@xen.org] > Sent: Thursday, April 16, 2015 11:16 PM > > Hi, > > At 17:21 +0800 on 10 Apr (1428686517), Tiejun Chen wrote: > > RMRR reserved regions must be setup in the pfn space with an identity > > mapping to reported mfn. However existing code has problem to setu

Re: [Xen-devel] [PATCH v5 p2 13/19] tools/libxl: Create a per-arch function to map IRQ to a domain

On Thu, 2015-04-16 at 16:26 +0100, Julien Grall wrote: > Hi Ian, > > On 16/04/2015 16:12, Ian Campbell wrote: > > Acked-by: Ian Campbell > > (as I did v4 with the typoes fixed) > > I wasn't sure if I could keep your ack because the function used to map > the IRQ wasn't the same on v4. I wouldn

Re: [Xen-devel] [RFC][PATCH 09/13] xen: enable XENMEM_set_memory_map in hvm

At 17:22 +0800 on 10 Apr (1428686520), Tiejun Chen wrote: > This patch enables XENMEM_set_memory_map in hvm. So we can use it to > setup the e820 mappings. > > Signed-off-by: Tiejun Chen Reviewed-by: Tim Deegan ___ Xen-devel mailing list Xen-devel@li

Re: [Xen-devel] [v2 06/11] vmx: add help functions to support PML

>>> On 15.04.15 at 09:03, wrote: > +int vmx_vcpu_enable_pml(struct vcpu *v) > +{ > +struct domain *d = v->domain; > + > +if ( vmx_vcpu_pml_enabled(v) ) > +return 0; > + > +v->arch.hvm_vmx.pml_pg = d->arch.paging.alloc_page(d); So you latch v->domain into d for this invocation,

Re: [Xen-devel] [RFC][PATCH 07/13] xen/passthrough: extend hypercall to support rdm reservation policy

Hi, At 17:21 +0800 on 10 Apr (1428686518), Tiejun Chen wrote: > +/* > + * In some cases, e.g. add a device to hwdomain, and remove a device from > + * user domain, 'try' is fine enough since this is always safe to hwdomain. > + */ > +#define XEN_DOMCTL_PCIDEV_RDM_DEFAULT XEN_DOMCTL_PCIDEV_RDM_TRY

Re: [Xen-devel] [RFC][PATCH 02/13] introduce XENMEM_reserved_device_memory_map

> From: Tim Deegan [mailto:t...@xen.org] > Sent: Thursday, April 16, 2015 11:24 PM > > At 16:10 +0100 on 16 Apr (1429200644), Jan Beulich wrote: > > >>> On 16.04.15 at 16:59, wrote: > > > At 17:21 +0800 on 10 Apr (1428686513), Tiejun Chen wrote: > > >> diff --git a/xen/include/public/memory.h b/x

Re: [Xen-devel] [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq

On Thu, 2015-04-16 at 16:20 +0100, Julien Grall wrote: > >> Concerning XSM, even if ARM is using one hypercall rather than 2, the > >> resulting check is nearly the same. > >> > >> XSM PHYSDEVOP_map_pirq: > >> 1) Check if the current domain can add resource to the domain > >> 2) Check if

Re: [Xen-devel] [PATCH 2/2] xen/arm: Make HAS_PCI compilable on ARM by adding place-holder code

On Mon, 2015-04-13 at 13:18 +0530, Manish Jaggi wrote: > uint8_t pci_conf_read8( > +uint32_t seg, uint32_t bus, uint32_t dev, uint32_t func, > +uint32_t reg) Shouldn't this (and the other functions) match the prototype in xen/pci.h, which is: uint8_t pci_conf_read8( unsigned int seg, u

Re: [Xen-devel] [v2 05/11] vmx: add new data structure member to support PML

>>> On 15.04.15 at 09:03, wrote: > --- a/xen/include/asm-x86/hvm/vmx/vmcs.h > +++ b/xen/include/asm-x86/hvm/vmx/vmcs.h > @@ -70,8 +70,12 @@ struct ept_data { > cpumask_var_t synced_mask; > }; > > +#define _VMX_DOMAIN_PML_ENABLED0 > +#define VMX_DOMAIN_PML_ENABLED (1ul << _VMX_DOMAI

Re: [Xen-devel] [PATCHv2 6/6] x86, arm: remove asm/spinlock.h from all architectures

>>> On 10.04.15 at 16:19, wrote: > Now that all architecture use a common ticket lock implementation for > spinlocks, remove the architecture specific byte lock implementations. > > Signed-off-by: David Vrabel > --- > xen/arch/arm/README.LinuxPrimitives | 28 --- > xen/include/as

Re: [Xen-devel] [PATCH 2/2] Update configure scripts by calling autogen

Stefano Stabellini writes ("[PATCH 2/2] Update configure scripts by calling autogen"): > I run ./autogen.sh and committed the result. This should be in the same patch as the source file updates (and there should be a note to the committer to ask them to do the autogen.sh run). Ian.

Re: [Xen-devel] [PATCH 0/2] Re-factoring passthrough/pci.c and adding place-holder code for ARM/PCI

On Tue, 2015-04-14 at 10:34 +0100, Stefano Stabellini wrote: > On Tue, 14 Apr 2015, Jaggi, Manish wrote: > > Hi Julien, > > > > From: Julien Grall > > Sent: Monday, April 13, 2015 3:49 PM > > To: Jaggi, Manish; xen Devel; Stefano Stabellini; Julien Grall; Ian > > Campbell; Kumar, Vijaya; prasun.k

Re: [Xen-devel] [PATCHv2 3/6] xen: generic xadd() for ticket locks

>>> On 10.04.15 at 16:19, wrote: > +#define xadd(ptr, v) generic_xaddl((ptr), (v)) I think it is at least confusing to call the thing xadd (looking to be size generic) and then expand to generic_xaddl (only supporting 32-bit operations), yet subsequently implementing a size-generic xadd() for x86

  1   2   3   >