>>> On 10.04.15 at 16:19, <david.vra...@citrix.com> wrote: > +#define xadd(ptr, v) generic_xaddl((ptr), (v))
I think it is at least confusing to call the thing xadd (looking to be size generic) and then expand to generic_xaddl (only supporting 32-bit operations), yet subsequently implementing a size-generic xadd() for x86. Plus the extra parentheses should be removed to not needlessly obfuscate things. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
