Re: [Xen-devel] [PATCH v1 00/47] mtrr/x86/drivers: bury MTRR

2015-03-20 Thread Andy Lutomirski
On Fri, Mar 20, 2015 at 4:17 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > When a system has PAT support enabled you don't need to be > using MTRRs. Andy had added arch_phys_wc_add() long ago to > help with this but not all drivers were converted over. We > have to take care to onl

[Xen-devel] [PATCH v1 47/47] mtrr: bury MTRR - unexport mtrr_add() and mtrr_del()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The crusade to replace mtrr_add() with architecture agnostic arch_phys_wc_add() is complete, this will ensure write-combining implementations (PAT on x86) is taken advantage instead of using MTRR. With the crusade done now, hide direct MTRR access for drivers. Cc: Sures

[Xen-devel] [PATCH v1 46/47] video: fbdev: gxt4500: use pci_ioremap_wc_bar() for framebuffer

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The driver doesn't use mtrr_add() or arch_phys_wc_add() but since we know the framebuffer is isolated already on an ioremap() we can take advantage of write combining for performance where possible. In this case there are a few motivations for this: a) Take advantage o

[Xen-devel] [PATCH v1 45/47] video: fbdev: geode gxfb: use ioremap_wc() for framebuffer

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The driver doesn't use mtrr_add() or arch_phys_wc_add() but since we know the framebuffer is isolated already on an ioremap() we can take advantage of write combining for performance where possible. In this case there are a few motivations for this: a) Take advantage o

[Xen-devel] [PATCH v1 44/47] video: fbdev: atmel_lcdfb: use ioremap_wc() for framebuffer

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The driver doesn't use mtrr_add() or arch_phys_wc_add() but since we know the framebuffer is isolated already on an ioremap() we can take advantage of write combining for performance where possible. In this case there are a few motivations for this: a) Take advantage o

[Xen-devel] [PATCH v1 43/47] video: fbdev: vt8623fb: use arch_phys_wc_add() and pci_iomap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [PATCH v1 42/47] video: fbdev: tdfxfb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [PATCH v1 41/47] video: fbdev: rivafb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [xen-4.4-testing test] 36527: tolerable FAIL - PUSHED

2015-03-20 Thread xen . org
flight 36527 xen-4.4-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36527/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-pair17 guest-migrate/src_host/dst_host fail like 36516 Tests which did not succee

[Xen-devel] [PATCH v1 40/47] video: fbdev: pm3fb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [PATCH v1 39/47] video: fbdev: pm2fb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [PATCH v1 38/47] video: fbdev: kyrofb: use arch_phys_wc_add() and pci_ioremap_wc_bar()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining

[Xen-devel] [PATCH v1 37/47] video: fbdev: i740fb: use arch_phys_wc_add() and pci_ioremap_wc_bar()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining

[Xen-devel] [PATCH v1 36/47] video: fbdev: i810: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The same area used for MTRR is used for the ioremap() area. Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that al

[Xen-devel] [PATCH v1 35/47] video: fbdev: aty: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining

[Xen-devel] [PATCH v1 34/47] video: fbdev: sisfb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [PATCH v1 33/47] video: fbdev: savagefb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [PATCH v1 32/47] video: fbdev: nvidia: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR and ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also en

[Xen-devel] [PATCH v1 31/47] video: fbdev: s3fb: use arch_phys_wc_add() and pci_iomap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

Re: [Xen-devel] [RFC PATCH v2 13/22] xen/arm: its: Add virtual ITS command support

2015-03-20 Thread Julien Grall
Hello Vijay, On 19/03/2015 14:38, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Add Virtual ITS command processing support to Virtual ITS driver. Also add API's to in physical ITS driver to send commands from Virtual ITS driver. In this patch, following are done -Physical ITS driver wi

[Xen-devel] [PATCH v1 30/47] video: fbdev: neofb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining

[Xen-devel] [PATCH v1 29/47] video: fbdev: matrox: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same ioremap()'d area for the MTRR. Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also

[Xen-devel] [PATCH v1 28/47] video: fbdev: intelfb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Although this driver gives the framebuffer layer a different size for the framebuffer it uses the entire aperture PCI BAR size for the MTRR. Since the framebuffer is included in that range and MTRR was used on the entire PCI BAR WC will have been preferred on that range

[Xen-devel] [PATCH v1 27/47] video: fbdev: gbefb: use arch_phys_wc_add() and devm_ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining

[Xen-devel] [PATCH v1 26/47] video: fbdev: gbefb: add missing mtrr_del() calls

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver never removed the MTRRs. Fix that. Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: Dave Airlie Cc: Antonino Daplas Cc: Jean-Christophe Plagniol-Villard Cc: To

[Xen-devel] [PATCH v1 25/47] video: fbdev: radeonfb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining

[Xen-devel] [PATCH v1 24/47] video: fbdev: arkfb: use arch_phys_wc_add() and pci_iomap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap'd area is requested as write-combining

[Xen-devel] [PATCH v1 23/47] staging: xgifb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The same area used for ioremap() is used for the MTRR area. Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that al

[Xen-devel] [PATCH v1 22/47] staging: sm750fb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The same area used for ioremap() is used for the MTRR area. Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that al

[Xen-devel] [PATCH v1 21/47] ethernet: myri10ge: use arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver already uses ioremap_wc() on the same range so when write-combining is available that will be used instead. Cc: Andy Lutomirski Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Hyong

[Xen-devel] [PATCH v1 20/47] mtrr: avoid ifdef'ery with phys_wc_to_mtrr_index()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There is only one user but since we're going to bury MTRR next out of access to drivers expose this last piece of API to drivers in a general fashion only needing io.h for access to helpers. Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Linus Torvalds

[Xen-devel] [PATCH v1 19/47] video: fbdev: vesafb: use arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap_wc(), if anything it just uses a smaller size in case MTRR reservation fails. ioremap_wc() API is already used to take advantage of architecture write-combining when available. Convert the driver from using the

[Xen-devel] [PATCH v1 18/47] vidoe: fbdev: vesafb: add missing mtrr_del() for added MTRR

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The MTRR added was never being deleted. Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: Dave Airlie Cc: Antonino Daplas Cc: Jean-Christophe Plagniol-Villard Cc: Tomi Valk

[Xen-devel] [PATCH v1 17/47] video: fbdev: vesafb: only support MTRR_TYPE_WRCOMB

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" No other video driver uses MTRR types except for MTRR_TYPE_WRCOMB, the other MTRR types were implemented and supported here but with no real good reason. The ioremap() APIs are architecture agnostic and at least on x86 PAT is a new design that extends MTRRs and can repla

[Xen-devel] [PATCH v1 16/47] fusion: use __arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" If and when this gets enabled the driver should address using ioremap_wc() on the same area, that could require a bit of work as it would mean a split with two ioremap'd areas. Annotate this. Cc: Andy Lutomirski Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Moln

[Xen-devel] [PATCH v1 15/47] [media] media: ivtv: use __arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Sadly this driver requires a bit of work in order to use ioremap_wc() on the range currently used for MTRR write-combining. We'd need to ensure two ioremap() calls are done. Annotate this. Cc: Andy Lutomirski Cc: Andy Walls Cc: Suresh Siddha Cc: Venkatesh Pallipadi

Re: [Xen-devel] [PATCH v1 09/47] vidoe: fbdev: atyfb: remove and fix MTRR MMIO "hole" work around

2015-03-20 Thread Andy Lutomirski
On Fri, Mar 20, 2015 at 4:17 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > The atyfb driver uses an MTRR work around since some > cards use the same PCI BAR for the framebuffer and MMIO. > In such cards the last page is used for MMIO, the rest for > the framebuffer, so on those car

[Xen-devel] [rumpuserxen test] 36570: regressions - FAIL

2015-03-20 Thread xen . org
flight 36570 rumpuserxen real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36570/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-rumpuserxen 5 rumpuserxen-build fail REGR. vs. 33866 build-i386-rumpuserxe

[Xen-devel] [PATCH v1 14/47] IB/ipath: use __arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver sadly does not have the MMIO registers and WC desired areas (PIO buffers in this case) properly split up and addressing a split is considerable work, as such this such requires using the __arch_phys_wc_add() call to ensure write combining is enforced using MT

Re: [Xen-devel] [PATCH v1 04/47] pci: add pci_ioremap_wc_bar()

2015-03-20 Thread Andy Lutomirski
On Fri, Mar 20, 2015 at 4:17 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This lets drivers take advanate of PAT when available. This > should help with the transition of converting video drivers over > to ioremap_wc() to help with the goal of eventually using > _PAGE_CACHE_UC ove

[Xen-devel] [PATCH v1 13/47] IB/ipath: add counting for MTRR

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There is no good reason not to, we eventually delete it as well. Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: Dave Airlie Cc: Antonino Daplas Cc: Jean-Christophe Plagni

Re: [Xen-devel] [PATCH v1 03/47] devres: add devm_ioremap_wc()

2015-03-20 Thread Andy Lutomirski
On Fri, Mar 20, 2015 at 4:17 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > We have devm_ioremap_nocache() but no devm_ioremap_wc() > so add that. This will be used later. > > Cc: Suresh Siddha > Cc: Venkatesh Pallipadi > Cc: Ingo Molnar > Cc: Thomas Gleixner > Cc: Juergen Gross

Re: [Xen-devel] [PATCH v1 06/47] mtrr: add __arch_phys_wc_add()

2015-03-20 Thread Andy Lutomirski
On Fri, Mar 20, 2015 at 4:17 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Ideally on systems using PAT we can expect a swift > transition away from MTRR. There can be a few exceptions > to this, one is where device drivers are known to exist > on PATs with errata, another situatio

[Xen-devel] [PATCH v1 12/47] IB/qib: use arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). Cc: Rickard Strandqvist Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: Roland Dreier Cc: Andy Lutomirski Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Mol

[Xen-devel] [PATCH v1 11/47] IB/qib: add acounting for MTRR

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There is no good reason not to, we eventually delete it as well. Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: Dave Airlie Cc: Antonino Daplas Cc: Jean-Christophe Plagni

[Xen-devel] [PATCH v1 10/47] video: fbdev: atyfb: use arch_phys_wc_add() and ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that

[Xen-devel] [PATCH v1 09/47] vidoe: fbdev: atyfb: remove and fix MTRR MMIO "hole" work around

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The atyfb driver uses an MTRR work around since some cards use the same PCI BAR for the framebuffer and MMIO. In such cards the last page is used for MMIO, the rest for the framebuffer, so on those cards we ioremap() the MMIO page alone, then again ioremap() the full fra

[Xen-devel] [PATCH v1 08/47] video: fbdev: atyfb: clarify ioremap() base and length used

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This has no functional changes, it just adjusts the ioremap() call for the framebuffer to use the same values we later use for the framebuffer, this will make it easier to review the next change. The size of the framebuffer varies but since this is for PCI we *know* thi

[Xen-devel] [PATCH v1 07/47] video: fbdev: atyfb: move framebuffer length fudging to helper

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The size of the framebuffer to be used needs to be fudged to account for the different type of devices that are out there. This captures what is required to do well, we'll resuse this later. This has no functional changes. Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc

[Xen-devel] [PATCH v1 06/47] mtrr: add __arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Ideally on systems using PAT we can expect a swift transition away from MTRR. There can be a few exceptions to this, one is where device drivers are known to exist on PATs with errata, another situation is observed on old device drivers where devices had combined MMIO re

[Xen-devel] [PATCH v1 05/47] pci: add pci_iomap_wc() variants

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This allows drivers to take advantage of write-combining when possible. Ideally we'd have pci_read_bases() just peg an IORESOURCE_WC flag for us but where exactly video devices memory lie varies *largely* and at times things are mixed with MMIO registers, sometimes we ca

[Xen-devel] [PATCH v1 04/47] pci: add pci_ioremap_wc_bar()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This lets drivers take advanate of PAT when available. This should help with the transition of converting video drivers over to ioremap_wc() to help with the goal of eventually using _PAGE_CACHE_UC over _PAGE_CACHE_UC_MINUS on x86 on ioremap_nocache() (de33c442e) Cc: Su

[Xen-devel] [PATCH v1 03/47] devres: add devm_ioremap_wc()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We have devm_ioremap_nocache() but no devm_ioremap_wc() so add that. This will be used later. Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: Dave Airlie Cc: Antonino Dapla

[Xen-devel] [PATCH v1 02/47] x86: mtrr: generalize run time disabling of MTRR

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" It is possible to enable CONFIG_MTRR and up with it disabled at run time and yet CONFIG_X86_PAT continues to kick through fully functionally. This can happen for instance on Xen where MTRR is not supported but PAT is, this can happen now on Linux as of commit 47591df50 b

[Xen-devel] [PATCH v1 01/47] x86: mtrr: annotate mtrr_type_lookup() is only implemented on generic_mtrr_ops

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There area few users of mtrr_type_lookup(), including PAT. Note that PAT can be in theory enabled without MTRR fully kicking in, such is the case with Xen. Cc: Andy Lutomirski Cc: Suresh Siddha Cc: Venkatesh Pallipadi Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen

[Xen-devel] [PATCH v1 00/47] mtrr/x86/drivers: bury MTRR

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" When a system has PAT support enabled you don't need to be using MTRRs. Andy had added arch_phys_wc_add() long ago to help with this but not all drivers were converted over. We have to take care to only convert drivers where we know that the proper ioremap_wc() API has b

[Xen-devel] [PATCH] libxl: fix dom0 balloon logic

2015-03-20 Thread Jim Fehlig
Recent testing on large memory systems revealed a bug in the Xen xl tool's freemem() function. When autoballooning is enabled, freemem() is used to ensure enough memory is available to start a domain, ballooning dom0 if necessary. When ballooning large amounts of memory from dom0, freemem() would

Re: [Xen-devel] [PATCH v5 5/8] sysctl: Add sysctl interface for querying PCI topology

2015-03-20 Thread Boris Ostrovsky
On 03/20/2015 12:26 PM, Jan Beulich wrote: On 19.03.15 at 22:54, wrote: --- a/xen/common/sysctl.c +++ b/xen/common/sysctl.c @@ -399,6 +399,67 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) u_sysctl) break; #endif +#ifdef HAS_PCI +case XEN_SYSCTL_pcitopoinfo: +{

Re: [Xen-devel] Compliling Xen 4.5.0 Fails with error: ‘bufioreq_pfn’ may be used uninitialised in this function [-Werror=uninitialized]

2015-03-20 Thread Slutz, Donald Christopher
On 03/17/15 06:37, Ian Campbell wrote: > On Tue, 2015-03-17 at 00:10 +, Slutz, Donald Christopher wrote: >> @@ -715,7 +715,7 @@ static int hvm_ioreq_server_map_pages(struct >> hvm_ioreq_server *s, >>bool_t is_default, bool_t >> handle_bufioreq) >> { >>

Re: [Xen-devel] [PATCH v4 00/33] xen/arm: Add support for non-PCI passthrough

2015-03-20 Thread Julien Grall
On 20/03/2015 01:22, Edgar E. Iglesias wrote: Hi Julien, Hello Edgar, The partial device-tree support is nice and very flexible. I couldn't help thinking that it would be nice to be able to describe more of the guest with device-trees. It may be controversial but it would be cool to be able t

[Xen-devel] [PATCH 2/5] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-03-20 Thread Olaf Hering
It is already used in the runlevel script and the service file. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 1 file changed, 8 insertions(+) diff --git a/tools/hotplug/Linu

[Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-20 Thread Olaf Hering
An increasing version and/or release number helps to update existing packages without --force as in "rpm Uvh --force xen.rpm". Instead its possible to do "rpm -Fvh *.rpm" to update only already installed packages. The usage of --force disables essentials checks such as file conflict detection. As

[Xen-devel] [PATCH 0/5] tools: various changes

2015-03-20 Thread Olaf Hering
The following series is a resend of changes I already sent earlier this year: * Not sure if the last discussion about mkrpm was a yes or no for inclusion. I find rpm -U --force dist/xen.rpm cumbersome... * The XENSTORED_ARGS= should be fine according to IanJ * The changes for reproducible buil

[Xen-devel] [PATCH 3/5] INSTALL: mention variables for reproducible builds

2015-03-20 Thread Olaf Hering
Mention two variables introduced by commit ac977f5 ("use more fixed strings to build the hypervisor"). Signed-off-by: Olaf Hering Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- INSTALL | 6 ++ 1 file changed, 6 insertions(+) diff --git a/INSTALL b/I

[Xen-devel] [PATCH 5/5] hvmloader: add knob for fixed VGABIOS date string

2015-03-20 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable VGABIOS_REL_DATE="dd Mon " to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu

[Xen-devel] [PATCH 4/5] hvmloader: add knob for fixed SMBIOS date string

2015-03-20 Thread Olaf Hering
To allow reproducible builds of hvmloader introduce a make variable SMBIOS_REL_DATE=mm/dd/ to provide a fixed date string. Without this change the hvmloader binary changes with every rebuild. Signed-off-by: Olaf Hering Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper Cc: Ian Jackson Cc:

Re: [Xen-devel] [PATCH v2 4/7] x86: add support for COS/CBM manangement

2015-03-20 Thread Jan Beulich
>>> On 19.03.15 at 11:41, wrote: > +static unsigned int get_socket_cpu(unsigned int socket) > +{ > +unsigned int cpu; > + > +for_each_online_cpu ( cpu ) > + if ( cpu_to_socket(cpu) == socket ) > + return cpu; > +return nr_cpu_ids; > +} This can be a rather long loop fo

Re: [Xen-devel] [PATCH v3 0/3] Xen/FLASK policy updates for device contexts

2015-03-20 Thread Richard Haines
I've been testing this and found a few problems: 1) I could not read a policy with sedispol (in the checkpolicy/test directory)     when the devicetreecon statement was included (checkpolicy built ok).     I've attached a patch that fixes this problem and included CIL Ref Guide    updates for the

Re: [Xen-devel] [PATCH] tools/libxl: Restore errnoval behavior for datacopier callback

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 16:04 +, Ross Lagerwall wrote: > 6d896e1357ff ("tools/libxl: Extend datacopier to support reading into a > buffer") changed the semantics of the errnoval parameter for the datacopier > callback without updating all callers. Restore the original behavior for now. > > Sign

Re: [Xen-devel] [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 11:45 -0400, Konrad Rzeszutek Wilk wrote: > From 45bd7cd377b0b8364757cc2bc0bd8d6a13523a97 Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk > Date: Fri, 13 Mar 2015 14:57:44 -0400 > Subject: [PATCH] libxc: Check xc_domain_maximum_gpfn for negative return > values > > I

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 17:44 +0100, Olaf Hering wrote: > + ("dev", Struct(None, [("m", libxl_vscsi_hctl)])), > + ("wwn", Struct(None, [("m", string)])), > + ("hctl", Struct(None, [("m", libxl_vscsi_hctl)])), > > Aside: What is the difference between dev and hctl in this cont

Re: [Xen-devel] [PATCH v2 3/7] x86: detect and initialize Intel CAT feature

2015-03-20 Thread Jan Beulich
>>> On 19.03.15 at 11:41, wrote: > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -1090,9 +1090,9 @@ This option can be specified more than once (up to 8 > times at present). > > `= ` > > ### psr (Intel) > -> `= List of ( cmt: | rmid_max: )` > +> `=

Re: [Xen-devel] [PATCH v2] xen-netback: making the bandwidth limiter runtime settable

2015-03-20 Thread David Miller
From: Imre Palik Date: Thu, 19 Mar 2015 11:05:42 +0100 > From: "Palik, Imre" > > With the current netback, the bandwidth limiter's parameters are only > settable during vif setup time. This patch register a watch on them, and > thus makes them runtime changeable. > > When the watch fires, the

Re: [Xen-devel] [PATCH v2 1/7] x86: clean up psr boot parameter parsing

2015-03-20 Thread Jan Beulich
>>> On 19.03.15 at 11:41, wrote: > +static void __init parse_psr_bool(char* s, char* value, char* feature, int > bit) > +{ > +if ( !strcmp(s, feature) ) > +{ > +if ( !value ) > +opt_psr |= bit; > +else > +{ > +int val_int = parse_bool(value)

Re: [Xen-devel] [RFC PATCH v2 12/22] xen/arm: its: Update irq descriptor for LPIs support

2015-03-20 Thread Julien Grall
Hello Vijay, On 19/03/2015 14:37, vijay.kil...@gmail.com wrote: diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h index 435dfcd..f091739 100644 --- a/xen/include/asm-arm/irq.h +++ b/xen/include/asm-arm/irq.h @@ -17,6 +17,8 @@ struct arch_pirq struct arch_irq_desc { int e

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-20 Thread Olaf Hering
On Fri, Mar 20, Ian Campbell wrote: > The name at (*) must be the enum member, which I've duplicated at (**) > but you might like to thing about whether (**) would have a better name > in the context of e.g. vscsi_dev->u.dev.dev or vscsi_dev->u.wwn.wwn. Thanks Ian. For some reason I have ocaml di

Re: [Xen-devel] [PATCH v3 5/5] Revert "x86/hvm: wait for at least one ioreq server to be enabled"

2015-03-20 Thread Jan Beulich
>>> On 20.03.15 at 17:19, wrote: > This reverts commit dd748d128d86996592afafea02e578cc7d4e6d42. > > We don't need this workaround anymore since we have fixed the toolstack > interlock problem that affects stubdom. > > Signed-off-by: Wei Liu > Cc: Jan Beulich > Cc: Andrew Cooper > Acked-by: I

Re: [Xen-devel] [RFC PATCH v2 10/22] xen/arm: Add helper function to get domain page

2015-03-20 Thread Julien Grall
Hello Vijay, On 19/03/2015 14:37, vijay.kil...@gmail.com wrote: +struct page_info *get_page_from_paddr(struct domain *d, paddr_t paddr, + unsigned long flags) +{ +struct p2m_domain *p2m = &d->arch.p2m; +struct page_info *page = NULL; + +ASSERT(d =

[Xen-devel] [PATCH v3 2/5] libxl: remove device model path in libxl__device_model_destroy

2015-03-20 Thread Wei Liu
... and not devices_destroy_cb because it is the right place to clean up device model stuff. And the path should use LIBXL_TOOLSTACK_DOMID instead of hardcoded 0. Signed-off-by: Wei Liu Acked-by: Ian Campbell --- Changes in v2: 1. Use helper function to generate xenstore path. --- tools/libxl/

[Xen-devel] [PATCH v3 5/5] Revert "x86/hvm: wait for at least one ioreq server to be enabled"

2015-03-20 Thread Wei Liu
This reverts commit dd748d128d86996592afafea02e578cc7d4e6d42. We don't need this workaround anymore since we have fixed the toolstack interlock problem that affects stubdom. Signed-off-by: Wei Liu Cc: Jan Beulich Cc: Andrew Cooper Acked-by: Ian Campbell --- xen/arch/x86/hvm/hvm.c |

[Xen-devel] [PATCH v3 0/5] Fix QEMU startup protocol

2015-03-20 Thread Wei Liu
This patch series tries to reason about various hardcoded "/local/domain/0" in libxl and 1) replace them with something sensible, 2) fix QEMU startup protocol. Please apply a patch to QEMU traditional first, squash the update to Config.mk into "libxl: use new QEMU xenstore protocol" to keep the tr

[Xen-devel] [PATCH v3 3/5] libxl: use LIBXL_TOOLSTACK_DOMID

2015-03-20 Thread Wei Liu
The function in question is libxl__spawn_local_dm. We should use LIBXL_TOOLSTACK_DOMID when constructing xenstore path. Currently LIBXL_TOOLSTACK_DOMID is 0, so this patch introduces no functional change. Use helper function to generate xenstore path. Signed-off-by: Wei Liu Acked-by: Ian Campbe

[Xen-devel] [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path

2015-03-20 Thread Wei Liu
Factor out libxl__vsprintf. Use it to implement libxl__device_model_xs_patch helper to return xenstore path for device model to avoid handcoded paths. Signed-off-by: Wei Liu --- Changes in v3: 1. Factor out libxl__vsprintf. --- tools/libxl/libxl_internal.c | 40 ++

[Xen-devel] [PATCH v3 4/5] libxl: use new QEMU xenstore protocol

2015-03-20 Thread Wei Liu
Originally both QEMU traditional and QEMU upstream used hardcoded /local/domain/0 paths. This patch changes the protocol to use /local/domain/$dm_domid path. For QEMU traditional and upstream without stubdom, $dm_domid is 0 so the path is in fact still /local/domain/0. For QEMU traditional stubdo

[Xen-devel] [PATCH 2/2] x86/vMSI-X: add valid bits for read acceleration

2015-03-20 Thread Jan Beulich
Again because Xen doesn't get to see all guest writes, it shouldn't serve reads from its cache before having seen a write to the respective address. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -153,12 +153,15 @@ struct msixtbl_entry /* TODO: res

[Xen-devel] [PATCH 1/2] x86/vMSI-X: honor all mask requests

2015-03-20 Thread Jan Beulich
Commit 74fd0036de ("x86: properly handle MSI-X unmask operation from guests") didn't go far enough: it fixed an issue with unmasking, but left an issue with masking in place: Due to the (late) point in time when qemu requests the hypervisor to set up MSI-X interrupts (which is where the MMIO interc

Re: [Xen-devel] [PATCH v5 5/8] sysctl: Add sysctl interface for querying PCI topology

2015-03-20 Thread Jan Beulich
>>> On 19.03.15 at 22:54, wrote: > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -399,6 +399,67 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) > u_sysctl) > break; > #endif > > +#ifdef HAS_PCI > +case XEN_SYSCTL_pcitopoinfo: > +{ > +xen_sysctl_pcit

Re: [Xen-devel] [RFC PATCH v2 00/22] xen/arm: Add ITS support

2015-03-20 Thread Julien Grall
Hi Vijay, On 19/03/2015 14:37, vijay.kil...@gmail.com wrote: From: Vijaya Kumar K Add ITS support for arm. Following major features are supported - GICv3 ITS support for arm64 platform - Supports multi ITS node - LPI descriptors are allocated on-demand - Only ITS Dom0 is supported Tes

Re: [Xen-devel] [PATCH v5 4/8] sysctl: Make XEN_SYSCTL_numainfo a little more efficient

2015-03-20 Thread Jan Beulich
>>> On 19.03.15 at 22:54, wrote: > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -274,53 +274,62 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xen_sysctl_t) > u_sysctl) > > case XEN_SYSCTL_numainfo: > { > -uint32_t i, j, max_node_index, last_online_node; > +uin

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 16:02 +, Ross Lagerwall wrote: > On 03/20/2015 11:15 AM, Ian Campbell wrote: > > On Fri, 2015-03-20 at 11:03 +, Ian Campbell wrote: > >> Do the new callers actually need the number of bytes read/written or was > >> this just something which seemed like a good idea sinc

Re: [Xen-devel] [PATCH 3/3] libxl: Domain destroy: fork

2015-03-20 Thread Ian Campbell
On Fri, 2015-03-20 at 09:14 -0600, Jim Fehlig wrote: > Ian Campbell wrote: > > On Tue, 2015-03-17 at 09:30 -0600, Jim Fehlig wrote: > > > >> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > >> index b6541d4..b43db1a 100644 > >> --- a/tools/libxl/libxl.c > >> +++ b/tools/libxl/libxl.c > >

[Xen-devel] [PATCH] tools/libxl: Restore errnoval behavior for datacopier callback

2015-03-20 Thread Ross Lagerwall
6d896e1357ff ("tools/libxl: Extend datacopier to support reading into a buffer") changed the semantics of the errnoval parameter for the datacopier callback without updating all callers. Restore the original behavior for now. Signed-off-by: Ross Lagerwall --- tools/libxl/libxl_aoutils.c | 2 +-

Re: [Xen-devel] [PATCH] tools/libxl: Fix the errno

2015-03-20 Thread Ross Lagerwall
On 03/20/2015 11:15 AM, Ian Campbell wrote: On Fri, 2015-03-20 at 11:03 +, Ian Campbell wrote: Do the new callers actually need the number of bytes read/written or was this just something which seemed like a good idea since it was in hand? If it isn't needed In fact, irrespective of the n

[Xen-devel] [PATCH 0/2] x86/vMSI-X: table read/write emulation adjustments

2015-03-20 Thread Jan Beulich
Due to the (late) point in time when qemu requests the hypervisor to set up MSI-X interrupts (which is where the MMIO intercept gets put in place), the hypervisor doesn't see all guest writes, and hence shouldn't make assumptions on the state the virtual MSI-X resources are in. 1: honor all mask r

Re: [Xen-devel] [PATCH v2 08/13] libxc: Check xc_domain_maximum_gpfn for negative return values

2015-03-20 Thread Konrad Rzeszutek Wilk
> > All of them are > > > > git://xenbits.xen.org/people/konradwilk/xen.git xc_cleanup.v4 ..snip.. > Looks good, only one minor comment: > [...] > > > -*gpfn = (xen_pfn_t)rc + 1; > > Perhaps the new parameter to xc_domain_maximum_gpfn should be a > xen_pfn_t? > Here you go. They are at:

[Xen-devel] [PATCH] x86: don't change affinity with interrupt unmasked

2015-03-20 Thread Jan Beulich
With ->startup unmasking the IRQ, setting the affinity afterwards without masking the IRQ again is invalid namely for MSI (which can't have their affinity updated atomically). Signed-off-by: Jan Beulich --- Changing the affinity of non-maskable MSI IRQs seems bogus too, but I can't immediately se

Re: [Xen-devel] [PATCH v2 2/4] x86: allow 64-bit PV guest kernels to suppress user mode exposure of M2P

2015-03-20 Thread Tim Deegan
At 15:22 + on 20 Mar (1426864937), Jan Beulich wrote: > Xen L4 entries being uniformly installed into any L4 table and 64-bit > PV kernels running in ring 3 means that user mode was able to see the > read-only M2P presented by Xen to the guests. While apparently not > really representing an exp

Re: [Xen-devel] [PATCH] xen/passthrough: Support a single iommu_domain(context bank) per xen domain per SMMU

2015-03-20 Thread Julien Grall
On 20/03/2015 13:56, Robert VanVossen wrote: xen/drivers/passthrough/arm/smmu.c | 113 1 file changed, 88 insertions(+), 25 deletions(-) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index a7a7da9..9b46054 100

Re: [Xen-devel] [PATCH v2 1/4] vm?assist: prepare for discontiguous used bit numbers

2015-03-20 Thread Tim Deegan
Hi, At 15:21 + on 20 Mar (1426864897), Jan Beulich wrote: > --- a/xen/include/asm-x86/config.h > +++ b/xen/include/asm-x86/config.h > @@ -343,6 +343,15 @@ extern unsigned long xen_phys_start; > #define ARG_XLAT_START(v)\ > (ARG_XLAT_VIRT_START + ((v)->vcpu_id << ARG_XLAT_VA_SHIFT

Re: [Xen-devel] [libvirt] [PATCH 00/10] libxl: switch driver to use a single libxl_ctx

2015-03-20 Thread Michal Privoznik
On 18.02.2015 04:56, Jim Fehlig wrote: > This series is a follow up to > > https://www.redhat.com/archives/libvir-list/2015-February/msg00024.html > > It goes a step further and changes the libxl driver to use one, > driver-wide libxl_ctx. Currently the libxl driver has one driver-wide > ctx for

  1   2   3   >