[Wormux-dev] [PATCH 00/26] Patch set fixing network issues.

Hello wormux developers, this small patch set address fix all network related bugs I know off. The first two patches, which add key combo support, have nothing to do with the other patches except that they are required. I haven't tested the patches in a real network game, but only in local ones.

[Wormux-dev] [PATCH 10/26] Drop the same box type for all players.

--- src/game/game.cpp |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/game/game.cpp b/src/game/game.cpp index 4935674..64d7325 100644 --- a/src/game/game.cpp +++ b/src/game/game.cpp @@ -581,7 +581,8 @@ bool Game::NewBox() // Type of box : 1 = MedKit, 2 = Bonus Box

[Wormux-dev] [PATCH 06/26] Remove unnecessary and wrongly implemented re-synchronization.

--- src/game/game.cpp |2 -- src/include/action_handler.cpp |4 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/game/game.cpp b/src/game/game.cpp index 065b129..480a5da 100644 --- a/src/game/game.cpp +++ b/src/game/game.cpp @@ -651,8 +651,6 @@ void Game

[Wormux-dev] [PATCH 08/26] Ensure that the directions in which the characters look are the same for each member of a network game.

--- src/character/character.cpp |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/character/character.cpp b/src/character/character.cpp index f6ffdb8..37aac08 100644 --- a/src/character/character.cpp +++ b/src/character/character.cpp @@ -94,7 +94,8 @@ void Character::S

[Wormux-dev] [PATCH 01/26] Add support for key combos.

--- src/interface/keyboard.cpp | 193 +-- src/interface/keyboard.h|6 + src/interface/man_machine_interface.cpp | 179 +++-- src/interface/man_machine_interface.h | 55 +++-- 4 files changed, 299 inserti

[Wormux-dev] [PATCH 09/26] Drop the boxes at the same times for all players.

--- src/game/game.cpp |7 --- src/game/game_blitz.cpp |2 +- src/game/game_classic.cpp |2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/game/game.cpp b/src/game/game.cpp index 480a5da..4935674 100644 --- a/src/game/game.cpp +++ b/src/game/game.cpp

[Wormux-dev] [PATCH 07/26] Add some random.get debug messages.

Those help to find out what request the random numbers and if you know that then you know where the differences are between turn master and non turn master. --- src/ai/ai_shoot_module.cpp |2 ++ src/graphic/polygon.cpp | 10 -- src/network/randomsync.cpp |7 +++ src/ob

[Wormux-dev] [PATCH 04/26] Reduce the time difference between turn master and non turn masters.

When receiving a ping a non turn master knows that there were no further actions and can continue the game. --- src/game/game.cpp | 10 +- src/game/game.h |3 +++ 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/src/game/game.cpp b/src/game/game.cpp index 70df1d8..e

[Wormux-dev] [PATCH 03/26] Don't continue the game if there could be outstanding actions.

Why is it necessary? Extreme example: The game time is 59,9 seconds and the turn master orders the character to jump in oder to save him from the water which will increase in 0.1 seconds. It's important that the non turn master does not continue the game to the 60th game second, if it hasn't re

[Wormux-dev] [PATCH 05/26] Don't hide bugs with synchronization.

--- lib/wormux/include/WORMUX_action.h |7 -- src/ai/ai_movement_module.cpp |2 +- src/character/character.cpp | 169 +-- src/character/character.h | 10 -- src/game/game.cpp | 31 +- src/in

[Wormux-dev] [PATCH 19/26] Send always an end of frame notification to the non turn masters.

The aim of this patch is to reduce the time difference between players. Additionally it should make it possible to remove the switch team notification. The patch increase the network traffic, however it's not the bad as it looks at the first glance: Previously at least every 100ms an action was s

[Wormux-dev] [PATCH 12/26] Set the same wind strength for all players.

--- src/game/game_blitz.cpp |3 +-- src/game/game_classic.cpp |3 +-- src/map/wind.cpp |4 +++- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/game/game_blitz.cpp b/src/game/game_blitz.cpp index ff146b3..71a0321 100644 --- a/src/game/game_blitz.cpp +++ b/

[Wormux-dev] [PATCH 11/26] Drop the same box content for all players.

--- src/object/bonus_box.cpp |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/object/bonus_box.cpp b/src/object/bonus_box.cpp index 320bac0..29317b5 100644 --- a/src/object/bonus_box.cpp +++ b/src/object/bonus_box.cpp @@ -60,7 +60,8 @@ void BonusBox::PickRandomWeapon(

[Wormux-dev] [PATCH 14/26] Generate the same particles for all players.

--- src/particles/body_member.cpp |9 ++--- src/particles/explosion_smoke.cpp |5 +++-- src/particles/fire.cpp| 10 -- src/particles/ill_bubble.cpp |6 -- src/particles/magic_star.cpp |5 +++-- src/particles/particle.cpp| 21 +++

[Wormux-dev] [PATCH 13/26] Drop the box at the same location for all players.

--- src/game/game.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/game/game.cpp b/src/game/game.cpp index 64d7325..1151dee 100644 --- a/src/game/game.cpp +++ b/src/game/game.cpp @@ -591,7 +591,7 @@ bool Game::NewBox() } // Randomize container box->Randomi

[Wormux-dev] [PATCH 17/26] Don't send ACTION_GAMELOOP_SET_STATE.

Previous to this patch remote characters don't drop dynamites and grenades. This bug occurred from time to time previous to the last patch and occurred constantly since the last patch. Additionally this patch makes the code simpler and reduce the network traffic. --- lib/wormux/include/WORMUX_ac

[Wormux-dev] [PATCH 18/26] Transfer fire angle changes over the network.

--- lib/wormux/include/WORMUX_action.h |4 + src/character/character.cpp| 116 ++-- src/character/character.h | 21 +-- src/include/action_handler.cpp | 32 ++ 4 files changed, 149 insertions(+), 24 deletions(-) diff --git

[Wormux-dev] [PATCH 20/26] Don't send ACTION_GAMELOOP_NEXT_TEAM.

This patch fix the issue that characters continue to walk for one player when the character was walking at the end of the turn. It also reduces network traffic and makes the code simpler. --- lib/wormux/include/WORMUX_action.h |1 - src/game/game_blitz.cpp| 16 ++--

[Wormux-dev] [PATCH 21/26] Add methods to share weapon movements over the network.

--- lib/wormux/include/WORMUX_action.h |9 + src/include/action_handler.cpp | 48 ++ src/weapon/weapon.cpp | 65 src/weapon/weapon.h| 24 + 4 files changed, 146 insertions(+), 0

[Wormux-dev] [PATCH 23/26] Don't transfer grapple reactions to movements over the network.

--- lib/wormux/include/WORMUX_action.h |1 - src/include/action_handler.cpp | 40 src/weapon/grapple.cpp | 32 +--- 3 files changed, 2 insertions(+), 71 deletions(-) diff --git a/lib/wormux/include/WORMUX_action.

[Wormux-dev] [PATCH 22/26] Transfer grapple movements over the network.

--- src/weapon/grapple.cpp | 100 ++-- src/weapon/grapple.h | 16 2 files changed, 96 insertions(+), 20 deletions(-) diff --git a/src/weapon/grapple.cpp b/src/weapon/grapple.cpp index 6d0c73e..e2e952b 100644 --- a/src/weapon/grapple.cpp ++

[Wormux-dev] [PATCH 26/26] Fix some network issues by drawing with 10 frames per second in network games.

Games could get out of sync at footbomb and grapple usage. It looks like these weapons require that all network participants draw after the same physic frames. A better physics engine may fix the issues with these weapons and make this workaround superfluous. --- src/game/game.cpp | 31 ++

[Wormux-dev] [PATCH 24/26] Make jetpack working.

This patch fix issues the jetpack had with the new way characters are moving. This patch also makes jetpack working over the network and improves the way how jetpack works. You can now for example release the left and right arrow key without stop flying upwards. --- src/character/character.cpp |

[Wormux-dev] [PATCH 25/26] Make parachute working over network.

--- src/weapon/parachute.cpp | 66 +++--- src/weapon/parachute.h |8 - 2 files changed, 10 insertions(+), 64 deletions(-) diff --git a/src/weapon/parachute.cpp b/src/weapon/parachute.cpp index 304fb23..2cbfe52 100644 --- a/src/weapon/parachute.c

[Wormux-dev] [PATCH 15/26] Make character movements transferable over network.

Previous this patch the character got moved by the HandleKeyRefreshed_Move* methods. Sending a character movement notification every frame would cause a lot of network traffic. This patch let the turn master only send two actions for a simple movement: One which starts the movement and one which

[Wormux-dev] [PATCH 16/26] Make character animation the same for all players.

This is important as the time when the character shoots depend on the shoot animation. --- src/character/body.cpp |5 +- src/character/character.cpp | 97 +++--- 2 files changed, 56 insertions(+), 46 deletions(-) diff --git a/src/character/body.cpp

Re: [Wormux-dev] [PATCH 00/26] Patch set fixing network issues.

Hi, thanks for all your patches! I will make a detailed review, I hope in the next few days! Of course, since the changes are heavy, they will *not* be included in Wormux 0.8.5 that is to be released in a little bit more than one week. Thanks again, Matt (gentildemon) Florian Köberle a écri