[Wireshark-dev] Wireshark and hardening flags

2015-09-24 Thread Bálint Réczey
Hi All, I have just created a review to add PIE when it is available to default flags: https://code.wireshark.org/review/#/c/10635 I think this matter is worth discussion here, too. Should we enable more compiler flags which make Wireshark more secure by default? I Debian I will enable all harde

Re: [Wireshark-dev] Master-2.0 reminder and Buildbot updates

2015-10-02 Thread Bálint Réczey
Hi Gerald, 2015-10-02 22:51 GMT+02:00 Gerald Combs : > As a quick reminder, the master-2.0 branch and builders will be created on > Monday. I've also made the following changes in our Buildbot environment: > > - Upgraded to Qt 5.3.2 on the Windows 64-bit, 32-bit, and Petri dish builders. > > - Ins

Re: [Wireshark-dev] GCC GTK3 Wireshark build warnings ?

2015-11-11 Thread Bálint Réczey
2015-11-11 22:10 GMT+04:00 Jeff Morriss : > On 11/11/15 12:28, Bill Meier wrote: >> >> When building GTK3 Wireshark on my Fedora system (after not having done >> so for a while), I'm getting many warnings similar to the following: >> >> >> CC libgtkui_a-about_dlg.o >> In file included from

Re: [Wireshark-dev] CMake: Disable building with QT ?

2015-11-14 Thread Bálint Réczey
Hi, To enable completion you also need the bash-completion package installed and sourced in your bash session. Sometimes the bash-completion package is missing in VM-s to save space, but on default Ubuntu Desktop it is installed and enabled. Bash-completion performs the completion part and uses t

Re: [Wireshark-dev] wiretap - using as a library rather than coupled with Wireshark?

2015-11-27 Thread Bálint Réczey
Hi Dario, You did not write the platforms you want to support, but in case it is just Ubuntu/Debian there are pre built wiretap headers and librerary for your consumption :-): https://packages.debian.org/unstable/libwiretap-dev It releasing the new software under GPL2+ we can integrate it to wire

Re: [Wireshark-dev] wiretap - using as a library rather than coupled with Wireshark?

2015-11-27 Thread Bálint Réczey
2015-11-27 9:45 GMT+01:00 Bálint Réczey : > Hi Dario, > > You did not write the platforms you want to support, but in case it is just > Ubuntu/Debian there are pre built wiretap headers and librerary for your > consumption :-): > https://packages.debian.org/unstable/libwiretap-de

Re: [Wireshark-dev] Moving codecs to libwireshark or libwsutil?

2015-12-03 Thread Bálint Réczey
2015-12-02 21:25 GMT+01:00 Pascal Quantin : > > > 2015-11-30 20:15 GMT+01:00 Guy Harris : >> >> >> On Nov 30, 2015, at 11:07 AM, Pascal Quantin >> wrote: >> >> >> > Yes I should have been clearer in my initial description. >> > My suggestion with an extra parameter giving the hash table address is

Re: [Wireshark-dev] -fPIC on Ubuntu Wily

2015-12-17 Thread Bálint Réczey
Hi All, I sadly became more and more convinced that starting the adoption of compiling with -fPIE was an overly optimistic move on my side. :-( It seems that there are too many integration corner cases to handle where -fPIE breaks and it may be a better idea to let the distribution-specific script

Re: [Wireshark-dev] UI Proposal for better Analysis for Android devices

2015-12-31 Thread Bálint Réczey
2015-12-31 0:10 GMT+01:00 Anders Broman : > > Den 30 dec 2015 17:01 skrev "Graham Bloice" : >> >> >> >> On 30 December 2015 at 10:52, VIKRAM VENKATESH HEGDE >> wrote: >>> >>> Hi, >>> >>> >>> >>> Sure, will submit the feature in patches may be will start doing so by >>> next week. >>> >>> Thanks fo

Re: [Wireshark-dev] Wireshark 2.01 packages in Ubuntu ppa

2016-01-10 Thread Bálint Réczey
Hi, 2016-01-09 16:40 GMT+01:00 Peter Wu : > Hi Bernard, > > On Thu, Jan 07, 2016 at 12:31:12PM -0500, bernard ck Wong wrote: >> I have installed wireshark2.01 from the wireshark stable ppa on Wily (64 >> bit) and wireshark-gtk crashes immediately. The errors are in attachment. >> The package for

Re: [Wireshark-dev] Wireshark 2.01 packages in Ubuntu ppa

2016-01-12 Thread Bálint Réczey
Hi Peter, 2016-01-13 1:11 GMT+01:00 Peter Wu : > On Sun, Jan 10, 2016 at 11:52:39AM +0100, Bálint Réczey wrote: >> Hi, >> >> 2016-01-09 16:40 GMT+01:00 Peter Wu : >> > Hi Bernard, >> > >> > On Thu, Jan 07, 2016 at 12:31:12PM -0500, bernard ck Wong

Re: [Wireshark-dev] Debian builds in wireshark

2016-04-25 Thread Bálint Réczey
Hi Born, 2016-04-25 19:46 GMT+02:00 Born In : > When I try to build an installer package for Ubuntu (Debian), I am asked > (per the INSTALL doc in the root folder) to execute: "dpkg-buildpackage -us > -uc -rfakeroot" before I use configure/make etc. > However, after I checkout the source, make the

Re: [Wireshark-dev] Debian builds in wireshark

2016-04-29 Thread Bálint Réczey
ake, thus it does not regenerate the code for the ASN.1 based dissectors. I have prepared a patch to change that which I will submit when gerrit accepts new changes again. Cheers, Balint > > Regards. > > > > On Monday, April 25, 2016 2:06 PM, Bálint Réczey > wrote: > > &g

Re: [Wireshark-dev] Debian builds in wireshark

2016-04-29 Thread Bálint Réczey
2016-04-29 11:12 GMT+02:00 Bálint Réczey : > Hi Born, > > 2016-04-25 21:30 GMT+02:00 Born In : >> Thanks Balint, >> Do you know if dpkg-buildpackage also builds the asn.1 structures inside >> epan/dissectors/asn1// (which is usually built by going into >> the s

[Wireshark-dev] Happy-shark or per-PDU regression tests

2016-06-16 Thread Bálint Réczey
Hi, With Dario and Peter we created a small regression test suit aiming at checking the dissection engine with very targeted tests. It compares specific PDU's PDML representation against stored references. You can find it on GitHub: https://github.com/wireshark/happy-shark Feel free to add your

Re: [Wireshark-dev] checklicenses.py

2016-09-23 Thread Bálint Réczey
Hi, 2016-08-05 23:31 GMT+02:00 Guy Harris : ... > > 'debian/rules' has non-whitelisted license 'UNKNOWN' > 'debian/copyright' has non-whitelisted license 'LGPL (v2 or later) > GPL (v2 or later) LGPL (v2 or later)' > 'debian/compat' has non-whitelisted license 'UNKNOWN' >

Re: [Wireshark-dev] unable to compile wireshark-2.0.1 on Ubuntu 14.04

2016-11-09 Thread Bálint Réczey
Hi, 2016-11-08 22:43 GMT+01:00 Vidya Dharmaraju : > Hi wireshark-dev, > > > > I am unable to compile wireshark 2 on Ubuntu 14.04 > > > > Need some quick help here – any clues, please share. > > > > Attached is the 1) config.log 2) Compile errors with make > > > > Steps followed: > > 1) > > sudo ap

Re: [Wireshark-dev] Segfault when running older Wireshark with capture from CVE-2013-4075

2016-11-11 Thread Bálint Réczey
2016-11-11 11:43 GMT+01:00 Guy Harris : > On Nov 11, 2016, at 1:59 AM, Anders Broman wrote: > >> https://wiki.wireshark.org/Development/LifeCycle >> >> Version Stable Release Date End of LifeNotes >> >> 1.8 June 21, 2012 June 21, 2014 Last release to support >> OS X

Re: [Wireshark-dev] Remove our bundled crypto library (in favor of Libgcrypt)?

2017-02-09 Thread Bálint Réczey
Hi Guy, 2017-02-08 19:51 GMT+01:00 Guy Harris : > On Feb 8, 2017, at 5:40 AM, Peter Wu wrote: > >> I did not expect Libgcrypt to consume entropy when it is just doing >> decryption. > > I'm concerned with consuming CPU and wall-clock time - i.e., slowing *shark > startup - not entropy. perf wou

Re: [Wireshark-dev] Remove our bundled crypto library (in favor of Libgcrypt)?

2017-02-09 Thread Bálint Réczey
Hi All, 2017-02-09 11:34 GMT+01:00 Bálint Réczey : > Hi Guy, > > 2017-02-08 19:51 GMT+01:00 Guy Harris : >> On Feb 8, 2017, at 5:40 AM, Peter Wu wrote: >> >>> I did not expect Libgcrypt to consume entropy when it is just doing >>> decryption. >> >&

Re: [Wireshark-dev] Remove our bundled crypto library (in favor of Libgcrypt)?

2017-02-11 Thread Bálint Réczey
Hi, 2017-02-11 22:44 GMT+01:00 Peter Wu : > On Sat, Feb 11, 2017 at 08:54:39PM +, João Valverde wrote: > [..] >> I think a small abstraction layer above the lower-level crypto routines, >> whatever those may be (libgcrypt, nettle, home-grown - yuck), would be a >> useful thing to have. It woul

[Wireshark-dev] Ubuntu PPAs

2017-03-13 Thread Bálint Réczey
Hi, I have created a separate PPA for backported dependencies of Wireshark: https://launchpad.net/~wireshark-dev/+archive/ubuntu/wireshark-deps This would help people running internal builds of Wireshark. (Hi Anders, sorry for the delay ;-)) I plan removing the dependencies from the wireshark-de

Re: [Wireshark-dev] Ubuntu PPAs

2017-03-14 Thread Bálint Réczey
2017-03-14 14:28 GMT+01:00 Peter Wu : > On Tue, Mar 14, 2017 at 12:29:24AM +0100, Bálint Réczey wrote: >> Hi, >> >> I have created a separate PPA for backported dependencies of Wireshark: >> https://launchpad.net/~wireshark-dev/+archive/ubuntu/wireshark-deps >>

[Wireshark-dev] Git tagging scheme

2019-03-03 Thread Bálint Réczey
Hi Gerald, I noticed that there is no wireshark-3.0.0 tag in the repository. Could you please create it? In the Debian package the debian/watch file monitors the wireshark-N.N.N tags for new releases. I found the establisted practice of tagging final releases as wireshark-.* and RC-s and similar

Re: [Wireshark-dev] G729

2020-12-08 Thread Bálint Réczey
Hi Jaap, Thanks for the heads up!: https://salsa.debian.org/debian/wireshark/-/commit/4f3b519334121ee8115f255d21c22f305e233cc2 Cheers, Balint Jaap Keuter ezt írta (időpont: 2020. dec. 7., H, 12:04): > > FYI, it seems to have finally happened, bcg729 has landed in Debian testing. > > ---8<--- >

Re: [Wireshark-dev] Debianbuild fails on Ubuntu 18.04

2021-10-21 Thread Bálint Réczey
Hi Anders, Anders Broman via Wireshark-dev ezt írta (időpont: 2021. okt. 20., Sze, 11:24): > > Hi, > > I can no longer create a debian package on Ubuntu 18.04... The build fails due to a debhelper bug. I've submitted the workaround at https://gitlab.com/wireshark/wireshark/-/merge_requests/4755

[Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-20 Thread Bálint Réczey
Hi All, João shared his opinion about the project's commitment to maintain stable shared library ABI within stable branches: https://gitlab.com/wireshark/wireshark/-/issues/17822 I believe the current practice is reasonable and beneficial enough for many parties to warrant the work, but I could b

Re: [Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-20 Thread Bálint Réczey
Hi Guy, Guy Harris ezt írta (időpont: 2022. jan. 20., Cs, 21:52): > > On Jan 20, 2022, at 12:34 PM, Gerald Combs wrote: > > > Q: Should *wsutil* be part of that stable ABI? > > > > Debian, Ubuntu and (according to rpmfind.net) OpenSuSE and Mageia treat it > > as such. It would be helpful to kno

Re: [Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-21 Thread Bálint Réczey
Hi João, João Valverde ezt írta (időpont: 2022. jan. 21., P, 1:14): > > > > On 20/01/22 12:41, Bálint Réczey wrote: > > Hi All, > > > > João shared his opinion about the project's commitment to maintain > > stable shared library ABI within stable b

Re: [Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-21 Thread Bálint Réczey
João Valverde ezt írta (időpont: 2022. jan. 21., P, 1:29): > > > > On 20/01/22 21:24, Bálint Réczey wrote: > > Hi Guy, > > > > Guy Harris ezt írta (időpont: 2022. jan. 20., Cs, > > 21:52): > >> On Jan 20, 2022, at 12:34 PM, Gerald Combs wrote:

Re: [Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-21 Thread Bálint Réczey
ted. Cheers, Balint > > kind regards > Roland > > Am Fr., 21. Jan. 2022 um 11:17 Uhr schrieb João Valverde : >> >> >> >> On 21/01/22 09:44, Bálint Réczey wrote: >> > Hi João, >> > >> > João Valverde ezt írta (időpont: 2022. jan. 21

Re: [Wireshark-dev] Future of Wireshark's shared library ABI stability

2022-01-21 Thread Bálint Réczey
João Valverde ezt írta (időpont: 2022. jan. 21., P, 11:17): > > > > On 21/01/22 09:44, Bálint Réczey wrote: > > Hi João, > > > > João Valverde ezt írta (időpont: 2022. jan. 21., P, 1:14): > >> > >> > >> On 20/01/22 12:41, Bálint Réczey

[Wireshark-dev] Future of Wireshark's Debian packaging scripts in the main repository

2023-11-21 Thread Bálint Réczey
Hi All, João shared his opinion about the project's commitment to maintain the packaging/debian/ in the project's repository: https://gitlab.com/wireshark/wireshark/-/commit/79da670bd1b4f91eebee5c96b19eaf1f33c94777#note_1656501952 I believe the current practice is reasonable and beneficial enoug

Re: [Wireshark-dev] Changes to the plugin registration API

2023-12-04 Thread Bálint Réczey
On 2023. Dec 4., Mon at 10:02, João Valverde wrote: > Hi, > > The GPL never allowed for that, as far as I know. See: > > https://www.gnu.org/licenses/gpl-faq.html#IfLibraryIsGPL > > In this case Wireshark is a library for plug-ins. > > What you can do is not distribute the (private-use) plug-in,

Re: [Wireshark-dev] Changes to the plugin registration API

2023-12-04 Thread Bálint Réczey
João Valverde ezt írta (időpont: 2023. dec. 4., H, 12:59): > > > > On 03/12/23 23:25, João Valverde wrote: > > Hi, > > > > There are some changes in progress to the plugin registration API that > > break compatibility and require manual intervention from plugin > > authors maintaining plugins out-

Re: [Wireshark-dev] Future of Wireshark's Debian packaging scripts in the main repository

2023-12-20 Thread Bálint Réczey
Hi, João Valverde ezt írta (időpont: 2023. nov. 27., H, 21:42): > > > > On 27/11/23 16:26, Jeff Morriss wrote: > > On Wed, Nov 22, 2023 at 11:54 AM João Valverde wrote: > > > > > > On 22/11/23 15:37, John Thacker wrote: > >> On Wed, Nov 22, 2023 at 9:40 AM João Valverde wrote: > >> > >>

Re: [Wireshark-dev] Changes to the plugin registration API

2023-12-20 Thread Bálint Réczey
ncially. I see that as mutually beneficial. I think we resolved the GPL question and there is no pressing need to check the plugins' license, it was just based on an unfortunate misunderstanding. Cheers, Balint > Just my 2 cents > > Roland > > Am Mo., 4. Dez. 2023 um 13:12

Re: [Wireshark-dev] Future of Wireshark's Debian packaging scripts in the main repository

2023-12-20 Thread Bálint Réczey
t I'm not one to skip a good technical >> discussion. >> >> I'm ignoring your other points on purpose, there is only so much I can >> handle in one sitting. >> >> On 20/12/23 13:24, Bálint Réczey wrote: >> > Having separate packages follows Debian p

Re: [Wireshark-dev] Future of Wireshark's Debian packaging scripts in the main repository

2023-12-21 Thread Bálint Réczey
Hi João, On 2023. Dec 21., Thu at 12:02, João Valverde wrote: > > On 20/12/23 23:20, Anders Broman wrote: > > Hi, > > To me it is a useful feature to be able to easily build .deb packages > > and make repos to easily update and maintain wireshark across servers. > > This is a feature I vote for

Re: [Wireshark-dev] Future of Wireshark's Debian packaging scripts in the main repository

2023-12-21 Thread Bálint Réczey
t dissector users should be "their users". In my eyes they are very much our users as well since they use Wireshark extended with the plugin and I'm happy that they get the best service. Cheers, Balint > > Am Mi., 20. Dez. 2023 um 19:57 Uhr schrieb Bálint Réczey < bal...@balint

Re: [Wireshark-dev] Future of Wireshark's Debian packaging scripts in the main repository

2023-12-21 Thread Bálint Réczey
Hi Guy, Guy Harris ezt írta (időpont: 2023. dec. 21., Cs, 21:04): > > On Dec 21, 2023, at 6:51 AM, Bálint Réczey wrote: > > > I'm not sure why libvirt dissector users should be "their users". In my > > eyes they are very much our users as well since they

Re: [Wireshark-dev] [Wireshark-core] Ubuntu buildbot failing when building the Debian package?

2013-07-15 Thread Bálint Réczey
Hi Guy, 2013/7/15 Guy Harris : > > On Jul 15, 2013, at 6:57 AM, Bálint Réczey wrote: > >> I think there is no clear preference. >> sensible-pager and sensible-editor are mentioned [1] in Debian Policy >> which gives direction to maintainers, but sensible browser is

Re: [Wireshark-dev] Make gtk3 default (over gtk2)?

2013-07-23 Thread Bálint Réczey
Hi, 2013/7/23 Joerg Mayer : > Hello, > > how about making gtk3 the default over gtk2 when building Wireshark? Just > to be clear: I only want to reverse the build defaults between gtk2 and 3. > Hopefully it will get much more testing that way, so it is up to prime time > for the next release? I fu

Re: [Wireshark-dev] Recent changes in composite TVB (extra changes beside move)

2013-08-01 Thread Bálint Réczey
2013/8/1 Graham Bloice : > On 31 July 2013 22:42, Jakub Zawadzki wrote: > > >> >> >> --- 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_2.c2013-07-31 >> 22:50:46.144101741 +0200 >> +++ 9d519b5659aa8c0c4aa984bc6169909eb31be7d6_1.c2013-07-31 >> 22:50:36.800818660 +0200 > > > Totally off-t

Re: [Wireshark-dev] Gently migrating to Git + Gerrit

2013-08-06 Thread Bálint Réczey
Hi Gerald, 2013/8/6 Gerald Combs : > I finally have some time set aside to do more work on the Git migration. > I'm hoping to do the following in the near future: Great! > > Switch code.wireshark.org from gitweb to cgit. > > This isn't strictly necessary but IMHO cgit has a slightly nicer > inter

Re: [Wireshark-dev] Remove hf_ variables

2013-08-06 Thread Bálint Réczey
2013/7/30 Joerg Mayer : > On Mon, Jul 29, 2013 at 10:42:02PM +0200, Jakub Zawadzki wrote: >> On Mon, Jul 29, 2013 at 01:25:41PM -0700, Guy Harris wrote: >> > >> > On Jul 29, 2013, at 1:12 PM, Jakub Zawadzki >> > wrote: >> > >> > > Is anyone attached to hf_ variables? ;) >> > > >> > > There's no r

Re: [Wireshark-dev] Clang build with ASAN

2013-08-13 Thread Bálint Réczey
Hi, 2013/8/12 Alexis La Goutte : > Hi, > > it is now possible to build wireshark with clang (CC=clang ./configure && > make) (i fix last issue last week end). Great news! > > > I will try the ASAN feature ( > http://clang.llvm.org/docs/AddressSanitizer.html ) ASAN is also ported to GCC 4.8. I'm n

Re: [Wireshark-dev] Clang build with ASAN

2013-08-13 Thread Bálint Réczey
Hi Evan, 2013/8/13 Evan Huus : > On Mon, Aug 12, 2013 at 11:17 AM, Alexis La Goutte > wrote: >> >> Hi, >> >> it is now possible to build wireshark with clang (CC=clang ./configure && >> make) (i fix last issue last week end). >> >> >> I will try the ASAN feature ( >> http://clang.llvm.org/docs/Ad

Re: [Wireshark-dev] Clang build with ASAN

2013-08-13 Thread Bálint Réczey
Hi Evan, 2013/8/13 Evan Huus : > On Tue, Aug 13, 2013 at 10:07 AM, Alexis La Goutte > wrote: >> >> >> >> >> On Tue, Aug 13, 2013 at 3:44 PM, Evan Huus wrote: >>> >>> On Tue, Aug 13, 2013 at 6:29 AM, Bálint Réczey >>> wrote:

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-22 Thread Bálint Réczey
Hi, I would be happier if the applications I run did not change kernel configuration without my consent. Regarding Wireshark I would prefer suggesting "echo 1 > /proc/sys/net/core/bpf_jit_enable" in the documentation instead of adding code to enable JIT. There may be good reasons for not enabling

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
Hi, 2013/8/23 Anders Broman : > Bálint Réczey skrev 2013-08-22 23:02: ... >> Regarding Wireshark I would prefer suggesting "echo 1 > >> /proc/sys/net/core/bpf_jit_enable" in the documentation >> instead of adding code to enable JIT. >> There may be good r

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
restore it > when dumpcap exits? > > Thus wrote Anders Broman (a.bro...@bredband.net): > >> Bálint Réczey skrev 2013-08-22 23:02: >>> Hi, > >>> I would be happier if the applications I run did not change kernel >>> configuration without m

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
2013/8/23 Anders Broman : > > > -Original Message- > From: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Bálint Réczey > Sent: den 23 augusti 2013 12:59 > To: Developer support list for Wireshark > Subject: Re:

Re: [Wireshark-dev] Enabling linux kernel jit compiler from dumpcap?

2013-08-23 Thread Bálint Réczey
2013/8/23 Anders Broman : > > > -Original Message- > From: rbal...@gmail.com [mailto:rbal...@gmail.com] On Behalf Of Bálint Réczey > Sent: den 23 augusti 2013 14:23 > To: Anders Broman > Cc: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] E

Re: [Wireshark-dev] Performance degradation in trunk

2013-09-12 Thread Bálint Réczey
Could they analyze perf results or run git bisect to find the point when the degradation started? Cheers, Balint 2013/9/12 Anders Broman : > Hi, > > I recently supplied some people with an internal build from recent trunk and > got complaints on performance. Switching back > > To the default Wire

Re: [Wireshark-dev] [Wireshark-commits] rev 52129: /trunk/asn1/ /trunk/asn1/p22/: CMakeLists.txt Makefile.common /trunk/asn1/p7/: CMakeLists.txt Makefile.common /trunk/asn1/x509ce/: CMakeLists.txt Mak

2013-09-17 Thread Bálint Réczey
2013/9/17 Evan Huus : > On 2013-09-17, at 8:45 PM, jma...@wireshark.org wrote: > >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52129 >> >> User: jmayer >> Date: 2013/09/17 01:45 PM >> >> Log: >> Fix remaining dependencides for -exp.cnf files. > > Does this mean it might finall

Re: [Wireshark-dev] Motivation for wmem [was: rev 52264]

2013-09-30 Thread Bálint Réczey
Hi All, 2013/9/30 Evan Huus : > On Sun, Sep 29, 2013 at 6:38 PM, Jakub Zawadzki > wrote: >> On Sun, Sep 29, 2013 at 05:35:59PM -0400, Evan Huus wrote: >>> On Sun, Sep 29, 2013 at 3:56 PM, Jakub Zawadzki >>> wrote: >>> > But back to topic (cause you'll probably see this problem few more times). >

Re: [Wireshark-dev] Trunk issues with GTK-3.10?

2013-10-03 Thread Bálint Réczey
Hi David, 2013/10/3 David Arnold : > Hi all, > > I'm seeing some issues compiling trunk against Gtk-3.10. Specifically, the > GTK_STOCK_* icon macros and GtkAction type have now been deprecated, and > their headers moved to the "deprecated" subdirectory. > > Should I be moving to Qt? Or back t

Re: [Wireshark-dev] Handling of generated dissectors

2013-10-07 Thread Bálint Réczey
2013/10/7 Joerg Mayer : > On Sun, Oct 06, 2013 at 04:27:50PM -0400, Evan Huus wrote: >> On Sun, Oct 6, 2013 at 4:25 PM, Joerg Mayer wrote: >> > Hello, >> > >> > Matthieu raised an issue that I've seen with asn2wrs generated dissectors >> > too, just not to the extent of the pidl dissectors. To mak

Re: [Wireshark-dev] 1.11.0 release

2013-10-09 Thread Bálint Réczey
Hi Gerald, 2013/10/8 Gerald Combs : > I've scheduled the release of 1.11.0 for next Tuesday, October 15. > Corrections and additions for the release notes are welcome. > > Unfortunately the transitional state of our UI will be reflected in the > release packages: > > Windows 32-bit: GTK3 and Qt >

Re: [Wireshark-dev] 1.11.0 release

2013-10-09 Thread Bálint Réczey
2013/10/9 Guy Harris : > > On Oct 9, 2013, at 2:47 AM, Bálint Réczey wrote: > >> How about dropping the automake based and nmake based makefile systems and >> replacing both with CMake? > > So do you propose that people who are building from source only because they &

Re: [Wireshark-dev] 1.11.0 release

2013-10-09 Thread Bálint Réczey
Hi Guy, 2013/10/9 Guy Harris : > > On Oct 9, 2013, at 3:21 AM, Bálint Réczey wrote: > >> Building Wireshark already needs way more tools than just make and a C >> compiler. > > Perhaps we should fix that, so that the release tarball includes all > generated sour

Re: [Wireshark-dev] [Wireshark-commits] rev 52484: /trunk/ /trunk/docbook/: CMakeLists.txt /trunk/cmake/modules/: FindXSLTPROC.cmake

2013-10-10 Thread Bálint Réczey
Hi, 2013/10/10 Joerg Mayer : > On Thu, Oct 10, 2013 at 05:02:51AM +, rbal...@wireshark.org wrote: >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52484 >> >> User: rbalint >> Date: 2013/10/10 05:02 AM >> >> Log: >> Fix using fop from CMake > > Last time I tried (~1 week ag

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-12 Thread Bálint Réczey
Hi Graham, 2013/10/12 Graham Bloice : > On 11 October 2013 16:09, Joerg Mayer wrote: ... > There are the dumpabi projects that I'm not sure are needed for win32; > dumpabi, dumpabi-libwireshark, dumpabi-libwiretap, dumpabi-libwsutil. I think those targets are not needed to be operational under Wi

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-12 Thread Bálint Réczey
Hi Jörg, 2013/10/11 Joerg Mayer : > Another milestone hit: > > - Win 32bit: The following executables build and run from the build directory > (as well as capture if they should be able to). *: Acutally tested > $ ls *exe > capinfos.exe* dumpcap.exe mergecap.exe randpkt.exe reordercap.ex

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-15 Thread Bálint Réczey
2013/10/12 Bálint Réczey : > Hi Jörg, > > 2013/10/11 Joerg Mayer : ... >> - abi check: Move abi check operation into a UseABICheck.cmake file and >> call that from CMakeLists. Then make it work on Win32 in a single place. > I think it is obsolete on Windows but re

Re: [Wireshark-dev] Licensing of tools/html2text.py

2013-11-03 Thread Bálint Réczey
2013/11/3 Evan Huus : > It appears to be licensed under GPLv3 only, which makes it > incompatible for us to include. > > It seems to be included only because links/lynx didn't appear to work > a while ago when building under WIndows. If that is no longer true > then I think we can just remove it wi

Re: [Wireshark-dev] Lemon crashing on Solaris? (was Re: [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris-10-SPARC)

2013-11-24 Thread Bálint Réczey
2013/11/25 Guy Harris : > > On Nov 24, 2013, at 2:59 PM, Guy Harris wrote: > >> I've removed -ftrapv; we'll see what that does. > > That fixed it. > > Either Lemon is explicitly depending on wrap-around on signed integer > overflow, or implicitly depending on a lack of trapping for signed integer

Re: [Wireshark-dev] Lemon crashing on Solaris? (was Re: [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris-10-SPARC)

2013-11-25 Thread Bálint Réczey
2013/11/25 Guy Harris : > > On Nov 24, 2013, at 5:37 PM, Bálint Réczey wrote: > >> I tried to trigger a crash using GCC and -ftrapv without success while >> the clang-compiled binary crashed as expected: > > Reproduced with clang on (x86-64) OS X. > > The prob

Re: [Wireshark-dev] Lemon crashing on Solaris? (was Re: [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris-10-SPARC)

2013-11-28 Thread Bálint Réczey
2013/11/25 Guy Harris : > > On Nov 25, 2013, at 12:00 PM, Bálint Réczey wrote: > >> At least we (you) found a real problem by temporarily enabling the >> broken -ftrapv. :-) > > ...with a compiler that actually does something with it. Hopefully the GCC > fol

Re: [Wireshark-dev] GTK+3 Win32/64 state

2013-12-04 Thread Bálint Réczey
rked totally OK on any other sides. 2013/6/13 Bálint Réczey : > Hi All, > > Tarnyko kindly sent me an update on the progress of providing an > official GTK+3 bundle on Windows. > I'm not working on Windows nowadays, but I provide Wireshark packages > in Debian unstable built wi

Re: [Wireshark-dev] Add -Wdocumentation

2013-12-09 Thread Bálint Réczey
2013/12/9 Joerg Mayer : > On Fri, Dec 06, 2013 at 03:38:08PM +0100, Alexis La Goutte wrote: >> I plan to add -Wdocumentation [1] by default to Wireshark (when build with >> Clang). >> I have already fix in trunk the documentation. >> >> The major issue to add -Wdocumentation is other library (like

Re: [Wireshark-dev] Add -Wdocumentation

2013-12-13 Thread Bálint Réczey
Hi, 2013/12/13 Alexis La Goutte : > > Hi, > > On Mon, Dec 9, 2013 at 5:58 PM, Bálint Réczey > wrote: >> >> 2013/12/9 Joerg Mayer : >> > On Fri, Dec 06, 2013 at 03:38:08PM +0100, Alexis La Goutte wrote: >> >> I plan to add -Wdocumentation [1

Re: [Wireshark-dev] Where is packet-isdn-sup-table31.c?

2013-12-13 Thread Bálint Réczey
cmake ... make -C asn1/isdn-sup/ generated it for me in asn1/isdn-sup/ Cheers, Balint 2013/12/13 Christopher Maynard : > In asn1/isdn-sup/packet-isdn-sup-template.c at line 110, there is: > > #include "packet-isdn-sup-table31.c" > > I'm unable to locate this file. Can someone more familiar with

Re: [Wireshark-dev] setcap for CMake install under Linux

2014-01-12 Thread Bálint Réczey
2014/1/13 Guy Harris : > > On Jan 12, 2014, at 2:23 PM, Joerg Mayer wrote: > >> It allows the compilation with capabilities (that's what I use), but right >> now >> the installation process has neither suid nor setcap support. >> Does it really make sense to add this? If so, I can do so tomorrow.

Re: [Wireshark-dev] setcap for CMake install under Linux

2014-01-13 Thread Bálint Réczey
2014/1/13 Guy Harris : > > On Jan 12, 2014, at 5:10 PM, Bálint Réczey wrote: > >> IMO it does not have to support Debian packages. >> The best practice (and Debian's policy) is calling CMake from >> debian/rules, not the other way around. > > As long as swi

Re: [Wireshark-dev] setcap for CMake install under Linux

2014-01-13 Thread Bálint Réczey
2014/1/13 Guy Harris : > > On Jan 13, 2014, at 1:05 PM, Alexis La Goutte > wrote: > >> Missing also make dist-* (gzip, bzip...) family in CMake > > Yes - we need a way of releasing the source to a particular version, for the > benefit of third parties making binary or source packages and people

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-15 Thread Bálint Réczey
Hi Evan, 2014/1/15 Evan Huus : > I have created an account and added an SSH key, but I am getting > "Permission denied (publickey)" when trying to clone. Is it working > for anyone else? After I set my username, it worked fine. Maybe you missed it like me for the first time. :-) > > On Tue, Jan 1

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Bálint Réczey
Hi Jörg, It is in the upper right corner. The links are pretty small. You are not the first who missed them. :-) Cheers, Balint 2014-01-28 Joerg Mayer : > Looks like I'm blind. Where do I create the account? > > Thanks > Jörg > > On Tue, Jan 14, 2014 at 09:28:08PM -0500, Evan Huus wrote: >>

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Bálint Réczey
Hi, 2014-01-28 Joerg Mayer : > On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: >> It is in the upper right corner. >> The links are pretty small. You are not the first who missed them. :-) > > Can you please provide the URL? If the URL is > https://code.wi

Re: [Wireshark-dev] Git tags

2014-01-29 Thread Bálint Réczey
Hi Gerald, 2014-01-24 Gerald Combs : > After Tuesday's migration I plan on adding the following tags. This > should make it easier to use 'git describe' to generate version numbers > and provide a consistent tag history in our current branches. Most of those git commits are already tagged with wir

Re: [Wireshark-dev] Gerrit Merge "" commits

2014-01-30 Thread Bálint Réczey
Hi, 2014-01-30 Evan Huus : > I believe the simpler answer is that the submit type has been set to "Merge > If Necessary" which means if changes are not submitted exactly on top of the > change they were authored on, Gerrit will produce a merge automatically. I suggested using "Cherry Pick" for "

Re: [Wireshark-dev] Gerrit Topic Names

2014-01-30 Thread Bálint Réczey
Please don't list bugs in topic names, reserve the fist line for the short summary. Listing bugs at the end of the commit message like below is a better practice and also helps processing the commit messages with standard tools. https://wiki.openstack.org/wiki/GitCommitMessages : "The 'bug' line c

Re: [Wireshark-dev] Gerrit Topic Names

2014-01-30 Thread Bálint Réczey
2014-01-30 Alexis La Goutte : > > > > On Thu, Jan 30, 2014 at 3:31 PM, Bálint Réczey > wrote: >> >> Please don't list bugs in topic names, reserve the fist line for the >> short summary. >> Listing bugs at the end of the commit message like below is a

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-30 Thread Bálint Réczey
2014-01-30 Gerald Combs : > On 1/28/14 5:57 AM, Bálint Réczey wrote: >> Hi, >> >> 2014-01-28 Joerg Mayer : >>> On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: >>>> It is in the upper right corner. >>>> The links a

Re: [Wireshark-dev] Gerrit Merge "" commits

2014-01-31 Thread Bálint Réczey
Hi Evan, 2014-01-30 Evan Huus : > On Thu, Jan 30, 2014 at 2:35 PM, Gerald Combs wrote: >> On 1/30/14 6:17 AM, Bálint Réczey wrote: >>> Hi, >>> >>> 2014-01-30 Evan Huus : >>>> I believe the simpler answer is that the submit type has been set to

Re: [Wireshark-dev] do we continue to reference revision numbers?

2014-01-31 Thread Bálint Réczey
Hi Hadriel, 2014-01-31 Hadriel Kaplan : > In the past with svn, when we found a bug caused by a previous code change, > we used the revision number in bugzilla comments with a leading ‘r’, like > ‘r12345’. This would auto-create a very convenient url link in bugzilla to > the svn browsing web

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Bálint Réczey
Hi, 2014-02-04 Pascal Quantin : > > > > 2014-02-04 Graham Bloice : >> >> On 4 February 2014 11:18, Pascal Quantin wrote: >>> >>> 2014-02-04 Graham Bloice : >>> On 3 February 2014 22:50, Pascal Quantin wrote: > > Hi all, > > with subversion we were using the native

Re: [Wireshark-dev] Git and line endings

2014-02-04 Thread Bálint Réczey
Hi, 2014-02-04 Pascal Quantin : > 2014-02-04 Bálint Réczey : > >> Hi, >> >> >> 2014-02-04 Pascal Quantin : >> > >> > >> > >> > 2014-02-04 Graham Bloice : >> >> >> >> On 4 February 2014 11:18, Pascal

Re: [Wireshark-dev] "right" git clone address

2014-02-20 Thread Bálint Réczey
Hi All & Gerald, 2014-02-01 23:04 GMT+01:00 Evan Huus : > On Sat, Feb 1, 2014 at 4:58 PM, Toralf Förster wrote: >> As a "follower" of the wireshark code I'm wondering if >> https://code.wireshark.org/review/wireshark or >> https://code.wireshark.org/git/wireshark is the right address to build >>

Re: [Wireshark-dev] "right" git clone address

2014-02-20 Thread Bálint Réczey
2014-02-20 14:36 GMT+01:00 Evan Huus : > On Thu, Feb 20, 2014 at 6:52 AM, Bálint Réczey wrote: >> Hi All & Gerald, >> >> 2014-02-01 23:04 GMT+01:00 Evan Huus : >>> On Sat, Feb 1, 2014 at 4:58 PM, Toralf Förster >>> wrote: >>>> As a "

Re: [Wireshark-dev] "right" git clone address

2014-02-21 Thread Bálint Réczey
Hi Gerald, 2014-02-21 1:20 GMT+01:00 Gerald Combs : ... > For the time being I've redirected the following URL prefixes to Gerrit: > > http://anongit.wireshark.org/git > http://code.wireshark.org/git > https://code.wireshark.org/git > > I'm able to fetch using a couple of old test repositories her

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
2014-02-26 10:30 GMT+01:00 Joerg Mayer : > On Wed, Feb 26, 2014 at 09:51:13AM +0100, Joerg Mayer wrote: >> I sent the sample workflow for two reasons: >> 1) Receive feedback whether I did something "stupid" (aka newbie error) >> 2) Start creating a little bit of help for newbies > > Attached a revi

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
2014-02-26 18:19 GMT+01:00 Hadriel Kaplan : > > On Feb 26, 2014, at 3:51 AM, Joerg Mayer wrote: > >> On Tue, Feb 25, 2014 at 08:39:37PM -0500, Hadriel Kaplan wrote: >> >>> - avoiding merging local branches because a merge commit won't have the >>> change-id and can't/shouldn't be sent up to gerri

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
/git-scm.com/book/en/Git-Basics-Undoing-Things Cheers, Balint > > On Wed, Feb 26, 2014 at 2:31 PM, Bálint Réczey wrote: >> 2014-02-26 10:30 GMT+01:00 Joerg Mayer : >>> On Wed, Feb 26, 2014 at 09:51:13AM +0100, Joerg Mayer wrote: >>>> I sent the sample workflow f

Re: [Wireshark-dev] Sample command line workflow with git and gerrit

2014-02-26 Thread Bálint Réczey
2014-02-26 9:22 GMT+01:00 Joerg Mayer : > On Tue, Feb 25, 2014 at 08:57:36PM -0500, Hadriel Kaplan wrote: >> >> On Feb 25, 2014, at 8:44 PM, Evan Huus wrote: >> >> > I'm all for consolidating the above information - we just need to >> > decide which of the many places to consolidate *to*. We've be

Re: [Wireshark-dev] new warning :/usr/include/gtk-3.0/gtk/gtkwidget.h:787:58: error: identifier "and" is a special operator name in C++ [-Werror=c++-compat]

2014-03-09 Thread Bálint Réczey
2014-03-09 10:43 GMT+01:00 Alexis La Goutte : > On Sat, Mar 8, 2014 at 4:21 PM, Toralf Förster wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> Switching from gtk-3.8.7 to gtp-3.10.7 I do get with current wireshark git >> tree at a stable 32 bit Gentoo Linux : >> >> make[2]: Ent

Re: [Wireshark-dev] Build bot failure

2014-03-11 Thread Bálint Réczey
2014-03-11 7:29 GMT+01:00 Anders Broman : > Hi, > > stock_icons.c:176: error: 'GTK_STOCK_CAPS_LOCK_WARNING' undeclared here (not > in a function) stock_icons.c:242: error: 'GTK_STOCK_PAGE_SETUP' undeclared > here (not in a function) stock_icons.c:246: error: 'GTK_STOCK_PRINT_ERROR' > undeclared her

Re: [Wireshark-dev] Fix bug in GSM MAP, have problems with GIT

2014-03-11 Thread Bálint Réczey
2014-03-11 15:00 GMT+01:00 Martin Mathieson : > I too am looking forward to seeing this. > > > On Tue, Mar 11, 2014 at 1:08 PM, Jeff Morriss > wrote: >> >> On 03/08/14 04:46, Anders Broman wrote: >>> >>> Pascal Quantin skrev 2014-03-08 09:56: Le 08/03/2014 09:45, Anders Broman a écrit :

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-21 Thread Bálint Réczey
Hi, 2014-03-20 23:11 GMT-01:00 Guy Harris : > > On Mar 20, 2014, at 2:24 PM, Chris Kilgour wrote: > >> On 03/20/2014 01:07 PM, Gerald Combs wrote: >>> >>> If the build system had open access what would keep someone from >>> uploading a shell script containing a box full of weasels wearing clown >

  1   2   3   >