Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-14 Thread Pascal Quantin
2013/10/14 didier > Hi, > Le dimanche 13 octobre 2013 à 16:43 -0400, Evan Huus a écrit : > > On Sun, Oct 13, 2013 at 3:54 AM, Jakub Zawadzki > > wrote: > > > About tvb_offset_exists() comment, compute_offset() is not returning > > > exception when offset == tvb->length. > > > > Ah, OK. Should it

Re: [Wireshark-dev] Status Cmake Win32 support

2013-10-14 Thread Alexis La Goutte
On Sat, Oct 12, 2013 at 1:22 AM, Joerg Mayer wrote: > On Fri, Oct 11, 2013 at 03:48:32PM -0700, Gerald Combs wrote: > > > - qtshark on win *requires* that gtk includes are present to build: > > > file_dlg_win32.c:#include > > > > This should be fixed in r52542-52545. > > Wow, that was fast! >

Re: [Wireshark-dev] Idea for process image dissection

2013-10-14 Thread Jakub Zawadzki
Hi, On Sun, Oct 13, 2013 at 10:17:45AM +0200, Roland Knall wrote: > I just wanted to bring something by you guys, if it would be worth > implementing. > > I work on the openSAFETY and EPL dissectors. Both are fieldbus > specific implementations. As such the communicate process images as > payloa

Re: [Wireshark-dev] Idea for process image dissection

2013-10-14 Thread Guy Harris
On Oct 13, 2013, at 1:17 AM, Roland Knall wrote: > For such a dissection, we need to tell a dissector, how to dissect a > specific payload. > > I would like to implement a new field type (FT_PIMAGE) and allow the > user using a dialog, to specify a filter and a mapping to dissect the > field.

[Wireshark-dev] r52604: Adding to col info is probably useless as next dissector will overwrite it.

2013-10-14 Thread Jakub Zawadzki
Hi Anders, Please revert it, dissectors after vlan can be disabled. If we want to have some lazy COL_INFO calculation - that's fine for me, but selectively disabling col_add_fstr is NACK for me. Cheers, Jakub. ___ Sent via:

Re: [Wireshark-dev] r52604: Adding to col info is probably useless as next dissector will overwrite it.

2013-10-14 Thread Anders Broman
Jakub Zawadzki skrev 2013-10-14 21:26: Hi Anders, Please revert it, dissectors after vlan can be disabled. Done in revision 52608 even tough I don't think the entry is useful. If we want to have some lazy COL_INFO calculation - that's fine for me, but selectively disabling col_add_fstr is NA

Re: [Wireshark-dev] [Wireshark-commits] rev 52608: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-vlan.c

2013-10-14 Thread Maynard, Chris
Why not add a fence so it's always visible then? -Original Message- From: wireshark-commits-boun...@wireshark.org [mailto:wireshark-commits-boun...@wireshark.org] On Behalf Of etx...@wireshark.org Sent: Monday, October 14, 2013 5:51 PM To: wireshark-comm...@wireshark.org Subject: [Wiresh

Re: [Wireshark-dev] [Wireshark-commits] rev 52607: /trunk/ui/qt/ /trunk/ui/qt/: follow_stream_dialog.cpp follow_stream_dialog.h follow_stream_dialog.ui main_window_slots.cpp

2013-10-14 Thread Guy Harris
On Oct 14, 2013, at 2:17 PM, ger...@wireshark.org wrote: > Get rid of the group box -- the OS X and Windows HIGs > discourage its use and I'm not sure if it fits the GNOME HIG in this > case either. ...and there's another HIG at least as relevant to Qt applications, if not more so: htt

[Wireshark-dev] follow_stream_dialog.cpp warning turning error

2013-10-14 Thread Joerg Mayer
[ 71%] Building CXX object ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o /home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cpp: In member function ‘virtual void FollowStreamDialog::keyPressEvent(QKeyEvent*)’: /home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cp

Re: [Wireshark-dev] [Wireshark-commits] rev 52608: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-vlan.c

2013-10-14 Thread Anders Broman
Maynard, Chris skrev 2013-10-15 00:47: Why not add a fence so it's always visible then? My point is that I don't want to write column info in the VLAN dissector to speed up dissection. If it could be arranged to only write the "last" entry that will actually be in the packet list or written o