Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-14 Thread Erik de Jong
On Thu, Jun 15, 2017 at 3:09 AM, Guy Harris wrote: > On Jun 13, 2017, at 1:54 PM, Erik de Jong wrote: > > > Is it possible to have a petridish build for OSX as well? That's where > the issue came from originally and why it got into the master branch. > > That might be a good idea, but don't rely

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-14 Thread Guy Harris
On Jun 13, 2017, at 1:54 PM, Erik de Jong wrote: > Is it possible to have a petridish build for OSX as well? That's where the > issue came from originally and why it got into the master branch. That might be a good idea, but don't rely on it to catch problems with older versions of libraries t

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Richard Sharpe
On Tue, Jun 13, 2017 at 4:14 PM, Guy Harris wrote: > On Jun 13, 2017, at 1:29 PM, Richard Sharpe > wrote: > >> It's a bit rude to cause build errors just because I don't have gcrypt >> 1.6.0 or above. > > Yes, that's why those #ifs were checked in - without them, you get build > errors because

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Guy Harris
On Jun 13, 2017, at 1:29 PM, Richard Sharpe wrote: > It's a bit rude to cause build errors just because I don't have gcrypt > 1.6.0 or above. Yes, that's why those #ifs were checked in - without them, you get build errors because the pre-1.6.0 versions of libcrypt don't have the gcry_mac_ routi

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Richard Sharpe
On Tue, Jun 13, 2017 at 3:15 PM, Richard Sharpe wrote: > On Tue, Jun 13, 2017 at 1:50 PM, Pascal Quantin > wrote: >> >> >> 2017-06-13 22:33 GMT+02:00 Pascal Quantin : >>> >>> Hi Richard, >>> >>> 2017-06-13 22:29 GMT+02:00 Richard Sharpe : Hi folks, After I did a git pull, I st

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Richard Sharpe
On Tue, Jun 13, 2017 at 1:50 PM, Pascal Quantin wrote: > > > 2017-06-13 22:33 GMT+02:00 Pascal Quantin : >> >> Hi Richard, >> >> 2017-06-13 22:29 GMT+02:00 Richard Sharpe : >>> >>> Hi folks, >>> >>> After I did a git pull, I started getting this error: >>> >>> CC packet-lorawan.lo >>> pack

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Erik de Jong
Yes, that got messed up quite a bit in certain situations. Is it possible to have a petridish build for OSX as well? That's where the issue came from originally and why it got into the master branch. Erik On Tue, Jun 13, 2017 at 10:50 PM, Pascal Quantin wrote: > > > 2017-06-13 22:33 GMT+02:00 P

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Pascal Quantin
2017-06-13 22:33 GMT+02:00 Pascal Quantin : > Hi Richard, > > 2017-06-13 22:29 GMT+02:00 Richard Sharpe : > >> Hi folks, >> >> After I did a git pull, I started getting this error: >> >> CC packet-lorawan.lo >> packet-lorawan.c: In function 'dissect_lorawan': >> packet-lorawan.c:657:7: err

Re: [Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Pascal Quantin
Hi Richard, 2017-06-13 22:29 GMT+02:00 Richard Sharpe : > Hi folks, > > After I did a git pull, I started getting this error: > > CC packet-lorawan.lo > packet-lorawan.c: In function 'dissect_lorawan': > packet-lorawan.c:657:7: error: variable 'frame_length' set but not > used [-Werror=un

[Wireshark-dev] packet-lorawan.c compile error because of stuff added yesterday ...

2017-06-13 Thread Richard Sharpe
Hi folks, After I did a git pull, I started getting this error: CC packet-lorawan.lo packet-lorawan.c: In function 'dissect_lorawan': packet-lorawan.c:657:7: error: variable 'frame_length' set but not used [-Werror=unused-but-set-variable] gint frame_length; Seems to be related to this