Re: [Wireshark-dev] p2p_dir

2007-08-14 Thread Richard van der Hoff
Jaap Keuter wrote: > Oh no, not this flamewar again... > > On the plus side: yes, your development cycle and intermediate release > is easier. > On the min side: You don't have the full API (on Win32 that is). It certainly wasn't my intention to start a flame war, I just hadn't seen the argumen

Re: [Wireshark-dev] p2p_dir

2007-08-12 Thread Guy Harris
Richard van der Hoff wrote: > Guy Harris wrote: >> That would make sense, especially given that, for WTAP_ENCAP_ISDN, >> dissect_frame() sets pinfo0>p2p_dir based on the setting of >> pinfo->pseudo_header.isdn.uton.> >> > Well, it does now I've made it do so... ;) As far as I can tell, it's done

Re: [Wireshark-dev] p2p_dir

2007-08-12 Thread Richard van der Hoff
Richard van der Hoff wrote: > Guy Harris wrote: > >>Richard van der Hoff wrote: >> >> >>>It seems better to use pinfo->p2p_dir for this. >> >>That would make sense, especially given that, for WTAP_ENCAP_ISDN, >>dissect_frame() sets pinfo0>p2p_dir based on the setting of >>pinfo->pseudo_header.is

Re: [Wireshark-dev] p2p_dir

2007-08-12 Thread Richard van der Hoff
Guy Harris wrote: > Richard van der Hoff wrote: > >>It seems better to use pinfo->p2p_dir for this. > > That would make sense, especially given that, for WTAP_ENCAP_ISDN, > dissect_frame() sets pinfo0>p2p_dir based on the setting of > pinfo->pseudo_header.isdn.uton.> > Well, it does now I've m

Re: [Wireshark-dev] p2p_dir

2007-08-12 Thread Guy Harris
Richard van der Hoff wrote: > It seems better to use pinfo->p2p_dir for this. That would make sense, especially given that, for WTAP_ENCAP_ISDN, dissect_frame() sets pinfo0>p2p_dir based on the setting of pinfo->pseudo_header.isdn.uton.> I just wanted to check > that this was the intended us

Re: [Wireshark-dev] p2p_dir

2007-08-11 Thread Jaap Keuter
Oh no, not this flamewar again... On the plus side: yes, your development cycle and intermediate release is easier. On the min side: You don't have the full API (on Win32 that is). IMHO when a protocol is complete (stable RFC or whatever standard bodies publish) and dissector is fully developed

Re: [Wireshark-dev] p2p_dir

2007-08-10 Thread Richard van der Hoff
Luis EG Ontanon wrote: > Richard, > Once that you are at it why don't you move it to epan/dissectors and > remove the plugin. I guess I could. The good thing about it being a plugin is that when you're hacking on it, you don't need to relink the entirety of libwireshark on each compile cycle. W

Re: [Wireshark-dev] p2p_dir

2007-08-10 Thread Luis EG Ontanon
Richard, Once that you are at it why don't you move it to epan/dissectors and remove the plugin. On 8/6/07, Richard van der Hoff <[EMAIL PROTECTED]> wrote: > Hi all, > > I'm looking at extending the H.223 dissector to work over ISDN. (ftr, > H.223 is a circuit-based protocol which is supposed to

[Wireshark-dev] p2p_dir

2007-08-06 Thread Richard van der Hoff
Hi all, I'm looking at extending the H.223 dissector to work over ISDN. (ftr, H.223 is a circuit-based protocol which is supposed to work over the telephone network; currently wireshark will dissect it over IAX2, TCP or RTP, and I want to extend it to the one place it really really _ought_ to