Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Hi Ahmed, On Tue, May 05, 2020 at 09:05:53AM -0700, Ahmed Elsherbiny wrote: > Hi Peter, > > Unfortunately I am not privy to the reasons for choosing this particular > cipher suite. If you can share them in private, I would be interested to hear about the use cases and why alternative configurati

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Hi Peter, Unfortunately I am not privy to the reasons for choosing this particular cipher suite. Sorry if my questions sounds naive - I'm really not into the security domain. What would be the risks of using this implementation (with the nonce issue and half-size key)? Does it make it easier for

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Hi Ahmed, On Mon, May 04, 2020 at 03:12:50PM -0700, Ahmed Elsherbiny wrote: > First of all, thank you again for creating the patch. I did test it and was > able to successfully decode some messages. > My implementation uses WolfSSL v4.3.0. > > I hope the patch will be merged in, please let me kno

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Hello Peter, First of all, thank you again for creating the patch. I did test it and was able to successfully decode some messages. My implementation uses WolfSSL v4.3.0. I hope the patch will be merged in, please let me know if there's any more info you need from my end. Regards, Ahmed On Sat

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Hi Ahmed, I have posted a patch at https://code.wireshark.org/review/37034 which should allow you to see the plaintext. However there is a big open question about the draft specification. Can you share some more details on your implementation, in particular which TLS library do you use? Without m

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Wow this is great news, thank you Peter! Regards, Ahmed On Sat, May 2, 2020 at 10:21 AM Peter Wu wrote: > Hi Ahmed, > > On Fri, May 01, 2020 at 02:10:01PM -0700, Ahmed Elsherbiny wrote: > > Hello, > > > > I've written a dissector for a custom protocol. The dissector works well, > > and now I'm

Re: [Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Hi Ahmed, On Fri, May 01, 2020 at 02:10:01PM -0700, Ahmed Elsherbiny wrote: > Hello, > > I've written a dissector for a custom protocol. The dissector works well, > and now I'm trying to run the protocol over TLS 1.3. > > The cipher suite being used is TLS_SHA256_SHA256 (Code: 0xC0B4). This is a

[Wireshark-dev] Trying to decode a TLS 1.3 with null cipher

Hello, I've written a dissector for a custom protocol. The dissector works well, and now I'm trying to run the protocol over TLS 1.3. The cipher suite being used is TLS_SHA256_SHA256 (Code: 0xC0B4). This is a new cipher suite, it is used for integrity and has a null cipher (The payload is actuall