Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-08-07 Thread Luis EG Ontanon
This is an automated answer: re-post in bugzilla. ;-) On 8/7/07, Victor Fajardo <[EMAIL PROTECTED]> wrote: > Hi Jaap, > > 1. We've recently changed the patch submission policy to go through > > bugzilla. This in order to have patches like this not overlooked. > > > > Ok. I'll go through that proce

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-08-07 Thread Victor Fajardo
Hi Jaap, > 1. We've recently changed the patch submission policy to go through > bugzilla. This in order to have patches like this not overlooked. > Ok. I'll go through that process in the next rev. > 2. I can't comment on the merits of the patch in relation to the draft > referenced, but I'

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-08-07 Thread Jaap Keuter
Hi, Two things. 1. We've recently changed the patch submission policy to go through bugzilla. This in order to have patches like this not overlooked. 2. I can't comment on the merits of the patch in relation to the draft referenced, but I've spotted this code error: /* Reserved field

[Wireshark-dev] Patches to update PANA Protocol dissector

2007-08-07 Thread Victor Fajardo
To wireshark-maintainers, Attached is a patch file for the PANA protocol dissector. The changes updates the packet-pana.c dissector to support draft-ietf-pana-pana-18.txt. regards, victor Index: packet-pana.c === --- packet-pana.c

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-07-09 Thread Jaap Keuter
Hi, Committed in revision 22282. Thanx, Jaap Victor Fajardo wrote: > Hi Jaap, > > I found a small problem with the previous patch I've sent. I've attached > a patch that fixes this issue; the patch is based on the latest rev I > could get. > > regards, > victor > >> Hi, >> >> Committed in r

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-07-09 Thread Victor Fajardo
Hi Jaap, I found a small problem with the previous patch I've sent. I've attached a patch that fixes this issue; the patch is based on the latest rev I could get. regards, victor Hi, Committed in revision 22098. Thanx, Jaap Victor Fajardo wrote: Hi, Attached is a patch based on rev

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-06-14 Thread Jaap Keuter
Hi, Committed in revision 22098. Thanx, Jaap Victor Fajardo wrote: > Hi, > > Attached is a patch based on rev 22093. > > regards, > victor > >> Hi, >> >> Could you recreate the patch against the current tree? Your revision >> 21417 is too old and doesn't apply. >> >> Thanx, >> Jaap >> >> Vic

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-06-13 Thread Victor Fajardo
Hi, Attached is a patch based on rev 22093. regards, victor Hi, Could you recreate the patch against the current tree? Your revision 21417 is too old and doesn't apply. Thanx, Jaap Victor Fajardo wrote: To wireshark-maintainers, Attached is a patch file for the PANA protocol dissecto

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-06-13 Thread Jaap Keuter
Hi, Could you recreate the patch against the current tree? Your revision 21417 is too old and doesn't apply. Thanx, Jaap Victor Fajardo wrote: > To wireshark-maintainers, > > Attached is a patch file for the PANA protocol dissector. The changes > updates the packet-pana.c dissector to support

[Wireshark-dev] Patches to update PANA Protocol dissector

2007-06-13 Thread Victor Fajardo
To wireshark-maintainers, Attached is a patch file for the PANA protocol dissector. The changes updates the packet-pana.c dissector to support draft-ietf-pana-pana-15.txt. regards, victor packet_pana_patch.gz Description: GNU Zip compressed data __

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-05-08 Thread Stephen Fisher
On Tue, May 08, 2007 at 01:42:02PM -0400, Victor Fajardo wrote: > The packet-pana.c dissector I have submitted previously had a minor > issue. The following are the fixes: > > Change packet-pana.c, Line 823: > >{ "Ping","pana.flags.e", > > to: > >

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-05-08 Thread Victor Fajardo
To wireshark-maintainers, The packet-pana.c dissector I have submitted previously had a minor issue. The following are the fixes: Change packet-pana.c, Line 823: { "Ping","pana.flags.e", to: { "Error","pana.flags.e", best regards, victor > To w

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-04-16 Thread Jeff Morriss
Jeff Morriss wrote: > > > Victor Fajardo wrote: >> To wireshark-maintainers, >> >> Attached is a patch file for the PANA protocol dissector. The changes >> updates the packet-pana.c dissector to support >> draft-ietf-pana-pana-15a.txt. > > Checked (rev 21447), thanks! I had to change the g_

Re: [Wireshark-dev] Patches to update PANA Protocol dissector

2007-04-16 Thread Jeff Morriss
Victor Fajardo wrote: > To wireshark-maintainers, > > Attached is a patch file for the PANA protocol dissector. The changes > updates the packet-pana.c dissector to support > draft-ietf-pana-pana-15a.txt. Checked (rev 21447), thanks! ___ Wireshark-

[Wireshark-dev] Patches to update PANA Protocol dissector

2007-04-13 Thread Victor Fajardo
To wireshark-maintainers, Attached is a patch file for the PANA protocol dissector. The changes updates the packet-pana.c dissector to support draft-ietf-pana-pana-15a.txt. regards, victor packet_pana_patch.gz Description: GNU Zip compressed data _