Re: [Wireshark-dev] Gerrit - 404 page not found

On 11/17/21 9:57 AM, chuck c wrote: https://code.wireshark.org/review/32179 https://code.wireshark.org/review/#/c/13828/ Was working yesterday. It should be fixed now. BTW, I'm considering decommissioni

[Wireshark-dev] Gerrit - 404 page not found

https://code.wireshark.org/review/32179 https://code.wireshark.org/review/#/c/13828/ Was working yesterday. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe:

Re: [Wireshark-dev] Gerrit commit missing in Gitlab

On Feb 9, 2021, at 4:57 PM, Guy Harris wrote: > "Doesn't exist" as in "immediately tells you no such commit" or as in "takes > a long time and eventually gives you a 500 error"? I get the latter; > presumably that's "500 Internal Server Error". > > The commit *is* in repositories I've cloned

Re: [Wireshark-dev] Gerrit commit missing in Gitlab

Thanks. I should have phrased that better. I was trying to use "Blame" in the Gitlab web interface to look at a typo. On Tue, Feb 9, 2021 at 6:57 PM Guy Harris wrote: > On Feb 9, 2021, at 3:26 PM, chuck c wrote: > > > 2eb7b05b - Convert most UDP dissectors to use "auto" preferences. > > > > E

Re: [Wireshark-dev] Gerrit commit missing in Gitlab

On Feb 9, 2021, at 3:26 PM, chuck c wrote: > 2eb7b05b - Convert most UDP dissectors to use "auto" preferences. > > Exists in Gerrit: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eb7b05b8c9c6408268f0d1e81f0a18a02610f1c > > Links to it in Gitlab on these pages: > https:/

[Wireshark-dev] Gerrit commit missing in Gitlab

2eb7b05b - Convert most UDP dissectors to use "auto" preferences. Exists in Gerrit: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eb7b05b8c9c6408268f0d1e81f0a18a02610f1c Links to it in Gitlab on these pages: https://gitlab.com/wireshark/wireshark/-/blame/master/epan/dissect

Re: [Wireshark-dev] Gerrit

I intended to add Jasper in CC, as I told him. I just realized that the assignee field and reviewers are close in the new UI and I clicked on the wrong one. I'm still getting used to polygerrit. On Thu, Sep 13, 2018 at 11:30 AM Jasper Bongertz wrote: > Hello Peter, > > I think calling it as "ass

Re: [Wireshark-dev] Gerrit

Hello Peter, I think calling it as "assigned to me" was a misinterpretation on my behalf. Dario only wanted me to be cc'd in, as you assumed. Thanks! Jasper Thursday, September 13, 2018, 11:26:07 AM, you wrote: > Hi Jasper, > On Tue, Sep 11, 2018 at 12:36:10PM +0200, Jasper Bongertz wrote: >>

Re: [Wireshark-dev] Gerrit

Hi Jasper, On Tue, Sep 11, 2018 at 12:36:10PM +0200, Jasper Bongertz wrote: > Hi Dario, > > I saw you assigned a Gerrit change/ticket/thingy to me - I have to admit > that > I'm not really sure what to do there. I have no build environment for > Wireshark at the moment, and I don't know wh

[Wireshark-dev] Gerrit

Hi Dario, I saw you assigned a Gerrit change/ticket/thingy to me - I have to admit that I'm not really sure what to do there. I have no build environment for Wireshark at the moment, and I don't know what I'm supposed to do? Are those changes ending up in the automatic builds? Cheers, Jas

Re: [Wireshark-dev] Gerrit - code review window

On 02/09/18 19:37, João Valverde wrote: On 11/08/18 11:48, Jaap Keuter wrote: Hi, A change I noticed is the way side-by-side code is presented in the code review window. This used to be two evenly spaced columns on the screen with horizontal scroll bars when the lines were longer than the

Re: [Wireshark-dev] Gerrit - code review window

On 11/08/18 11:48, Jaap Keuter wrote: Hi, A change I noticed is the way side-by-side code is presented in the code review window. This used to be two evenly spaced columns on the screen with horizontal scroll bars when the lines were longer than the available width. Both scrollbars were syn

Re: [Wireshark-dev] Gerrit - code review window

> On 12 Aug 2018, at 23:42, Peter Wu wrote: > ... > This is the case with the "Old UI". If you are looking at the "New UI" > (which says "PolyGerrit" in the top left corner"), then I can confirm > that the diff view provides no way to change it. In that case, try to > switch back to the old UI b

Re: [Wireshark-dev] Gerrit - code review window

Hi Jaap, On Sat, Aug 11, 2018 at 12:48:54PM +0200, Jaap Keuter wrote: > A change I noticed is the way side-by-side code is presented in the code > review window. > This used to be two evenly spaced columns on the screen with horizontal > scroll bars when the lines were longer than the available

[Wireshark-dev] Gerrit - code review window

Hi, A change I noticed is the way side-by-side code is presented in the code review window. This used to be two evenly spaced columns on the screen with horizontal scroll bars when the lines were longer than the available width. Both scrollbars were synchronised to help sideways navigation. The

Re: [Wireshark-dev] Gerrit problems ?

On 8/8/18 4:40 AM, Jaap Keuter wrote: > > > I’m not sure what to make of this but I noticed the following: > After having a (rather unremarkable) change (28995) accepted and merged by > Anders (thanks Anders!) I received the usual two emails about this > (Code-Review +2, Merged). The remarkabl

Re: [Wireshark-dev] Gerrit problems ?

On Wed, Aug 8, 2018 at 1:40 PM Jaap Keuter wrote: > I’m not sure what to make of this but I noticed the following: > After having a (rather unremarkable) change ( 28995) accepted and merged > by Anders (thanks Anders!) I received the usual two emails about this > (Code-Review +2, Merged). The rem

Re: [Wireshark-dev] Gerrit problems ?

> On 8 Aug 2018, at 12:39, Peter Wu wrote: > > Hi Dylan. > > On Wed, Aug 08, 2018 at 10:01:38AM +0200, Peter Wu wrote: >> On Tue, Aug 07, 2018 at 09:30:38PM -0400, Dylan Ulis wrote: >>> Anybody else having Gerrit issues after the upgrade? Under Profile, my >>> username is blank. When I try to

Re: [Wireshark-dev] Gerrit problems ?

Hi Dylan. On Wed, Aug 08, 2018 at 10:01:38AM +0200, Peter Wu wrote: > On Tue, Aug 07, 2018 at 09:30:38PM -0400, Dylan Ulis wrote: > > Anybody else having Gerrit issues after the upgrade? Under Profile, my > > username is blank. When I try to re-enter my old username I get "Code > > Review - Error.

Re: [Wireshark-dev] Gerrit problems ?

Hi Dylan. On Tue, Aug 07, 2018 at 09:30:38PM -0400, Dylan Ulis wrote: > Anybody else having Gerrit issues after the upgrade? Under Profile, my > username is blank. When I try to re-enter my old username I get "Code > Review - Error. Username must contain only letters, numbers..." There appears to

[Wireshark-dev] Gerrit problems ?

Anybody else having Gerrit issues after the upgrade? Under Profile, my username is blank. When I try to re-enter my old username I get "Code Review - Error. Username must contain only letters, numbers..." Thanks, Dylan ___ Sen

Re: [Wireshark-dev] Gerrit down

On 8/7/18 12:04 PM, Gerald Combs wrote: > The updated time is correct. I'll start the upgrade in about two hours. > The upgrade is done and we're now running Gerrit 2.14.11. The new version features an updated UI which you can toggle by clicking on "Old UI" or "New UI" at the bottom of each pag

Re: [Wireshark-dev] Gerrit down

On 8/7/18 11:28 AM, Guy Harris wrote: > On Aug 7, 2018, at 1:30 AM, Dario Lombardo wrote: > >> Anyone has news about the upgrade process? > > For what it's worth, code.wireshark.org now says > > Gerrit will be down for maintenance on Tuesday, August 7 from 14:00 to > 15:00 PST (22:00 to

Re: [Wireshark-dev] Gerrit down

On Aug 7, 2018, at 1:30 AM, Dario Lombardo wrote: > Gerrit was expected to be upgraded yesterday. Now it seems down. Networking issues on a number of Wireshark sites. > Anyone has news about the upgrade process? For what it's worth, code.wireshark.org now says Gerrit will be down for

[Wireshark-dev] Gerrit down

Gerrit was expected to be upgraded yesterday. Now it seems down. Anyone has news about the upgrade process? -- Naima is online. ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wiresh

[Wireshark-dev] Gerrit 2.14 upgrade

I'm planning on upgrading our Gerrit installation from 2.12.7 to 2.14.11 this Monday at 2:00 pm PST (22:00 UTC). Gerrit 2.13 and 2.14 include many new features and improvements, including an updated user interface. https://www.gerritcodereview.com/releases/2.14.md https://www.gerritcodereview.co

Re: [Wireshark-dev] gerrit registration problems

On 02/20/2018 10:39 PM, Richard Sharpe wrote: On Tue, Feb 20, 2018 at 7:07 PM, Ed Beroset wrote: On 01/31/2018 09:44 AM, Ed Beroset wrote: I've submitted code to Wireshark in the past, but not since Gerrit. I tried again yesterday to register and now I remember why it's been so long -- I can

Re: [Wireshark-dev] gerrit registration problems

On Tue, Feb 20, 2018 at 7:07 PM, Ed Beroset wrote: > On 01/31/2018 09:44 AM, Ed Beroset wrote: >> >> I've submitted code to Wireshark in the past, but not since Gerrit. I >> tried again yesterday to register and now I remember why it's been so long >> -- I can't seem to register. Is this the pla

Re: [Wireshark-dev] gerrit registration problems

On 01/31/2018 09:44 AM, Ed Beroset wrote: I've submitted code to Wireshark in the past, but not since Gerrit.  I tried again yesterday to register and now I remember why it's been so long -- I can't seem to register.  Is this the place to ask for help, or is there a better way to do it? I may

Re: [Wireshark-dev] gerrit registration problems

Hi, I’m not an admin, but managed to check that ‘Ed Beroset http://ieee.org/>>’ is a recognised user in Gerrit. Hope it helps, Jaap > On 31 Jan 2018, at 19:36, Ed Beroset wrote: > > On 01/31/2018 11:36 AM, Jeff Widman wrote: >> What error message are you hitting when you try to register? > >

Re: [Wireshark-dev] gerrit registration problems

On 01/31/2018 11:36 AM, Jeff Widman wrote: What error message are you hitting when you try to register? I had two problems, which may be related. First, I appear to have been able to register, but when I tried to assign myself a user name, it rejected it saying that it needed to consist of o

Re: [Wireshark-dev] gerrit registration problems

On 01/31/2018 11:36 AM, Jeff Widman wrote: What error message are you hitting when you try to register? I had two problems, which may be related. First, I appear to have been able to register, but when I tried to assign myself a user name, it rejected it saying that it needed to consist of o

Re: [Wireshark-dev] gerrit registration problems

What error message are you hitting when you try to register? On Wed, Jan 31, 2018 at 6:44 AM, Ed Beroset wrote: > I've submitted code to Wireshark in the past, but not since Gerrit. I > tried again yesterday to register and now I remember why it's been so long > -- I can't seem to register. Is

[Wireshark-dev] gerrit registration problems

I've submitted code to Wireshark in the past, but not since Gerrit. I tried again yesterday to register and now I remember why it's been so long -- I can't seem to register. Is this the place to ask for help, or is there a better way to do it? Ed _

Re: [Wireshark-dev] Gerrit repository offline

t; Regards >> >> Anders >> >>   >> >> *From:*Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On >> Behalf Of *Roland Knall >> *Sent:* den 14 november 2017 07:49 >> *To:* Developer support list for Wireshark > <mailto:wireshark-dev

Re: [Wireshark-dev] Gerrit repository offline

... and we’re back. Happy coding! > On 14 Nov 2017, at 13:50, Roland Knall wrote: > > Hi > > We are working on it. No timeframe yet. > > Cheers > Roland ___ Sent via:Wireshark-dev mailing list Archives:https:/

Re: [Wireshark-dev] Gerrit repository offline

] On Behalf Of > Roland Knall > Sent: den 14 november 2017 07:49 > To: Developer support list for Wireshark > Subject: [Wireshark-dev] Gerrit repository offline > > Hi > > It appears the gerrit repository is offline, we

Re: [Wireshark-dev] Gerrit repository offline

Hi, Any prognosis on when it will be back? Info on the problem? Regards Anders From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Roland Knall Sent: den 14 november 2017 07:49 To: Developer support list for Wireshark Subject: [Wireshark-dev] Gerrit repository offline

[Wireshark-dev] Gerrit repository offline

Hi It appears the gerrit repository is offline, we are working on the issue. cheers, Roland ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wire

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

On Jul 6, 2017, at 2:58 PM, Graham Bloice wrote: > I have always found this amusing in times of git induced stress: > http://stevelosh.com/blog/2013/04/git-koans/ Thank you. I have added that to my bookmark collection. Losh's projects page: http://stevelosh.com/projects/ mentions a

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

On 6 July 2017 at 22:47, Guy Harris wrote: > On Jul 6, 2017, at 1:39 PM, Graham Bloice > wrote: > > > Careful, I only know enough git to work out things have gone wrong and > very specific ways of getting out of trobule. Glad to be of help. > > https://xkcd.com/1597/ (make sure you read

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

On Jul 6, 2017, at 1:39 PM, Graham Bloice wrote: > Careful, I only know enough git to work out things have gone wrong and very > specific ways of getting out of trobule. Glad to be of help. https://xkcd.com/1597/ (make sure you read the mouseover tooltip) http://forums.xkcd.co

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

gt; Behalf Of *Graham Bloice > *Sent:* 05 July 2017 13:17 > *To:* Developer support list for Wireshark > *Subject:* Re: [Wireshark-dev] Gerrit Patch Set Submission Problem > > > > > > > > On 5 July 2017 at 12:47, Paul Offord wrote: > > Hi, > > > > I’m s

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

...@wireshark.org] On Behalf Of Graham Bloice Sent: 05 July 2017 13:17 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Gerrit Patch Set Submission Problem On 5 July 2017 at 12:47, Paul Offord mailto:paul.off...@advance7.com>> wrote: Hi, I’m struggling with git again. I want to

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

Hi Paul You have a merge branch in between two syncro branches. That happens, when you are not working cleanly of branches, but instead pull changes into the master branch. Take a look at git log You should see your Syncro at the top, then a merge-branch and then again a syncro at the bottom. T

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

Cheers Graham – I’ll give that a go. Beer in the post. From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Graham Bloice Sent: 05 July 2017 13:17 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Gerrit Patch Set Submission Problem On 5 July

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

On 5 July 2017 at 12:47, Paul Offord wrote: > Hi, > > > > I’m struggling with git again. I want to submit a new patch set for > change 19666 - https://code.wireshark.org/review/#/c/19666/ > > > > When I try git review I get: > > > > C:\Development\wireshark>git review > > You are about to submit

[Wireshark-dev] Gerrit Patch Set Submission Problem

Hi, I'm struggling with git again. I want to submit a new patch set for change 19666 - https://code.wireshark.org/review/#/c/19666/ When I try git review I get: C:\Development\wireshark>git review You are about to submit multiple commits. This is expected if you are submitting a commit that is

Re: [Wireshark-dev] gerrit authentication

hi Jeff, > On 6 Oct 2016, at 20:19, Jeff Morriss wrote: > > > It was a problem (bug in Gerrit) but Gerald applied the fix. It works for me > now. > thanks for the advice. i know Gerald did a good work. regards. > _

Re: [Wireshark-dev] gerrit authentication

On Mon, Oct 3, 2016 at 3:32 PM, Francisco Javier Sanchez-Roselly < franciscojavier.sanchezrose...@ujaen.es> wrote: > dear all, > > since Friday, it is impossible for me to authenticate via Google. is it > just my issue? > > just a second one, is there a way to unsubscribe an email address from > C

[Wireshark-dev] gerrit authentication

dear all, since Friday, it is impossible for me to authenticate via Google. is it just my issue? just a second one, is there a way to unsubscribe an email address from Code Review avoiding login in Gerrit? thanks, regards. pd.- the reasoning for my questions: i have lost the Owner credential

Re: [Wireshark-dev] Gerrit upgrade tomorrow

On Sat, May 9, 2015 at 1:34 PM, Graham Bloice wrote: > > Seems to work for me, without needing to relink my old Google identity. > > Works for me, as well. ___ Sent via:Wireshark-dev mailing list Archives:https://www

Re: [Wireshark-dev] Gerrit upgrade tomorrow

On 5/9/15 4:34 AM, Graham Bloice wrote: > On 9 May 2015 at 01:34, Gerald Combs > wrote: > > The upgrade is complete. Logging in using your Google account, which was > initially OK and then not OK is once again OK. > > You can now link your GitHub account

Re: [Wireshark-dev] Gerrit upgrade tomorrow

On 9 May 2015 at 01:34, Gerald Combs wrote: > The upgrade is complete. Logging in using your Google account, which was > initially OK and then not OK is once again OK. > > You can now link your GitHub account as well. > > In either case if you have an existing account you should make sure your >

Re: [Wireshark-dev] Gerrit upgrade tomorrow

The upgrade is complete. Logging in using your Google account, which was initially OK and then not OK is once again OK. You can now link your GitHub account as well. In either case if you have an existing account you should make sure your identities are properly linked by doing the following: -

Re: [Wireshark-dev] Gerrit upgrade tomorrow

If your account is currently linked to a Google OpenID identity it should automatically link to its corresponding Google OAuth ID. I tried this yesterday on a test server and it worked fine. On 5/8/15 12:20 AM, Dario Lombardo wrote: > Hi Gerald > Do we still need to re-bind the google account to t

Re: [Wireshark-dev] Gerrit upgrade tomorrow

Hi Gerald Do we still need to re-bind the google account to the actual gerrit profile or will be automatically done based on the email address? Thanks Dario. On Fri, May 8, 2015 at 12:12 AM, Gerald Combs wrote: > Gerrit 2.10.4 has been released, which includes improved support for OAuth: > > > h

[Wireshark-dev] Gerrit upgrade tomorrow

Gerrit 2.10.4 has been released, which includes improved support for OAuth: https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.10.4.html I've scheduled an upgrade for 4:00 PM PDT tomorrow afternoon (23:00 UTC). The upgrade should re-enable authentication via Google at

Re: [Wireshark-dev] Gerrit upgrade schedule

On 16 April 2015 at 22:45, Pascal Quantin wrote: > > Le 16 avr. 2015 11:29 PM, "Gerald Combs" a écrit : > > > > On 4/16/15 1:17 PM, Pascal Quantin wrote: > > > 2015-04-02 1:06 GMT+02:00 Gerald Combs > > >: > > > > > > As was discussed last month, Google's OpenID

Re: [Wireshark-dev] Gerrit upgrade schedule

Le 16 avr. 2015 11:29 PM, "Gerald Combs" a écrit : > > On 4/16/15 1:17 PM, Pascal Quantin wrote: > > 2015-04-02 1:06 GMT+02:00 Gerald Combs > >: > > > > As was discussed last month, Google's OpenID is going away on the 20th. > > Logins to code.wireshark.org

Re: [Wireshark-dev] Gerrit upgrade schedule

On 4/16/15 1:17 PM, Pascal Quantin wrote: > 2015-04-02 1:06 GMT+02:00 Gerald Combs >: > > As was discussed last month, Google's OpenID is going away on the 20th. > Logins to code.wireshark.org using Google > will break on that d

Re: [Wireshark-dev] Gerrit upgrade schedule

2015-04-02 1:06 GMT+02:00 Gerald Combs : > As was discussed last month, Google's OpenID is going away on the 20th. > Logins to code.wireshark.org using Google will break on that date. The > Gerrit development team has been busy making releases recently to account > for this. Unfortunately, a chang

Re: [Wireshark-dev] Gerrit upgrade schedule

Hi Gerald, I'm looking forward to the new Gerrit! I note in the 2.9 release notes that the bugzilla integration has been rewritten; hopefully that migration goes smoothly. Evan On Wed, Apr 1, 2015 at 7:06 PM, Gerald Combs wrote: > As was discussed last month, Google's OpenID is going away on the

[Wireshark-dev] Gerrit upgrade schedule

As was discussed last month, Google's OpenID is going away on the 20th. Logins to code.wireshark.org using Google will break on that date. The Gerrit development team has been busy making releases recently to account for this. Unfortunately, a change which would allow both OpendID and OAuth2 logins

[Wireshark-dev] Gerrit StartSSL OpenID provider

Hi, Has anyone tried to link a StartSSL identity in Gerrit? I just tried to do so, but get a 401 Unauthorized back in Gerrit. Although not available in the UI, you can chose your own OpenID provider by hitting one of the provider buttons (e.g. StartSSL), then cancel by hitting Esc (Stop). Use Fir

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

> -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > boun...@wireshark.org] On Behalf Of Evan Huus > Sent: den 25 augusti 2014 19:32 > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] Gerrit patches with t

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On 25 August 2014 20:03, Joerg Mayer wrote: > On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote: > > When reviewing some submissions on Gerrit, I've noted a few with trailing > > whitespace. The git pre-commit hook always warns me of this, so how are > > folks managing to do this? A

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On Mon, Aug 25, 2014 at 06:06:15PM +0100, Graham Bloice wrote: > When reviewing some submissions on Gerrit, I've noted a few with trailing > whitespace. The git pre-commit hook always warns me of this, so how are > folks managing to do this? Are they using clients that ignore the hook? How about

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On 8/25/2014 1:48 PM, Alexis La Goutte wrote: Should we add some info then to the Dev Guide as to where to get the hook, It's already in http://wiki.wireshark.org/Development/SubmittingPatches#Setup We keep running into this problem - should the wiki page and the dev guide be consolidated? a

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On Mon, Aug 25, 2014 at 7:32 PM, Evan Huus wrote: > On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice > wrote: >> On 25 August 2014 18:17, Graham Bloice wrote: >>> >>> On 25 August 2014 18:11, Juan Jose Martin Carrascosa >>> wrote: I think that you are talking about my just committed cha

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On Mon, Aug 25, 2014 at 1:21 PM, Graham Bloice wrote: > On 25 August 2014 18:17, Graham Bloice wrote: >> >> On 25 August 2014 18:11, Juan Jose Martin Carrascosa >> wrote: >>> >>> I think that you are talking about my just committed changes. I just did >>> it and I just checked in the website tha

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On 25 August 2014 18:17, Graham Bloice wrote: > On 25 August 2014 18:11, Juan Jose Martin Carrascosa > wrote: > >> I think that you are talking about my just committed changes. I just did >> it and I just checked in the website that it has the whitespaces... >> >> As Evan said, I don't have it i

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

On 25 August 2014 18:11, Juan Jose Martin Carrascosa wrote: > I think that you are talking about my just committed changes. I just did > it and I just checked in the website that it has the whitespaces... > > As Evan said, I don't have it installed by default and I wasn't really > aware of the pr

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces... As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry. I w

[Wireshark-dev] Gerrit patches with trailing whitespace

When reviewing some submissions on Gerrit, I've noted a few with trailing whitespace. The git pre-commit hook always warns me of this, so how are folks managing to do this? Are they using clients that ignore the hook? -- Graham Bloice

Re: [Wireshark-dev] Gerrit patches with trailing whitespace

Probably they are simply not installing the hook - none of our tooling sets it up by default that I'm aware of. On Mon, Aug 25, 2014 at 1:06 PM, Graham Bloice wrote: > When reviewing some submissions on Gerrit, I've noted a few with trailing > whitespace. The git pre-commit hook always warns me

[Wireshark-dev] Gerrit usability and git web interface

Hi, First, a request: could the gitweb commit messages also be post- processed such that things like "Bug: XXX" and URLs become clickable? An arbitrary example that shows the expected and actual messages: https://code.wireshark.org/review/999/ https://code.wireshark.org/review/gitweb?p=wireshark.

Re: [Wireshark-dev] Gerrit Drafts

On 6/13/14 6:35 AM, Alexis La Goutte wrote: > On Fri, Jun 13, 2014 at 3:30 PM, Evan Huus wrote: > Hi Evan, > >> I was poking around gerrit a bit and I found an alternative way of handling >> WIP (work-in-progress) code. Apparently if you push to refs/drafts/BRANCH >> instead of refs/for/BRANCH (o

Re: [Wireshark-dev] Gerrit Drafts

On Fri, Jun 13, 2014 at 3:30 PM, Evan Huus wrote: Hi Evan, > I was poking around gerrit a bit and I found an alternative way of handling > WIP (work-in-progress) code. Apparently if you push to refs/drafts/BRANCH > instead of refs/for/BRANCH (or alternatively pass -D to git-review) the > review e

Re: [Wireshark-dev] Gerrit Drafts

I'm using them already. The difference is that if You use [WIP], the commit is visible to everybody by default, and for draft it is visible only to the author and to reviewers. On 13 June 2014 15:30, Evan Huus wrote: > I was poking around gerrit a bit and I found an alternative way of > handlin

[Wireshark-dev] Gerrit Drafts

I was poking around gerrit a bit and I found an alternative way of handling WIP (work-in-progress) code. Apparently if you push to refs/drafts/BRANCH instead of refs/for/BRANCH (or alternatively pass -D to git-review) the review ends up in a special draft state that gerrit handles. Thoughts on usi

Re: [Wireshark-dev] Gerrit down?

al Message- > From: Anders Broman > To: Developer support list for Wireshark ; > Gerald Combs > Sent: Sat, May 3, 2014 6:37 am > Subject: [Wireshark-dev] Gerrit down? > > Hi, > Is any one else havin

Re: [Wireshark-dev] Gerrit down?

Yes. I would say that it's down. -Original Message- From: Anders Broman To: Developer support list for Wireshark ; Gerald Combs Sent: Sat, May 3, 2014 6:37 am Subject: [Wireshark-dev] Gerrit down? Hi, Is any one else having problem accessing Gerrit? Regards A

[Wireshark-dev] Gerrit down?

Hi, Is any one else having problem accessing Gerrit? Regards Anders ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wire

Re: [Wireshark-dev] Gerrit Diff format

On 3/28/14 11:17 AM, Bill Meier wrote: > (To: Gerald) > > Currently the Gerrit diff shows whitespace changes. > > Previously, when viewing diffs of SVN commits via the web, whitespace > changes were not shown. > > If others agree, is it possible to configure the Gerrit diff to not show > whitesp

[Wireshark-dev] Gerrit Diff format

(To: Gerald) Currently the Gerrit diff shows whitespace changes. Previously, when viewing diffs of SVN commits via the web, whitespace changes were not shown. If others agree, is it possible to configure the Gerrit diff to not show whitespace changes ? (Or to provide an option ?) Bill __

Re: [Wireshark-dev] Gerrit versus Buildbot

On 3/26/14 6:06 AM, Bálint Réczey wrote: > 2014-03-21 22:24 GMT+01:00 Bálint Réczey : >> Hi, >> >> 2014-03-20 23:11 GMT-01:00 Guy Harris : >>> >>> On Mar 20, 2014, at 2:24 PM, Chris Kilgour wrote: >>> On 03/20/2014 01:07 PM, Gerald Combs wrote: > > If the build system had open access

Re: [Wireshark-dev] Gerrit versus Buildbot

2014-03-21 22:24 GMT+01:00 Bálint Réczey : > Hi, > > 2014-03-20 23:11 GMT-01:00 Guy Harris : >> >> On Mar 20, 2014, at 2:24 PM, Chris Kilgour wrote: >> >>> On 03/20/2014 01:07 PM, Gerald Combs wrote: If the build system had open access what would keep someone from uploading a shell

Re: [Wireshark-dev] Gerrit versus Buildbot

Hi, 2014-03-20 23:11 GMT-01:00 Guy Harris : > > On Mar 20, 2014, at 2:24 PM, Chris Kilgour wrote: > >> On 03/20/2014 01:07 PM, Gerald Combs wrote: >>> >>> If the build system had open access what would keep someone from >>> uploading a shell script containing a box full of weasels wearing clown >

Re: [Wireshark-dev] Gerrit versus Buildbot

On Mar 20, 2014, at 2:24 PM, Chris Kilgour wrote: > On 03/20/2014 01:07 PM, Gerald Combs wrote: >> >> If the build system had open access what would keep someone from >> uploading a shell script containing a box full of weasels wearing clown >> shoes? > > Isn't the same thing true for Jenkins/

Re: [Wireshark-dev] Gerrit versus Buildbot

Fyi, the current Version of Jenkins works just fine with gerrit 2.8.2 on my setup. Regards, Roland Am Donnerstag, 20. März 2014 schrieb Gerald Combs : > On 3/20/14 11:40 AM, Chris Kilgour wrote: > > Just had the unpleasant experience of having a patch submitted to gerrit > where it sat for nearl

Re: [Wireshark-dev] Gerrit versus Buildbot

On 03/20/2014 01:07 PM, Gerald Combs wrote: > > If the build system had open access what would keep someone from > uploading a shell script containing a box full of weasels wearing clown > shoes? Isn't the same thing true for Jenkins/buildbot spawned from gerrit? Surely the build machines must

Re: [Wireshark-dev] Gerrit versus Buildbot

On 3/20/14 11:40 AM, Chris Kilgour wrote: > Just had the unpleasant experience of having a patch submitted to gerrit > where it sat for nearly one month, just got merged after a code review, then > got reverted when buildbot revealed issues. > > When I have submitted to other gerrit-based projec

[Wireshark-dev] Gerrit versus Buildbot

Just had the unpleasant experience of having a patch submitted to gerrit where it sat for nearly one month, just got merged after a code review, then got reverted when buildbot revealed issues. When I have submitted to other gerrit-based projects like OpenOCD, they have an automated build syste

Re: [Wireshark-dev] Gerrit Stuck?

ssh -p 29418 Code.wireshark.org gerrit And he will Print the help Regards Am Donnerstag, 27. Februar 2014 schrieb Hadriel Kaplan : > > And we just had an email mid-air collision. :) > > I can't abandon them, because I can't access them at all through the web > page. > Is there some way to aband

Re: [Wireshark-dev] Gerrit Stuck?

On Thu, Feb 27, 2014 at 3:05 PM, Gerald Combs wrote: > We appear to have had a mid-air collision. The server log has the > "Concurrent modification detected" and duplicate key errors described in > Gerrit bug 2034: > > http://code.google.com/p/gerrit/issues/detail?id=2034 Yikes. Thanks for cleani

Re: [Wireshark-dev] Gerrit Stuck?

Scratch that - looks like you did it already. Well that was exciting. :) -hadriel On Feb 27, 2014, at 3:35 PM, Hadriel Kaplan wrote: > > Actually shouldn't it be Evan who abandons them? I assumed the cherry-pick > mode of gerrit meant he was cherry-picking my branch patch commit, creating

Re: [Wireshark-dev] Gerrit Stuck?

I was able to abandon them through the web interface. On 2/27/14 12:12 PM, Hadriel Kaplan wrote: > > And we just had an email mid-air collision. :) > > I can't abandon them, because I can't access them at all through the web page. > Is there some way to abandon them through command line? > > -h

Re: [Wireshark-dev] Gerrit Stuck?

Actually shouldn't it be Evan who abandons them? I assumed the cherry-pick mode of gerrit meant he was cherry-picking my branch patch commit, creating a new commit, and merging the new one into master. So it's his commit that needs to be abandoned no? (I'm willing to try it, but I just don't

Re: [Wireshark-dev] Gerrit Stuck?

ssh -p 29418 Code.wireshark.org gerrit And he will Print the help Regards Am Donnerstag, 27. Februar 2014 schrieb Hadriel Kaplan : > > And we just had an email mid-air collision. :) > > I can't abandon them, because I can't access them at all through the web > page. > Is there some way to aband

  1   2   >