if
"someone" doesn't like what I've done.
--
Best regards
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wi
Am 23.07.2020 um 20:58 schrieb Jaap Keuter:
> That smells like a bug to me.
I'll submit a patch for this.
proto_item_get_display_repr() is only used in two other dissectors. The
function itself has no comments and is not mentioned in the readme.
I'd expect to get the same string back as its displ
r_len().
Is there a good reason for this or a bug?
--
Cheers,
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/o
ssector). Other that it takes some time and memory, I didn't notice
any problems.
Is there any reason why it's limited to exactly 500?
Would it be possible to make this limit configurable in the Wireshark
settings dialog?
Am 10.08.2019 um 19:59 schrieb Roland Knall:
> The main reason why the preference pane did not work, where, that
> QT_TR_NOOP did not take. I moved the texts inside the class which seemed to
> do the trick. I will walk through the rest of the application and see if
> this is also the case in some
Hi Uli,
do you know who is doing the backport of the translation files from
transifex to Wireshark?
I've seen that at transifex all entries in master are translated now,
but they aren't in the wireshark_de.ts file.
--
Thomas
___
I've seen Roland has fixed this.
Roland, are you also working on the other translation problems in the
preferences dialog?
--
Thomas
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wir
elements can't be translated.
I guess for the protocol preferences it's not possible as the texts are
inside the protocol dissectors.
--
Cheers
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:
On 10 Jul 2019, at 08:37, Tomasz Moń wrote:
> My general experience with splitting big changes into small commits
> *after* they are done is rather bad. That is, the artificially
> splitted changes I have seen were failing to work (sometimes even fail
> to compile individually). As I find such ar
Hi,
I've made a relative big change to the existing dissector for s7comm.
I added further decoding of some functions, but first I had to implement
packet reassembly.
This also results in minor changes to some existing functions.
Should I commit all changes at once (diff will look very messy, gitl
On 13.01.2018 08:31, Roland Knall wrote:
> Could you create a bug entry for this, including an example trace,
> with which we could demonstrate this behavior ?
There is still an issue with this. Should I reopen the bug or create a
new one?
The subtree is now opened correctly, but only if you have
On 13.01.2018 08:31, Roland Knall wrote:
> Could you create a bug entry for this, including an example trace,
> with which we could demonstrate this behavior ?
Done.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340
On Windows 7 64 Bit it's the same problem.
Does no one else notice this?
Hi,
when I build Wireshark from the current git repository, I get a
different behaviour in tracking expanded/collapsed subtrees compared to
the latest stable 2.4.4.
In 2.4.4 if I have expanded a 2nd level (or deeper) subtree element like
tcp.flags and then selected another packet, then also the tr
On 25.10.2017 18:36, Jeff Morriss wrote:
> Typically how multiple PDUs are handled is by setting a "fence" in the INFO
> column. Calling col_clear() only clears as far back as the fence; this
> allows upper-layer dissectors to clear what the lower-layer dissector(s)
> put in the INFO column--but
Hi Guy,
thank you for the detailled answer.
I've started writing a patch, but that would have looked a little
different to yours. I smelled that there are things on other systems
which I aren't aware of.
--
Best Regards
Th
When I open a logfile captured in a different timezone, then timezone
will show MESZ/MEZ for me as arrival timezone. Which is at least not
correct, as struct tm (from windows time.h) contains no information
about the timezone or gmt-offset.
--
Cheers
Thomas
On 01.11.2016 12:05, Pascal Quantin wrote:
> Why not simply select the right function based on ft type? For FT_(U)INT40
> and above use the functions I indicated earlier.
Now someone can use a value_string inside a bitmask field, even if the
type FT_UINT64 is used.
If I change it so you have to u
On 31.10.2016 17:02, Pascal Quantin wrote:
> Looks like no one is currently working on it (or at least no patch is
> queued in Gerrit yet). As you seem to be the fist user of those functions
> with 64bits fields, you are probably a good candidate to submit a patch as
> you can easily test it ;)
>
On 31.10.2016 11:53, Thomas Wiens wrote:
> On 31.10.2016 08:10, Pascal Quantin wrote:
>
>> Because we overlooked this. I intended to change it today but Guy was
>> faster than me. Nightly master-2.0, master-2.2 and master builds should
>> behave properly. If you need
On 31.10.2016 08:10, Pascal Quantin wrote:
> Because we overlooked this. I intended to change it today but Guy was
> faster than me. Nightly master-2.0, master-2.2 and master builds should
> behave properly. If you need to use a stable released version, then you
> need to create the tree and sub e
On 30.10.2016 22:52, Pascal Quantin wrote:
> When looking at proto_item_add_bitmask_tree() it looks like
> proto_tree_add_uint64() is called both for FT_UINT64 and ft_INT64 (which
> seems surprising, not to say wrong). Until this gets clarified, you might
> get more success by manually creating th
On 30.10.2016 22:54, Guy Harris wrote:
> But you said it was a 64-bit unsigned integer:
>
> { "Error code", "s7comm-plus.returnvalue.errorcode", FT_UINT64, BASE_HEX,
> NULL, 0x,
>NULL, HFILL }},
>
> Try saying it's a 16-bit signed integer - FT_INT16 - instead.
Does not wor
Hi,
I'm working on a protocol where I want to use proto_tree_add_bitmask for
a 64 Bit value.
You can see the structure in the attached screenshot.
This are my hf definitions (1st one is the header, the other ones are
the fields):
{ &hf_s7commp_data_returnvalue,
{ "Return value", "s7comm-plus.ret
On 21.10.2016 22:49, Michael Mann wrote:
>
> Depending on what you're doing, you could go with
> proto_tree_add_xxx_format_value. I think that's how most dissectors
> end up avoiding the need for BASE_CUSTOM callback.
Maybe one of you has another solution for what I want to realize.
In my prot
On 21.10.2016 22:17, Guy Harris wrote:
> On Oct 21, 2016, at 1:08 PM, Jaap Keuter wrote:
>
>> For my understanding, would this be covered by using
>> val_to_str_wmem(wmem_file_scope(), val, vs, fmt);
>
> Yes, but the strings will remain allocated until the capture file is closed,
> even if that
Hi,
I'am using fieldtype BASE_CUSTOM and a callback function in my own
dissector.
Works well, but when I am calling val_to_str with a value which is not
inside the value_string list, then wireshark crashes.
This happens only when calling val_to_str inside the callback function.
When outside, then
Hi,
I've just noticed that a dissector bug is not shown in the "Expert Info"
field, with the current build from git master.
I remember seeing a "malformed" in Expert Info field in previous
versions. Or is it now an option where I have to enable this?
Also the view from Menu Analyze -> Expert Info
ere are some), or if there is none, by the cycle-counter differences.
But the Profinet dissector is still a plugin, I don't know if it's
possible to write a tap (which I think is needed) for a dissector which
comes as a plugin. Is there any reason why it'
As it seems not easy solvable, is it really neccessary to use the UTF-8
for dotdotdot and not plain ascii three dots?
On Windows 7 I don't see any difference between the two versions.
There are some other UTF-8 characters used inside the .cpp files, but
the UTF8_HORIZONTAL_ELLIPSIS is most often u
found out that changing the entry in "wireshark_de.ts" to:
Check for Updates…
still does the job.
I have missed the point to regenerate the .qm file, calling lrelease
program from Qt directory.
But the .ts files are automatically generated by lupdate from the
cpp-sourcefiles. So manually adding t
r Updates…
does not help.
Any suggestions how to fix this?
--
Regards
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org
On 02.01.2016 21:40 Graham Bloice wrote:
> What version of Git do you have? In your case it looks like git bash is
> being called and isn't able to execute tools\runlex.sh.
>
> I have git version 2.6.4.windows.1 installed, and the only element of that
> installation on my path is "C:\Program Fil
On 02.01.2016 18:06 Graham Bloice wrote:
> Can you try:
>
> msbuild /p:Configuration=RelWithDebInfo /t:clean
> .\docbook\user_guide_docbook.vcxproj
>
> to clean the user guide docbook target, followed by:
>
> msbuild /p:Configuration=RelWithDebInfo
> .\docbook\user_guide_docbook.vcxproj
On 02.01.2016 17:23 Graham Bloice wrote:
> I can't see what the error is from so little context. You're using the
> same build approach, i.e. CMake and the same environment with VS2010 and
> that works?
No, VS2010 on Win7/32 using nmake, works.
New computer, VS2013, Win7/64, used the actual gui
ave to
add this, or why they aren't automatically added as in all other paths.
Best Regards
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: h
not up to date, or is there an error in the file?
I have to mention that I don't have Qt installed.
Thanks,
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:https://www.wireshark.org/lists/wireshar
Hi,
I've got a comment in the code review, that I can use
proto_tree_add_item instead of proto_tree_add_uint.
I have used proto_tree_add_uint() when the value which is added is
needed for packet dissection (e.g. to decide which path is to follow).
Should I change all of my proto_tree_add_uint()
On 22 August 2014 16:44, Bill Meier wrote:
>
> See my comment to you on the new patch
>
> https://code.wireshark.org/review/#/c/3794/
>
I've got a question to the "Reply 'Done'" Button in gerrit.
Should I use it when I think I've fixed what's mentioned in the comment,
or is/should it done by t
On 22 August 2014 16:05, wrote Graham Bloice:
> As I noted on the review, I think you must have removed the Change-ID: line
> from the commit message that Gerrit uses to track a new patch set for an
> existing change.
>
> You should have used `git commit --amend` to commit and use the existing
>
Hi,
I've just commited a fixed version.
I think I did something wrong. In the review system it is shown as a new
version.
I used:
git commit -a
git review
--
Thomas
___
Sent via:Wireshark-dev mailing list
Archives:h
On 22 August 2014 00:03, Graham Bloice wrote:
> Create a batch file containing something like:
>
> REM Environment setup for Wireshark using VS2010
> set CYGWIN=nodosfilewarning
> set WIRESHARK_BASE_DIR=E:\Wireshark
> set WIRESHARK_TARGET_PLATFORM=win32
> set QT5_BASE_DIR=C:\qt\Qt-5.1.1-MSVC2010-
On 21 August 2014 21:41, Jeff Morriss wrote:
> For the short term, I'd suggest doing:
>
> git stash
> git review [-f]
> git stash pop
>
> There might be a better answer longer term--maybe one of the guys who
> actually uses Windows has practical suggestion.
It works! Thanks.
Is that a problem
On 21 August 2014 21:10, Jeff Morriss wrote:
> What does "git status" say at this point?
>
Thomas@VORTEX /c/Development/wireshark (s7comm)
$ git status
On branch s7comm
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard c
On 21 August 2014 16:25, Graham Bloice wrote:
> Don't confuse git and Gerrit. Use git to add files to your staging area
> and then commit them to your repository, and then push the commit to
> Gerrit, where the Gerrit review process takes over.
I've got gerrit review running, and commited the fi
On 21 August 2014 15:14, Graham Bloice wrote:
> Have a look at the Wiki page on submitting patches:
> http://wiki.wireshark.org/Development/SubmittingPatches which advises using
> the Gerrit helper git-review
>
Oh man, that's a hard task to upload 4 files.
Is this review addon absolute necessar
On 21 August 2014 14:46, Michal Orynicz wrote:
> Hi,
> the best line of doing this would be going to
> https://code.wireshark.org/review/, registering there and then pushing Your
> change to https://code.wireshark.org/review/wireshark . This way the
> changes will go through review in gerrit, and n
ster/s7comm
I don't know how to fix the problem with the concurrent T.125 dissector,
seems that my captures are also valid T.125 protocols.
Thanks,
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:
of view?
The website is:
http://sourceforge.net/projects/s7commwireshark/
There are some sample captures available.
--
Regards
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:http://www.wireshark.org/lists/wi
here
"choice_index" is the function parameter "val".
But "val" is several times calculated, shifted and so on, that I don't
know what value comes out.
Is there a possibilitiy to make the heuristic check of the T.125
protocol stronger?
--
Thomas Wiens
__
x27;t need the proto-id. Seems
as if I can register a new pointer-array in every file, or not?
--
Regards
Thomas Wiens
___
Sent via:Wireshark-dev mailing list
Archives:http://www.wireshark.org/lists/wireshark-dev
U
er fields (e.g. comments in status
bar).
At this time I'm using the proto_tree_add_text() in my 'outsourced'
functions to display the dissected items.
Thanks!
--
Regards
Thomas Wiens
___
Sent
51 matches
Mail list logo
