Re: [Wireshark-dev] Exporting FTP objects

2021-12-14 Thread Moshe Kaplan
ts were dissected to generate the export object list entries then. Moshe On Tue, Dec 14, 2021 at 1:11 PM Richard Sharpe wrote: > On Tue, Dec 14, 2021 at 9:34 AM Moshe Kaplan > wrote: > > > > Good afternoon, > > > > I've been working on MR 1611 for exporting FTP

[Wireshark-dev] Exporting FTP objects

2021-12-14 Thread Moshe Kaplan
Good afternoon, I've been working on MR 1611 for exporting FTP objects. One of the complexities is that because the transmitted FTP files are spread across multiple "packets", they need to be reassembled by the export objects 'tap' int

Re: [Wireshark-dev] Replacing wmem_packet_scope() with pinfo->pool?

2021-07-21 Thread Moshe Kaplan
Coverity is complaining that some of the allocations made with pinfo -> pool are leaking. Is it possible that the pinfo->pool based allocations are not always cleaned up? As an example, CoverityID 1487512 complains about packet-tcp.c's calls to port_with_resolution_to_str leaking: https://gitlab.c

Re: [Wireshark-dev] Can the OSS-FUZZ tool be modified to generate a pcap test file?

2021-05-27 Thread Moshe Kaplan
I believe Peter Wu created a script a while back to do that and published it here: https://github.com/Lekensteyn/wireshark-fuzztools Moshe On Thu, May 27, 2021 at 12:37 PM Richard Sharpe wrote: > Hi folks, > > It seems like the OSS-FUZZ tool is very useful in finding certain > types of problems

[Wireshark-dev] Fwd: [Season of Docs - Announcements] The 2021 Season of Docs application for organizations is open!

2021-02-10 Thread Moshe Kaplan
Is this worth participating in again? Moshe -- Forwarded message - From: Season of Docs - Announce Date: Tue, Feb 9, 2021 at 1:09 PM Subject: [Season of Docs - Announcements] The 2021 Season of Docs application for organizations is open! To: Season of Docs - Announce We’re del

Re: [Wireshark-dev] Dissector functions and variables that could be static

2021-01-23 Thread Moshe Kaplan
Would it also be possible to build this script into a GitLab CI job, to detect and prevent the issue from recurring? Moshe On Sat, Jan 23, 2021 at 11:45 AM Martin Mathieson via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > Hi, > > I wrote a script to check whether variables and functions

[Wireshark-dev] Google - Finding Critical Open Source Projects

2020-12-10 Thread Moshe Kaplan
https://opensource.googleblog.com/2020/12/finding-critical-open-source-projects.html If you look at the listing of the top 200 C programs ( https://commondatastorage.googleapis.com/ossf-criticality-score/index.html), you can see Wireshark listed as number 114. Moshe _

Re: [Wireshark-dev] GSoD approved technical writer - community bonding phase

2020-08-17 Thread Moshe Kaplan
1. The Wireshark manuals are written with docbook. The text is in the wsug_src directory here: https://gitlab.com/wireshark/wireshark/-/tree/master/docbook . Information on submitting patches is available here: https://gitlab.com/wireshark/wireshark/-/wikis/Development/SubmittingPatches 2. The miss

[Wireshark-dev] Lua API - register_menu unavailable after launch?

2020-02-23 Thread Moshe Kaplan
The register_menu function in Lua API can only be called when Wireshark is first launched, as can be seen from how register_menu is replaced with wslua_not_register_menu in init_wslua.c : https://github.com/wireshark/wireshark/blob/20800366ddbbb2945491120afe7265796c26bf11/epan/wslua/init_wslua.c#L1

Re: [Wireshark-dev] Wireshark Developer's Guide bad URL

2019-11-19 Thread Moshe Kaplan
Thanks for reporting; I submitted https://code.wireshark.org/review/#/c/35146/ to fix this issue. Moshe On Tue, Nov 19, 2019 at 7:21 PM Gavin Higham wrote: > I noticed on this page of the Wireshark Developer's Guide something that > looks like it should have become a URL after a text replacemen

Re: [Wireshark-dev] Two typos is wireshark manual

2019-10-07 Thread Moshe Kaplan
Nice catches Nan. I've submitted https://code.wireshark.org/review/#/c/34725/ and https://code.wireshark.org/review/#/c/34726/ for fixing repeated words in the WSUG and WSDG. I've also submitted https://code.wireshark.org/review/34727 to (hopefully) improve the opening sentences. Moshe On Mon,

Re: [Wireshark-dev] Wireshark User’s Guide comment

2019-07-23 Thread Moshe Kaplan
Good catch. I've submitted https://code.wireshark.org/review/34062 to fix this issue. Moshe On Mon, Jul 22, 2019 at 11:14 AM Field, James via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > Hi, > > > > Thanks for the Wireshark User’s Guide. > > > > In the PD

Re: [Wireshark-dev] core dump when parsed VoIP call with text media

2019-05-31 Thread Moshe Kaplan
Please a file on the Wireshark bugzilla: https://bugs.wireshark.org/bugzilla/enter_bug.cgi?product=Wireshark You can include the PCAP, exact version, stack traces, and any other information that may be relevant for debugging. Moshe On Fri, May 31, 2019 at 2:52 PM Sergey Safarov wrote: > I comp

Re: [Wireshark-dev] Volunteers and ideas needed for Google Season of Docs

2019-04-12 Thread Moshe Kaplan
6) Remediating the known documentation issues in Bugzilla: https://bugs.wireshark.org/bugzilla/buglist.cgi?component=Documentation&list_id=55638&product=Wireshark&resolution=--- Moshe On Fri, Apr 12, 2019 at 9:32 AM Moshe Kaplan wrote: > Some specific ideas from what I'v

Re: [Wireshark-dev] Volunteers and ideas needed for Google Season of Docs

2019-04-12 Thread Moshe Kaplan
Some specific ideas from what I've noticed (mostly in the User Guide): 1) There are 35 menu items that aren't documented in the User Guide. These are indicated in the docs as " Not yet written. See https://wiki.wireshark.org/Development/SubmittingPatches"; 2) The User Guide references the Wiki (I'

Re: [Wireshark-dev] Statistical Analysis of pcapng files

2019-04-03 Thread Moshe Kaplan
It may be easiest to extract the pcap data as JSON with: "tshark -r mypcap -T json" Moshe On Wed, Apr 3, 2019, 3:31 PM Ross Jacobs wrote: > Hi Paul, > > It looks like there is a package called crafter > to work with pcap files, which fits > with extracting/