[Wireshark-dev] Re: wiretap vs text2pcap

2025-05-05 Thread Michael Mann via Wireshark-dev
; like I would want for the PEAK wiretap interface. On Monday, May 5, 2025 at 01:43:19 PM EDT, Guy Harris wrote: On May 5, 2025, at 8:24 AM, Michael Mann via Wireshark-dev wrote: > There have been several times where I've been given a simple, text-based > capture file fo

[Wireshark-dev] wiretap vs text2pcap

2025-05-05 Thread Michael Mann via Wireshark-dev
There have been several times where I've been given a simple, text-based capture file for Serial or CAN communications.  My (quick and dirty) solution has been to write a text2pcap derived application to convert the file to pcapng format and then view it Wireshark.  The packet dissection support

Re: [Wireshark-dev] a bug or a feature

2021-11-04 Thread Michael Mann via Wireshark-dev
One of the other main reasons is that some users switch between different versions of Wireshark and if a preference has been "removed" (not registered as obsolete) the preferences file will be modified to have that preference removed, which would result in it being restored to a "default" value

Re: [Wireshark-dev] LUA chained dissector drops data parameter

2019-11-29 Thread Michael Mann via Wireshark-dev
Using proto data "works" and I believe is used in a few places, but is not a preferred solution because it makes "dissector flow" much harder to follow and maintenance more difficult.  I have spend some time converting dissectors to pass dissector data directly instead of using proto data. I'm n

Re: [Wireshark-dev] Do we have a "standard" way to calcucate CRC24?

2019-09-18 Thread Michael Mann via Wireshark-dev
If you would like to use the CRC24 calculation from packet-gprs-llc.c, my recommendation would be to move it to a new crc24.[c|h] file in /wsutil and probably a crc24-tvb.[c|h] in /epan directory.  As you can see from the other CRC files, there isn't always a single "standard" way to calculate a

Re: [Wireshark-dev] What is best way to use other protocol subdissectors?

2019-01-31 Thread Michael Mann via Wireshark-dev
What is the format of the IEEE-1722 "CAN message"?  From my experience there are many different formats for CAN, so I think it's abstracted as best it can be.  The SocketCAN "packet format" isCAN ID (4 bytes).  Since CAN IDs are typically 11 or 29-bits, SocketCAN uses some of the higher bits for

Re: [Wireshark-dev] The 802.11 dissector is a big hairy ball of wax that needs to be refactored in some way

2019-01-07 Thread Michael Mann via Wireshark-dev
There are a number of dissector tables used, so I thought the TAGs and Extended TAGs could be moved around.  You would just have to move thedissector_add_uint("wlan.tag.number", … along with the function. If enums/value_strings need to be shared for breaking the dissector up into multiple files,

Re: [Wireshark-dev] dfilter functions

2019-01-06 Thread Michael Mann via Wireshark-dev
len - Checks the string length of "string types" (FT_STRING, FT_STRINGZ, FT_UINT_STRING, FT_STRINGZPAD) or array length of "byte types" (FT_BYTES, FT_UINT_BYTES) and does a compare. Examples:len(smpp.message_id)  > 10len(smpp.message) > 25 size - Checks the size of the field in a packet.  Can be

Re: [Wireshark-dev] Retrieving dissection result from another dissector

2018-07-04 Thread Michael Mann via Wireshark-dev
My objection to using p_proto_add_data in the particular case (passing data between dissectors) is that it makes the code/flow much harder to read and mistakes can result (usually found through fuzztesting) because the data flow isn't obvious. I think the most "common" case is still a dissecto

Re: [Wireshark-dev] Switch to C++11 or C++14

2018-06-02 Thread Michael Mann via Wireshark-dev
What features of C++11 and 14 do you plan to use and where? I know we've had the C vs C++ discussion before and I'd still vote for keeping things where they are as far as "GUI" is C++ and epan + dissectors (i.e. libwireshark) as C. I'm a little more indifferent to the "peripherals"/tools. Ot

Re: [Wireshark-dev] Subtree expand/collapse tracking

2018-01-15 Thread Michael Mann via Wireshark-dev
I'd just reopen the existing bug. -Original Message- From: Thomas Wiens To: wireshark-dev Sent: Mon, Jan 15, 2018 12:51 pm Subject: Re: [Wireshark-dev] Subtree expand/collapse tracking On 13.01.2018 08:31, Roland Knall wrote:> Could you create a bug entry for this, including an exa

[Wireshark-dev] Qt 4 and template support

2017-12-26 Thread Michael Mann via Wireshark-dev
I've been working on converting a lot of the Qt GUI that uses QTreeWidgetItem into using a model/view architecture that better separates data from GUI. Some of the dialogs I've converted have a simple tree/leaf architecture that lends itself to creating a simple "data" class that holds the par

Re: [Wireshark-dev] OSCORE dissector

2017-12-19 Thread Michael Mann via Wireshark-dev
Mališa, I think you are approaching this correctly in making OSCORE a separate protocol for now. The deciding point may be overall size of "OSCORE only" code and how much of the CoAP dissector API you have to put in a header file. Remember dissectors don't always equal protocols, so you may

Re: [Wireshark-dev] GTK version broken in master?

2017-12-18 Thread Michael Mann via Wireshark-dev
Well it was nice of you to break it ;) See https://code.wireshark.org/review/24885. I had a heck of time hunting this down. Part of the problem was that I had (capture) preferences changed (capture.real_time_update) and I'm not sure how they were changed. Not sure if the bug created befor

Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-14 Thread Michael Mann via Wireshark-dev
er support list for Wireshark Cc: Michael Mann Sent: Tue, Nov 14, 2017 2:53 am Subject: Re: [Wireshark-dev] Multiple TRANSUM fixes Apart from broken ability, how should gerrit behave with multiple "Bug:" tags? With one, once the change gets merged, it closes the bug on bugzilla. Bu

Re: [Wireshark-dev] Multiple TRANSUM fixes

2017-11-13 Thread Michael Mann via Wireshark-dev
You need separate line for each bug, ie. Bug: 12345 Bug: 12346 Bug: 12347 When you do that on the initial push, gerrit will mark the bugs. If you do it after the initial commit, the bugs will only be notified when patch is submitted to master. The ability for Gerrit to actually move bug to

Re: [Wireshark-dev] MASTER wsutil.lib won't build

2017-10-26 Thread Michael Mann via Wireshark-dev
I'm having the same problem. https://code.wireshark.org/review/24080/ fixed it for me. -Original Message- From: Paul Offord To: Developer support list for Wireshark Sent: Thu, Oct 26, 2017 1:15 pm Subject: [Wireshark-dev] MASTER wsutil.lib won't build Hi, I’m building Wires

Re: [Wireshark-dev] Duplicate dissectors (anonymous) and (anonymous) for protocol xxx

2017-10-25 Thread Michael Mann via Wireshark-dev
If you create separate dissector handles with a protocol, how is a user using "Decode As" functionality supposed to know which dissection function will be picked? That's why the check was added. You can have the same protocol ID between TCP and UDP, but you can't have the same one twice in TCP

Re: [Wireshark-dev] Reusing the code for various things in ieee802.11 in other dissectors ...

2017-10-15 Thread Michael Mann via Wireshark-dev
-Original Message- From: Richard Sharpe To: Developer support list for Wireshark Sent: Sat, Oct 14, 2017 1:47 pm Subject: [Wireshark-dev] Reusing the code for various things in ieee802.11 in other dissectors ... > Hi folks, > > I am almost finished a dissector for the IEEE1905 M

Re: [Wireshark-dev] XXXX: avoid appending xxxx multiple times to frame.protocols field

2017-10-06 Thread Michael Mann via Wireshark-dev
There's also this explanation: https://www.wireshark.org/lists/wireshark-dev/201701/msg5.html -Original Message- From: Pascal Quantin To: Developer support list for Wireshark Sent: Fri, Oct 6, 2017 3:06 am Subject: Re: [Wireshark-dev] : avoid appending multiple times to

Re: [Wireshark-dev] Is there any example C dissectors I can study?

2017-09-22 Thread Michael Mann via Wireshark-dev
Description beyond the filename? No. But I'd turn it around and ask "what kind of dissector are you trying to make"? If its a protocol that runs over TCP or UDP, we can probably point you to some of the "simpler" ones to get started. There are also many dissectors for other underlying layer

Re: [Wireshark-dev] Best way to give configuration information to a protocol

2017-09-18 Thread Michael Mann via Wireshark-dev
I would agree that a dissector table for the GUIDs is probably the best way to go. I also just created a GUID dissector table in my recent work with Netmon. grep "netmon.provider_id" for example of how to setup a GUID dissector table (it's much more straightforward than the DCE/RPC one) --

Re: [Wireshark-dev] Add a protocol to the "decode as" option

2017-09-18 Thread Michael Mann via Wireshark-dev
Juan Jose, Pascal is correct that you need to setup a dissector table, but you also need to set and register a "decode as structure" (decode_as_t) using register_decode_as. Your "RTPS payload" should fall into one of 2 categories: 1. You have a "unique identifier" that determines how to di

Re: [Wireshark-dev] causes for losing COL_PROTOCOL or COL_INFO data

2017-09-16 Thread Michael Mann via Wireshark-dev
I would have blamed having logic under pinfo->fd->flags.visited, but since Wireshark does 2 passes (one with visited = FALSE, other visited = TRUE), your columns should never be populated. Subsequent dissection from changing display filters will continue to have pinfo->fd->flags.visited = TRUE

Re: [Wireshark-dev] Improving Network Monitor (and Message Analyzer) dissection supp

2017-09-12 Thread Michael Mann via Wireshark-dev
opher Smith To: wireshark-dev Sent: Tue, Sep 12, 2017 2:18 am Subject: Re: [Wireshark-dev] Improving Network Monitor (and Message Analyzer) dissection supp For Michael Mann, thanks for your message dated “Sat, 9 Sep 2017 11:30:31 -0400” – and does it work for you now? Opening a *.cap ex

Re: [Wireshark-dev] unit_name_string for FT_STRING field types?

2017-09-11 Thread Michael Mann via Wireshark-dev
Are you suggesting "unit types" for "strings" or are you suggesting "unit types" for "string values that should really be considered integers or floats"? It certainly sounds like the latter and in which case I would suggest converting them in your dissector. Numeric fields that are treated a

[Wireshark-dev] Improving Network Monitor (and Message Analyzer) dissection support in Wireshark

2017-09-09 Thread Michael Mann via Wireshark-dev
I started working on the problem of having Wireshark read packet comments from Network Monitor (NetMon) (.cap) files. It escalated quickly and I found myself implementing way more functionality than I had intended just because of the information I stumbled across (and being "in the neighborhood

Re: [Wireshark-dev] Enrich tshark data

2017-09-09 Thread Michael Mann via Wireshark-dev
Adding on to Jaap's comments, because this is a particularly interesting case that you picked. There are 2 fields here, the "HTTP status code" (as an integer), "http.response.code" and the "HTTP status code 'meaning'" (as a string, i.e. "OK"), "http.response.code.desc". The "HTTP status cod

Re: [Wireshark-dev] Default encodage for FT_ABSOLUTE_TIME

2017-09-08 Thread Michael Mann via Wireshark-dev
I just took a look at packet-zep.c, and the "timestamp field" is being added explicitly with proto_tree_add_time, which negates the need for an encoding. Are you looking to convert that to proto_tree_add_item and pass the correct encoding? That's the only time the encoding needs to be specifi

Re: [Wireshark-dev] [RFC] Vendor-specific dissector extension for EtherNet/IP

2017-09-04 Thread Michael Mann via Wireshark-dev
Hopefully inlining comments will work... -Original Message- From: Samuel GROOT To: Developer support list for Wireshark Cc: Michael Mann Sent: Thu, Aug 31, 2017 8:58 am Subject: Re: [Wireshark-dev] [RFC] Vendor-specific dissector extension for EtherNet/IP Hi, I was already

Re: [Wireshark-dev] Wireshark 2.4.1 build errors (with Qt 4)

2017-08-31 Thread Michael Mann via Wireshark-dev
Per the conversation that started with https://www.wireshark.org/lists/wireshark-dev/201707/msg00132.html, I would say that yes Qt 4 is still supported by Wireshark 2.4, but it looks like it won't be supported for Wireshark 2.6 release (in what is now current master branch). The problem is ju

Re: [Wireshark-dev] Idea about Adding extra functionality in wireshark.

2017-08-30 Thread Michael Mann via Wireshark-dev
I think the first step is just to submit your patch for review. See https://wiki.wireshark.org/Development/SubmittingPatches for more details. -Original Message- From: krishna Kulkarni To: wireshark-dev Sent: Tue, Aug 29, 2017 10:20 am Subject: [Wireshark-dev] Idea about Adding ext

Re: [Wireshark-dev] [RFC] Vendor-specific dissector extension for EtherNet/IP

2017-08-30 Thread Michael Mann via Wireshark-dev
My mail client decided to butcher the formatting of your email, so I manually tried to reformat it so that my inline replies make sense. Hopefully the mail client doesn't butcher it on the way out too. Sorry for the inconvience. Le 29/08/2017 à 21:34, Michael Mann via Wireshark-dev a

Re: [Wireshark-dev] [RFC] Vendor-specific dissector extension for EtherNet/IP

2017-08-29 Thread Michael Mann via Wireshark-dev
The answer depends on exactly what you are trying to do, some things will be easier than others. 1. If you want to add vendor specific objects, that can easily be done in Lua because there is a dissector table that you can just register your vendor specific class with ("cip.class.iface"). T

Re: [Wireshark-dev] Bugs no longer autoclose?

2017-08-25 Thread Michael Mann via Wireshark-dev
This was briefly discussed on -core back in March (when you brought it up then). Copy/pasted the comments from there (conversation between you and Gerald): >> It looks like we've run into j2bugzilla issue: >> >> https://github.com/TomRK1089/j2bugzilla/issues/14 > > That is unfortunate, but ..

Re: [Wireshark-dev] Making oui_base_custom available more generally

2017-08-19 Thread Michael Mann via Wireshark-dev
ug 19, 2017 at 8:10 AM, Michael Mann via Wireshark-dev wrote:> I don't know exactly how far BASE_CUSTOM goes back, but it is for "custom"> display of a field. But if there are enough fields with the same "custom"> formatting, it's probably time to make it a

Re: [Wireshark-dev] Making oui_base_custom available more generally

2017-08-19 Thread Michael Mann via Wireshark-dev
Richard Sharpe To: Developer support list for Wireshark Sent: Sat, Aug 19, 2017 10:16 am Subject: Re: [Wireshark-dev] Making oui_base_custom available more generally On Sat, Aug 19, 2017 at 5:19 AM, Michael Mann via Wireshark-dev wrote:> If you're talking about oui_base_custom(), I think

Re: [Wireshark-dev] Making oui_base_custom available more generally

2017-08-19 Thread Michael Mann via Wireshark-dev
FT_OUI would support the latter. -Original Message- From: Alexis La Goutte To: Developer support list for Wireshark Sent: Sat, Aug 19, 2017 8:33 am Subject: Re: [Wireshark-dev] Making oui_base_custom available more generally On Sat, Aug 19, 2017 at 2:19 PM, Michael Mann via

Re: [Wireshark-dev] Making oui_base_custom available more generally

2017-08-19 Thread Michael Mann via Wireshark-dev
If you're talking about oui_base_custom(), I think the better idea would be to create a field type (FT_OUI) for it. -Original Message- From: Roland Knall To: Developer support list for Wireshark Sent: Sat, Aug 19, 2017 7:16 am Subject: Re: [Wireshark-dev] Making oui_base_custom avai

Re: [Wireshark-dev] Vendor-specific dissectors for 802.11

2017-08-13 Thread Michael Mann via Wireshark-dev
See https://code.wireshark.org/review/23065 It could probably use some review for "naming". I'm not familiar enough with the dissector to know if fields/dissector table name makes sense. In regards to not already having a dissector table, not all developers think about it, especially if there

Re: [Wireshark-dev] checkapi prefs

2017-08-08 Thread Michael Mann via Wireshark-dev
See https://code.wireshark.org/review/22974 This was added to help developer mistakes, but maybe there is a legitimate reason? (or regex in checkAPI needs tweeking) -Original Message- From: Dario Lombardo To: Developer support list for Wireshark Sent: Aug 8 5:33 am Subject: [Wire

Re: [Wireshark-dev] Conditional compilation (debug)

2017-07-29 Thread Michael Mann via Wireshark-dev
" grouping (reuse preference architecture, but for things needed a lot closer to startup), but it hasn't materialized. -Original Message- From: Dario Lombardo To: Developer support list for Wireshark Cc: Michael Mann Sent: Sat, Jul 29, 2017 4:36 pm Subject: Re: Conditiona

Re: [Wireshark-dev] Conditional compilation (debug)

2017-07-29 Thread Michael Mann via Wireshark-dev
Define "config". Do you mean preferences (which I thought we already had)? Or build configuration? (or "other") -Original Message- From: Dario Lombardo To: Developer support list for Wireshark Sent: Sat, Jul 29, 2017 11:23 am Subject: Re: [Wireshark-dev] Conditional compilation (d

Re: [Wireshark-dev] LNK2019: unresolved external symbol proto_deregister_protocol

2017-07-28 Thread Michael Mann via Wireshark-dev
See some discussion on the issue here: https://code.wireshark.org/review/21490/ -Original Message- From: Pascal Quantin To: Developer support list for Wireshark Sent: Fri, Jul 28, 2017 1:41 pm Subject: Re: [Wireshark-dev] LNK2019: unresolved external symbol proto_deregister_protocol

[Wireshark-dev] Qt translations when refactoring

2017-07-15 Thread Michael Mann via Wireshark-dev
I'm working on refactoring the Decode As dialog into using model/view functionality (https://code.wireshark.org/review/22625). The model appears to be "forced" to provide the names of the column headers that are part of the "table" in the Decode As dialog. Currently the names of the column he

Re: [Wireshark-dev] Using col_set_str(pinfo->cinfo, COL_PROTOCOL, "some_string") but cannot filter on some_string

2017-07-01 Thread Michael Mann via Wireshark-dev
that allows the filterability. -Original Message- From: Richard Sharpe To: Developer support list for Wireshark Sent: Sat, Jul 1, 2017 5:02 pm Subject: Re: [Wireshark-dev] Using col_set_str(pinfo->cinfo, COL_PROTOCOL, "some_string") but cannot filter on some_string On Sa

Re: [Wireshark-dev] Using col_set_str(pinfo->cinfo, COL_PROTOCOL, "some_string") but cannot filter on some_string

2017-07-01 Thread Michael Mann via Wireshark-dev
I think you're running into this: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4684 -Original Message- From: Richard Sharpe To: Developer support list for Wireshark Sent: Sat, Jul 1, 2017 2:31 pm Subject: Re: [Wireshark-dev] Using col_set_str(pinfo->cinfo, COL_PROTOCOL, "s

[Wireshark-dev] The "right" Qt header files

2017-06-28 Thread Michael Mann via Wireshark-dev
I use Visual Studio (VS2013 for the moment) for my development, but up until Sharkfest I hadn't done much GUI development. Now that I've dipped my toe in the water, I'm paying more attention to the project organization done by VS. Why is the "Header Files" folder under UI/qtui only contain Qt

Re: [Wireshark-dev] Building CORBA dissectors

2017-06-26 Thread Michael Mann
I'm guessing you didn't get a response because no one is building CORBA dissectors outside of the 3 or 4 that are in the source tree. Those are generated with idl2wrs, but then the C output is part of source control (partially because I'm not sure all platforms could generate the C dissector a

Re: [Wireshark-dev] Wireshark 2.4.0rc1 - TRANSUM

2017-06-08 Thread Michael Mann
Analyze -> Enabled Protocols... The dialog lists all protocols and TRANSUM is considered one of them. -Original Message- From: Paul Offord To: Developer support list for Wireshark Sent: Thu, Jun 8, 2017 3:25 am Subject: [Wireshark-dev] Wireshark 2.4.0rc1 - TRANSUM Thanks for incl

Re: [Wireshark-dev] Wave Short Message Protocol : IEEE P1609.3 Errors

2017-06-02 Thread Michael Mann
There hasn't been any real updates to this dissector since 2013 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9244). You're welcome to contribute (https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html) by submitting patches through Gerrit (https://wiki.wireshark.org/D

Re: [Wireshark-dev] small vs large patch sets ?

2017-04-19 Thread Michael Mann
I still say the answer is "it depends" with respect to large vs. small as it's more about complexity. If you're adding request/response tracking, conversation data, or changes to a state machine those can get complicated quickly so a small patch would be preferred. If you need to add 100 fiel

Re: [Wireshark-dev] The build broke on the recent X11 changes

2017-04-18 Thread Michael Mann
https://code.wireshark.org/review/21199 -Original Message- From: Jaap Keuter To: alexis.lagoutte ; Developer support list for Wireshark Sent: Tue, Apr 18, 2017 1:48 pm Subject: Re: [Wireshark-dev] The build broke on the recent X11 changes Hi, Indeed: gcc version 6.3.0 20170406 (De

Re: [Wireshark-dev] epan_t and capture_file

2017-04-14 Thread Michael Mann
ng the "packet/color summary scroll bar" might be an option. -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Fri, Apr 14, 2017 7:32 pm Subject: Re: [Wireshark-dev] epan_t and capture_file On Apr 14, 2017, at 4:26 PM, Michael Mann wrote: >

Re: [Wireshark-dev] epan_t and capture_file

2017-04-14 Thread Michael Mann
I agree with the suggested name changes, but I still don't think the functionality is necessary. The timeline view (in its current form) seems to look very similar to the new (Qt only) "packet/color summary scroll bar" to the right of the packet list (not sure of its official name). That ne

Re: [Wireshark-dev] Debugging an assertion failure

2017-04-14 Thread Michael Mann
There were a lot of suggestions on how to break on the failure point (which I can't help with), but if you just go to the line it complains about (it's slightly different in the master branch I have), you come up with: * Make sure that only lower-case ASCII letters, numbers,

Re: [Wireshark-dev] Change in wireshark[master]: Add support for BASE_VALS_NO_UNKNOWN

2017-04-10 Thread Michael Mann
, 2017 6:19 pm Subject: Re: [Wireshark-dev] Change in wireshark[master]: Add support for BASE_VALS_NO_UNKNOWN On Apr 10, 2017, at 1:31 PM, Michael Mann (Code Review) wrote: > Michael Mann has submitted this change and it was merged. > > Change subject: Add support for BASE_VALS_N

[Wireshark-dev] Adding decryption keys at "runtime" (dissection time)

2017-03-21 Thread Michael Mann
There are currently two outstanding patches (https://code.wireshark.org/review/20585 and https://code.wireshark.org/review/20656) that want to modify a UAT at runtime for additional decryption keys/information found during dissection. In this case the UAT is providing all of the "static" keys

[Wireshark-dev] Throwing exception can shorten tree

2017-02-26 Thread Michael Mann
I can't remember where I had the conversation, but I remember talking about cases where a thrown exception in Wireshark leads to it not showing as much as was dissected in the tree. I remember first seeing this issue when I was writing some dissector code and it wasn't quite finished, so I had

Re: [Wireshark-dev] Submitting a fix to 2.2.4

2017-02-10 Thread Michael Mann
It would still end up in Gerrit (just like a cherry-pick) Presuming you have a master-2.2 branch (and have pulled the latest): git push ssh://@code.wireshark.org:29418/wireshark HEAD:refs/for/master-2.2 (git review may work, but I've never tried it outside of master branch) -Original

Re: [Wireshark-dev] adding a new nvme dissector - pre-commit verifications

2017-01-25 Thread Michael Mann
Note that a dissector for the NVME protocol was recently submitted (https://code.wireshark.org/review/19063). I presume you've rebased to the latest commits on master to include that functionality (and maybe you're just adding support for more commands?) -Original Message- From: Ni

Re: [Wireshark-dev] Protocols vs dissectors, take 23

2017-01-05 Thread Michael Mann
: Re: [Wireshark-dev] Protocols vs dissectors, take 23 On Jan 1, 2017, at 11:39 PM, Michal Labedzki wrote: > On 2 January 2017 at 03:13, Michael Mann wrote: > >> To me, pinos don't have the same capabilities as real protocols. They don't >> have hf_ fields or heu

Re: [Wireshark-dev] Protocols vs dissectors, take 23

2017-01-05 Thread Michael Mann
ssage- From: Guy Harris To: Developer support list for Wireshark Sent: Thu, Jan 5, 2017 8:23 pm Subject: Re: [Wireshark-dev] Protocols vs dissectors, take 23 On Jan 1, 2017, at 6:13 PM, Michael Mann wrote: > I really like the flexibility and power that the current dissector table API

Re: [Wireshark-dev] Preferences needed during Wireshark startup

2017-01-05 Thread Michael Mann
FWIW, I'm working a little bit towards refactoring the preference functionality. Nothing big, just trying to encapsulate all functionality into the prefs.c file (it's mostly the memory management issues that I want to simplify for (code) users of the preference interface). I'm not sure if this

[Wireshark-dev] Protocols vs dissectors, take 23

2017-01-01 Thread Michael Mann
I really like the flexibility and power that the current dissector table API provides. The one small shortcoming is that a "protocol" needs to be provided when adding a dissection function to a dissector table. And not all dissection functions are a protocol. The "protocol" API is intention

[Wireshark-dev] Enabling/disabling post dissectors

2016-12-24 Thread Michael Mann
I started doing some cleanup on the TRANSUM post-dissector (https://code.wireshark.org/review/19406). Included in that cleanup was removing an explicit preference to enable/disable the post-dissector (it apparently can be resource and processor intensive) because dissectors can already be en

Re: [Wireshark-dev] proto.h extension (unit strings)

2016-12-16 Thread Michael Mann
2016-12-16 16:14 GMT+01:00 Michael Mann : I've finished my work adding unit string support and converting dissectors to use it (There are now over 300 examples of how to use this new feature). I believe I was conservative in the conversion, so if anyone wants to check their favorite

Re: [Wireshark-dev] proto.h extension (unit strings)

2016-12-16 Thread Michael Mann
of work (in case others thought it was needed). -Original Message- From: Michael Mann To: wireshark-dev Sent: Mon, Dec 12, 2016 8:26 am Subject: Re: [Wireshark-dev] proto.h extension (unit strings) I'm not sure where the line between screaming "FEATURE CREAP!" an

Re: [Wireshark-dev] proto.h extension (unit strings)

2016-12-12 Thread Michael Mann
ds, s) and provide user option to choose between full-form and abbrev. I am not sure, but I will probably use abbreviation. I am not sure if mixing abbrev/non-abbrev on dissector level is good idea. On 12 December 2016 at 04:17, Michael Mann wrote: I thought this was a good idea, just took a wh

Re: [Wireshark-dev] proto.h extension (unit strings)

2016-12-11 Thread Michael Mann
I thought this was a good idea, just took a while to get around to it: https://code.wireshark.org/review/19211 -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Fri, May 8, 2015 3:09 pm Subject: Re: [Wireshark-dev] proto.h extension On May 8, 2015, a

Re: [Wireshark-dev] Duplicate entries in tap output

2016-12-03 Thread Michael Mann
Moshe, Did you ever find a solution for this? When I was working on the Export Object refactoring, I also saw this (duplicate entries) in the GUI (for SMB, not IMF), but now I can't duplicate the issue. I've even tried switching between commits that have the new Export Object refactoring an

Re: [Wireshark-dev] FW: Change in wireshark[master]: transum: plugin code

2016-11-26 Thread Michael Mann
Cc: Evan Huus ; Petri Dish Buildbot ; Anders Broman ; Jaap Keuter ; Michael Mann Subject: Change in wireshark[master]: transum: plugin code Alexis La Goutte has posted comments on this change. Change subject: transum: plugin code

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-14 Thread Michael Mann
The answer is typically "follow the coding convention of the dissector if modifying an existing dissector". And when most dissectors are created, they start by using the example packet-PROTOABBREV.c (which explicitly lists out the parameters). I don't think the performance is an issue either

Re: [Wireshark-dev] Lua file io

2016-10-21 Thread Michael Mann
Have you checked https://wiki.wireshark.org/Lua/Examples? I believe there is an example there (https://wiki.wireshark.org/Lua/Examples#dumping_to_multiple_files) -Original Message- From: Jerry White To: wireshark-dev Sent: Fri, Oct 21, 2016 4:55 pm Subject: [Wireshark-dev] Lua fil

Re: [Wireshark-dev] Problem with val_to_str inside BASE_CUSTOM callback function

2016-10-21 Thread Michael Mann
Depending on what you're doing, you could go with proto_tree_add_xxx_format_value. I think that's how most dissectors end up avoiding the need for BASE_CUSTOM callback. -Original Message- From: Thomas Wiens To: Developer support list for Wireshark Sent: Fri, Oct 21, 2016 4:45 pm

Re: [Wireshark-dev] Intro and lua question

2016-10-21 Thread Michael Mann
Does your protocol give the length of your variable data within the fixed header? If so, tcp_dissect_pdus would be for you, but I don't immediately see how that's implemented in Lua (IANALP - I am not a Lua programmer). I did a quick search through Bugzilla because I remember it being talked

Re: [Wireshark-dev] Duplicate dissectors error

2016-08-29 Thread Michael Mann
"duplicates allowed". -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Mon, Aug 29, 2016 10:43 pm Subject: Re: [Wireshark-dev] Duplicate dissectors error On Aug 29, 2016, at 7:05 PM, Guy Harris wrote: > On Aug 29, 2016, at 6:09 PM, M

Re: [Wireshark-dev] Duplicate dissectors error

2016-08-29 Thread Michael Mann
Yes, that's the main side effect, and if all the registering is with proprietary dissectors, it's your users that have to deal with it. Solutions are: 1. Change dissector table to allow duplicates. 2. Create "placeholder" protocols (you'll see a few examples in native Wireshark dissectors) so th

Re: [Wireshark-dev] Downgrading my dev environment

2016-08-09 Thread Michael Mann
You may also just want to have 2 copies of the repo. One for "master" branch and one for 2.0 branch. The repos themselves don't take up that much space and it saves some potential hassles of cleaning when switching between branches (of such drastic difference) in the same repo. -Origi

Re: [Wireshark-dev] checklicenses.py

2016-08-06 Thread Michael Mann
So is the "checklicense tool" now the same between the Petri-Dish and the master buildbot? Is that the reason the master buildbot now has to "pass" (otherwise all Petri-Dish runs will fail)? If so, I prefer the way it used to be - master buildbot (legitimately) failing, but Petri-Dish being

Re: [Wireshark-dev] dissecting TCP packets with multiple PDUs

2016-08-05 Thread Michael Mann
This may be related/similar to bug 6392 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6392). I believe the capture in this bug has only a few "leftover" bytes (and I thought the issue may be related to amount of fixed data needed by dissector). However 38 bytes seems much larger than

[Wireshark-dev] checklicenses.py

2016-08-04 Thread Michael Mann
I thought I'd try to cut down on some of the "noise" created by checklicenses.py and creating exceptions for files that obviously don't need a license header (COPYING/AUTHORS files in plugins for example). I thought it would simply be a matter of running the script, seeing the output, and then

Re: [Wireshark-dev] proto_tree_add_item_ret_uint() returns unmasked value - should it?

2016-07-18 Thread Michael Mann
I've been wondering that myself, and I'm leaning towards "yes it should" because there have been many cases where I couldn't use proto_tree_add_item_ret_uint where I wanted to because masks were involved. -Original Message- From: Anders Broman To: wireshark-dev Sent: Mon, Jul 18, 2

[Wireshark-dev] checksum standardization

2016-07-13 Thread Michael Mann
There has been discussion over the years about standardizing the way checksums are handled in Wireshark. A lot of the discussion has been captured in bug 8859 [1], and I started writing a patch that would address it [2]. In developing the patch, I came across the following types of checksum "

[Wireshark-dev] build warnings

2016-07-13 Thread Michael Mann
I've done some investigation into the build warnings generated by the Ubuntu and Windows buildbots. I thought I'd highlight some of the "big offenders" so that if anyone has good ideas on how to fix them, it may lead to thinning the forest out enough that we can see trees (and the raw number o

Re: [Wireshark-dev] Adding dynamic fields to tree from dissector

2016-07-02 Thread Michael Mann
You may want to look at the diameter dissector (register_diameter_fields). It registers a lot of its fields when Wireshark sees a diameter packet for the first time. -Original Message- From: marko To: wireshark-dev Sent: Sat, Jul 2, 2016 5:19 pm Subject: Re: [Wireshark-dev] Adding

Re: [Wireshark-dev] Adding dynamic fields to tree from dissector

2016-06-19 Thread Michael Mann
Wireshark is more than just a "nice tree". Most users want to be able to find values within a packet and the only way you're able to do that is with hf_ items, so we now effectively made it a "requirement" to have an hf_ field for each field in the tree (subtree headings would be the exceptio

Re: [Wireshark-dev] Some questions about the "option block" interface in libwiretap

2016-05-20 Thread Michael Mann
I'll take a shot at this. I think I have some ideas that could work. -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Fri, May 20, 2016 7:28 pm Subject: Re: [Wireshark-dev] Some questions about the "option block" interface in libwiretap > 11) Se

Re: [Wireshark-dev] Some questions about the "option block" interface in libwiretap

2016-05-16 Thread Michael Mann
Not if we can get then into 2.2 in time. It seems like the bugs that were created by the first refactoring have been fixed, so maybe its time to think about the next layer. When I was last working on it my big concern was option "datatypes". The existing blocks that were refactored didn't h

Re: [Wireshark-dev] Some questions about the "option block" interface in libwiretap

2016-05-16 Thread Michael Mann
-Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Sun, May 15, 2016 10:17 pm Subject: Re: [Wireshark-dev] Some questions about the "option block" interface in libwiretap On May 15, 2016, at 6:40 PM, Guy Harris wrote: > 1) What is an "option block

Re: [Wireshark-dev] formatted time in dissector

2016-05-06 Thread Michael Mann
I thought one of the other reasons Jaap's suggestion is good is that when you try to filter with that field, you will get your desired format as the filter text. Right now the field displays as "mm:ss.nn" in the packet details, but will still show up as ".n" if you try to filt

Re: [Wireshark-dev] TCP conversation analysis can be expensive, and you can't disable it

2016-04-27 Thread Michael Mann
See https://code.wireshark.org/review/15138/ https://code.wireshark.org/review/15139 They at least put a dent in it. -Original Message- From: Guy Harris To: Developer support list for Wireshark Sent: Mon, Apr 25, 2016 8:00 pm Subject: [Wireshark-dev] TCP conversation analysis can b

Re: [Wireshark-dev] Back-port new protocol (OpenDOF) to 2.0 branch?

2016-04-14 Thread Michael Mann
The 2.2 release will probably be in June (major releases are usually centered around Sharkfest). There is a 0% chance of it being accepted to the 2.0 branch. Enhancements aren't backported, especially a new large dissector. -Original Message- From: Mike Morrin To: Developer supp

Re: [Wireshark-dev] Back-port new protocol (OpenDOF) to 2.0 branch?

2016-04-14 Thread Michael Mann
The 2.2 release will probably be in June (major releases are usually centered around Sharkfest). There is a 0% chance of it being accepted to the 2.0 branch. Enhancements aren't backported, especially a new large dissector. -Original Message- From: Mike Morrin To: Developer supp

Re: [Wireshark-dev] So why is _ws.expert an FT_PROTOCOL field rather than an FT_STRING field?

2016-04-12 Thread Michael Mann
Because it made sense to integrate the expert info under the protocol architecture (and register it through proto_register_protocol("Expert Info", "Expert", "_ws.expert"); ). The "string version" of the field would be "_ws.expert.message" and there are a few other fields of the format _ws.ex

Re: [Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-29 Thread Michael Mann
s bottom, the call which lead to the error and a more detailed error information in regard to the missing utility. regards Roland On Tue, Mar 29, 2016 at 9:14 PM, Michael Mann wrote: I had gotten CMake to build on my setup a few months back, but it was a bit "quirky" (I had to

[Wireshark-dev] Building with CMake on Win10 and VS2013 (win64)

2016-03-29 Thread Michael Mann
I had gotten CMake to build on my setup a few months back, but it was a bit "quirky" (I had to keep deleting and regenerating the build directory because consecutive rebuilds would fail). I tried again with a more recent version of master (maybe a week old at this point) and can't seem to get t

Re: [Wireshark-dev] How is the protocol display filter name determined?

2016-03-24 Thread Michael Mann
The protocol display filter works like all filters. It has to be used in a proto_tree_add_xxx call to be used as a filter What you may be confused by is protocol identifier (proto_fapi) can also be passed like an hf_ field is. Typically the first proto_tree_add_item call in a dissector is for

Re: [Wireshark-dev] Manually resolve name

2016-03-19 Thread Michael Mann
Is there a standard format for GUIDs? Are we presuming a 16 byte "datatype"? I think GUID may be too vague to have "global" resolution. This seems like a RTPS specific issue, so the "resolving" can just be handled within preferences of the RTPS protocol. I'd recommend a UAT format if there

Re: [Wireshark-dev] Upcoming Gerrit upgrade

2016-03-19 Thread Michael Mann
I'm also seeing bad "download" links from gerrit pages. It appears to be adding an additional "a" directory git fetch https://@code.wireshark.org/review/a/wireshark refs/changes/21/14521/2 && git cherry-pick FETCH_HEAD instead of git fetch https://@code.wireshark.org/review/wireshark r

  1   2   >