Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

2014-04-04 Thread Hadriel Kaplan
Ugh, forgot the "defined". So this: for my $k (sort keys %{$href}) { my $h = defined($href->{$k}) ? $href->{$k} : "undef"; printf "%-40.40s %5.5s %s\n", $title, $h, $k; } On Apr 4, 2014, at 11:49 PM, Hadriel Kaplan wrote: > > Change this at line 563 in checkhf.pl: >

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

2014-04-04 Thread Hadriel Kaplan
Change this at line 563 in checkhf.pl: for my $k (sort keys %{$href}) { printf "%-40.40s %5.5s %s\n", $title, $href->{$k} // "undef", $k; } to this: for my $k (sort keys %{$href}) { my $h = ($href->{$k}) ? $href->{$k} : "undef"; printf "%-40.40s %5.5s %s\n",

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

2014-04-04 Thread Hadriel Kaplan
What version of Perl do you have? I think that line 564's logical-or only became available in Perl 5.10. (it's not a regex search, but a ternary conditional-or apparently, because, ya know... Perl can't possibly have only 20 ways of doing something when it could instead have 21 ways... and at

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

2014-04-04 Thread Hadriel Kaplan
On Apr 4, 2014, at 11:26 PM, Hadriel Kaplan wrote: > I barely know perl, but checkhf.pl line 564 does indeed look bogus to me. > (the double slashes are what it thinks is starting a regex search pattern > that's not terminated I believe) Actually, no it's fine. I don't know why your computer'

Re: [Wireshark-dev] checkhf.pl fails only on pre-commit hook

2014-04-04 Thread Hadriel Kaplan
On Apr 4, 2014, at 10:36 PM, mman...@netscape.net wrote: > I've taken the pre-commit hook file provided in \tools and put it in my git > hooks folder. However, whenever I commit something (I've focused mostly on > dissector patches and they all fail this way), it fails with "Search pattern >

[Wireshark-dev] checkhf.pl fails only on pre-commit hook

2014-04-04 Thread mmann78
I've taken the pre-commit hook file provided in \tools and put it in my git hooks folder. However, whenever I commit something (I've focused mostly on dissector patches and they all fail this way), it fails with "Search pattern not terminated at ./tools/checkhf.pl line 564." When I run checkh

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

2014-04-04 Thread Hadriel Kaplan
On Apr 4, 2014, at 4:04 PM, Guy Harris wrote: > On Apr 4, 2014, at 7:30 AM, Hadriel Kaplan wrote: > >> I might be overlooking something, but I don’t see a tvb_get_* function to >> get a uint8/16/32/64 that was encoded as a ascii or utf-8 string in the >> packet. Is there such a thing? > > N

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

2014-04-04 Thread Jeff Morriss
On 04/04/14 16:08, Evan Huus wrote: On Fri, Apr 4, 2014 at 4:04 PM, Guy Harris wrote: On Apr 4, 2014, at 7:30 AM, Hadriel Kaplan wrote: And I'd like to see proto_tree_add_XXX_item() routines that add an item with a particular type *and* take a pointer argument and return the value for the it

Re: [Wireshark-dev] GIT vs SVN

2014-04-04 Thread Evan Huus
On Fri, Apr 4, 2014 at 4:08 PM, Guy Harris wrote: > > On Apr 4, 2014, at 9:21 AM, Herb Falk > wrote: > >> No, I just wanted to understand. It will be a couple of hours work. Tried >> to GIT clone and to add in my changes, but it didn't go well. > > > If you only want to keep your own private

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

2014-04-04 Thread Evan Huus
On Fri, Apr 4, 2014 at 4:04 PM, Guy Harris wrote: > > On Apr 4, 2014, at 7:30 AM, Hadriel Kaplan wrote: > >> I might be overlooking something, but I don't see a tvb_get_* function to >> get a uint8/16/32/64 that was encoded as a ascii or utf-8 string in the >> packet. Is there such a thing? > >

Re: [Wireshark-dev] GIT vs SVN

2014-04-04 Thread Guy Harris
On Apr 4, 2014, at 9:21 AM, Herb Falk wrote: > No, I just wanted to understand. It will be a couple of hours work. Tried > to GIT clone and to add in my changes, but it didn't go well. If you only want to keep your own private repository, with a modified version of Wireshark that tracks

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

2014-04-04 Thread Guy Harris
On Apr 4, 2014, at 7:30 AM, Hadriel Kaplan wrote: > I might be overlooking something, but I don’t see a tvb_get_* function to get > a uint8/16/32/64 that was encoded as a ascii or utf-8 string in the packet. > Is there such a thing? No. I've occasionally also thought there should be such a r

Re: [Wireshark-dev] overriding dissector for port 8080

2014-04-04 Thread John Dill
>Message: 2 >Date: Fri, 4 Apr 2014 10:59:18 -0400 >From: Hadriel Kaplan >To: Developer support list for Wireshark >Subject: Re: [Wireshark-dev] overriding dissector for port 8080 >Message-ID: <225ee544-6929-4484-a8c2-2260be860...@oracle.com> >Content-Type: text/plain; charset=windows-1252 > >> O

[Wireshark-dev] Running away from, while still being nice to, XP

2014-04-04 Thread Gerald Combs
I'd like to upgrade our 32-bit Windows buildbot from XP to 8.1 in the near future. Aside from the obvious EOL issue it's difficult to use automated management and packaging tools like Puppet and Chocolatey under XP. Upgrading would also let us build releases using Visual C++ 2012 and later, assumin

Re: [Wireshark-dev] make error when building envirement

2014-04-04 Thread Jeff Morriss
"git pull" to grab the latest version. There was a compile breakage for about an hour this morning. On 04/04/14 12:21, khemis haythem wrote: hello well !!! here i get another error message :packet-msrp.c:573:33: error: too few arguments to function 'tvb_get_string_enc' ../../epan/tvbuff.h:52

Re: [Wireshark-dev] make error when building envirement

2014-04-04 Thread Pascal Quantin
Hi, 2014-04-04 18:21 GMT+02:00 khemis haythem : > > > Khemis Haythem > Adresse : Boite Postale 101 4118, Mednine > GSM : +216 55 69 19 90 > E-mail : khemis.hayt...@yahoo.fr > Statut : Élève ingénieur > Spatialité : Génie des Communications et des Réseaux > Ecole : Ecole National d'Ingénieurs de

Re: [Wireshark-dev] make error when building envirement

2014-04-04 Thread khemis haythem
  Khemis Haythem Adresse : Boite Postale 101  4118, Mednine GSM : +216 55 69 19 90 E-mail : khemis.hayt...@yahoo.fr Statut : Élève ingénieur  Spatialité : Génie des Communications et des Réseaux  Ecole : Ecole National d'Ingénieurs de Gabes   hello  well !!!  here i get another error message :pa

Re: [Wireshark-dev] GIT vs SVN

2014-04-04 Thread Herb Falk
No, I just wanted to understand. It will be a couple of hours work. Tried to GIT clone and to add in my changes, but it didn't go well. I will pull again over the weekend and see if my environment can compile the clone and then start adding things into it one at a time. Thanks. Herbert Fal

Re: [Wireshark-dev] GIT vs SVN

2014-04-04 Thread Gerald Combs
On 4/4/14 8:47 AM, Gerald Combs wrote: > On 4/4/14 7:21 AM, Herb Falk wrote: >> The latest source code does not appear to be available through the use >> of SVN any longer? If there is a mechanism, can somebody explain to me >> how to get this to work. My current dev environment is SVN tree/mana

Re: [Wireshark-dev] GIT vs SVN

2014-04-04 Thread Gerald Combs
On 4/4/14 7:21 AM, Herb Falk wrote: > The latest source code does not appear to be available through the use > of SVN any longer? If there is a mechanism, can somebody explain to me > how to get this to work. My current dev environment is SVN tree/managed. We migrated to Git + Gerrit on January

Re: [Wireshark-dev] overriding dissector for port 8080

2014-04-04 Thread Hadriel Kaplan
On Apr 4, 2014, at 10:43 AM, John Dill wrote: > The Filter Expression dialog is the best place in Wireshark to locate the > data elements they are looking for, so it was mentioned as a "nice to have”. Oh well if it’s just the dialog, why not just disable the other protocols? Go to menu Analyz

Re: [Wireshark-dev] No tvb_get for string-encoded numbers?

2014-04-04 Thread Evan Huus
On Fri, Apr 4, 2014 at 10:30 AM, Hadriel Kaplan wrote: > Hi, > I might be overlooking something, but I don't see a tvb_get_* function to get > a uint8/16/32/64 that was encoded as a ascii or utf-8 string in the packet. > Is there such a thing? > > Instead, it seems the dissectors that deal with

Re: [Wireshark-dev] overriding dissector for port 8080

2014-04-04 Thread John Dill
>Message: 2 >Date: Fri, 4 Apr 2014 10:19:52 -0400 >From: Hadriel Kaplan >To: Developer support list for Wireshark >Subject: Re: [Wireshark-dev] overriding dissector for port 8080 >Message-ID: >Content-Type: text/plain; charset=windows-1252 > >On Apr 4, 2014, at 9:56 AM, John Dill wrote: >

Re: [Wireshark-dev] make error when building envirement

2014-04-04 Thread Alexis La Goutte
On Fri, Apr 4, 2014 at 4:24 PM, khemis haythem wrote: > > > Khemis Haythem > Adresse : Boite Postale 101 4118, Mednine > GSM : +216 55 69 19 90 > E-mail : khemis.hayt...@yahoo.fr > Statut : Élève ingénieur > Spatialité : Génie des Communications et des Réseaux > Ecole : Ecole National d'Ingénieur

[Wireshark-dev] No tvb_get for string-encoded numbers?

2014-04-04 Thread Hadriel Kaplan
Hi, I might be overlooking something, but I don’t see a tvb_get_* function to get a uint8/16/32/64 that was encoded as a ascii or utf-8 string in the packet. Is there such a thing? Instead, it seems the dissectors that deal with string messages do a tvb_get_string_enc() or tvb_format_text(), an

[Wireshark-dev] test

2014-04-04 Thread Hadriel Kaplan
please ignore this email - just testing, because I can’t seem to send new non-reply emails to this list… ___ Sent via:Wireshark-dev mailing list Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: http

[Wireshark-dev] make error when building envirement

2014-04-04 Thread khemis haythem
  Khemis Haythem Adresse : Boite Postale 101  4118, Mednine GSM : +216 55 69 19 90 E-mail : khemis.hayt...@yahoo.fr Statut : Élève ingénieur  Spatialité : Génie des Communications et des Réseaux  Ecole : Ecole National d'Ingénieurs de Gabes      hello  i m newer in wireshark and i m trying to ad

[Wireshark-dev] GIT vs SVN

2014-04-04 Thread Herb Falk
The latest source code does not appear to be available through the use of SVN any longer? If there is a mechanism, can somebody explain to me how to get this to work. My current dev environment is SVN tree/managed. If SVN can no longer pull releases, I guess I can live with that, but these ty

Re: [Wireshark-dev] overriding dissector for port 8080

2014-04-04 Thread Hadriel Kaplan
On Apr 4, 2014, at 9:56 AM, John Dill wrote: >>> I also noticed a disabled_protos.[ch], so maybe there is a feature to >>> disable other protocols. Is there a feature that could be used to hide >>> protocols I don't need in the Filter Expression (to reduce the list to >>> simplify the interface

Re: [Wireshark-dev] overriding dissector for port 8080

2014-04-04 Thread John Dill
>Message: 4 >Date: Thu, 03 Apr 2014 16:14:53 -0400 >From: Jeff Morriss >To: Developer support list for Wireshark >Subject: Re: [Wireshark-dev] overriding dissector for port 8080 >Message-ID: <533dc13d.8010...@gmail.com> >Content-Type: text/plain; charset=ISO-8859-1; format=flowed > >On 04/03/14