Re: [Wireshark-dev] BASE_CUSTOM and 64-bit values

2013-03-26 Thread Evan Huus
On Tue, Mar 26, 2013 at 2:30 PM, Guy Harris wrote: > > On Mar 26, 2013, at 10:31 AM, Evan Huus wrote: > >> I'm not 100% convinced we should though - it would be more flexible, >> but we'd be exposing some of the guts of the dissection backend into >> 'userspace' as it were. Not a particular stron

Re: [Wireshark-dev] [Wireshark-commits] rev 48555: /trunk/epan/ /trunk/epan/: value_string.c

2013-03-26 Thread Bill Meier
On 3/26/2013 1:29 PM, Guy Harris wrote: On Mar 26, 2013, at 5:40 AM, Bill Meier wrote: I'm curious why you added the following test in the recent value_string.c patch if (first_value > vs_p[i].value) { g_warning("Extended value string %s forced to fall back to linear search: en

Re: [Wireshark-dev] Bluetooth SBC codec in RTP Player

2013-03-26 Thread Jaap Keuter
Hi, Two questions: 1) Why move codec infrastructure into epan? I don't understand the rationale. 2) Why destroy the G729/G723 support? Even though it's not in there, they're hooks for having it there. Thanks, Jaap On 03/26/2013 02:14 PM, michal.labed...@tieto.com wrote: > Hi All, > > I want to

Re: [Wireshark-dev] BASE_CUSTOM and 64-bit values

2013-03-26 Thread Guy Harris
On Mar 26, 2013, at 10:31 AM, Evan Huus wrote: > I'm not 100% convinced we should though - it would be more flexible, > but we'd be exposing some of the guts of the dissection backend into > 'userspace' as it were. Not a particular strong objection, but > something to keep in mind. I'm not sure

Re: [Wireshark-dev] [Wireshark-commits] rev 48555: /trunk/epan/ /trunk/epan/: value_string.c

2013-03-26 Thread Guy Harris
On Mar 26, 2013, at 5:40 AM, Bill Meier wrote: > I'm curious why you added the following test in the recent value_string.c > patch > > if (first_value > vs_p[i].value) { >g_warning("Extended value string %s forced to fall back to linear > search: entry %u, value %u < first entry,

Re: [Wireshark-dev] BASE_CUSTOM and 64-bit values

2013-03-26 Thread Evan Huus
On Tue, Mar 26, 2013 at 1:00 PM, Jakub Zawadzki wrote: > Hi, > > On Tue, Mar 26, 2013 at 05:39:54PM +0100, David Arnold wrote: >> Is there any enthusiasm for a BASE_CUSTOM64? > > I'd rather want some generic BASE_CUSTOM which pass to custom functiom > fvalue_t (and maybe hf_index). It looks like

Re: [Wireshark-dev] BASE_CUSTOM and 64-bit values

2013-03-26 Thread David Arnold
On 25/03/2013, at 10:23 PM, Jeff Morriss wrote: > On 03/17/13 11:58, David Arnold wrote: <...> >> My question then becomes one of consistency: should I do this for all my >> BASE_CUSTOM cases? Or is there some advantage in using BASE_CUSTOM that >> I've missed (beyond saving a couple of line

Re: [Wireshark-dev] BASE_CUSTOM and 64-bit values

2013-03-26 Thread Jakub Zawadzki
Hi, On Tue, Mar 26, 2013 at 05:39:54PM +0100, David Arnold wrote: > Is there any enthusiasm for a BASE_CUSTOM64? I'd rather want some generic BASE_CUSTOM which pass to custom functiom fvalue_t (and maybe hf_index). Jakub. _

[Wireshark-dev] Bluetooth SBC codec in RTP Player

2013-03-26 Thread Michal.Labedzki
Hi All, I want to ask about how to add SBC codec support to RTP Player. SBC is codec used by Bluetooth. There is GPL library for that (libsbc developed by BlueZ developers). I decided to move codecs to "epan" directory and small extend existing fine API - my idea can be simply described in word

Re: [Wireshark-dev] [Wireshark-commits] rev 48555: /trunk/epan/ /trunk/epan/: value_string.c

2013-03-26 Thread Bill Meier
On 3/25/2013 8:37 PM, g...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=48555 User: guy Date: 2013/03/25 05:37 PM Guy; I'm curious why you added the following test in the recent value_string.c patch if (first_value > vs_p[i].value) {