Re: [Wireshark-dev] [Wireshark-commits] rev 38515: /trunk/gtk/ /trunk/gtk/: capture_dlg.c capture_if_dlg.c

2011-08-13 Thread Guy Harris
On Aug 13, 2011, at 1:50 PM, Michael Tüxen wrote: > On Aug 13, 2011, at 10:26 PM, Stig Bjørlykke wrote: > >> BTW, why do we build the same string ("%s\n> size='small'>%s") 4 different places? > Two for the initial setup of the interface list, one might be able > to reduce it to one. insert_new_

[Wireshark-dev] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis

2011-08-13 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Visual-Studio-Code-Analysis while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Visual-Studio-Code-Analysis/builds/1643 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildsla

[Wireshark-dev] Time shift patch causes compile error

2011-08-13 Thread Joerg Mayer
At least when compiling with UI_MANAGER set, I get the following compile error: [ 0%] Building C object gtk/CMakeFiles/ui.dir/menus.c.o /home/jmayer/work/wireshark/svn/trunk/gtk/menus.c:1537:85: error: ‘set_time_shift_cb’ undeclared here (not in a function) cc1: warnings being treated as err

Re: [Wireshark-dev] [Wireshark-commits] rev 38515: /trunk/gtk/ /trunk/gtk/: capture_dlg.c capture_if_dlg.c

2011-08-13 Thread Michael Tüxen
On Aug 13, 2011, at 10:36 PM, Guy Harris wrote: > > On Aug 13, 2011, at 1:26 PM, Stig Bjørlykke wrote: > >> What about displaying nothing in the interface list, and "none" in the >> details? >> Like in the attached patch. > > That sounds good. Any objections? Already done. I had this on the T

Re: [Wireshark-dev] [Wireshark-commits] rev 38515: /trunk/gtk/ /trunk/gtk/: capture_dlg.c capture_if_dlg.c

2011-08-13 Thread Michael Tüxen
On Aug 13, 2011, at 10:26 PM, Stig Bjørlykke wrote: > On Sat, Aug 13, 2011 at 9:21 PM, wrote: >> Log: >> Say "none" rather than "unknown" if there are no IP addresses; in most >> if not all cases, it's not that we don't know the IP addresses, it's >> that there are no IP addresses to know. >

Re: [Wireshark-dev] [Wireshark-commits] rev 38515: /trunk/gtk/ /trunk/gtk/: capture_dlg.c capture_if_dlg.c

2011-08-13 Thread Guy Harris
On Aug 13, 2011, at 1:26 PM, Stig Bjørlykke wrote: > What about displaying nothing in the interface list, and "none" in the > details? > Like in the attached patch. That sounds good. Any objections? ___ Sent via:Wiresh

Re: [Wireshark-dev] [Wireshark-commits] rev 38515: /trunk/gtk/ /trunk/gtk/: capture_dlg.c capture_if_dlg.c

2011-08-13 Thread Stig Bjørlykke
On Sat, Aug 13, 2011 at 9:21 PM, wrote: > Log: >  Say "none" rather than "unknown" if there are no IP addresses; in most >  if not all cases, it's not that we don't know the IP addresses, it's >  that there are no IP addresses to know. What about displaying nothing in the interface list, and "no

Re: [Wireshark-dev] capture_dlg.c: several "unused_but_set" warnings [GCC 4.6]

2011-08-13 Thread Michael Tüxen
On Aug 10, 2011, at 11:26 PM, Bill Meier wrote: > capture_dlg.c: In function ‘insert_new_rows’: > > capture_dlg.c:665:18: warning: variable ‘cap_settings’ set but not used > [-Wunused-but-set-variable] > capture_dlg.c:664:8: warning: variable ‘linktype_select’ set but not used > [-Wunused-but-s

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-08-13 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows-7-x64 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/2709 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-

Re: [Wireshark-dev] [Wireshark-commits] rev 38507: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2011-08-13 Thread Guy Harris
On Aug 13, 2011, at 9:57 AM, tue...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38507 > > User: tuexen > Date: 2011/08/13 09:57 AM > > Log: > Fix Windows builds (hopefully). > > Directory: /trunk/gtk/ > ChangesPath Action > +2 -2

[Wireshark-dev] buildbot failure in Wireshark (development) on Clang-Code-Analysis

2011-08-13 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Clang-Code-Analysis while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Clang-Code-Analysis/builds/351 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build:

[Wireshark-dev] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis

2011-08-13 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Visual-Studio-Code-Analysis while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Visual-Studio-Code-Analysis/builds/1634 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildsla

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2011-08-13 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows-XP-x86 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/3745 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-08-13 Thread buildbot-no-reply
The Buildbot has detected a new failure on builder Windows-7-x64 while building Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/2701 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-