Re: [Wireshark-dev] mix of c and C++

2011-07-18 Thread Helge Kruse
Am 19.07.2011 07:10, schrieb sagar Guledagudda: I am compiling it for linux ( xxx.so file ) Includes files are as below #ifdef HAVE_CONFIG_H # include "config.h" #endif #include #include #include // fastfix API #include #include CC = g++ CFLAGS = $(INCS) -fPIC $(PLUGIN) : $(OBJS)

Re: [Wireshark-dev] [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c

2011-07-18 Thread Guy Harris
On Jul 18, 2011, at 10:19 PM, Maynard, Chris wrote: > Isn't this more confusing now? The whole dissector is confusing, given the use of TRUE in the proto_tree_add_item() calls. At least this makes the confusion obvious > I don't have access to the BACnet standard, but surely it's either b

Re: [Wireshark-dev] [Wireshark-commits] rev 38106: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-bacapp.c

2011-07-18 Thread Maynard, Chris
> -Original Message- > From: wireshark-commits-boun...@wireshark.org [mailto:wireshark-commits- > boun...@wireshark.org] On Behalf Of g...@wireshark.org > Sent: Monday, July 18, 2011 11:20 PM > To: wireshark-comm...@wireshark.org > Subject: [Wireshark-commits] rev 38106: /trunk/epan/dissect

Re: [Wireshark-dev] mix of c and C++

2011-07-18 Thread sagar Guledagudda
I am compiling it for linux ( xxx.so file ) Includes files are as below #ifdef HAVE_CONFIG_H # include "config.h" #endif #include #include #include // fastfix API #include #include CC = g++ CFLAGS = $(INCS) -fPIC $(PLUGIN) : $(OBJS) mkdir -p $(PLUGIN_DIR)

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Jaap Keuter
On 18 jul. 2011, at 15:15, Andreas wrote: > Am 18.07.2011 10:12, schrieb Guy Harris: >> >> On Jul 18, 2011, at 1:02 AM, Helge Kruse wrote: >> >>> I use always C++ to write my custom dissectors. Did you surround the >>> Wireshark #include with extern "C" like this? >> >> Perhaps Wireshark shou

Re: [Wireshark-dev] Procedure to compile wireshark dissector on linux

2011-07-18 Thread Chris Maynard
Tony Trinh writes: > I like the CMake build better (easier to use and 'pretty') except for the verbose output, which is masochistically enabled by default. There's a comment that suggests the verboseness was meant to be temporary: > # Disable this later. Alternative: "make VERBOSE=1" > set(CMAKE_

[Wireshark-dev] Wireshark 1.4.8 is now available

2011-07-18 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm proud to announce the release of Wireshark 1.4.8. What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis, development and education. What's New Bug Fixes The f

[Wireshark-dev] Wireshark 1.6.1 is now available

2011-07-18 Thread Gerald Combs
I'm proud to announce the release of Wireshark 1.6.1. What is Wireshark? Wireshark is the world's most popular network protocol analyzer. It is used for troubleshooting, analysis, development and education. What's New Bug Fixes The following vulnerabilities have been fixed. See t

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Chris Maynard
Chris Maynard writes: > There is nothing to commit. Just to clarify, when I wrote that, I mean there is nothing to commit in order to support multiple help files. The bug I opened contains a sample wireshark.ini file, which could be committed if folks think there's any merit in doing so. > I

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Chris Maynard
Joerg Mayer writes: > Did you commit the code to suport several help files? How is the order of > the help entries decided if you have entries in more than one .ini file? There is nothing to commit. Just dump as many valid help.ini files in the protocol_help directory as you want and then start

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Joerg Mayer
On Mon, Jul 18, 2011 at 08:37:53PM +, Chris Maynard wrote: > Joerg Mayer writes: > > > Just a question regarding the download: The download will only provide the > > protocol_help/ph.ini file and to use it I need to be online? Or are the > > pages also available offline? > > By default, inac

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Joerg Mayer
On Mon, Jul 18, 2011 at 10:31:48PM +0200, Joerg Mayer wrote: > Btw, do we want to distribute and install the protocol_help stuff of the > light version with Wireshark? Just to answer myself: While it might be interesting, the datafiles have a copyright that is "incompatible" with Wireshark's. From

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Chris Maynard
Joerg Mayer writes: > Btw, do we want to distribute and install the protocol_help stuff of the > light version with Wireshark? Personally I think their help is pretty darn good, so I would be in favor of it. ___ Sent via:

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Chris Maynard
Joerg Mayer writes: > Just a question regarding the download: The download will only provide the > protocol_help/ph.ini file and to use it I need to be online? Or are the > pages also available offline? By default, inacon's protocol help is available at http://www.inacon.de/ph/data/, since that'

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Joerg Mayer
On Mon, Jul 18, 2011 at 10:20:14PM +0200, Joerg Mayer wrote: > On Mon, Jul 18, 2011 at 07:12:34PM +, Chris Maynard wrote: > > Inacon supplied their help files in bug 3045: > > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3045. > > > > But, my understanding is that since they were never

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Joerg Mayer
On Mon, Jul 18, 2011 at 07:12:34PM +, Chris Maynard wrote: > Inacon supplied their help files in bug 3045: > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3045. > > But, my understanding is that since they were never incorporated into > Wireshark, > Inacon supplies those help files them

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Michael Tüxen
On Jul 18, 2011, at 8:31 PM, Alexander Koeppe wrote: > Am 14.07.2011 22:49, schrieb Anders Broman: >> Hi, >> protocol_help. has been disabled in the new UIManager based code as it >> uses the deprecated GtkItemFactory >> methods. If you whant it to be part of Wireshark once Wireshark has >> been

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Chris Maynard
Alexander Koeppe writes: > Are the protocol help files still maintained? > I can't find any on my system. > > ~/.wireshark$ find -name protocol_help > ~/.wireshark$ find ~/build/wireshark -name protocol_help > ~/.wireshark$ > > Why then keeping it? Inacon supplied their help file

Re: [Wireshark-dev] Wireshark's proto_help stuff

2011-07-18 Thread Alexander Koeppe
Am 18.07.2011 16:23, schrieb Joerg Mayer: > Hello Edgar, > > last year your proto_help code was added to Wireshark. As we are working > on getting Wireshark to build with GTK3 we do test compiles with some > additional GTK compile flags. The only decprecated GTK functions left are in > the menu co

Re: [Wireshark-dev] proto_help.c

2011-07-18 Thread Alexander Koeppe
Am 14.07.2011 22:49, schrieb Anders Broman: > Hi, > protocol_help. has been disabled in the new UIManager based code as it > uses the deprecated GtkItemFactory > methods. If you whant it to be part of Wireshark once Wireshark has > been converted to use UIManager > you need to convert proto help t

Re: [Wireshark-dev] mix of c and C++

2011-07-18 Thread Helge Kruse
Am 18.07.2011 16:45, schrieb sagar sg: compiler i am using is g++ parameters - -fPIC root/wireshark/wireshark-1.4.7/epan/tfs.h:56: error: expected constructor, destructor, or type conversion before âconstâ error is in the file given above .. its not showing in the dissector code. On Mon, Jul

Re: [Wireshark-dev] mix of c and C++

2011-07-18 Thread sagar sg
compiler i am using is g++ parameters - -fPIC root/wireshark/wireshark-1.4.7/epan/tfs.h:56: error: expected constructor, destructor, or type conversion before âconstâ error is in the file given above .. its not showing in the dissector code. On Mon, Jul 18, 2011 at 6:53 PM, Helge Kruse wrote:

Re: [Wireshark-dev] [Wireshark-commits] rev 38084: /trunk/ /trunk/: configure.in

2011-07-18 Thread Joerg Mayer
On Mon, Jul 18, 2011 at 01:36:15PM +, tue...@wireshark.org wrote: > Log: > Get --enable-ui-manager working. Thanks for fixing this - sorry for not properly testing it. Joerg -- Joerg Mayer We are stuck with technology when what we really want is ju

[Wireshark-dev] Wireshark's proto_help stuff

2011-07-18 Thread Joerg Mayer
Hello Edgar, last year your proto_help code was added to Wireshark. As we are working on getting Wireshark to build with GTK3 we do test compiles with some additional GTK compile flags. The only decprecated GTK functions left are in the menu code and in the proto_help code: The use of GtkItemFacto

Re: [Wireshark-dev] Makefile for wireshark dissector

2011-07-18 Thread Ed Beroset
sagar sg wrote: > >I am doing the same way, but i am getting lot of errors with wireshark >libraries like > >/export/qdserver/wireshark/wireshark-1.4.7/epan/tfs.h:39: error: expected >constructor, destructor, or type conversion before const > >u have any idea abt this type of error ? i am using g++

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Andreas
Am 18.07.2011 15:22, schrieb sagar sg: Okay, you mean to say we have to add the extern c { tfs.h } to the wireshark code ? No, it wouldn't help to solve your problem. You can add this guard in your C++ project. I just mentioned that Wireshark could be prepared to be used in a C++ project.

Re: [Wireshark-dev] mix of c and C++

2011-07-18 Thread Helge Kruse
Am 18.07.2011 11:24, schrieb sagar sg: hello, My Dissector is in C++ and internally uses wireshark libraries ( eg: epan ) , Is there any way to wrote makefile such that we can mix the gcc and g++ compilers for particular type of code to be compiled with corresponding compiler ?? Thanks

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread sagar sg
Okay, you mean to say we have to add the extern c { tfs.h } to the wireshark code ? On Mon, Jul 18, 2011 at 6:45 PM, Andreas wrote: > Am 18.07.2011 10:12, schrieb Guy Harris: > > >> On Jul 18, 2011, at 1:02 AM, Helge Kruse wrote: >> >> I use always C++ to write my custom dissectors. Did you sur

Re: [Wireshark-dev] Makefile for wireshark dissector

2011-07-18 Thread sagar sg
I am doing the same way, but i am getting lot of errors with wireshark libraries like /export/qdserver/wireshark/wireshark-1.4.7/epan/tfs.h:39: error: expected constructor, destructor, or type conversion before const u have any idea abt this type of error ? i am using g++ compiler and wireshark 1

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Andreas
Am 18.07.2011 10:12, schrieb Guy Harris: On Jul 18, 2011, at 1:02 AM, Helge Kruse wrote: I use always C++ to write my custom dissectors. Did you surround the Wireshark #include with extern "C" like this? Perhaps Wireshark should surround the body of epan/tfs.h with that Well, Wireshar

Re: [Wireshark-dev] Makefile for wireshark dissector

2011-07-18 Thread Ed Beroset
sagar sg wrote: > I am trying to compile my dissector independently by writing a >single make file and Included some wireshark libraries. Can i do this or i >need to compile it with wireshark s source code only?? If it's a plugin, and you've done things the way the other plugins are done,

Re: [Wireshark-dev] Makefile for wireshark dissector

2011-07-18 Thread sagar sg
Hello, I am trying to compile my dissector independently by writing a single make file and Included some wireshark libraries. Can i do this or i need to compile it with wireshark s source code only?? On Mon, Jul 11, 2011 at 4:16 PM, Ankith Agarwal wrote: > > On Mon, Jul 11, 2011, sagar

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2011-07-18 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/3485 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-xp-x86 Build Reason

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Andreas
Am 18.07.2011 11:51, schrieb sagar sg: How do u write makefile for that ? do u use gcc or g++ ? if u can paste a sample makefile then that may help. Honestly, I don't write any makefile, if I can avoid it. I use the New-Project wizard of Visual Studio to create a DLL project, add some files

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-07-18 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/2412 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason:

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread sagar sg
How do u write makefile for that ? do u use gcc or g++ ? if u can paste a sample makefile then that may help. On Mon, Jul 18, 2011 at 1:32 PM, Helge Kruse wrote: > Am 18.07.2011 07:16, schrieb sagar sg: > > Yes. My dissector code is in C++ which i am compiling independently and >> using the req

[Wireshark-dev] mix of c and C++

2011-07-18 Thread sagar sg
hello, My Dissector is in C++ and internally uses wireshark libraries ( eg: epan ) , Is there any way to wrote makefile such that we can mix the gcc and g++ compilers for particular type of code to be compiled with corresponding compiler ?? Thanks Sagar G __

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Guy Harris
On Jul 18, 2011, at 1:17 AM, sagar sg wrote: > let me know, is there something need to be changed in code to compile it in > linux. because in windows i was able to compile the same code success fully. ? I have absolutely no idea, as I haven't seen the code. Perhaps there's something that som

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread sagar sg
let me know, is there something need to be changed in code to compile it in linux. because in windows i was able to compile the same code success fully. ? On Mon, Jul 18, 2011 at 1:44 PM, Guy Harris wrote: > > On Jul 17, 2011, at 10:18 PM, sagar sg wrote: > > > Yes, I have > > > > #ifdef H

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Guy Harris
On Jul 17, 2011, at 10:18 PM, sagar sg wrote: > Yes, I have > > #ifdef HAVE_CONFIG_H ># include "config.h" >#endif > > But my code is in C++ and i am using gcc compiler. does this make any > difference? I wouldn't expect it to. Could we see the code, please? You m

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Guy Harris
On Jul 18, 2011, at 1:02 AM, Helge Kruse wrote: > I use always C++ to write my custom dissectors. Did you surround the > Wireshark #include with extern "C" like this? Perhaps Wireshark should surround the body of epan/tfs.h with that

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread sagar sg
Yes i did that.. On Mon, Jul 18, 2011 at 1:32 PM, Helge Kruse wrote: > Am 18.07.2011 07:16, schrieb sagar sg: > > Yes. My dissector code is in C++ which i am compiling independently and >> using the required libraries. >> > > I use always C++ to write my custom dissectors. Did you surround the >

Re: [Wireshark-dev] error in epan/tfs.h

2011-07-18 Thread Helge Kruse
Am 18.07.2011 07:16, schrieb sagar sg: Yes. My dissector code is in C++ which i am compiling independently and using the required libraries. I use always C++ to write my custom dissectors. Did you surround the Wireshark #include with extern "C" like this? extern "C" { #include #includ