[Wireshark-dev] Why isn't this a bug (2)?

2011-07-08 Thread Jaap Keuter
Hi list, From the source code of packet-msrp.c static gboolean check_msrp_header(tvbuff_t *tvb) { ... linelen = tvb_find_line_end(tvb, 0, -1, &next_offset, FALSE); /* Find the first SP */ space_offset = tvb_find_guint8(tvb, 0, -1, ' '); ... token_1_len = space_offset; token

Re: [Wireshark-dev] Conversation and endpoints byte counts

2011-07-08 Thread Guy Harris
On Jul 8, 2011, at 8:07 PM, Chris Maynard wrote: > What is the most accurate/desirable/expected number to report? ...which is the question I was asking - what do people want with the byte count, so what do they expect it to count?

Re: [Wireshark-dev] my dissector breaks with updated 1.6 source and libs

2011-07-08 Thread oleksab
Guy I searched my packet-helen.c file and I did not find anything with FT_PCRE as the field type. I have never heard or saw this type before. Why would I be getting an error like this..?? Any other thoughts..?? Thanks, Brian > > On Jul 8, 2011, at 7:31 PM, olek...@darkcornersoftware.com wrote:

Re: [Wireshark-dev] Conversation and endpoints byte counts

2011-07-08 Thread Chris Maynard
Guy Harris writes: > What exactly do people want with those byte counts? I don't presume to know what one might want to use that data for. I am merely trying to report the most meaningful information possible. > ...which means that you can't get a link-layer byte count that pertains to what wa

Re: [Wireshark-dev] Conversation and endpoints byte counts

2011-07-08 Thread Guy Harris
On Jul 8, 2011, at 7:44 PM, Chris Maynard wrote: > With my recent commit in r37945, it is now possible to view GRE-encapsulated > IP > conversations and endpoints, which also include any other supported > conversations such as UDP and TCP as well. However, when looking at the bytes > being coun

[Wireshark-dev] Conversation and endpoints byte counts

2011-07-08 Thread Chris Maynard
With my recent commit in r37945, it is now possible to view GRE-encapsulated IP conversations and endpoints, which also include any other supported conversations such as UDP and TCP as well. However, when looking at the bytes being counted as part of those conversations, I noticed that they were a

Re: [Wireshark-dev] my dissector breaks with updated 1.6 source and libs

2011-07-08 Thread Guy Harris
On Jul 8, 2011, at 7:31 PM, olek...@darkcornersoftware.com wrote: > 22:26:55 Err new_fi->hfinfo->type 28 not handled Do you have any fields declared with the field type FT_PCRE? If so, change it to a type that's supported as a field type, such as FT_BYTES. FT_PCRE is not, and never has be

Re: [Wireshark-dev] my dissector breaks with updated 1.6 source and libs

2011-07-08 Thread oleksab
Chris Thanks for the reply. My dissector worked when I updated libs and sources from 1.2 to 1.4. So I figured it would work from 1.4 to 1.6. But it did not. I did get the latest libs and sources and I did recompile everything...but I ended up with some errors (which I will need to dig through).

Re: [Wireshark-dev] my dissector breaks with updated 1.6 source and libs

2011-07-08 Thread Chris Maynard
Brian Oleksa writes: > I have updated to the latest sources today as well as the latest libs. > I put my dissector in place and it crashes. It ran just fine on 1.4.X So you previously built a plugin dissector against 1.4.x and dropped it into the 1.6.0 plugins directory expecting it to work? Th

Re: [Wireshark-dev] Why isn't this a bug?

2011-07-08 Thread Chris Maynard
Jaap Keuter writes: > From the packet-giop.c source code: > > if (*offset > header->message_size) >return FALSE; >} > > Why isn't this a bug? It sure looks like a bug to me. ___ Sent via:Wireshark-d

[Wireshark-dev] Why isn't this a bug?

2011-07-08 Thread Jaap Keuter
Hi list, From the packet-giop.c source code: static gboolean try_heuristic_giop_dissector(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, guint32 *offset, MessageHeader *header, gchar *operation ) { ... { guint32 message_size; gboolean stream_is_big_endian = is

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Michael Tüxen
On Jul 8, 2011, at 9:03 PM, Maynard, Chris wrote: >> -Original Message- >> From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- >> boun...@wireshark.org] On Behalf Of Michael Tüxen >> Sent: Friday, July 08, 2011 2:30 PM >> To: Developer support list for Wireshark >> Subject: Re

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Maynard, Chris
> -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > boun...@wireshark.org] On Behalf Of Michael Tüxen > Sent: Friday, July 08, 2011 2:30 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/g

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Michael Tüxen
On Jul 8, 2011, at 6:57 PM, Maynard, Chris wrote: >> -Original Message- >> From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- >> boun...@wireshark.org] On Behalf Of Michael Tüxen >> Sent: Friday, July 08, 2011 12:34 PM >> To: Developer support list for Wireshark >> Subject: R

[Wireshark-dev] my dissector breaks with updated 1.6 source and libs

2011-07-08 Thread Brian Oleksa
Wiresharkers I have updated to the latest sources today as well as the latest libs. I put my dissector in place and it crashes. It ran just fine on 1.4.X What are the major changes...?? WHY is this always a problem. Where can I get help with fixing my problems..?? Thanks, Brian ___

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Michael Tüxen
On Jul 8, 2011, at 6:57 PM, Maynard, Chris wrote: >> -Original Message- >> From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- >> boun...@wireshark.org] On Behalf Of Michael Tüxen >> Sent: Friday, July 08, 2011 12:34 PM >> To: Developer support list for Wireshark >> Subject: R

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Maynard, Chris
> -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > boun...@wireshark.org] On Behalf Of Michael Tüxen > Sent: Friday, July 08, 2011 12:34 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Michael Tüxen
On Jul 8, 2011, at 6:23 PM, Maynard, Chris wrote: >> -Original Message- >> From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- >> boun...@wireshark.org] On Behalf Of Michael Tüxen >> Sent: Friday, July 08, 2011 11:19 AM >> To: Developer support list for Wireshark >> Subject: R

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Maynard, Chris
> -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > boun...@wireshark.org] On Behalf Of Michael Tüxen > Sent: Friday, July 08, 2011 11:19 AM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Michael Tüxen
On Jul 8, 2011, at 4:14 PM, Maynard, Chris wrote: >> -Original Message- >> From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- >> boun...@wireshark.org] On Behalf Of Michael Tüxen >> Sent: Thursday, July 07, 2011 5:19 PM >> To: Developer support list for Wireshark >> Subject:

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Maynard, Chris
> -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > boun...@wireshark.org] On Behalf Of Michael Tüxen > Sent: Thursday, July 07, 2011 5:19 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk

Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: main_welcome.c

2011-07-08 Thread Maynard, Chris
> -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > boun...@wireshark.org] On Behalf Of Guy Harris > Sent: Thursday, July 07, 2011 4:28 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gt

[Wireshark-dev] XMPP dissector

2011-07-08 Thread Mariusz Okrój
Hi all, I'm cooperating with Jitsi community as Google Summer of Code project. Main goal of this project is creating dissector for XMPP protocol. As you know, there is Jabber dissector in Wireshark but it has got only few filtering possibilities and displays packets in inconvenient way. This is t

Re: [Wireshark-dev] [Wireshark-commits] rev 37913: /trunk/gtk/ /trunk/gtk/: main.c main_welcome.c main_welcome.h

2011-07-08 Thread Michael Tüxen
On Jul 6, 2011, at 11:30 PM, Stig Bjørlykke wrote: > On Wed, Jul 6, 2011 at 11:17 AM, wrote: >> Log: >> Add support for multiple interface to the main welcome screen. > > Some initial comments: :) > - The description is missing from the interfaces Fixed in svn. > - The icon is missing from t

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2011-07-08 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/3645 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86 Build Reason: Bui

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.6-x64

2011-07-08 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.6-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/3222 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.6-x64 Build Reason: Bui

Re: [Wireshark-dev] gtk/main_welcome.c using gtk_cell_renderer_set_visible() (gtk 2.18)

2011-07-08 Thread Michael Tüxen
On Jul 7, 2011, at 5:26 PM, Martin Mathieson wrote: > Hi, > > My build is broken because of this, for now we seem to still support gtk 2.4 > in configure.in Should be fixed now in svn. Please let me know if the problem still exists. Best regards Michael > > Best regards, > Martin > __