Re: [Wireshark-dev] Compilation error Red Hat 3.4.3-9.EL4

2011-04-28 Thread Guy Harris
On Apr 28, 2011, at 11:19 PM, Anders Broman wrote: > So we should require at least 1.2.2.4 then? It's 6 years old after all. I would not mind. I wouldn't to it by checking for a particular version, though - I'd just check for inflatePrime() and, if it's not present, don't build in the "transp

Re: [Wireshark-dev] Compilation error Red Hat 3.4.3-9.EL4

2011-04-28 Thread Anders Broman
Guy Harris skrev 2011-04-29 08:05: On Apr 28, 2011, at 10:48 PM, Anders Broman wrote: It seems like Wireshark no longer compiles if zlib is 1.2.1: file_wrappers.c: In function `file_seek': file_wrappers.c:893: warning: implicit declaration of function `inflatePrime' make: *** [libwiretap_la-fi

Re: [Wireshark-dev] Compilation error Red Hat 3.4.3-9.EL4

2011-04-28 Thread Guy Harris
On Apr 28, 2011, at 10:48 PM, Anders Broman wrote: > It seems like Wireshark no longer compiles if zlib is 1.2.1: > > file_wrappers.c: In function `file_seek': > file_wrappers.c:893: warning: implicit declaration of function `inflatePrime' > make: *** [libwiretap_la-file_wrappers.lo] Error 1 >

[Wireshark-dev] Compilation error Red Hat 3.4.3-9.EL4

2011-04-28 Thread Anders Broman
Hi, It seems like Wireshark no longer compiles if zlib is 1.2.1: file_wrappers.c: In function `file_seek': file_wrappers.c:893: warning: implicit declaration of function `inflatePrime' make: *** [libwiretap_la-file_wrappers.lo] Error 1 file_wrappers.c: 893: (void)inflatePrime(strm, here-

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-04-28 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/1705 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason:

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-28 Thread Jeff Morriss
Bruce, Joseph R (Joe) wrote: On 4/25/11 11:17 AM, "Jeff Morriss" wrote: Bruce, Joseph R (Joe) wrote: Bruce, Joseph R (Joe) wrote: Hi, I'm writing a plugin that registers a capture file callback via cf_callback_add (./file.c:173, ./file.h:83). The callback is invoked on read and other inte

Re: [Wireshark-dev] Reassembling tvbuff_t

2011-04-28 Thread Jeff Morriss
The reassembly code can deal with out-of-order fragments: it needs to because in TCP/IP the fragments may come out of order (they usually don't, of course). One concern with your code is that all the composite tvbuff stuff is not well tested or used. There have been some fixes lately (in tr

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC

2011-04-28 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-PowerPC on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/2604 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build Reas

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2011-04-28 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/3008 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86 Build Reason: Bui

Re: [Wireshark-dev] Any interest in a USB-encapsulated AT/Hayes Commands dissector?

2011-04-28 Thread Tyson Key
Right, so I've just added the latest revisions of the source files to a new bug report (5868). Please feel free to play with the code, and provide comments/criticism/suggestions for improvement. Tyson. On 28 April 2011 15:42, Chris Maynard wrote: > Stephen Fisher writes: > > > > If there's an

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.6-x64

2011-04-28 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.6-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/2556 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.6-x64 Build Reason: Bui

Re: [Wireshark-dev] Any interest in a USB-encapsulated AT/Hayes Commands dissector?

2011-04-28 Thread Chris Maynard
Stephen Fisher writes: > > If there's any interest, I'd be willing to try and clean it up for > > potential submission into mainline Wireshark. > > Sure, why not contribute it. I'm sure someone will find it useful at > some point. Oops, meant to respond sooner, but yes, I for one would be in

Re: [Wireshark-dev] Buildbot relocation

2011-04-28 Thread Gerald Combs
Oops, you're right. It's the 29th. On 4/27/11 11:07 PM, Abhik Sarkar wrote: > Hi Gerald, > > The date you mention is in the past. Should it be 29th instead? > > Regards, > Abhik > > On Wed, Apr 27, 2011 at 9:29 PM, Gerald Combs > wrote: > > The Windows, Ubuntu

[Wireshark-dev] Source Code Analysis for Wireshark

2011-04-28 Thread Lynn Gayowski
I believe Klocwork's open source program did some source code analysis for Wireshark a few years back. We'd like to analyze the project again using our static analysis product, Klocwork Insight, to give a report on bugs and potential security vulnerabilities. The results would be hosted on a secu

Re: [Wireshark-dev] Reassembling tvbuff_t

2011-04-28 Thread fab12
> When you receive a fragment, can you tell which PDU it belongs to (1 or > 2), or does that only become clear after one of the PDUs is reassembled? > > If you can identify the PDU ID before reassembly, then the existing > reassembly code can be made to work, by allocating a separate reassembly > b

Re: [Wireshark-dev] Reassembling tvbuff_t

2011-04-28 Thread Mike Morrin
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of fa...@freesurf.fr Sent: 28 April 2011 08:09 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Reassembling tvbuff_t Hi Anders, I'm not sure the regu

Re: [Wireshark-dev] Crash in capture_dlg.c:1890 (latest SVN)

2011-04-28 Thread Kaul
Looks good, thanks. 2011/4/28 Stig Bjørlykke > On Thu, Apr 28, 2011 at 10:29 AM, Kaul wrote: > > When trying to run wireshark, then - capture -> options from SVN 36928, > > F15beta/x86_64: > > I think this was introduced in revision 36741. > Try the fix in revision 36929. > > > -- > Stig Bjørly

Re: [Wireshark-dev] Crash in capture_dlg.c:1890 (latest SVN)

2011-04-28 Thread Stig Bjørlykke
On Thu, Apr 28, 2011 at 10:29 AM, Kaul wrote: > When trying to run wireshark, then - capture -> options from SVN 36928, > F15beta/x86_64: I think this was introduced in revision 36741. Try the fix in revision 36929. -- Stig Bjørlykke

[Wireshark-dev] Crash in capture_dlg.c:1890 (latest SVN)

2011-04-28 Thread Kaul
When trying to run wireshark, then - capture -> options from SVN 36928, F15beta/x86_64: #0 0x003be1a36415 in raise () from /lib64/libc.so.6 #1 0x003be1a37d2b in abort () from /lib64/libc.so.6 #2 0x003be1a723b3 in __libc_message () from /lib64/libc.so.6 #3 0x003be1a788aa in mall

Re: [Wireshark-dev] Reassembling tvbuff_t

2011-04-28 Thread fab12
Hi Anders, I'm not sure the regular reassembling algo presented in README is good for me because my fragment do not come in sequence. That is I can receive fragment of packet 2 between 2 fragment of packet 1. That is why I'm wondering if my algorithm below is correct and especially the way I use