Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Martin Sustrik
Hi, GPL is ok. The only concern is that I don't like an idea of publishing the thing to the public before I have it reviewed by people from AMQP working group. Something like: send them so/dll, collect the comments, incorporate them into the product, submit it to Wireshark. If that's not possi

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Jaap Keuter
Hi, I don't understand. Do you want to share the object/DLL, or the complete WS source code, or create a patch? Or are you worried about distribution in the GPL sense? Thanx, Jaap On Thu, 22 Mar 2007, Martin Sustrik wrote: > Hi, > > The question I've actually wanted to ask was: "Is there a way

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Martin Sustrik
Hi, The question I've actually wanted to ask was: "Is there a way to distribute plugin dissectors separately from the Wireshark codebase?" The idea being that we review the plugin internally in AMQP working group before submitting it to you. Thanks. Martin ronnie sahlberg wrote: > For inclusio

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Joerg Mayer
On Thu, Mar 22, 2007 at 01:54:19AM +0100, Sebastien Tandel wrote: > packet-pflog.c > "ifdef __GCC_WARNING_NO_USE__" around capture_pflog and > capture_old_pflog which aren't used anymore in the code. Why not just delete them? Ciao Joerg -- Joerg Mayer

[Wireshark-dev] [PATCH] ipv6 dissector update

2007-03-21 Thread Sebastien Tandel
Hi, a patch for the ipv6 dissector : - use of proto_tree_add_item whenever possible - follows the same rules as the one in ipv4 dissector for ipv6_[src|dst|addr][_host] items. - use proto_tree_add_item for displaying the name of the parsed options. - added header type value_string - add an expe

Re: [Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Sebastien Tandel
one version gzipped ;) Sebastien Tandel wrote: > some warning fixes > > packet-http.c > set headers.content_length = 0 before the first potential use of it. > packet-kink.c > "ifdef kerberos" around one function declaration > packet-nbns.c > set headers.{dgm_length|pkt_offset|error_co

[Wireshark-dev] [PATCH]fix warnings II

2007-03-21 Thread Sebastien Tandel
some more fixes packet-ncp.c ncpiph.signature initialized and the following test changed and ncpiph.length = 0 packet-sip in_quoted_string unused variable packet-smb-common.c string_len initialized to 0 packet-smb-pipe.c ent_count initialized to 0 packet-smb.c subcmd unit

[Wireshark-dev] The "...might be clobbered by longjmp..." warning

2007-03-21 Thread Stephen Fisher
With -Werror turned on in certain directories, I am running into a number of warnings turned errors about "[variable|argument] 'variable' might be clobbered by 'longjmp' or 'vfork'". These are happening in the exception code when a variable is modified in a TRY or CATCH statement. Files that

Re: [Wireshark-dev] Getting destination IP

2007-03-21 Thread Jeff Morriss
sara vanan wrote: > > I saw that today only and I tried executing in Linux OS but it gives > error( Invalid filter). Note that "dns && ip.addr == 192.168.16.67 && ip.addr == 192.168.16.106" is a *display* filter which is different from a *capture* filter. E.g., you can type it into the filt

[Wireshark-dev] [PATCH]fix warnings

2007-03-21 Thread Sebastien Tandel
some warning fixes packet-http.c set headers.content_length = 0 before the first potential use of it. packet-kink.c "ifdef kerberos" around one function declaration packet-nbns.c set headers.{dgm_length|pkt_offset|error_code} = 0 packet-pflog.c "ifdef __GCC_WARNING_NO_USE__" around

Re: [Wireshark-dev] Prevent compiler warnings by using "stop on warnings"/"treat warnings as errors" compiler option?

2007-03-21 Thread Stephen Fisher
On Tue, Mar 20, 2007 at 11:09:40PM -0700, Stephen Fisher wrote: > On Tue, Mar 20, 2007 at 05:57:12PM -0700, Guy Harris wrote: > > > Or do it in the config file - look for "-W" in the top-level > > configure.in and the Wiretap configure.in. > > Thanks. I introduced -Werror into the configure.in

Re: [Wireshark-dev] [Wireshark-users] Support for Microsoft LLTD Protocol

2007-03-21 Thread ronnie sahlberg
This document contains a lot of information about this protocol (and others) and would likely be very useful for someone planning to start implementing a dissector. http://www.symantec.com/avcenter/reference/ATR-VistaAttackSurface.pdf On 3/22/07, Jaap Keuter <[EMAIL PROTECTED]> wrote: > Hi, > >

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread ronnie sahlberg
For inclusion into mainline wireshark, please send the patch to the list for revies (unless it is very large in case a url is better) also please provide a few example captures that we can use to test the dissector with. On 3/21/07, Martin Sustrik <[EMAIL PROTECTED]> wrote: > Hi all, > > I've w

Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

2007-03-21 Thread Shaun Jackman
On 3/20/07, ronnie sahlberg <[EMAIL PROTECTED]> wrote: > 1, shouldnt the defines MPA_MARSHAL_... really be called > MPA_UNMARSHAL_... instead? Good point. > 2, do you really need all these includes? > +#include > +#include > +#include > +#include > +#include > +#include > +#include > are a

Re: [Wireshark-dev] Are tap-listeners called for malformed packets?

2007-03-21 Thread Luis Ontanon
It depends on when it "goes malformed" and whether or not the call to tap_queue_packet() was made or not. On 3/21/07, Lars Ruoff <[EMAIL PROTECTED]> wrote: > Hi, > if i have a tap listener registered for protocol X, will it be called also > for a malformed packet of protocol X ? > (I.e. a packet

Re: [Wireshark-dev] error during rpm installation

2007-03-21 Thread Abhik Sarkar
Or perhaps, use --root=/usr/local or --root=/opt to install wireshark in a completely new location which doesn't conflict with the already installed ethereal (if you wanted to keep both for any reason ;-) ) On 3/14/07, Carsten Prescher <[EMAIL PROTECTED]> wrote: > Hello, > > > I've generated an rp

[Wireshark-dev] [PATCH] Packlog fix/enhancement

2007-03-21 Thread Abhik Sarkar
Hi All, Sometime back, with a fair bit of help from Jeff Morris, I added support for dissection of Cisco's Packet Logging Facility messages (the facility allows their ITP router to send SS7 MSUs encapsulated in syslog messages for tracing purposes). One of the problems that the initial implement

[Wireshark-dev] Are tap-listeners called for malformed packets?

2007-03-21 Thread Lars Ruoff
Hi, if i have a tap listener registered for protocol X, will it be called also for a malformed packet of protocol X ? (I.e. a packet which was passed to dissector X, but there was an exception thrown during dissection) br, Lars Ruoff ___ Wireshark-dev

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Jaap Keuter
Hi, Send it to list (if not too big) or open a bugzilla item for it. We'll have a look. If it doesn't break stuff, it should be fine. Have a look in the developer guide and Wiki about submitting patches. Thanx, Jaap On Wed, 21 Mar 2007, Martin Sustrik wrote: > Hi all, > > I've written dissector

Re: [Wireshark-dev] [Wireshark-users] Support for Microsoft LLTD Protocol

2007-03-21 Thread Jaap Keuter
Hi, I've added the Ethernet type (88D9) for it. Someone looking for a project can goto http://www.microsoft.com/whdc/Rally/LLTD-spec.mspx for the spec. A sample capture would be nice as well. Thanx, Jaap On Tue, 20 Mar 2007, Stephen Fisher wrote: > On Tue, Mar 20, 2007 at 06:08:23PM +0530, Mani

Re: [Wireshark-dev] [Wireshark-commits] rev 21077 : /trunk/gtk/ /trunk/gtk/: voip_calls.c voip_ca lls.h voip_calls_dlg.c

2007-03-21 Thread term-autoreply
The person < mrozhavsky @fortinet.com > you were trying to reach is no longer available. Your email is important to us and has been forwarded to another individual who will respond to your email promptly. Thank you for contacting Fortinet. ___ Wire

Re: [Wireshark-dev] [Wireshark-commits] rev 21077 : /trunk/gtk/ /trunk/gtk/: voip_calls.c voip_ca lls.h voip_calls_dlg.c

2007-03-21 Thread Ulf Lamping
> -Ursprüngliche Nachricht- > Von: Developer support list for Wireshark > Gesendet: 21.03.07 14:45:52 > An: "Developer support list for Wireshark" > Betreff: Re: [Wireshark-dev] [Wireshark-commits] rev 21077: /trunk/gtk/ > /trunk/gtk/: voip_calls.c voip_calls.h voip_calls_dlg.c > That

[Wireshark-dev] Capture File

2007-03-21 Thread melike pinar ata
Hi, I am sending more detailed in the attachment.Thanks. _ Hem e-postalarinizi, hem de Bilgisayarinizi MSN Güvenlik ile koruma altina alin! http://www.msn.com.tr/security/ tfo_codec_list_example.pcap Description: Binary data _

Re: [Wireshark-dev] Regarding building Ethereal in MSVC 8.0 .....

2007-03-21 Thread Ulf Lamping
Manjunath P wrote: > Hi All, > I am a newbie to Ethereal and am working to build a pugin. > I hv few simple queries > 1) As per the Project requirements, I hv to use MSVC 8.0 and > nothing else. Is it possible to compile and build Ethereal using MSVC > 8.0??? Has anyone tri

Re: [Wireshark-dev] Prevent compiler warnings by using "stop on warnings"/"treat warnings as errors" compiler option?

2007-03-21 Thread Ulf Lamping
Joerg Mayer wrote: > No, it won't work. I've spent many many hours in the past to get rid of > compiler warnings and it just won't work. While we definitely should try > to get rid of some warnings, fixing warnings on one platform may introduce > warnings on other platforms (or even gcc versions).

[Wireshark-dev] Regarding building Ethereal in MSVC 8.0 .....

2007-03-21 Thread Manjunath P
Hi All, I am a newbie to Ethereal and am working to build a pugin. I hv few simple queries 1) As per the Project requirements, I hv to use MSVC 8.0 and nothing else. Is it possible to compile and build Ethereal using MSVC 8.0??? Has anyone tried this?? I hv read in the D

Re: [Wireshark-dev] Getting destination IP

2007-03-21 Thread sara vanan
I saw that today only and I tried executing in Linux OS but it gives error( Invalid filter). Thanks for mailing me. On 3/21/07, Jeff Morriss <[EMAIL PROTECTED]> wrote: Did you see my answer to your question in your previous email? (At the top of the email I said something about the Excel d

[Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Martin Sustrik
Hi all, I've written dissector for AMQP protocol (www.amqp.org). It's in alpha version and I would like to distribute it among AMQP working group members to get comments/suggestions. Do you think it is appropriate to incorporate alpha version into Wireshark codebase? Or is there some other pr

Re: [Wireshark-dev] [Wireshark-commits] rev 21077: /trunk/gtk/ /trunk/gtk/: voip_calls.c voip_calls.h voip_calls_dlg.c

2007-03-21 Thread Luis Ontanon
That's odd because I checked in changes to packet-sccp.h before those to voip_calls*.[ch] see http://anonsvn.wireshark.org/viewvc/viewvc.py/trunk/epan/dissectors/packet-sccp.h?r1=21076&r2=21075&pathrev=21076&diff_format=l In fact the buildbot seems happy with it. On 3/21/07, Ulf Lamping <[EMAIL

Re: [Wireshark-dev] [Wireshark-commits] rev 21077: /trunk/gtk/ /trunk/gtk/: voip_calls.c voip_calls.h voip_calls_dlg.c

2007-03-21 Thread Ulf Lamping
[EMAIL PROTECTED] wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21077 > > User: lego > Date: 2007/03/21 12:59 AM > > Log: > Add the sccp tap to the "VoIP Calls" Tap (which by now should be renamed to > just "Calls") but that's for later. > > Now it does H323, SIP, M