Re: [Wireshark-dev] Beginners help. How to add additional subtrees ?

2007-01-19 Thread Jan Kokott
Hi, thank you for the tip. I encountered another problem with ti = proto_tree_add_item(zigbee_tree, hf_zigbee_adr, tvb, 3, hlen, FALSE); adr_tree = proto_item_add_subtree(ti, ett_zigbee_adr); /*(again another for() to fill in the fields)*/ because hlen was 20 and the for() did work quite good wi

Re: [Wireshark-dev] [PATCH v2] Add support for the CIPSO IPv4 option

2007-01-19 Thread Jaap Keuter
Hi, Done. Thanx, Jaap On Fri, 19 Jan 2007, Paul Moore wrote: > On Friday, January 19 2007 6:57 pm, Jaap Keuter wrote: > > Checked in. > > Thank you. > > > Would it be oke to put the capture file up on the Wiki on the > > SampleCaptures page? > > No problem here, I think that would be a good ide

Re: [Wireshark-dev] [PATCH v2] Add support for the CIPSO IPv4 option

2007-01-19 Thread Paul Moore
On Friday, January 19 2007 6:57 pm, Jaap Keuter wrote: > Checked in. Thank you. > Would it be oke to put the capture file up on the Wiki on the > SampleCaptures page? No problem here, I think that would be a good idea. -- paul moore linux security @ hp _

Re: [Wireshark-dev] [PATCH v2] Add support for the CIPSO IPv4 option

2007-01-19 Thread Jaap Keuter
Hi, Checked in. Would it be oke to put the capture file up on the Wiki on the SampleCaptures page? Thanx, Jaap On Fri, 19 Jan 2007, Paul Moore wrote: > Attached is the an updated version of the patch I sent on January 17th. The > only two changes are the shift from glib-2.0 specific string fu

Re: [Wireshark-dev] Wireshark 0.99.5pre1 is now available

2007-01-19 Thread Stephen Fisher
On Fri, Jan 19, 2007 at 10:09:42AM -0800, Gerald Combs wrote: > Wireshark 0.99.5pre1 is now available for testing. Source code and a > Windows installer can be downloaded immediately from When I click on the option to "show news" at the end of the installation, it shows me what looks like an o

[Wireshark-dev] [PATCH v2] Add support for the CIPSO IPv4 option

2007-01-19 Thread Paul Moore
Attached is the an updated version of the patch I sent on January 17th. The only two changes are the shift from glib-2.0 specific string functions to the more portable standard C library string functions as well as a small bugfix found during the shift. Below is the text/abstract from the orig

Re: [Wireshark-dev] Use of ep/se mem

2007-01-19 Thread ronnie sahlberg
you probably want ep_alloc() here so that the storage is released once the packet dissection completes (and thus the "tree" is deleted) On 1/19/07, Graham Bloice <[EMAIL PROTECTED]> wrote: > I'm updating an older dissector (dnp3) and it uses a g_malloc() to build > a tmp buffer of data extracted

Re: [Wireshark-dev] [PATCH] Add support for the CIPSO IPv4 option

2007-01-19 Thread Paul Moore
On Friday, January 19 2007 2:38 pm, Jaap Keuter wrote: > Have a look at the developer manual to see which libraries are used to > provide cross platform support. Some other functions are wrapped in an > application specific wrapper since normal libraries didn't provide > sufficient cross platform s

Re: [Wireshark-dev] [PATCH] Add support for the CIPSO IPv4 option

2007-01-19 Thread Jaap Keuter
Hi, Have a look at the developer manual to see which libraries are used to provide cross platform support. Some other functions are wrapped in an application specific wrapper since normal libraries didn't provide sufficient cross platform support. File handling comes to mind. That's it. Thanx, J

[Wireshark-dev] Wireshark 0.99.5pre1 is now available

2007-01-19 Thread Gerald Combs
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Wireshark 0.99.5pre1 is now available for testing. Source code and a Windows installer can be downloaded immediately from http://www.wireshark.org/download/prerelease/wireshark-0.99.5pre1.tar.gz http://www.wireshark.org/download/prerelease/wireshark-

Re: [Wireshark-dev] [PATCH] Add support for the CIPSO IPv4 option

2007-01-19 Thread Paul Moore
On Friday, January 19 2007 12:36 pm, Jaap Keuter wrote: > You at the right spot here, but sometimes it's a bit busy that review of > patches gets delayed. A headsup is always oke. > > Few remarks on the patch. > > Please attach the patch to your emails i.s.o. pasting them in. It makes > handling pa

[Wireshark-dev] Use of ep/se mem

2007-01-19 Thread Graham Bloice
I'm updating an older dissector (dnp3) and it uses a g_malloc() to build a tmp buffer of data extracted in chunks from the tvb. A new tvb is then created from this tmp buffer. After the new tvb (created by a call to tvb_new_real_data()) is created the tmp buffer isn't used. Which emem version sh

Re: [Wireshark-dev] Problems while displaying the digits in the packet

2007-01-19 Thread Jaap Keuter
Hi, We're in need for FT_BCD and FT_PACKED_BCD types. I've once started on them but ended up hacking my own proto_tree_add_packed_bcd() functions. Still these types would be very nice to have. Thanx, Jaap On Fri, 19 Jan 2007, Jeff Morriss wrote: > > > [EMAIL PROTECTED] wrote: > [...] > > proto_

Re: [Wireshark-dev] [PATCH] Add support for the CIPSO IPv4 option

2007-01-19 Thread Jaap Keuter
Hi, You at the right spot here, but sometimes it's a bit busy that review of patches gets delayed. A headsup is always oke. Few remarks on the patch. Please attach the patch to your emails i.s.o. pasting them in. It makes handling patches so much easier. You've used some string handling glib fu

Re: [Wireshark-dev] Beginners help. How to add additional subtrees ?

2007-01-19 Thread Jaap Keuter
Hi, Even though I'm not into the details, if you want to have 20 bytes straight up use FT_BYTES as type. This has an arbitrary length. Thanx, Jaap On Fri, 19 Jan 2007, Jan Kokott wrote: > Hi, > > I found the problem. > The second Subtree has a length of 20 byte. > And that doesn??t work with FT

Re: [Wireshark-dev] h.223 dissector: maybe a bug, mabe a fix?

2007-01-19 Thread Still Life
> The H.223 dissector expects its parent protocol to support > defragmentation; if you just give wireshark the raw data, I don't think > you'll get the defragmentation, as it's quite specific to individual > protocols such as TCP. Fabio's approach makes sense to me. > Fabio, I'm away next week,

Re: [Wireshark-dev] Buildbot builds don't show up for download

2007-01-19 Thread Gerald Combs
I updated Cygwin on the Windows builder a few days ago. It looks like that exposed a bug in make-version.pl which kept the revision number from being appended to the package names. Revision-less packages don't get copied to the web site automatically (otherwise we might end up with several wiresh

Re: [Wireshark-dev] Problems while displaying the digits in the packet

2007-01-19 Thread Jeff Morriss
[EMAIL PROTECTED] wrote: [...] > proto_tree_add_string(tree, hf_xyz_imsi, tvb, (imsi_len/2 + 1), > (imsi_len/2 + 1), digit_str); [...] > When the above code snippet is executed, we are getting the following error: > > Warn Dissector bug, protocol MACIC, in packet 1: proto.c:1859: failed > as

Re: [Wireshark-dev] Problems while displaying the digits in the packet

2007-01-19 Thread Sebastien Tandel
Hi, It seems that hf_xyz_imsi that you have defined in your hf_register_info struct is not a FT_STRING or a FT_STRINGZ type. Regards, Sebastien Tandel [EMAIL PROTECTED] wrote: > > Hi , > > > > We have a parameter IMSI in our protocol . It has the following format : > > > > 7 > > > >

Re: [Wireshark-dev] Crash when loading large capture files

2007-01-19 Thread Jeff Morriss
Mike Tisdell wrote: > Dev, > > Wireshark crashes regularly when I try to load large capture files (over > 100MB) on my FreeBSD system. I am currently using Wireshark > wireshark-0.99.4_1, and FreeBSD 6.2-PRERELEASE, but I have seen this problem > through several version of Wireshark, and unde

[Wireshark-dev] Problems while displaying the digits in the packet

2007-01-19 Thread taraniteja.vishwanatha
Hi , We have a parameter IMSI in our protocol . It has the following format : 7 6 5 4 3 2 1 0 octet Number of digits 3 IMSI digit 2 IMSI digit 1 4 IMSI digit 4 IMSI digit 3 5 IMSI digit 2n IMSI digit 2n-1 n+3 typedef struct dgt_set_t { unsigned char out[15]; }

[Wireshark-dev] Crash when loading large capture files

2007-01-19 Thread Mike Tisdell
Dev, Wireshark crashes regularly when I try to load large capture files (over 100MB) on my FreeBSD system. I am currently using Wireshark wireshark-0.99.4_1, and FreeBSD 6.2-PRERELEASE, but I have seen this problem through several version of Wireshark, and under previous version of FreeBSD. Th

Re: [Wireshark-dev] [PATCH] Add support for the CIPSO IPv4 option

2007-01-19 Thread Paul Moore
On Wednesday, January 17 2007 2:52 pm, Paul Moore wrote: > This patch adds support for the IPv4 Commercial IP Security Option (CIPSO) > as defined in the IETF draft, draft-ietf-cipso-ipsecurity-01.txt. While > this draft has long since expired, it has become a de-facto standard for > labeled netwo

Re: [Wireshark-dev] Beginners help. How to add additional subtrees ?

2007-01-19 Thread Jan Kokott
Hi, I found the problem. The second Subtree has a length of 20 byte. And that doesn´t work with FT_NONE or FT_UNIT64. As it seems I have to declare a struct which will be used in the hf_register_info hf[] to replace the FT_ variable. Regards Jan Original-Nachricht Datum: Fri

Re: [Wireshark-dev] Buildbot builds don't show up for download

2007-01-19 Thread Jaap Keuter
Hi, The successful builds from 20486 and up are missing though. Gerald fixed it, starting again from 20500 after a three day gap. Thanx, Jaap On Fri, 19 Jan 2007, Ulf Lamping wrote: > Jaap Keuter wrote: > > Hi Gerald, > > > > Even though the build has been restored to working order, rsyncing th

Re: [Wireshark-dev] h.223 dissector: maybe a bug, mabe a fix?

2007-01-19 Thread Richard van der Hoff
Anders Broman wrote: > Hi, > It would be more interesting and useful to add the capability in > wiretap to read the raw h.223 data with a pcap header. Others can perhaps > help with hints on how to do that. The H.223 dissector expects its parent protocol to support defragmentation; if you just gi

Re: [Wireshark-dev] Buildbot builds don't show up for download

2007-01-19 Thread Ulf Lamping
Jaap Keuter wrote: > Hi Gerald, > > Even though the build has been restored to working order, rsyncing them to > buildbot.wireshark.org:dropoff/winxpx86 doesn't make them show up in the > download page. They're also missing the revision number in the installer > file name. > > Thanx, > Jaap > >

Re: [Wireshark-dev] [Wireshark-commits] rev 20491: /trunk/docbook/ /trunk/docbook/: Makefile

2007-01-19 Thread Sebastien Tandel
just for the fun and to get an idea of how long these commands last ... I made the tests three times (just extract one representative), each followed by a sync and the computer has enough free memory to load the file into it. Here are numbers for a file of 179M time tr -d '\015' file.unix real

[Wireshark-dev] Beginners help. How to add additional subtrees ?

2007-01-19 Thread Jan Kokott
Hi, My 802.15.4 plugin starts working, but as a newbie to C it´s still quite difficult to deal with the idea of pointer. :( For starting the plugin I just reused the rudp plugin, so at the moment I implemented the Frame Control field and Addressing field of Zigbee under UDP at an virtual udp po

Re: [Wireshark-dev] [Wireshark-commits] rev 20491: /trunk/docbook/ /trunk/docbook/: Makefile

2007-01-19 Thread Sake Blok
On Thu, Jan 18, 2007 at 04:20:40PM -0800, Guy Harris wrote: > > On Jan 18, 2007, at 4:08 PM, Sebastien Tandel wrote: > > >> Is it safe to assume that dos2unix is available on a common UNIX > >> developer machine?!? > > > > Nope, it is not ... :-/ > > No, but > > tr -d '\015' file_with_