On Friday, January 19 2007 12:36 pm, Jaap Keuter wrote: > You at the right spot here, but sometimes it's a bit busy that review of > patches gets delayed. A headsup is always oke. > > Few remarks on the patch. > > Please attach the patch to your emails i.s.o. pasting them in. It makes > handling patches so much easier. > > You've used some string handling glib functions which, to my knowledge, > aren't available in glib 1.2. Functions I've seen are g_stpcpy and > g_strlcat, but maybe there more. Can you verify this works on glib 1.2?
Thanks for the response and the comments; I'll attach my patches instead of including them inline as before. Regarding the use of the glib string functions, I saw a bunch of glib functions being used in the sources instead of their standard C counterparts so I went to the glib website and used as many functions as I could out of their 2.0 API. Guess I picked the wrong version. Personally, I guess I would prefer to just stick with the standard C functions as they are far more portable but I can understand the desire to use glib where possible. What is the "official" stance on things like this? -- paul moore linux security @ hp _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
