Hi Aric,
Aric Stewart wrote:
> ---
> dlls/msctf/threadmgr.c | 28
> 1 files changed, 24 insertions(+), 4 deletions(-)
>
+if (!pdimFocus ||
FAILED(IUnknown_QueryInterface(pdimFocus,&IID_ITfDocumentMgr,(LPVOID*) &check)))
+return E_INVALIDARG;
+
+Thi
Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
> mshtml: Add support for IHTMLStyle4 interface
>
---
dlls/mshtml/Makefile.in |1 +
dlls/mshtml/htmlstyle.c |4 ++
dlls/mshtml/htmlstyle.h |3 +
dlls/mshtml/htmlstyle4.c | 135 ++
dl
Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
> mshtml: Add support for IHTMLStyle3 interface
>
+
+hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle3, (void**)&style3);
+ok(hres == S_OK, "Could not get IHTMLStyle3 iface: %08x\n", hres);
+if(SUCCEEDED(hres)) {
+IH
Hi Juan,
These failures are on Win64 where we should query for different
interface. I've sent a patch to fix it:
http://www.winehq.org/pipermail/wine-patches/2009-February/068760.html
Jacek
Paul Vriens wrote:
> Alistair Leslie-Hughes wrote:
>
>> Hi,
>>Added Tests
>>
>> Changelog:
>> shdocvw: OnAmbientPropertyChange should refresh all properties with
>> a DISPID_UNKNOWN
>>
>> Best Regards
>> Alistair Leslie-Hughes
>>
>>
>>
>>
>>
>> -
Alistair Leslie-Hughes wrote:
> Hi,
>After testing on XP, it appears that OnAmbientPropertyChange when
> passwed DISP_UNKNOWN doesnt check all properties.
>
> Changelog:
> shdocvw: Correct OnAmbientPropertyChange regession
+CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED);
+
any new regressions with it.
Also the last debug version was accidentally stripped. It will be fixed
in this release. I'm planning to do the release tomorrow, so it will be
in Git on Friday.
Thanks,
Jacek
>From 35f651d05f04dc80dd85451d48428d5c6174dac2 Mon Sep 17 00:00:00 2001
From: J
Scott Ritchie wrote:
> Jacek Caban wrote:
>
>> Hi all,
>>
>> The last release of Wine Gecko caused a few regressions. Thanks to
>> Alexandre, we've found the reason. The bad news is that the fix requires
>> a new package. I've uploaded RC build to:
Detlef Riekenberg wrote:
> I did a speed test for JS with Wine:
>
>
>
> http://v8.googlecode.com/svn/data/benchmarks/v3/run.html
>
> wine 17666004c839a40f1dbc5c98468557091bf3e13c
> Score: 48.5
>
> Richards: 47.7
> DeltaBlue: 56.3
> Crypto: 32.1
>
James Mckenzie wrote:
> Jacek Caban wrote:
>
>> Scott Ritchie wrote:
>>
>>> Is this version compatible with Wine 1.0.1 by chance?
>>>
>>>
>> No, it's technically impossible.
>>
>>
> Is it possible to bu
Paul TBBle Hampson wrote:
> On Thu, Feb 05, 2009 at 12:52:23AM +0100, Jacek Caban wrote:
>
>> The last release of Wine Gecko caused a few regressions. Thanks to
>> Alexandre, we've found the reason. The bad news is that the fix
>> requires a new packa
Hi Austin,
Austin English wrote:
-hres = IHTMLDocument2_get_body(doc, &body);
-ok(hres == S_OK, "get_body failed: %08x\n", hres);
-
if(body) {
+hres = IHTMLDocument2_get_body(doc, &body);
+ok(hres == S_OK, "get_body failed: %08x\n", hres);
You check body before get
Vitaliy Margolen wrote:
Jacek Caban wrote:
Hi all,
The last release of Wine Gecko caused a few regressions.
Yes it did and some are still not fixed. Flash does not work anymore on all
the pages. This really needs to be fixed.
I've been looking on it for a while and I didn&#
Dan Kegel wrote:
> Is it a bug? I don't know those flags well enough.
It's not a bug, a constant 0 value is passed as flags to
set_nsstyle_attr. I've marked it as FALSE in coverity.
Jacek
Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
> mshtml: Implement IHTMLStyle_put_textDecorationUnderline
+
+return set_style_attr(This, STYLEID_TEXT_DECORATION, v == VARIANT_TRUE ?
valUnderline : emptyW, 0);
You shouldn't compare v to VARIANT_TRUE. The correct way to deal with
bo
Hi Alistair,
Alistair Leslie-Hughes wrote:
> Hi,
>
> Changelog:
> mshtml: Implement IHTMLStyle get/put minHeight
>
[get|set]_nsstyle_attr_var functions were introduces to avoid the code
duplication like you do. You should use them (and probably implement
VT_I4 handling in set_nsstyle_attr_v
Rico Schüller wrote:
> Hi,
>
> I'd like to have some feedback, before I send this to wine-patches.
>
> This patch removes a regression in the mshtml test, where the wrong
> variable is called by SysFreeString, which leads sometimes to a crash
> (
> http://test.winehq.org/data/0d7bec3578e02e1f551
Hi Alistair,
Alistair Leslie-Hughes wrote:
Hi,
The spec file specified 4 parameters but it only takes 3.
Validate parameters to XP.
Added test cases.
Tested on win98 and XP.
Changelog:
shlwapi: Correct AssocCreate and tests
+hr = pAssocCreate(IID_NULL, &IID_NULL, NULL);
Hi Robert,
Robert Wilhelm wrote:
Third try of my effort to get create vbscript skeleton similar to
jscript one.
Your patch series looks good for me, except one little problem:
+#include "windef.h"
+#include "winbase.h"
+#include "winuser.h"
+#include "ole2.h"
+#include "dispex.h"
+#include
Alistair Leslie-Hughes wrote:
Hi Jacek,
Jacek Caban wrote:
---
dlls/mshtml/htmlelem.c | 33 +++--
dlls/mshtml/tests/dom.c | 42
++
2 files changed, 73 insertions(+), 2 deletions(-)
static const WCHAR xW[] = {'
Hi Roman,
On parsing of manifest in PE module is possible access to zero address
and crash. It's happens because not all manifest attributes can be
specified and pointers in assembly_identity structure can be
uninitialized. This patch adds function for setting empty strings in
structure elements
Hi Alistair,
Alistair Leslie-Hughes wrote:
Hi,
Added check for IUnknown, thanks Jacek.
It would be better to return correct error on QueryInterface failure.
Otherwise you're duplicating the code.
Jacek
Hi Paul,
Paul Vriens wrote:
Hi,
The Gopher protocol has been removed from Vista (and later versions).
hres = CoGetClassObject(&CLSID_GopherProtocol, CLSCTX_INPROC_SERVER, NULL,
&IID_IUnknown, (void**)&unk);
+if (hres == REGDB_E_CLASSNOTREG) {
+win_skip("Gopher protocol has bee
Ge van Geldorp wrote:
Hi Jacek,
I've been investigating the failures in the urlmon ftp protocol tests that
show up on quite a few WinXP and higher machines. It seems to me that there
is an inherent race condition in the test.
The main thread waits in line 1822 until IInternetProtocolSink_Switch
Hi Paul,
Paul Vriens wrote:
Jacek Caban wrote:
---
dlls/urlmon/tests/protocol.c | 723
+++---
1 files changed, 608 insertions(+), 115 deletions(-)
Hi Jacek,
This introduces
Hi Dan,
Dan Kegel wrote:
Hi Jacek,
why do you have tls_list in
http://www.winehq.org/pipermail/wine-patches/2009-May/072833.html
? The usual idiom is to just free each thread's data in THREAD_DETACH,
isn't it?
THREAD_DETACH is called only if thread detaches before urlmon.dll is
unloaded.
Hi Paul,
Paul Vriens wrote:
Changelog
Fix 2 test failures on IE8
-ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp);
+ok(disp == (void*)0xdeadbeef ||
+ disp == NULL, /* IE8 */
This test does no longer make sense. It would be better to remove it and
preferably chan
Paul Vriens wrote:
Jacek Caban wrote:
Hi Paul,
Paul Vriens wrote:
Changelog
Fix 2 test failures on IE8
-ok(disp == (void*)0xdeadbeef, "disp=%p\n", disp);
+ok(disp == (void*)0xdeadbeef ||
+ disp == NULL, /* IE8 */
This test does no longer make sense. I
Hi Paul,
Paul Vriens wrote:
Jacek Caban wrote:
---
dlls/wininet/tests/http.c | 107
++--
1 files changed, 82 insertions(+), 25 deletions(-)
Hi Jacek,
This patch
Hi Hans,
Hans Leidekker wrote:
Fixes file downloads in ie7.
-Hans
diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
index 8f9f404..2721427 100644
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -3807,8 +3807,7 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWININETHTTPREQW
lpwhr, LPCWSTR
Hi Paul,
Paul Vriens wrote:
This piece however doesn't look correct:
+static void _test_disp2(unsigned line, IUnknown *unk, const IID
*diid, const IID *diid2)
+{
+IID iid;
+
+if(_test_get_dispid(line, unk, &iid))
+ok_(__FILE__,line) (IsEqualGUID(&iid, diid) ||
broken(IsEqualG
Hi Detlef,
Detlef Riekenberg wrote:
This time, we don't care about dwEnum.
That value is returned from CreateZoneEnumerator and
checked only in GetZoneAt and DestroyZoneEnumerator.
Windows has only the Zones "0" upto "4" since IE4.0
and no UI to add or remove a Zone.
Did you test what happ
Hi Paul,
Paul Vriens wrote:
Jacek Caban wrote:
---
dlls/urlmon/tests/misc.c | 84
-
1 files changed, 82 insertions(+), 2 deletions(-)
Hi Jacek,
The addition of these
Hi Piotr,
Piotr Caban wrote:
---
dlls/jscript/date.c|2 +-
dlls/jscript/dispex.c |2 +-
dlls/jscript/engine.c | 12
dlls/jscript/jscript.h |9 ++-
dlls/jscript/jsutils.c | 57
dlls/jscript/tests/
If everything goes well, I will do the release on Monday next week.
Thanks,
Jacek
commit 63e1e5a530b27b2bbd1795a418e618b1d4692235
Author: Jacek Caban
Date: Wed Jul 29 18:00:53 2009 +0200
Wine Gecko 1.0.0 release.
diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c
index 0
Hi André,
André Hentschel wrote:
Works great as fire as i tested it.
Great, thanks for testing.
Nice to see HTML5 in wines iexplore, really great and crazy! So we can
call next release of Wine HTML5-ready :)
I'd file a bug report: "Wine treats HTML5 differently than IE" :)
Jacek
ssion.
If everything goes well, I will do the release on Monday next week.
Thanks,
Jacek
commit 63e1e5a530b27b2bbd1795a418e618b1d4692235
Author: Jacek Caban
Date: Wed Jul 29 18:00:53 2009 +0200
Wine Gecko 1.0.0 release.
diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c
Alexandre Julliard wrote:
Jacek Caban writes:
It's time for the new Wine Gecko package release. I've prepared a new
package based on Mozilla code a bit newer than Firefox 3.5 and my
fixes (most of them are on their way to mainstream Mozilla
repository). This release fixes a few
André Hentschel wrote:
Jacek Caban schrieb:
Hi André,
André Hentschel wrote:
Works great as fire as i tested it.
Great, thanks for testing.
Nice to see HTML5 in wines iexplore, really great and crazy! So we
can call next release of Wine HTML5-ready :)
I'd file a bug report: "W
Nikolay Sivov wrote:
Hi.
After upgrading to Wine-gecko 1.0.0 I've got a wineboot crashes on
initial .wine directory creation (log attached).
Removing cab throws a message about missed gecko engine and no crash
occurred.
What is it about?
Alexandre has found the problem. Commenting FreeLibr
Hi Alistair,
Alistair Leslie-Hughes wrote:
Hi,
Could I get some feedback on this patch please?
+HRESULT hr = E_INVALIDARG;
+
+TRACE("(%p)->(%p, %p)\n", This, pAdvSink, pdwConnection);
+
+if(!pdwConnection || !pAdvSink)
+return hr;
+
+if(!This->holder)
+{
+h
Hi Dan,
Dan Kegel wrote:
While one doesn't really need to build the apps
under Wine to run their test suites, it's a pain
to have to compile them on one system and
ship them over to another.
And supporting building might have a nice benefit: if
it's easy to develop for Windows on Wine,
more Wind
Hi Reece,
Reece Dunn wrote:
2009/8/10 Jacek Caban :
- We need a patched version of Mozilla
These patches are in Wine Gecko source and some of them are already in
Mozilla repository. Newer Mozilla version requires however another patches.
I'd put them in a Git repository, but repo.or.cz do
Reece Dunn wrote:
2009/8/10 Jacek Caban :
Hi Reece,
Reece Dunn wrote:
2009/8/10 Jacek Caban :
- We need a patched version of Mozilla
These patches are in Wine Gecko source and some of them are already in
Mozilla repository. Newer Mozilla version requires however another
Dan Kegel wrote:
On Mon, Aug 10, 2009 at 6:50 AM, Jacek Caban wrote:
While I agree with this arguments, I think Wine would benefit more from
compiling using MinGW in case of Firefox. It would test code of Wine Gecko
package, which would be great. Obviously MSVC compilation would also test
Alistair Leslie-Hughes wrote:
Hi,
This fixes bug http://bugs.winehq.org/show_bug.cgi?id=18531
Changelog:
shdocvw: Implement OleInPlaceObject InPlaceDeactivate
It's not an implementation, but a bit better stub. Please leave the
FIXME message.
Jacek
Alistair Leslie-Hughes wrote:
Hi,
Changelog:
msxml3: Add IDispatchEx support to IXMLDOMElement
@@ -46,6 +47,9 @@ typedef struct _domelem
LONG ref;
IUnknown *node_unk;
IXMLDOMNode *node;
+
+/* IDispatchEx */
+DispatchEx dispex;
} domelem;
It would be probably be
Alistair Leslie-Hughes wrote:
Hi,
This is just to silence a noisy fixme.
Changelog:
msxml3: IXMLDOMElement doesnt support IObjectIdentity
It's an interface used by jscript engine, so it would be better to
silence it for all object that implements IDispatch. I'd suggest to move
it to d
> dbghelp: Fixed arena allocation in pool_alloc.
Well, 'fixed' might be a wrong word, but this patch makes it more intuitive.
Jacek
André Hentschel wrote:
Just tried to copy in some german dictionaries from my firefox but it
didnt work.
Then i deleted both the copied in german and the standard english ones
and the spellchecker was disabled.
That looks much better when writing nonenglish.
I've sent a patch that disables sp
Hi Vladimir,
Vladimir Pankratov wrote:
Hello all.
Implemented OmNavigator_get_appName.
Please add a test.
Jacek
Hi Alistair,
Alistair Leslie-Hughes wrote:
Hi,
Changelog:
msxml3: Add IDispatchEx support to IXMLDOMElement
+else if( IsEqualGUID( riid, &IID_IDispatch ) ||
+ IsEqualGUID( riid, &IID_IDispatchEx ) )
+{
+xmlnode *node = impl_from_IXMLDOMNode( This->node );
+
+
Alexandre Julliard wrote:
Jacek Caban writes:
@@ -84,6 +83,13 @@ static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode
*iface )
return (xmlnode *)((char*)iface - FIELD_OFFSET(xmlnode, lpVtbl));
}
+static inline IXMLDOMNode *_IXMLDOMNode_(xmlnode *This)
+{
+return
Alexandre Julliard wrote:
Jacek Caban writes:
I just feel that it's better to have a wrapper to avoid explicit casts
in the code and have vtbl logic separated from other code. I usually
use macros, but I know you don't like it, so I used an inline function
here.
For secon
Hi Alistair,
Alistair Leslie-Hughes wrote:
Hi,
Changelog:
mshtml: Implement IHTMLStyle get/put wordSpacing
static HRESULT WINAPI HTMLStyle_put_wordSpacing(IHTMLStyle *iface, VARIANT v)
{
-HTMLStyle *This = HTMLSTYLE_THIS(iface);
-FIXME("(%p)->(v%d)\n", This, V_VT(&v));
-retur
Hi Juan,
Your patch looks good (although I'd suggest splitting set_proxy to two
function instead of doing it by gotos), but I've just sent a patch that
makes mshtml use wininet for networking (via urlmon), so your patch is
no longer needed. My patch is a major step forward in MSHTML/shdocvw
i
Hi Austin,
static BOOL msi_strequal(LPCWSTR str1, LPCSTR str2)
{
- DWORD len, ret;
+ WCHAR len, ret;
WCHAR doesn't look like a right type here. Although technically it's integer,
it's meant for unicode chars.
Jacek
Hi Austin,
Austin English wrote:
Please apply after the first dxdiag patch (unicode-ify). Based on a
patch by Dan Kegel.
case 'w':
+opt_given = TRUE;
+while (isalpha(*s) || *s == ':')
+
You can't use isalpha on WCHAR. Use isalphaW instead.
Jacek
Hi Francois,
It should be completely removed as it's not used anymore. Also
nsIStringInputStream may be removed. I've sent a patch, thanks for
catching it.
Jacek
Francois Gouget wrote:
It turns out I was missing libxml2 in one of my environments and this
lead to the following compilation error:
$ gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__
-DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
-Wwrite-strings -Wpointe
Hi Alistair,
Alistair Leslie-Hughes wrote:
Hi,
Changelog:
msxml3: Add IDispatchEx support to IXMLDOMElement
+static const tid_t domelem_iface_tids[] = {
+IXMLDOMNode_tid,
+IXMLDOMElement_tid,
IXMLDOMElement inherits from IXMLDOMNode, so there is not need to add
IXMLDOMNode her
Hi Vladimir,
Vladimir Pankratov wrote:
Hello all.
Added test for IsValidURL.
changed files:
dlls/urlmon/tests/misc.c
+{
+hr = IsValidURL(NULL, bad_urls[i], 0);
+ok(hr != S_OK, "URL %s must be invalid\n", wine_dbgstr_w(bad_urls[i]));
It would be better to test the exact
Hi Paul,
Paul Vriens wrote:
Hi Jacek,
Looks like this patch introduced test failures on IE6 and IE7 (only?
as a box with IE5 succeeded and IE8 seems ok as well).
Could you have a look?
It strange, it works for me on IE6. IE7 is clearly broken. I've sent
patches fixing it, thanks for notif
Hi Paul,
Paul Vriens wrote:
On 09/02/2009 12:27 PM, Jacek Caban wrote:
---
dlls/mshtml/tests/htmldoc.c | 270
+--
1 files changed, 182 insertions(+), 88 deletions(-)
Hi Jacek
Hi Vincent,
Vincent Povirk wrote:
As far as I know, this failure only occurs when I do something stupid
like set use_midl_tlb to 1 and don't provide a working
midl_tmarshal.tlb, but I need the test to remind me that I'm an idiot
when I do that. Silently skipping tests is unacceptable.
W
Hi Aric,
Aric Stewart wrote:
---
dlls/shlwapi/shlwapi.spec |1 +
dlls/shlwapi/string.c | 23 +++
2 files changed, 24 insertions(+), 0 deletions(-)
I didn't test it myself, but StrChrNW name suggests, that the search
shouldn't be case insensitive.
Jacek
Hi Paul,
Paul Vriens wrote:
Hi Jacek,
I've been looking at the tests reports and we seem to have a few
spurious errors:
http://test.winehq.org/data/tests/urlmon:protocol.html
The ones I mean are:
protocol.c:2535: Testing http protocol (direct read)...
protocol.c:497: Test failed: unexpecte
Hi Paul,
Paul Vriens wrote:
Hi Jacek,
The second one never happened on any of my boxes. I'm also not able to
reproduce the first failure. As said, it happens intermittently and,
so it seems, only when running winetest?
I do see two boxes (Jeff's Vista box and Aurimas's XP box) that
regula
Hi Roderick,
Roderick Colenbrander wrote:
Hi,
This is an updated version which uses a proper function prototype for
alloc_xrenderinfo. Further it checks whether the function succeeded in
XRender_SelectFont.
EnterCriticalSection(&xrender_cs);
-if(!physDev->xrender) {
-physDev
Hi Andrew,
Andrew Eikum wrote:
---
dlls/mshtml/htmllocation.c | 93
+++--
dlls/mshtml/tests/htmllocation.c |4 +-
2 files changed, 90 insertions(+), 7 deletions(-)
What's IHTMLDocument2::URL value in these cases? I'd expect it to be the
same, whi
Andrew Eikum wrote:
---
dlls/mshtml/htmllocation.c | 27 ++-
dlls/mshtml/tests/htmllocation.c |8
2 files changed, 10 insertions(+), 25 deletions(-)
-hres = CoInternetParseUrl(doc_url, PARSE_PATH_FROM_URL, 0, buf, sizeof(buf),
&size, 0);
Ple
Andrew Eikum wrote:
Jacek Caban wrote:
Hi Andrew,
Andrew Eikum wrote:
---
dlls/mshtml/htmllocation.c | 93
+++--
dlls/mshtml/tests/htmllocation.c |4 +-
2 files changed, 90 insertions(+), 7 deletions(-)
What's IHTMLDocument2::URL value in
Andrew Eikum wrote:
Jacek Caban wrote:
-hres = CoInternetParseUrl(doc_url, PARSE_PATH_FROM_URL, 0, buf,
sizeof(buf), &size, 0);
Please don't remove it. Using pluggable protocol has a visible on
application and I've tested that it really should be called when I
implemente
Hi Andrew,
Andrew Eikum wrote:
---
dlls/mshtml/dispex.c | 16 ++--
1 files changed, 14 insertions(+), 2 deletions(-)
+if(This->data->vtbl && This->data->vtbl->value){
+IUnknown *unk;
+IDispatchEx_QueryInterface(iface, &IID_IUnknown,
Hi Andrew,
Andrew Eikum wrote:
---
dlls/mshtml/htmlimg.c | 46
+-
1 files changed, 45 insertions(+), 1 deletions(-)
+if(params->cArgs >= 2) {
+width = params->rgvarg;
+height = params->rgvarg + 1;
+}else if(params->cA
Jacek Caban wrote:
argc = params->cArgs - params->cNamedArgs;
width = argc >= 2 ? params->rgvarg+argc-1 : ∅
height = argc >= 1 ? params->rgvarg+argc-2 : ∅
I've made an obvious mistake here, but I guess it's easy to fix :)
Jacek
Hi Dan,
Dan Kegel wrote:
Hi Jacek!
Please have a look at
http://kegel.com/wine/valgrind/logs/2009-10-20-01.09/vg-jscript_run.txt
There are a few interesting errors there. The first one (with a
little context from
http://kegel.com/wine/valgrind/logs/2009-10-20-01.09.log) is:
Thanks for the
Andrew Eikum wrote:
Jacek Caban wrote:
Jacek Caban wrote:
argc = params->cArgs - params->cNamedArgs;
width = argc >= 2 ? params->rgvarg+argc-1 : ∅
height = argc >= 1 ? params->rgvarg+argc-2 : ∅
I've made an obvious mistake here, but I guess it's easy to fix :)
Robert Shearman wrote:
Are these helpstrings an exact copy of what is in native? If so, I
don't think we want them in Wine (and they are only useful to VB
programmers anyway).
I've added them because I wanted to have shdocvw typelib, that should be
generated from exdisp.idl, as near to origin
Alexandre Julliard wrote:
Jacek Caban <[EMAIL PROTECTED]> writes:
ChangeLog:
Move IOleClientSite to new DocHost object to allow sharing code
between WebBrowser and InternetExplorer.
Thanks for sending a series of small patches instead of a big one, but
next time can you please
Stefan Leichter wrote:
Hi,
i am getting a compile error on current cvs. Does anyone else seeing this
problem e.g. on git ?
Does the attached patch help?
Jacek
diff --git a/tools/widl/parser.y b/tools/widl/parser.y
index 9f288bf..4f3ed57 100644
--- a/tools/widl/parser.y
+++ b/tools/widl/par
Robert Shearman wrote:
> Jacek Caban wrote:
>
>> static HRESULT WINAPI WebBrowser_put_Visible(IWebBrowser2 *iface,
>> VARIANT_BOOL Value)
>> {
>> WebBrowser *This = WEBBROWSER_THIS(iface);
>> -FIXME("(%p)->(%x)\n", This, Value);
Robert Shearman wrote:
> Jacek Caban wrote:
>
>> static HRESULT WINAPI WebBrowser_get_HWND(IWebBrowser2 *iface, long
>> *pHWND)
>> {
>> WebBrowser *This = WEBBROWSER_THIS(iface);
>> -FIXME("(%p)->(%p)\n", This, pHWND);
>> -re
Dimi Paun wrote:
> On Sun, 2006-04-30 at 14:51 +0200, Jacek Caban wrote:
>
>> I also have tests showing that we do exactly what we should. The same
>> applies to a few of my other similar patches.
>>
>
> This is not as obvious to people, it would be be
Dimi Paun wrote:
> On Sun, 2006-04-30 at 23:40 +0200, Jacek Caban wrote:
>
>> I'll send a patch with comments. I'd prefer to add tests as well, but
>> it has to wait for the switch to MSHTML based WebBrowser
>> implementation (BTW that seems to be really near)
Alexandre Julliard wrote:
> Thanks; my idea is that since we don't want to make widl load a tlb
> from a builtin dll, we'll need to ship the raw tlb, and it would make
> sense to ship it in the include dir since the lib dir already contains
> the builtin dll. And when building Wine itself, we'll ne
Hi Detlef,
Detlef Riekenberg wrote:
> Changelog:
>
> DEVELOPER-HINTS: Some directories are renamed / removed / added
>
>
> @@ -192,11 +194,15 @@ DLLs (under dlls/):
> Winelib programs (under programs/):
> ---
>
> - avitools/ - AVI informati
Alexandre Julliard wrote:
> Jacek Caban <[EMAIL PROTECTED]> writes:
>
>
>> dlls/urlmon/binding.c | 25 -
>> 1 files changed, 20 insertions(+), 5 deletions(-)
>>
>
> This breaks the tests:
>
> ../../../tools/ru
Hi.
Please consider this mail as:
Re: Built-in iexplore
Re: acad 2004 licence file bug
Re: Broken FC5 packages - stay clear.
Last week Wine Gecko was mentioned a few times on this mailing list and
I can see that there is no understanding of it. It's not really
surprising as it's a big mess AT
Hi Boaz,
Boaz Harrosh wrote:
Hi Jacek.
This would maybe also Address my problem. Please see my posting this
week [Wine's Mozilla Control - Very old]
I doubt if it's what you need. This implementation replaces windows'
DLLs. What you need is something that replaces only the control.
Choosing
Mike Hearn wrote:
On 6/14/06, Jacek Caban <[EMAIL PROTECTED]> wrote:
Last week Wine Gecko was mentioned a few times on this mailing list and
I can see that there is no understanding of it. It's not really
surprising as it's a big mess ATM. We can still use Mozilla ActiveX
c
Mike Hearn wrote:
On 6/14/06, Jacek Caban <[EMAIL PROTECTED]> wrote:
See http://www.winehq.org/?issue=285#MSHTML%20Update. I'd really like to
use Linux Gecko, but it's impossible because we'd need XEmbed embedder
support that's impossible to implement in Wine (perhap
Hi,
Piotr Caban wrote:
Hi,
Changelog:
- Removed use of strlenW, strcmpW, strcpyW functions
programs/oleview/details.c | 14 +++---
programs/oleview/tree.c| 16
2 files changed, 15 insertions(+), 15 deletions(-)
--
Piotr
You should also remove include wi
Hi,
Now that Wine Gecko installer is in the tree, we have to enable it. All
we have to do on Wine side is set one registry value, but first we need
to have wine_gecko.cab file available to download. It means:
- Uploading wine_gecko.cab to SourceForge. I don't have an access to do
so. Could so
Jeremy Newman wrote:
This is now live at:
http://source.winehq.org/winegecko.php
On Sun, 2006-06-25 at 11:40 +0200, Jonathan Ernst wrote:
Le samedi 24 juin 2006 à 20:06 +0200, Jacek Caban a écrit :
Hi,
[...]
- We need php script redirecting to SourceForge similar to one
Robert Shearman wrote:
Jacek,
I have a patch that fixes the crash by validating the conditions on
entry to CoGetClassObject (attached). However, this test still fails:
err:ole:CoGetClassObject apartment not initialised
url.c:768:http test...
url.c:424: Test failed: unexpexted code 34
fixme:w
Hi Piotr,
Piotr Caban wrote:
Hi,
Changelog:
- Added skeleton for IDL files generation
programs/oleview/main.h|8
programs/oleview/pane.c|9
programs/oleview/typelib.c | 96
+++-
3 files changed, 111 insertions(+), 2 deletion
Troy Rollo wrote:
On Tuesday 18 July 2006 03:16, Ge van Geldorp wrote:
the biggest problem is that the 64-bit calling conventions are
different between PE executables and Linux executables. Some more info on
the Wine64 wiki page http://wiki.winehq.org/Wine64
This isn't necessarily a hu
Vitaliy Margolen wrote:
Ever since replacement of Mozilla Active X control with new gecko.
And shift of attention to mshtml we have lots of programs that still
need shdocvw break.
Is this a temporary or intentional? Could author look at related bugs
on bugzilla?
I have looked at bugzilla. T
Dan Kegel wrote:
On 7/26/06, Jacek Caban <[EMAIL PROTECTED]> wrote:
I have looked at bugzilla. There is one regression (bug 5630) that needs
more widl improvements to work. I have done some work on widl that will
help it some time ago, but I've never had time to finish it.
Dan H
1 - 100 of 861 matches
Mail list logo
