Re: Initial creation of directory and config with ttydrv

2004-07-09 Thread Vincent Béron
Le ven 09/07/2004 à 00:19, Shachar Shemesh a écrit : [snip] > Actually, it's a little more complicated than that. I am creating the > initial config from an RPM, giving the winehq RPM as a dependancy. For > the time being, I solved this problem by having my RPM create a new user > (which it has

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Jonathan Wilson
This would be great but how do you do with COM objects. What did you do for your direct3d hooking. I remember someone on the ReactOS team gave me the hook related stuff. (I cant remember who) What I do is to modify the target to load the hook dll instead of the normal dll. The hook dll then load

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Mike Hearn
On Fri, 09 Jul 2004 17:08:05 -0400, Andrei Barbu wrote: > Even if it does it a different way, this > is a reliable way of testing to see if we can write to a pointer, so if > it's valid. Actually it's not - IsBadWritePtr isn't thread safe, as it only tells you whether the pointer was valid at the

Re: RFC: OpenSSL vs NSS

2004-07-09 Thread Steven Edwards
Hi Lionel, --- Lionel Ulmer <[EMAIL PROTECTED]> wrote: > Well, from the FAQ on OpenSSL, they say that on Linux systems it > should not > be a problem as OpenSSL is part of the 'base' system. No idea if RMS > would > agree to that one though :-) I know what his answer is. I to him before about a b

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Lionel Ulmer
> This would be great but how do you do with COM objects. What did you do > for your direct3d hooking. Well, this is a pet project I had for a long time (and maybe will do the day I will have a faster PC and QEMU runs any Windows version in a reasonnable speed :-) ). Basically, take the Wine Dir

Re: RFC: OpenSSL vs NSS

2004-07-09 Thread Lionel Ulmer
On Fri, Jul 09, 2004 at 09:58:04AM -0700, Steven Edwards wrote: > This stipulation seems to introduce a incompatibility with the GPL. For > normal Wine this is not a big deal but if someone wants to make a > Winelib application that is GPL or if I want to take Wines Wininet and > Adavapi32 code in

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Christian Costa
Jonathan Wilson wrote: This is the best things to do but the problem is not always obvious. If REing does not give significant result, I would suggest to check how the function behaves in windows and implement the same behaviour with maybe a big comment about ChessMaster 9000. I suggest that some

Re: Marshal bug

2004-07-09 Thread Duane Clark
Mike Hearn wrote: ... So you need to figure out why {402b4180-fa0c-40ee-ebf8-ee40f0ce5360} isn't being registered, which may involve figuring out what it actually is :) Okay, I'll see if I can make some sense out of that. Good luck! If a more complete marshalling explanation would be useful, let me

Re: MSI: implement MsiVerifyPackage, cosmetic fixes (with the patch)

2004-07-09 Thread Mike McCormack
Mike McCormack wrote: This is the last change required to sync up the CrossOver's current MSI implementation with WineHQs. Mike ChangeLog: * implement MsiVerifyPackage, cosmetic fixes diff -ur dlls/msi/action.c /home/mike/codeweavers/office/wine/dlls/msi/action.c --- dlls/msi/action.c 2004-07-

Re: Fix snprintfW Return Value

2004-07-09 Thread Alexandre Julliard
Uwe Bonnes <[EMAIL PROTECTED]> writes: > Doesn't it sound like it's wrong for ntdll _vsnwprintf() to rely on a > restricted implementation for snprintfW()? No, since we provide snprintfW ourselves we can decide how it should behave. We could of course have two different implementations but that d

Re: support code for HANDLE tables

2004-07-09 Thread Alexandre Julliard
Michael Jung <[EMAIL PROTECTED]> writes: > I'm currently playing around with the rsabase.dll implementation. Since this > is the first time I'm writing wine code, I've got some questions: Is there > support code for managing HANDLE tables? Or does every dll implementation > provide it's own fun

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Alexandre Julliard
Andrei Barbu <[EMAIL PROTECTED]> writes: > I don't personally know enough about IsBadWritePtr to write a test case. > Any suggestions? :P > I'll check out the code later on, but for now it seems to be fine. > > What else could it use to validate that pointer? The proper way is to use an exception

Re: Fix snprintfW Return Value

2004-07-09 Thread Uwe Bonnes
> "Alexandre" == Alexandre Julliard <[EMAIL PROTECTED]> writes: Alexandre> Rob Shearman <[EMAIL PROTECTED]> writes: >> At present, if the size of the buffer passed to snprintfW is too >> small then the function returns -1, as opposed to the required size >> of the buffer (as pe

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Andrei Barbu
I don't personally know enough about IsBadWritePtr to write a test case. Any suggestions? :P I'll check out the code later on, but for now it seems to be fine. What else could it use to validate that pointer? Andrei On Fri, 2004-07-09 at 15:02, Mike McCormack wrote: > Andrei Barbu wrote: > > >

Re: Fix snprintfW Return Value

2004-07-09 Thread Alexandre Julliard
Rob Shearman <[EMAIL PROTECTED]> writes: > At present, if the size of the buffer passed to snprintfW is too small > then the function returns -1, as opposed to the required size of the > buffer (as per C snprintf). This greatly limits its usefulness and can > give incorrect results for those using

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Mike Hearn
On Fri, 09 Jul 2004 16:14:31 -0400, Andrei Barbu wrote: > Point is.. it works, it's compliant letter for letter with the MSDN > docs, and it doesn't break anything. The easiest way to advance this is to write a simple test case which gets an instance of that object and then calls it with a bad poi

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Andrei Barbu
Don't be sorry, We're both trying to help the wine project. Wine itself never calls IDirect3DDevice8Impl_GetCreationParameters. I greped through the sources for that. So it can't be a straightforward call from inside wine that would be passing that bad pointer. And MSDN says: " Return Value

Re: RFC: OpenSSL vs NSS

2004-07-09 Thread Mike Hearn
On Fri, 09 Jul 2004 09:58:04 -0700, Steven Edwards wrote: > From the what I understand this lib provides everything we need so all > it really means is that our soft dependency on OpenSSL in now a soft > dependency on Mozilla. If we want to use the webbrowser module in Wine > then a Mozilla depende

Re: Marshal bug

2004-07-09 Thread Mike Hearn
On Fri, 09 Jul 2004 10:17:07 -0700, Duane Clark wrote: > If I had some idea of what is going on in the traces, I would attempt to > do some debugging. Do you know of any "Marshalling for dummies" or some > such thing? Currrently the traces are complete jibberish to me. > > Is this likely to be a r

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Mike McCormack
Andrei Barbu wrote: Point is.. it works, it's compliant letter for letter with the MSDN docs, and it doesn't break anything. Don't see why it would need more testing. It needs more testing because at least three other developers believe that you're not fixing a bug, you're masking another bug. Yo

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Andrei Barbu
Point is.. it works, it's compliant letter for letter with the MSDN docs, and it doesn't break anything. Don't see why it would need more testing. On Fri, 2004-07-09 at 13:41, Mike McCormack wrote: > Andrei Barbu wrote: > > > So I'm guessing this is right now. > > > > I don't have a windows com

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Mike McCormack
Andrei Barbu wrote: So I'm guessing this is right now. I don't have a windows computer to check this against, but it does comply with the docs. I have a feeling you'll need to be a bit more thorough than that to get your patch applied. Mike

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Andrei Barbu
MSDN says that if it's given an invalid pointer it should return D3DERR_INVALIDCALL, so that's what it does now. MSDN: http://msdn.microsoft.com/archive/default.asp?url=/archive/en-us/directx9_c/directx/graphics/reference/d3d/interfaces/idirect3ddevice9/GetCreationParameters.asp So I'm guessing t

Re: Marshal bug

2004-07-09 Thread Duane Clark
Duane Clark wrote: Mike Hearn wrote: What happens if you reinstall the app or reregister all the DLLs shipped with it (using regsvr32) ? Does that fix it ? Because of some reconfiguration on my end, I performed a new clean install in a fresh c: and fresh ~/.wine/config just a couple of days ago,

RFC: OpenSSL vs NSS

2004-07-09 Thread Steven Edwards
Hello, I believe we have a licensing issue with the crypto implementation in Wine and would like feedback relating to this. I know that some of the OpenSSL developers monitor this list so please provide feedback. The first question is in regards to the following: Clause 3 of OpenSSL license: *

Re: support code for HANDLE tables

2004-07-09 Thread Mike McCormack
Hi Michael, There are two client side handle table implementations in Wine that you might be interested in. One is in wininet.dll (dlls/wininet/internet.c) and the other is in msi.dll (dlls/msi/handle.c). They are pretty small, but the major flaw is that although the handle tables themselves ar

Re: Marshal bug

2004-07-09 Thread Duane Clark
Mike Hearn wrote: What happens if you reinstall the app or reregister all the DLLs shipped with it (using regsvr32) ? Does that fix it ? Because of some reconfiguration on my end, I performed a new clean install in a fresh c: and fresh ~/.wine/config just a couple of days ago, with a CVS from the

support code for HANDLE tables

2004-07-09 Thread Michael Jung
Hello, I'm currently playing around with the rsabase.dll implementation. Since this is the first time I'm writing wine code, I've got some questions: Is there support code for managing HANDLE tables? Or does every dll implementation provide it's own functions for doing this? Or do HANDLEs of ea

Fullscreening patch

2004-07-09 Thread Mike Hearn
Hi Alexandre, Yes, it's that time again. Can you take another look at this patch? Getting it in is the first step towards fixing a bunch of "i typed but it appeared on the console instead of the game!" bugs (as well as improving a bunch of apps like IE, TightVNC etc). thanks -mike Index: dlls/x1

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Andrei Barbu
And this is the correct patch. Sorry about that, ignore the above. The above actually allocated the memory, this just returns that the op. didn't succeed which is the correct thing to do. Chessmaster seems to be happy too. On Thu, 2004-07-08 at 15:38, Andrei Barbu wrote: > Changelog: > > Fixes a

Re: Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Lionel Ulmer
On Fri, Jul 09, 2004 at 11:06:54AM +0200, Christian Costa wrote: > I think he means ChessMaster 9000. So the patch has no chances at all to be included in Wine by Alexandre knowing his stance on pointer checks in API functions... > This is the best things to do but the problem is not always obvio

Re: Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Christian Costa
> Message du 09/07/04 10:46 > De : "Lionel Ulmer" > A : "Andrei Barbu" > Copie à : "Christian Costa" , "Marcus Meissner" , "Mike McCormack" , [EMAIL > PROTECTED] > Objet : Re: D3D8_GetCreationParameters fix > On Thu, Jul 08, 2004 at 08:45:16PM -0400, Andrei Barbu wrote: > > I agree on the docs

Re: Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Christian Costa
> Message du 09/07/04 00:57 > De : "Andrei Barbu" > A : "Christian Costa" > Copie à : "Marcus Meissner" , "Mike McCormack" , [EMAIL PROTECTED] > Objet : Re: D3D8_GetCreationParameters fix > Having given thought to the issue, you're right. > That was a bad solution, sorry. > > It should have fa

Re: D3D8_GetCreationParameters fix

2004-07-09 Thread Lionel Ulmer
On Thu, Jul 08, 2004 at 08:45:16PM -0400, Andrei Barbu wrote: > I agree on the docs, interestingly enough though, > Chessmaster 9000 gives an invalid pointer (0x1) > and there's a memory access error. > > Works on Windows though, so I'm assuming DX might be > allocating the memory on it's own. Wh