Maybe a silly question: With this change we have some piece of C++ code living
in directory data/. As i understand this folder would be regularly installed in
a whole (from an installer or when installing over a ppa). So they get
installed without usage?
--
https://code.launchpad.net/~widelands
Sorry, answered myself... the files are needed after compiling and when
starting widelands.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1397500/+merge/284574
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1397500 into lp
I can confirm what Tibor describes on linux. Here is some output with given
command:
$:> python2.7 regression_test.py -b ./widelands
Using './widelands' binary.
test/maps/plain.wmf/scripting/test_gamespeed.lua ...
Running Widelands ... FAIL
test/maps/plain.wmf/scripting/test_fires_do_not_burn
Investigating the error files it seems some files couldn't be found or are
incompatible:
Fatal exception:
[/home/kaputtnik/Quellcode/widelands-repo/trunk/src/logic/game.cc:225] could
not load "test/maps/lua_persistence.wmf"
terminate called after throwing an instance of
Sorry, replace "found" with "loaded" :-S
--
https://code.launchpad.net/~widelands-dev/widelands/tags_again/+merge/284636
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/tags_again.
___
Mailing list: https://launchpad.
ome directory: /tmp/widelands_regression_testxYqcI9
There's no configuration file, using default values.
Realpath: /home/kaputtnik/Quellcode/widelands-repo/trunk/data
Adding directory: /home/kaputtnik/Quellcode/widelands-repo/trunk/data
Output with the print statement:
python2.7 reg
Review: Approve
Looks good :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1541697/+merge/285054
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1541697.
___
Mailing list: https://launchpad.net/~wi
No /./ anymore, nice :-)
Tested normal start of widelands and widelands with option --datadir. Both
looks good.
We should test if bug 1541697 (regression_test.py does not work in some setups)
is also solved with this changes. I can only test this after this weekend
because my current machine d
Review: Approve testing
Fantastic :-) Really great job :-)
https://bugs.launchpad.net/widelands/+bug/1531114/+attachment/4564387/+files/shot0002.png
--
https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517
Your team Widelands Developers is subscribed to bran
kaputtnik has proposed merging lp:~widelands-dev/widelands/add_hint_to_map_info
into lp:widelands.
Commit message:
Add "hint" to the json file created by wl_map_info.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~wid
Review: Approve testing
Works also for me.
--
https://code.launchpad.net/~widelands-dev/widelands/building-statistics-window-labels/+merge/285292
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/building-statistics-window-labels.
___
356ms
widelands:
/home/kaputtnik/Quellcode/widelands-repo/bug-1525706-artifacts/src/logic/map.h:510:
static Widelands::MapIndex Widelands::Map::get_index(const Widelands::Coords&,
int16_t): Asser
> Good idea of adding the map name to the output though; I will look into it.
If possible please also add the current widelands version to the output. I am
always searching for it and have to start widelands (or investigate the VERSION
file) to get it.
--
https://code.launchpad.net/~widelands-d
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/add_hints
into lp:widelands-website.
Commit message:
Add hints-field to the description of the maps.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1542449 in Widelands Website: "Display map-
The proposal to merge lp:~widelands-dev/widelands-website/add_hints into
lp:widelands-website has been updated.
Description changed to:
* Add hints filed to show on the website.
* Uploader description could be edited.
* Added exception for KeyError
* Did some style changes.
I ran pyformat over
Another crash in menu load map when trying to select a map. First crash was
when pointing on map "Ice wars", second time when trying select map "Sun of
Fire":
backtrace from first crash attached to bug report.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1525706-artifacts/+merge
Oh i see now that this crash happens also in trunk r7816.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1525706-artifacts/+merge/285566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1525706-artifacts.
_
I have lost overview :-S "Lost in bugs" :-D Sorry
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1525706-artifacts/+merge/285566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1525706-artifacts.
___
M
Review: Approve testing
I had several map load-save-load-save-... sessions with this branch, and no
crash anymore. So the main bug seems also to be fixed :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543944-suggested-teams/+merge/285654
Your team Widelands Developers is subscri
Works :-)
One thing is curious: In "Terrains tab" either the up/down arrow keys are
working nor the mouse wheel in the left list. In "Trees tab" both are working
for the left list.
--
https://code.launchpad.net/~widelands-dev/widelands/editor_help/+merge/283900
Your team Widelands Developers is
Review: Approve testing
I tried French ad Cyrillic (i believe :-D ). I found long strings mostly in the
editor main menu and all looks fine for me.
--
https://code.launchpad.net/~widelands-dev/widelands/fit_button_text/+merge/285528
Your team Widelands Developers is subscribed to branch
lp:~wid
Is there really a need for a paragraph in map description? The place to show
the description is not really big, adding a possibility for a paragraph
consumes just more space. Is a normal line break also needed? I knew
king_of_nowhere has asked for this, but i think the description is meant to
h
Is there something specific to look at? I tested a short 2Player game against
AI and found nothing strange. Does this affect calculation of statistics f.e.
the productivity shown on each building? Is a game with 8 players better to
test this changes?
--
https://code.launchpad.net/~widelands-dev
Review: Resubmit
Thanks for proofreading :-)
Some indentation is fixed and the exception for the KeyError was useless. The
idea was to have a hint if something in wl_map_info and the resulting json file
was changed. But if this is the case, the call to wl_map_info fails before the
KeyError exc
> - Listselect now uses the new font renderer, and text is aligned according to
> rtl/ltr per entry.
Text aligning per entry is used only in Options Language? It looks very
uncommon. I don't know how this is made in other game UIs. Wikipedia aligns
regarding to the selected language. You could
Review: Approve testing
> I am checking if there is an RTL character in the entry or not.
Ah, ok.
--
https://code.launchpad.net/~widelands-dev/widelands/listselect/+merge/286033
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/listselect.
_
Review: Approve testing
Merged with trunk an looks good.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1525706-artifacts/+merge/285566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1525706-artifacts.
_
Thanks for your offer SirVer :-) I am bit scary to act on the server... and i
am bit slow because of that (checking each command three times ;) ). But i
applied the changes now on the alpha site. Please test it:
http://alpha.widelands.org/maps/
Upload a map which contain text in the hint field,
Thanks :-)
Done.
--
https://code.launchpad.net/~widelands-dev/widelands-website/add_hints/+merge/285664
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to : wi
Funny behavior now: In authors field write "\text" the backslash could be seen.
Make a space -> the backslash disappear. Write "\\" and a space, the last
backslash disappear. Hit Backspace the last Backslash appears again.
In the Description it is similar and sometimes when positioning the curso
Review: Approve testing
Works well :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1546153-suggested-teams/+merge/286345
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1546153-suggested-teams.
___
What is the state of affairs? Just asking :-)
--
https://code.launchpad.net/~widelands-dev/widelands/beautiful_correct_lines/+merge/284517
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/beautiful_correct_lines.
___
M
Review: Approve testing
Works :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1525706-artifacts/+merge/285566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1525706-artifacts.
___
Mailing list: ht
Review: Approve testing
Works perfect again :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1546810-undo-redo/+merge/286733
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1546810-undo-redo.
___
Ma
The one slash thing is solved :-)
As you mentioned this is better than a crash. But i would still wait with
merging this until the backspace bug is fixed. Just do it like you want.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1546095-backslash-edit/+merge/286189
Your team Widelands
The website is now running under Django 1.3.7 You can see this in
pip_requirements.txt
The Django devs have removed all documentation prior to Django version 1.7 from
her website. And i believe that Django 1.3.7 isn't available at all anymore. At
least from Pypi...
See also: https://www.django
Review: Approve testing
Works :-)
--
https://code.launchpad.net/~widelands-dev/widelands/statistics_gui/+merge/286787
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/statistics_gui.
___
Mailing list: https://launchpa
I just took a look what version of django registration is installed here:
django-registration 0.8
So you may test
https://github.com/ubernostrum/django-registration/releases/tag/0.8 in
pip_requirements.txt
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix-installation/+merge/2
Review: Approve
Cool :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix-installation/+merge/286797
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
P
> libmysqlclient-dev is needed for MySQL-python
Maybe we could make this optional? F.e.:
# If you want to use mysql as database you should install these packages (but
it's not needed to running the website for testing):
sudo apt-get install libmysqlclient-dev
--
https://code.launchpad.net/~
Is the MySql-python package needed at all when using sqlite? I didn't think so,
but haven't test it. If not we should remove the entry in pip_requirements
instead of installing unneeded packages :-)
I am currently trying to install and run with backend-mysql, so i need either
MySql-python or my
I removed MySql-Python from my normal website installation with pip and it
seems to work properly.
I have trouble with my windows7 after an hardware upgrade, and i need to fix
that soonish. So i am not online for a while... ( dammned windows :-/ )
--
https://code.launchpad.net/~widelands-dev/w
Windows runs again...
I fixed "ibmysql..." to "libmysql..." and clarified some statements.
I will merge this if the spelling is correct :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix-installation/+merge/286797
Your team Widelands Developers is subscribed to branch lp:wid
I didn't changed that. This in in there until 22.2.2016 ... ;)
I just installed with this README and pip_requirements.txt and all works fine.
When using a later version of django may all this has to be updated again.
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix-installation
Hm, maybe i have done a mistake through pulling and merging because your
revisions aren't shown anymore?
The change you mentioned was made in revision 4.1.3 See
http://bazaar.launchpad.net/~widelands-dev/widelands-website/fix-installation/revision/404.1.3
And i think you made this change becau
Thanks for testing again.
As i know information provided by Django-tracking is currently only used by the
Online_users box.
I am currently trying to get an installation with Django 1.8 to work (only
installation, with sqlite3, no bugfixes). Regarding to django-tracking see f.e.
my notes in
ht
Review: Approve testing
Really good :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1540782-multilineeditbox/+merge/287590
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1540782-multilineeditbox.
_
Review: Approve testing
Works :-)
Maybe we could adjust media/css/help.css to fit the table style with the one
from the wiki? Currently the table headers have a really small font size and
does not not show the wooden background. You could load the wiki.css before
help.css and adjust only distu
Review: Approve testing
Works :-)
--
https://code.launchpad.net/~widelands-dev/widelands/map_object_info/+merge/287409
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/map_object_info.
___
Mailing list: https://launch
> I managed to run Widelands from an installation now, but we will need to add
> an argument to the executable now to choose the path for the JSON files,
> because we won't want to run this with sudo.
Could you please explain a bit more?
Because widelands is installed on the server, it should w
Ah, now i understand... the update process is a bit uncomfortable anyway:
1. call '[sudo] wl_map_object_info' to generate updated json files
2. call ./manage.py update_help to update the database
The json files are only needed by the website, so why not call
wl_map_object_info from update_help.p
> I am already doing that.
Oh i overlooked that, sorry.
--
https://code.launchpad.net/~widelands-dev/widelands-website/encyclopedia/+merge/287410
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://l
Review: Approve testing
Good idea to split this up :-)
Not related to this change, but it would be good to have the keyboard shortcuts
available on a (help) button on the main screen. Or rename the button "About
Widelands" to "About/Help" and provide an additional tab for the Help?
Something t
Took some time to find the new entries :-D
Editor: Here it is in the Menu called "Main Menu"
In Game: Here the Menu is called "Options Menu"
Maybe we should call them the same? Then the sentence "You could find general
help about gameplay or the editor in the Main Menu" makes more sense.
It's a
The proposal to merge lp:~widelands-dev/widelands-website/fix-installation into
lp:widelands-website has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/fix-installation/+merge/286797
--
Your team Widelands De
Review: Disapprove
I have tested this again and got an error because of pagination:
> AssertionError: pagination .dist-info directory not found
Because so many things has changed i reject this merge proposal. Feel free to
reopen this again.
--
https://code.launchpad.net/~widelands-dev/widelan
Review: Approve testing
I think all is fine now :-)
--
https://code.launchpad.net/~widelands-dev/widelands/about/+merge/288697
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/about.
___
Mailing list: https://launchp
Review: Approve testing
Works fine :-)
--
https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/improve-restool.
___
Mailing list: https:/
The proposal to merge lp:~widelands-dev/widelands/new_workarea_pics into
lp:widelands has been updated.
Commit Message changed to:
Better coloring for workarea pics.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/new_workarea_pics/+merge/289578
--
Your team Wideland
kaputtnik has proposed merging lp:~widelands-dev/widelands/new_workarea_pics
into lp:widelands.
Commit message:
Better coloring for workarea pics.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #536473 in widelands: "Improve working area preview&quo
It is really annoying that in the situation of the screenshot no portspace is
shown:
https://bugs.launchpad.net/widelands/+bug/1559729/+attachment/4607287/+files/shot.png
I have to build another blockhouse to expand the territory. But this blockhouse
prevent building a port because there is
Review: Needs Fixing
Hm, i have to go over some maps again, because Map options -> Author is meant
to be smart and replaces "," with "&". So something like "Nasenbaer, edited by
king_of_nowhere" gets "Nasenbaer & edited by king_of_nowhere" :-(
I have to recheck the scenario maps also.
--
https
Review: Resubmit
Should all be fine now. I would ask someone else to test the scenario maps
because i am not familiar with those.
--
https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/
t gdb) could be found here:
http://home.arcor.de/frank.ue/editor_crash.txt
Ohh, now the program segfaults directly after startup:
END GRAPHICS REPORT
[New Thread 0x7fffddfbe700 (LWP 31112)]
[New Thread 0x7fffdd7bd700 (LWP 31113)]
widelands:
/home/kaputtnik/Quellcode/widelands-repo/lua-
Hm... i compiled this branch on another mashine and couldn't trigger such
segfaults anymore. Maybe there was a malfunction on my other maschine used
yesterday? Next Monday evening i could test on the faulty computer again and
will approve when i found no such segfaults anymore :-)
--
https://co
I got different segfaults... so i think it's not related not this branch. On
the other side i had no trouble with other programs, so i think it's not my
computer which causes such segfaults. Annoying was that the segfaults are
irreproducable, sometimes there was no segfault. Because there is no
Sorry, i got a crash now on my Laptop after some restarts of widelands:
*** Error in `./widelands': double free or corruption (!prev):
0x06a0dd90 ***
I do always start widelands, open editor, click help. No crash -> leave
widelands and start again.
There is definitely something wrong h
This is really strange i restarted widelands about 25 times without any
crash until my last post. So the first crashes i encountered was kind of "luck"
:-D Is there a possibility to have a bashscript to make automatic tests?
--
https://code.launchpad.net/~widelands-dev/widelands/lua-driven-h
> The Nile has lost its suggested teams - is that on purpose?
We should ask einstein if the old suggested teams are still valid for the new
map.
Thanks for proofreading and the fixes :-) Shouldn't the localization macro not
be set automatically when saving a map?
--
https://code.launchpad.n
I just saw that einstein wrotes the suggested teams in the "Uploader comment"
of the website. I add the information to the shipped maps.
--
https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wide
The NIle v2 i now completed. I've compared also all elemental files against the
ones from trunk and found no relevant changes. The only thing is that the
world= things are removed. This should be no problem for build19 :-)
Regarding the localization tags: It's your decision. This long weekend i
Thanks Miroslav :-)
--
https://code.launchpad.net/~widelands-dev/widelands/infotool_stuck_painting/+merge/290076
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/infotool_stuck_painting.
___
Mailing list: https://launc
Yes, this branch could brake loading a map in editor or starting a game, not
during gameplay (maybe except scenarios).
If you got a crash, it would be always helpful to have the last console output.
--
https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704
Your team Widel
As i understand the "double free or corruption (!prev)" failure happens because
of trying to free memory which is already been freed former.
And i have the feeling that the crash is mostly triggered when much memory
(RAM) is consumed/newly assigned through some other programs. So i tried to
con
I don't think that bug 1562332 is related to this branch.
Lets wait with merging until eastern is past, maybe we get some comments in the
forum over this weekend.
--
https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704
Your team Widelands Developers is subscribed to bra
Works :-) The only thing is F1 hotkey, which triggers the tribal encyclopedia
during gameplay and Trees/terrains in editor and not a general help. But i
think this would be fixed with the lua_driven_help branch.
Some other things:
Editor:
"H" Shortcut: Closes README window if open
Opening the RE
Sorry, meant the Help window instead of README window
--
https://code.launchpad.net/~widelands-dev/widelands/about/+merge/288697
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/about.
___
Mailing list: https://launchp
Klaus, i don't know what your intend to doing... If a shipped map is loaded in
Game or Editor, the changes of this branch does not take any effect anymore.
The only exception are maybe the scenarios (but i don't understand them at all
:-( ).
--
https://code.launchpad.net/~widelands-dev/wideland
Review: Approve testing
I think it's good now :-)
--
https://code.launchpad.net/~widelands-dev/widelands/about/+merge/288697
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/about.
___
Mailing list: https://launchpad.
What about bug 1543001 (update eris)?
Is it sure that this bug isn't already in trunk somewhere?
--
https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/lua-driven-help.
_
I don't know why but most files are encoded in ASCII Text and one file contains
obviously a bad character.
I will try to find it.
Is it normal to have a mix of ASCII and UTF8 encoded files? File edited by me
are UTF8, this is normal for a linux BS, but all files created by widelands are
encode
I think i have found it already: The elemental file of "Islands_at_War"
contains at column 27 an apostrophe (') and the file is encoded in UTF8.
Loading this map into the editor and open the map options the apostrophe is
converted to ’ (on linux with ALTGR+SHIFT+n) instead of the one on the key
But there are a mix of encodings. Go to your folder where current trunk
/data/maps is stored and run:
find -name "elemental" -exec file {} \;
The output is something like:
./The_Far_North.wmf/elemental: UTF-8 Unicode text, with very long lines
./MP_Scenarios/Smugglers.wmf
Running a python2 console and trying manually decode the first chars of the
string of "descr=" in Islands_of_war/elemental:
>>> 'descr=_"For centuries, you’ve lived peacefully side by
>>> side"'.decode('ascii')
Traceback (most recent call last):
File "", line 1, in
UnicodeDecodeError: 'ascii'
I believe it's the apostroph ' vs. ’ (ALTGR+SHIFT+n)
Part from the original String from elemental file. This contains the
ALTGR+SHIFT+n - apostroph:
>>> "For centuries, you’ve lived peacefully side by side".decode('ascii')
Traceback (most recent call last):
File "", line 1, in
UnicodeDecodeErr
Thanks :-)
But i think we should keep this in mind if there is some trouble with String
related things and i believe it's nevertheless a bad thing. F.e. i got some
errors/warnings when installing in archlinux from the Archlinux user
Respository (AUR). These errors/warnings are shown when a pack
Related to your diff comment:
> Why not remove this heading from developers.json?
If i remember right i asked for this, because of parsing the developers.json on
the website: https://wl.widelands.org/developers/
--
https://code.launchpad.net/~widelands-dev/widelands/about/+merge/288697
Your tea
Just found when compiliing trunk:
In file included from
/home/kaputtnik/widelands-repo/trunk/src/logic/map_objects/bob.h:23:0,
from
/home/kaputtnik/widelands-repo/trunk/src/logic/map_objects/bob.cc:20:
/home/kaputtnik/widelands-repo/trunk/src/logic/map_objects/bob.cc: In
"C: Shows Census" in Editor help, F1 does not work during
game play (in editor it works). Is this intended? Otherwise i want to rebuild
the whole branch and test again.
Compilation hints:
/home/kaputtnik/widelands-repo/lua-driven-help/src/editor/ui_menus/editor_help.cc:34:
Line is too long!
Sorry ...
--
https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands.
___
Ma
Review: Approve testing
I couldn't trigger the error anymore by open several programs/images and
afterwards start this branch. So i think Miroslav has found and fixed the error
:-)
All looks good now and this would be a really great enhancement to widelands.
There is only one small thing:
The
Review: Needs Fixing
I couldn't trigger the crash anymore, but loading a smaller map after a big map
the position in upper left corner isn't 0,0, it depends on the position of
previous loaded map.
Resolution 800x600 (window mode)
Load "Wideworld", mapsize 384,256 scroll the map until position 2
Review: Approve testing
Works now :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1512151-load-small-map/+merge/290802
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1512151-load-small-map.
___
Ma
Review: Approve testing
I think this is much better :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1526911-cursor-positioning/+merge/290954
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1526911-cursor-positioning.
Review: Approve testing
Great :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395322-tool3.
___
Mailing list: https://la
I don't know the reason why Ctrl is used to remove objects at all. In my
opinion there should be only one key for removing objects and use this key for
all objects. So for all objects:
Click: Place Objects or Increase (meaning 'add something')
Shift + Click: Remove Objects or Decrease (meaning '
Ok, then it would be fine if the CTRL + Click for Portdocks get changed in this
branch :-)
And removing the shift key from:
"Shift or Ctrl + Click : Set height to the value selected by ‘Set Value’"
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team
Removing the additional headers for "Height and Resources tool" and "Noise
height tool" in the help doesn't fit my taste. A general help should be driven
by "Information as clear as it could be", not "Information as short it could
be". But if you think it's good, lets leave it. The Tooltips make
kaputtnik has proposed merging
lp:~widelands-dev/widelands/bug_1566720_set_origin into lp:widelands.
Commit message:
Fix miscalculation of map->get_width() and map->get_height() regarding
coordinates.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1566
Review: Approve testing
I think it's good to go now :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1395322-tool3.
___
Ma
201 - 300 of 1276 matches
Mail list logo
