Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-09-03 Thread GunChleoc
I have pushed a commit that shuts up clang compiler warnings, so you need to pull before continuing to work. I think that Checkstep should ignore waterways that don't have ferries - I have attached a savegame to illustrate the issue. https://bugs.launchpad.net/widelands/+bug/1584203/comments/47

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-09-03 Thread GunChleoc
And another thing that can be improved in checkstep, but will probably be non-trivial: https://bugs.launchpad.net/widelands/+bug/1584203/comments/48 I'd be OK with doing this in a follow-up branch. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands De

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-09-03 Thread GunChleoc
When I have 2 economies only liked by a waterway, the metal workshop won't produce the necessary wares - I expect the request is generated by the wrong warehouse. Savegame: https://bugs.launchpad.net/widelands/+bug/1584203/comments/50 -- https://code.launchpad.net/~widelands-dev/widelands/ferry

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-03 Thread Benedikt Straub
Fixed the fieldaction bug and split off FindNodeTerraform. New terraform syntax: "findspace=size:any radius:6 terraform", "walk=coords", "terraform", "return" There´s no real reason why we need a World or EGBase in Tool parameters, is there? I removed it, as it can be fetched directly from th

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-09-03 Thread bunnybot
Continuous integration builds have changed state: Travis build 5382. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/580127580. Appveyor build 5152. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-5152

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/emp_4_fixes into lp:widelands

2019-09-03 Thread hessenfarmer
hessenfarmer has proposed merging lp:~widelands-dev/widelands/emp_4_fixes into lp:widelands. Commit message: fixes issues described in https://www.widelands.org/forum/topic/4617/?page=1#post-29597 Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/new-shipping into lp:widelands

2019-09-03 Thread Benedikt Straub
The detour-baselength assert will definitely not give any further trouble now – I removed it ;) Making a detour really can shorten the ship´s path by a few fields in some cases… :P The ship.get_nritems() assert is also fixed now, though the savegame might remain broken. -- https://code.launchp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/amazons-coding-changes into lp:widelands

2019-09-03 Thread bunnybot
Continuous integration builds have changed state: Travis build 5383. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/580196177. Appveyor build 5153. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_amazons_cod

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/emp_4_fixes into lp:widelands

2019-09-03 Thread bunnybot
Continuous integration builds have changed state: Travis build 5384. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/580250613. Appveyor build 5154. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_emp_4_fixe