Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-25 Thread Klaus Halfmann
Compiling again, got: src/wui/constructionsitewindow.cc:33:19: warning: unused variable 'pic_max_fill_indicator' static const char pic_max_fill_indicator[] = "images/wui/buildings/max_fill_indicator.png"; ^ src/wui/constructionsitewindow.cc:34:19: warning: unused variable 'pi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-25 Thread Klaus Halfmann
Review: Needs Fixing testplay No I got a crash :( kaputtnik is right, we must play some network games on trunk, RSN. FATAL ERROR - game crashed. Attempting emergency save. ... InternetGaming: logout(SERVER_CRASHED) [NetClient] Closing network socket connected to 2a03:4000:32:524:48cb:feff:feae:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-25 Thread GunChleoc
Can you please create a bug report when finding errors caused by trunk, rather than putting them in a code review? You now have marked this branch as "needs fixing"; but it's trunk that needs fixing ;) I have created a new bug report for this: https://bugs.launchpad.net/widelands/+bug/1834151

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-25 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands has been updated. Commit message changed to: Dropdown fixes and improvements - Fix positioning of dropdown lists on fullscreen switches - Define dropdown list height by number of items - Add dropdowns to Lua interf

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/get-rid-of-transport-draw into lp:widelands

2019-06-25 Thread bunnybot
Continuous integration builds have changed state: Travis build 5241. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/549898990. Appveyor build 5020. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_get_rid_of

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-25 Thread GunChleoc
Tracked down the line for the crash, it is caused by the new WIP constructionsite options. So, definitely not related to this branch. -- https://code.launchpad.net/~widelands-dev/widelands/fix-dropdowns/+merge/368223 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widela

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-25 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix-dropdowns/+merge/368223 -- Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/quiz_captcha into lp:widelands-website

2019-06-25 Thread GunChleoc
My current test run: How many tribes - I gave wrong answer on purpose -> I get the form again Name of the game - I answer this correctly -> I get the form again Name of the game - I answer this correctly -> I get the form again Name of the game - I answer this correctly, with uppercase W -> The fo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands

2019-06-25 Thread GunChleoc
Found 2 bugs: - After using the toolbar menus, map navigation with arrow keys is broken - Opening the ship statistics -> heap-use-after-free -- https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-menus/+merge/368230 Your team Widelands Developers is requested to review the propos

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-25 Thread Benedikt Straub
Should be fixed now. I´m unable to compile and test at the moment though. -- https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/369210 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/constructionsite_options. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-25 Thread GunChleoc
Yes, that fixed it :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/369210 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/constructionsite_options. ___ Mailin

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/unify-program-parsers into lp:widelands

2019-06-25 Thread bunnybot
Continuous integration builds have changed state: Travis build 5242. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/549900235. Appveyor build 5021. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_unify_pro

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_playercommand_enums into lp:widelands

2019-06-25 Thread bunnybot
Continuous integration builds have changed state: Travis build 5244. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/549982685. Appveyor build 5023. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cleanup_pl

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands

2019-06-25 Thread Klaus Halfmann
Looks ike playing te tutorial is the best test? What are the names of Tutorial 1 & 4 ? -- https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-menus/+merge/368230 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/toolbar-drop

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands

2019-06-25 Thread GunChleoc
Basic Control and Economy. -- https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-menus/+merge/368230 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands

2019-06-25 Thread Klaus Halfmann
Review: Needs Fixing play 1st tutorial Not nice, you open the tool popup toheeter with the tool-size window. The zoom Icons look a bit rough? Via the Editor-Main-Menu one can open all windows at the same time, this cries for all kinds of Errors. Tutorial did not wait until I actually used te "Sh

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/quiz_captcha into lp:widelands-website

2019-06-25 Thread kaputtnik
Yes, my approach does not work on the server. Not really sure why, but i guess its because the website runs with 4 gunicorn workers, whereas at home there is only one process involved. Thanks for testing again :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/quiz_captcha/+merg

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-25 Thread bunnybot
Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 5246. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/550167492. -- https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/369210 Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands

2019-06-25 Thread bunnybot
Continuous integration builds have changed state: Travis build 5247. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/550168297. Appveyor build 5026. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_toolbar_dr

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/toolbar-dropdown-menus into lp:widelands

2019-06-25 Thread GunChleoc
Thanks for testing! > Not nice, you open the tool popup toheeter with the tool-size window. I do not understand what you mean here - please explain more. > The zoom Icons look a bit rough? The images are just placeholders, a graphic artist will need to make proper ones. > Via the Editor-Main