Review: Approve
LGTM now :)
I'd like to retest this due to the code changes made during review.
Diff comments:
>
> === modified file 'src/logic/map_objects/tribes/militarysite.cc'
> --- src/logic/map_objects/tribes/militarysite.cc 2019-05-26 17:21:15
> +
> +++ src/logic/map_objects/t
Review: Needs Fixing
This doesn't work, because the test suite runner intercepts it.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1825486-inputqueue-test/+merge/368430
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1825486-inputqueue-test.
_
The proposal to merge lp:~widelands-dev/widelands/bug-1825486-inputqueue-test
into lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1825486-inputqueue-test/+merge/368430
--
Your team Widela
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1825486-inputqueue-test-wait-longer into
lp:widelands.
Commit message:
Wait longer after save in input queue test
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1825486 in widelands: "input_queues tes
GunChleoc has proposed merging lp:~widelands-dev/widelands/elk_moose into
lp:widelands.
Commit message:
Rename "elk" to "moose" and add map compatibility code
- Add support for critter renamings depending on packet version to
WorldLegacyLookupTable
- New map version property "needs_widelands_ve
Tested and still working - thanks for this great feature!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/367428
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/constructionsite_options.
__
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 5203. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/547642295.
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/367428
Your
inputqueues again
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/367428
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/constructionsite_options.
___
Mail
Some questions inline Code otherwise LGTM.
Will commpile this and the read that code again.
Diff comments:
>
> === modified file 'src/logic/map.cc'
> --- src/logic/map.cc 2019-05-16 09:15:03 +
> +++ src/logic/map.cc 2019-06-22 11:22:28 +
> @@ -714,6 +714,22 @@
> pathfieldmgr_->se
Continuous integration builds have changed state:
Travis build 5215. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/549057129.
Appveyor build 4994. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182548
Error merging this proposal:
Output:
stdout:
stderr:
Unable to obtain lock held by sir...@bazaar.launchpad.net on taotie (process
#21580), acquired 19 hours, 2 minutes ago.
See "bzr help break-lock" for more.
bzr: ERROR: Could not acquire lock "(remote lock)":
bzr+ssh://bazaar.launchpad.net/~w
I expect some followup change on the website then.
Widelands will always read older Maps.
Did another review with a look into the complete code.
(We need some Widelands historian for all this legacy :-)
A bit more documentation would help.
Diff comments:
>
> === modified file 'src/map_io/widel
I openend some buitin and a new Map,
how can I see this new value in a map?
I am missing some info about wl_map_info / wl_map_object_info
--
https://code.launchpad.net/~widelands-dev/widelands/elk_moose/+merge/369201
Your team Widelands Developers is requested to review the proposed merge of
lp:
Review: Approve review, compile, short test
OTOH the code is OK for me, anything more I can / must do?
--
https://code.launchpad.net/~widelands-dev/widelands/elk_moose/+merge/369201
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/elk_moose.
___
I have added comments.
If you run ./wl_map_info without parameters, it will give you command line
help. It results in a JSON file for the website.
Diff comments:
>
> === modified file 'src/logic/map.cc'
> --- src/logic/map.cc 2019-05-16 09:15:03 +
> +++ src/logic/map.cc 2019-06-22 11:22:
Review: Approve testing
Ahh, the json file is created in thee same dir as the wmf file, e.g.
{
"name": "CrossriverA",
"author": "Hasi50",
"description": "A nice River flows through this land and water can be found
there. Metal in the hills nearby, but you are not alone",
"hint": "",
Thanks for the review & testing!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/elk_moose/+merge/369201
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/elk_moose.
___
Mailing list: https://lau
Continuous integration builds have changed state:
Travis build 5218. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/549145830.
Appveyor build 4997. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_elk_moose
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 5218. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/549145830.
--
https://code.launchpad.net/~widelands-dev/widelands/elk_moose/+merge/369201
Your team Widelands
Continuous integration builds have changed state:
Travis build 5219. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/549145910.
Appveyor build 4998. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18254
20 matches
Mail list logo
