Having a message in the chat window isn't enough. I did not see it, and the
same will happen to others. So, I still think that we should show the games as
unconnectable rather than hiding them.
Other things we could to is make the text in the editbox red and adding a
tooltip to the editbox.
--
Review: Approve
LGTM :)
This branch can go in once codecheck has been fixed. If you don't want to
trigger a compile for this, you can use
cmake/codecheck/CodeCheck.py src/* | grep -v "src/third_party"
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/3
Done. :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
___
Mailing list: https://launch
Continuous integration builds have changed state:
Travis build 4856. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/527411124.
Appveyor build 4637. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_build20-46
I agree. We should change the colour in the editbox and have a tooltip. But
currently I have no idea how to change the text's colour. Can you give me a
hint, please?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1825932-open-games/+merge/366860
Your team Widelands Developers is requ
Review: Resubmit
OK, now InteractiveBase receives a notification instead when a portspace is
found. Since there are fairly many reasons why a port space can become
unavailable again (ship sails on, port is constructed, ship is sunk…), the
IBase takes care of cleaning up the set itself now when
Review: Disapprove short review
I go along with Benedikt. An average player will have a _lot_ of trouble to get
the economy
going and will have no clue what the problems are. We would have to rethink all
the Tutorials and Scenarios. Some novice players may be trapped in on of the
tribes special
Continuous integration builds have changed state:
Travis build 4861. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/527614965.
Appveyor build 4642. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_tribe_eco
Review: Approve
Code LGTM. Tested briefly, no issues seen.
--
https://code.launchpad.net/~widelands-dev/widelands/representative_image_in_font_renderer/+merge/363781
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/representative_image_in_font_renderer.
___
* Used parent instead of This.
* moved all Variables into Impl
About that -2 magic: I got lost in finding the sematics of user/player etc.
I added a TODO comment with our best guess by now.
I am at the End of my vacation (sigh) so lets get this in before it
starts lingering around for too long.
-
Found a first bug, still need some debugging
--
https://code.launchpad.net/~widelands-dev/widelands/refactor_gameclient/+merge/366743
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/refactor_gameclient into lp:widelands.
___
Still get a heap-use-after-free related to
std::unique_ptr loader_ui(new UI::ProgressWindow());
But this is maybe just a problem as the game crashed with
disconnect(CLIENT_CRASHED, )
A have a deja vue around GameClientImpl.modal which is released twice.
--
https://code.launchpad.net/~widel
You could also do the game tips like this:
const std::string tribename = get_players_tribe();
assert(Widelands::tribe_exists(tribename));
std::unique_ptr tips(new GameTips(*loader, {"general_game",
"multiplayer", tribename}));
As to the ASan crash, I suspect that there is a problem
Tooltip is implemented. But the changing text colour... that's beyond my
understanding. Thought I could implement this with boost::format but that
doesn't work.
We have set_color() available for tables and textfields, but I have no idea how
to implement this for editboxes.
--
https://code.laun
I am still wondering if we can get more performance out of this thing.
* Ship sails on and ship is sunk could be taken care of by the ShipNote
* Port being built can be taken care of by buildcaps, just like we do for the
building spaces overlays in general
Any other reasons?
+1 for the saving s
I actually don't know whether changing text color is supported at this time. I
don't want to touch the editbox code right now, because I have a big
refactoring in the works.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1825932-open-games/+merge/366860
Your team Widelands Developers
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
___
Mailing list: https:/
Sadly it doesn't.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1825932-open-games/+merge/366860
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1825932-open-games into lp:widelands.
> Port being built can be taken care of by buildcaps
IMHO we should remove the portspaces either only in response to Notes or only
autonomously. Mixing both feels messy.
To use notes, we´d need subscriptions (in addition to what we already have) to
– NoteExpeditionCanceled
– FieldPossession (anot
I guess what we could have here is to allow players to define their own default
options, because micromanaging this to the same values for each game start is
probably a bit annoying.
--
https://code.launchpad.net/~widelands-dev/widelands/tribe-economy-settings/+merge/366878
Your team Widelands D
I have created a merge request for the other branch:
https://code.launchpad.net/~widelands-dev/widelands/font_size-lua/+merge/366938
Once that is in, I can take care of the color.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1825932-open-games/+merge/366860
Your team Widelands Deve
I agree with Benedikt and Klaus as well as I think some of the defaults could
be reduced (e.g. basic weapon from 30 to 10). I believe setting the values to
the default starting values would be the lowest limit to reduce to as it would
trigger production immediately if something is used.
However
Continuous integration builds have changed state:
Travis build 4865. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/527627946.
Appveyor build 4646. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-4646.
The proposal to merge lp:~widelands-dev/widelands/font_size-lua into
lp:widelands has been updated.
Commit message changed to:
Except for scenario and win condition messages, define all font styles via Lua.
Reduce the number of construtors in TextArea.
For more details, see:
https://code.launc
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 4866. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/527644741.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Continuous integration builds have changed state:
Travis build 4866. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/527644741.
Appveyor build 4647. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18271
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/expedition_portspace_indicator/+merge/366640
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/expedition_portspace_indicator.
___
Mailing list: h
You have convinced me.
I have done more testing - all working now :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/expedition_portspace_indicator/+merge/366640
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/expedition_portspace_indica
Continuous integration builds have changed state:
Travis build 4871. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/527824464.
Appveyor build 4652. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_refactor_g
The proposal to merge
lp:~widelands-dev/widelands/expedition_portspace_indicator into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/expedition_portspace_indicator/+merge/366640
--
Your team Widelands
Bug filed: https://bugs.launchpad.net/widelands/+bug/1827696
Shall we discuss the rest on the forum?
--
https://code.launchpad.net/~widelands-dev/widelands/tribe-economy-settings/+merge/366878
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/tribe-economy-settin
31 matches
Mail list logo
