[Widelands-dev] [Merge] lp:~widelands-dev/widelands/territorial_unify_notifications into lp:widelands

2019-04-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 4698. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/517401116. Appveyor build 4484. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_territori

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 4702. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/517666765. Appveyor build 4488. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182361

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread GunChleoc
Review: Resubmit This is ready for review now, targeted at Build 20. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1823612-llvm8-build-errors/+merge/365644 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup-soundhandler into lp:widelands

2019-04-09 Thread Klaus Halfmann
Review, found so far: * restructered the sound directory wihht more subdirectories * Help now shows --nosoundStarts the game with sound disabled. * Using FXset one could have different soundscapes for testing or scenarions, interesting * I assuem the random must be a _local_ random, as

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread hessenfarmer
Found at least one questionable change in ai code see inline. needs intensive testing of programs especially for the mines Diff comments: > > === modified file 'src/ai/defaultai.cc' > --- src/ai/defaultai.cc 2019-03-24 13:13:34 + > +++ src/ai/defaultai.cc 2019-04-09 17:16:30 +000

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/screshot_ordering into lp:widelands-website

2019-04-09 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/screshot_ordering into lp:widelands-website. Commit message: Allow ordering of screenshots by applying a new database column. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1823634 in Widelands Web

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread TiborB
Yes, it is obviously a typo but I suggest not to touch it unless it is followed by some training. BTW, I plan to came return and spend some time on AI in about two months -- https://code.launchpad.net/~widelands-dev/widelands/bug-1823612-llvm8-build-errors/+merge/365644 Your team Widelands D

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread hessenfarmer
BTW: what was the reason for change the Program result code, as the previous revision did already compile with clang 8? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1823612-llvm8-build-errors/+merge/365644 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wid

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread bunnybot
Continuous integration builds have changed state: Travis build 4706. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/517922834. Appveyor build 4492. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18236

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/editor-resize-map into lp:widelands

2019-04-09 Thread GunChleoc
I have given this a very quick spin. I don't think that it is obvious to the user that they need to click on the map after selecting the values. Best add a Multilinetextarea with a hint. I think it would also be good to have dropdown menus for the map size rather than spin boxes - selecting the

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread GunChleoc
Which changes do you mean exactly? Please point me to the commit in the commit log for this branch, or to the line in the code. All that the AI change does is to assign a value to the same element only once instead of twice. Do you want me to record the value assignment that I deleted in a comm

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread TiborB
@Gun, I am not sure whom you are asking, but still I left the comment in the code Diff comments: > > === modified file 'src/ai/defaultai.cc' > --- src/ai/defaultai.cc 2019-03-24 13:13:34 + > +++ src/ai/defaultai.cc 2019-04-09 17:16:30 + > @@ -5458,10 +5455,9 @@ >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread hessenfarmer
@Tibor: I think that was addressed to my question. I was just wondering what is the reason behind commit 9048. I am a little bit concerned due to the commit message whether the programs still work as desired. Especially whether the statistics fix (result no-stats) still works. -- https://code

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1823612-llvm8-build-errors into lp:widelands

2019-04-09 Thread hessenfarmer
for the AI part we could leave this as it is now (i.e. nothing has changed) and record a bug to fix inputs[19] in this part of the code. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1823612-llvm8-build-errors/+merge/365644 Your team Widelands Developers is subscribed to branch lp:~