I think the word "official" is confusing here - I associate public
announcements and sticky topics with that. I think we should call them "public".
Code LGTM otherwise :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/official_posts/+merge/364989
Your team Widelands Developers is
I have fixed 2 compiler warnings. You need to use the PRIuS macro for logging
size_t, because the exact data type depends on the operating system. Also,
uint8_t will be interpreted as a character code point rather than a number, so
it needs an annoying explicit cast to every time you want to
p
Barbarian Ferry Yard needs cloth to build, but there is no Weaving Mill,
because that building needs seafaring.
It would be nice to have some indicators for the range when building a new
waterway - I think we best wait with that until after we have the new work
areas, because there could be som
Fixed the assert. Thanks for taking care of the warnings :)
--
https://code.launchpad.net/~widelands-dev/widelands/bridges/+merge/364318
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bridges into lp:widelands.
Review: Approve
Done a bit of testing ad it looks fine.
There is 2 small z-layering glitch for bridges going north-south: Workers
walking on roads behind them to their upper flag are blitted after the bridge
is, so they appear to be on top of it. It's not a biggie though and shouldn't
block th
The proposal to merge lp:~widelands-dev/widelands/cleanup-rendertarget into
lp:widelands has been updated.
Description changed to:
This is for Build 21.
Some housekeeping where I squashed 4 functions that do the same into 1.
Prerequisite for
https://code.launchpad.net/~widelands-dev/widelands
GunChleoc has proposed merging lp:~widelands-dev/widelands/cleanup-rendertarget
into lp:widelands.
Commit message:
Get rid of code duplication in rendertarget.h
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/c
The proposal to merge lp:~widelands-dev/widelands/cleanup-soundhandler into
lp:widelands has been updated.
Commit message changed to:
Complete overhaul of the sound handler
- Extensive refactoring of the SoundHandler, FXSet and SongSet classes.
Make it Widelands-agnostic.
- Categorize sound e
Removed the duplicate code and the superfluous animation frames, downscaled the
remaining images.
The barbarian ferry yard now uses reed instead of cloth.
The textures for built waterways are now better visible.
I agree about the range indicators. That will be easy to implement, but I´ll
wait
Review: Resubmit
Public is much better :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/official_posts/+merge/364989
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net
Review: Approve
Just 2 more string nits. Deploy any time :)
Diff comments:
>
> === modified file 'pybb/models.py'
> --- pybb/models.py2018-12-21 09:43:02 +
> +++ pybb/models.py2019-03-23 09:01:09 +
> @@ -255,6 +255,31 @@
> except:
> return []
>
> +class P
The new UI classes and changes to WLApplication are missing from the diff,
because it is too long :(
--
https://code.launchpad.net/~widelands-dev/widelands/cleanup-soundhandler/+merge/365001
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/c
Continuous integration builds have changed state:
Travis build 4625. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/510312741.
Appveyor build 4412. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cleanup_ren
Continuous integration builds have changed state:
Travis build 4626. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/510312899.
Appveyor build 4413. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bridges-441
Continuous integration builds have changed state:
Travis build 4628. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/510328711.
Appveyor build 4415. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cleanup_sou
Continuous integration builds have changed state:
Travis build 4631. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/510422490.
Appveyor build 4418. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18098
16 matches
Mail list logo
