Review: Approve
Code looks good to me
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1795976-port-attack-crash.
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1795976-port-attack-crash into lp:widelands.
Commit message:
Fix endless loop in DefaultAI::dispensable_road_test
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1795976 in widelands: "Crash, game freez
How about trying to do what the original error message is suggesting?
https://cmake.org/cmake/help/latest/policy/CMP0072.html
Try this line:
OpenGL_GL_PREFERENCE=LEGACY
--
https://code.launchpad.net/~widelands-dev/widelands/cmakepolicy/+merge/356018
Your team Widelands Developers is subscribed
Well, I have fully mature branches that have been sitting around for a year
that won't make it in because they are still waiting for a code review slot...
I could just call them "UI bugs" and insist on having them in Build 20,
delaying the release until who knows when, maybe another year?
Every
OK, good idea... thanks
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1795976-port-attack-crash.
___
Mailing lis
now when I look more deep into the code I think the function has a logical
error there, I will investigate and let you know..
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454
Your team Widelands Developers is subscribed to branch
lp:~widelands-de
Do you want to take up this branch and improve it before we merge?
I'll hold off merging for now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1795976-port-attack-crash/+merge/356454
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1795976-port
@GunChleoc
But that does not solve the underlying issue, does it?
Setting:
cmake_policy(SET CMP0072 OLD)
is the same as not setting the policy at all. In both will result in:
OpenGL_GL_PREFERENCE=LEGACY
The first one though would silence the warning BUT we would run into issues
with Cmake ve
@kaputtnik can you give this another try?
--
https://code.launchpad.net/~widelands-dev/widelands/cmakepolicy/+merge/356018
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/cmakepolicy.
___
Mailing list: https://launchp
Continuous integration builds have changed state:
Travis build 4110. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/440029552.
Appveyor build 3905. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_179597
"Widelands is too mature for the player base to find bugs like that acceptable
in a release."
Unless you have asked the player-base about the matter, the above statement is
arbitrary. If you dare, you can conduct a poll on the issue. Projects much
bigger and much more serious than Widelands hav
Continuous integration builds have changed state:
Travis build 4111. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/440139202.
Appveyor build 3906. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cmakepolicy
Compiling is fine here with the latest change: No Warning and no compile errors.
I do not really understand that stuff, but can't we just add a switch like that
(instead of setting the linker flags):
if(${CMAKE_VERSION} VERSION_GREATER "3.11")
cmake_policy(SET CMP0072 OLD)
endif()
I teste
@Klaus: I don´t think using real portraits would work. There are very few
portraits of Frisians. Aldgisl is about as close as we can get, and he was a
Western Frisian duke (so he´d fit to Reebaud, who seems more Western than
Northern frisian anyway), but there are few others. In the middle ages,
kaputtnik has proposed merging lp:~widelands-dev/widelands/cmakepolicy_2 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1772079 in widelands: "CMake 3.11: warning about FindOpenGL"
https://bugs.launchpad.net/widelands/+bug/1772079
For more det
@kaputtnik the changes I made set the policy to NEW. The trick that it. did
were the additional linker options. But it broke travis builds and will throw
errors on system that use old cmake version.
Your proposed switch sets it to the old (deprecated) behavior. Would you be so
nice and test the
Btw. AFAIK when using the new behavior, it seems mandatory to set the
linker-flags.
See here:
https://stackoverflow.com/questions/23729213/link-error-when-trying-to-build-a-simple-opengl-program
--
https://code.launchpad.net/~widelands-dev/widelands/cmakepolicy/+merge/356018
Your team Widelands
@kaputtnik you could try to remove the linker flags bit by bit and see which
one is really necessary to compile without linker errors.
--
https://code.launchpad.net/~widelands-dev/widelands/cmakepolicy/+merge/356018
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelan
Continuous integration builds have changed state:
Travis build 4113. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/440355897.
Appveyor build 3908. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cmakepolic
Continuous integration builds have changed state:
Travis build 4114. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/440360936.
Appveyor build 3909. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cmakepolic
20 matches
Mail list logo
