Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_sound into lp:widelands

2017-03-03 Thread Notabilis
Review: Approve Why does the description of this merge request sounds familiar? Strange... ;-) But the diff looks good to me and the sounds are playing in-game so it seems to be alright. I don't know much about cmake so I can't say much about moving widelands.h. Is there a real reason to move i

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_sound into lp:widelands

2017-03-03 Thread GunChleoc
No wonder this looks familiar - I have a whole series of these. Untangling the Widelands dependencies is a long-term project, but I hope to eventually speed up compiling and linking. So, these branches aim at not changing any functionality really except for code quality. Thanks for the review!

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/notifications_sound into lp:widelands

2017-03-03 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/notifications_sound into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/notifications_sound/+merge/318763 -- Your team Widelands Developers is subscrib