Continuous integration builds have changed state:
Travis build 1708. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/181170109.
Appveyor build 1548. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_glossary_c
Review: Needs Fixing
Can you put the RST comments directly above each method? This will make the
code easier to read and avoid accidentally documenting this twice in the future.
I have also added come nits and ideas.
Diff comments:
> === modified file 'src/scripting/lua_map.cc'
> --- src/scrip
Review: Approve
I have used the new test to confirm that this fixes the bug.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-supply/+merge/312421
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-supply.
__
The proposal to merge lp:~widelands-dev/widelands/bug-supply into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-supply/+merge/312421
--
Your team Widelands Developers is subscribed to branch
lp:~
The reason that the warehouse statistics don't list them is that people might
try to set a policy on them. Players might still be interested in the inventory
though.
--
https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue/+merge/309763
Your team Widelands Developers is request
We can use destroy() in the interactive player, so I have done that now.
The fieldaction call has to be a raw delete, otherwise crash boom bang.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-buildhelp-button/+merge/312429
Your team Widelands Developers is requested to review
Forgot to say: adding window = nullptr after the destroy() call doesn't help,
it still crashes.
Since we should slowly go over all our remaining delete calls anyway, I'd say
let's get this in to get rid of the crash ASAP.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-buildh
Is this meant to run with python3 or python2?
I put some comments in the diff.
Diff comments:
> === added directory 'utils'
> === added file 'utils/fix_formatting.py'
> --- utils/fix_formatting.py 1970-01-01 00:00:00 +
> +++ utils/fix_formatting.py 2016-12-04 06:57:43 +
> @@ -0,0 +1,
Ah, forgotton: Wouldn't it be better to have this script in the _ops directory?
--
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/pyformat_util
The proposal to merge lp:~widelands-dev/widelands-website/news_rework into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345
--
Your team Widelands Developers is
Thanks :-)
Merged and deployed.
--
https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-de
Looks great :)
The archive links are hard to see because they are sort of beige on beige, can
you make them green?
Also - News Archiv: -> News Archive:
--
https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345
Your team Widelands Developers is subscribed to branch
Because of coloring: Please try hitting F5 (reload) several times because the
browser loads the css from his cache. It should like in theses screenshots:
https://launchpadlibrarian.net/294049360/news_new_01.png
I will change the string in the wlimages_rework branch, which i want to deploy
soon.
Background went dark now, looks good :)
--
https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widela
If that directory does the same job as utils does on Widelands, yes.
Diff comments:
> === added directory 'utils'
> === added file 'utils/fix_formatting.py'
> --- utils/fix_formatting.py 1970-01-01 00:00:00 +
> +++ utils/fix_formatting.py 2016-12-04 06:57:43 +
> @@ -0,0 +1,51 @@
> +#!
Review: Resubmit
I am running out of time for working on this, so I'm in favour of getting this
in now. We can always do another round of cleanups next year.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is subscribed
There where some server errors, because two posts from year 2013 had the same
slug. I fixed this over the admin page by changing the slug of one of them
according to the title.
--
https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345
Your team Widelands Develope
Works good, though I found one issue - when on lowest resolution and when
opening map with 16 players - bottom players are out of window and not
accessible.
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_3_mapselect/+merge/310744
Your team Widelands Developers is reques
I looked into this because I was confused why this crashed. I found that the
problem was that the registry was used by two windows at the same time: the old
one, because die() would only kill it in the next frame and the new one,
because FieldActionWindow() would use the same registry.
The solu
GunChleoc has proposed merging
lp:~widelands-dev/widelands/codecheck_remove_2_rules into lp:widelands.
Commit message:
Remove 2 codecheck rules which are now covered by calling clang-format:
- long_line: causes frequent Travis fails
- illegal_space_before: conflicts with clang-format in the caser
Review: Approve
lgtm. sgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler_warnings_201611.
___
Mailing list: ht
Review: Approve
lgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/codecheck_remove_2_rules/+merge/312526
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/codecheck_remove_2_rules.
___
Mailing list: https:
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/codecheck_remove_2_rules/+merge/312526
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/codecheck_remove_2_rules.
___
Mailing list: https://launchp
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1647033-immovable-packet-no into lp:widelands.
Commit message:
Immovables now have a dynamic packet number, so maps will still load with Build
19: The packet number is only increased if the immovable has a former building.
Requested
Review: Approve
Tested and LGTM. Let's wait for Travis then merge.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-buildhelp-button/+merge/312429
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1644553-buildhelp-button.
_
The proposal to merge lp:~widelands-dev/widelands/bug-1644553-buildhelp-button
into lp:widelands has been updated.
Commit Message changed to:
Fixed crash with destroying UniqueWindow in FieldActionWindow.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1644553-bui
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler_warnings_201611.
___
Mailing list: https://launchp
The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_201611 into
lp:widelands has been updated.
Commit Message changed to:
Fixed a series of compiler warnings for clang and WIndows.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20161
The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_201611 into
lp:widelands has been updated.
Commit Message changed to:
Fixed a series of compiler warnings for clang and Windows.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_20161
The proposal to merge lp:~widelands-dev/widelands/compiler_warnings_201611 into
lp:widelands has been updated.
Commit Message changed to:
Fixed some compiler warnings for clang and WIndows.
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merg
The proposal to merge lp:~widelands-dev/widelands/codecheck_remove_2_rules into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/codecheck_remove_2_rules/+merge/312526
--
Your team Widelands Developers i
31 matches
Mail list logo
