Review: Needs Fixing
I couldn't trigger the crash anymore, but loading a smaller map after a big map
the position in upper left corner isn't 0,0, it depends on the position of
previous loaded map.
Resolution 800x600 (window mode)
Load "Wideworld", mapsize 384,256 scroll the map until position 2
Review: Approve compile, review
Looks good to me, with Apple clang I get a lot less warnings.
You removed on break; that looks incorrect, but I am but sure,
see diff comments.
I prepared some changes that would remove some implicit float -> double
warnings, too.
Not sure if I should commit these
I have added some replies to your comments, could you please have a look?
Diff comments:
>
> === modified file 'src/ai/ai_help_structs.h'
> --- src/ai/ai_help_structs.h 2016-03-12 20:06:24 +
> +++ src/ai/ai_help_structs.h 2016-04-02 16:49:56 +
> @@ -351,8 +350,8 @@
> uint16_t min
Expect a commit in some minutes
Diff comments:
>
> === modified file 'src/ai/ai_help_structs.h'
> --- src/ai/ai_help_structs.h 2016-03-12 20:06:24 +
> +++ src/ai/ai_help_structs.h 2016-04-02 16:49:56 +
> @@ -351,8 +350,8 @@
> uint16_t mines_percent; // % of res it can mine
>
I think I found the correct move view function now.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1512151-load-small-map/+merge/290802
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1512151-load-small-map.
_
Miroslav Remák has proposed merging lp:~widelands-dev/widelands/escaping-fixes
into lp:widelands.
Commit message:
- Remove unnecessary code
- Unescape several plaintext strings
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands
Continuous integration builds have changed state:
Travis build 916. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/119615081.
Appveyor build 748. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_escaping_fi
Review: Approve
LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1535065-mapgen-user-feedback/+merge/290803
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1535065-mapgen-user-feedback.
___
Mailin
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1535065-mapgen-user-feedback/+merge/290803
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1535065-mapgen-user-feedback.
___
Mail
The proposal to merge
lp:~widelands-dev/widelands/bug-1535065-mapgen-user-feedback into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1535065-mapgen-user-feedback/+merge/290803
--
Your team Widel
Continuous integration builds have changed state:
Travis build 947. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/120426572.
Appveyor build 780. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_escaping_fix
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1395322-tool3
into lp:widelands.
Commit message:
Added CTRL as selection key for the 2nd alternative tool and updated help text.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1395322 in widelands: "Ed
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1554552.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
Review: Approve
This also fixes a bug with the /help chat output :)
--
https://code.launchpad.net/~widelands-dev/widelands/escaping-fixes/+merge/290821
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/escaping-fixes.
___
Oh, I didn't even realize that code was evil. Good thing it's gone now, then.
--
https://code.launchpad.net/~widelands-dev/widelands/escaping-fixes/+merge/290821
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/escaping-fixes.
___
Definitely! I really want the old font renderer gone, but I'm still having some
issues in the About screen for the new font renderer that need fixing. Anything
else there can be hacked, but not those bugs...
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/escaping-fixes/+
The proposal to merge lp:~widelands-dev/widelands/escaping-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/escaping-fixes/+merge/290821
--
Your team Widelands Developers is subscribed to bran
Review: Approve testing
Works now :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1512151-load-small-map/+merge/290802
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1512151-load-small-map.
___
Ma
Review: Approve code review + testing
LGTM, just a few minor typos in documentation (see diff comments).
Diff comments:
>
> === modified file 'src/scripting/lua_map.cc'
> --- src/scripting/lua_map.cc 2016-03-22 07:32:14 +
> +++ src/scripting/lua_map.cc 2016-04-02 16:56:15 +
> @@ -2716
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1530370-soldiers-lua/+merge/290800
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1530370-soldiers-lua.
___
Mailing list: https:
GunChleoc has proposed merging
lp:~widelands-dev/widelands/chat-messages-overlap into lp:widelands.
Commit message:
Shifted chat overlay up so it won't overlap with the menu buttons.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~wid
The proposal to merge lp:~widelands-dev/widelands/bug-1530370-soldiers-lua into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1530370-soldiers-lua/+merge/290800
--
Your team Widelands Developers i
Review: Needs Fixing
Change the height here as well, so it doesn't shift back down on resolution
change:
graphic_resolution_changed_subscriber_ =
Notifications::subscribe(
[this](const GraphicResolutionChanged& message) {
set_size(message.width, message.hei
Continuous integration builds have changed state:
Travis build 946. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/120420888.
Appveyor build 779. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1512151_
24 matches
Mail list logo
